When excluding/re-including DRC violations, update the
BDS list immediately rather than waiting for the
BOARD::RecordDRCExclusions() to be called.
This was implemented in 8.99 in 0598ca0f90
(along with DRC exclusion comments).
Follow that commit's updates of the m_DrcExclusions
structures in an analogous way.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/19113
Currently, unselecting the bold option resets the thickness to the
standard size instead of reverting to the original thickness.
To address this, the original thickness should be preserved so it
can be restored when bold is turned off.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18975
(cherry picked from commit 43b1bc52db)
If a schematic item was selected, when activating the probe tool from the
simulator, and deactivating from the Select Item sch editor tool, a crash
happened.
From master branch
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18547
Parsing an empty string as double/int produces uninitialised data.
That is likely to cause an undefined amout of chaos later on,
so catch it explicitly with a wxCHECK.
It's still something that shouldn't happen, and could still cause
chaos, but it's at least deterministic. It also avoids putting
gigantic numbers into things that don't expect them. For example
normalising an angle of 1e303 is functionally an infinite loop.
This happens at least in files with missing fields in rows,
like in #19174's file, line 4:
S!U2306!IC!!!!!!SOT_23_5!!!!!SGM2576/TT9107!!!
The file is still broken, but now it loads.
Relates-To: https://gitlab.com/kicad/code/kicad/-/issues/19174
(cherry picked from commit 4d2d70ce22)
When the italic or bold nature is changed, text using outline fonts may
need to change its font. Add this to the SetItalic/SetBold functions.
Also add a counterpart SetItalicFlag function (following SetBoldFlag)
when you only need to set the flag (e.g. when importing or changing
everything in the text properties dialog).
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/18592
(cherry picked from commit b043f334de)
Because it's confusing when the dialog shows last target value, but it
doesn't apply when you start tuning.
Also the last values are remembered in DRAWING_TOOL::PlaceTuningPattern
now, instead of global variables.
Related: https://gitlab.com/kicad/code/kicad/-/issues/18979
-Allow changing length tuning settings before tuning has been started
-Do not exit out of the length tuning tool after each placement
-Keep specified settings between pattern placements
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18979
(cherry picked from commit 78b2e53777)
A recent change set the parent member of a item put in the repeat list to
nullptr (this is OK) but the code to copy an item from this list did not
update this parent member.
From master branch, commit 8f348820
Handle boolean value parsing during paste operation. The boolean value
was not being handled correctly in grid_tricks, which prevented the
boolean value from being pasted into the target row
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18985
(cherry picked from commit 07f96b83b7)
The white text in dark mode is too washed out on the cell colors to be
visible. Since we already purposely subdue the colors in dark mode, the
easiest fix is to just always use black text.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17033
(cherry picked from commit c7d280dfa1)
Currently, the used layers passed from parseLayers() do not include
mandatory layers if they are missing in the loaded board file.
To fix this, we can manually add the mandatory layers to ensure they
are always enabled.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18978
(cherry picked from commit 6e2ed5666d)
Previously, when attempting to paste an entire row copied from the global
table into a project table, the value would be pasted from the cell where
the cursor was focused, rather than from the first cell. This issue
occurred because the first cell, a checkbox column, was not selectable.
To resolve this, the checkbox column should be enabled for selection
when the Left Mouse Button event is triggered
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18732
(cherry picked from commit 1fc8e65f7a)