mariadb

Commit Graph

Author	SHA1	Message	Date
Thirunarayanan Balathandayuthapani	d93934d7bc	MDEV-35475 Assertion `!rec_offs_nth_extern(offsets1, n)' failed in cmp_rec_rec_simple_field Problem: ======= InnoDB wrongly stores the primary key field in externally stored off page during bulk insert operation. This leads to assert failure. Solution: ======== row_merge_buf_blob(): Should store the primary key fields inline. Store the variable length field data externally based on the row format of the table.	11 months ago
Daniel Black	27c7e73f9a	MDEV-35513 fails to compile on riscv32 Misplaced brace in my_rdtsc.h results in RV32 failing to compile. ref: https://github.com/MariaDB/server/pull/1981/files#r1859762957 Thanks Jessica Clarke for the note.	11 months ago
Alexander Barkov	8b057889d7	MDEV-34981 Functions missing from INFORMATION_SCHEMA.SQL_FUNCTIONS Plugin functions are now displayed in I_S.SQL_FUNCTIONS	11 months ago
Monty	c34a2feceb	MDEV-35509 mariabackup.alter_copy_race crashes with abort in backup_file_op_fail The bug was that backup_file_op_fail() was using a static variable initialized by arguments. This does not work as static variables will only be initialized on the first call and not change for future calls, even when the arguments changes. Fixed by removing 'static'.	11 months ago
ParadoxV5	e81ed928ff	MDEV-35478 part 2: Redo `space_id` format fix `table->space_id` is `ulint` on 10.6 and `uint32_t` on 10.11+, but I included its format specifier change in 10.6 rather than 10.11. PR #3650 reverts the change from 10.6; this commit reapplies it on 10.11 as a follow up on its batch (MDEV-35431, merged #3518).	11 months ago
Daniel Black	a54692a4b5	main.ctype_utf8 test fix for cursor protocol Cursor protocol requires results to be simple.	11 months ago
Yuchen Pei	db59bb62aa	[fixup] Revert an incorrect removal of some code in spider_get_crd in a merge The merge was `fd0b47f9d6`	11 months ago
ParadoxV5	79cc0f9f78	MDEV-11675 fixup: Fill in the GTID TODO Fill in the `todo:gtid` in `check_and_remove_stale_alter` (Note that `Master_info::master_id` is a `ulong`, unlike `rpl_gtid::server_id`) > We could have caught this before MDEV-11675 was > published if we'd had this validation earlier 😇 . > ⸺ Brandon, reply in #3360 (MDEV-21978) Co-authored-by: Brandon Nesterenko <brandon.nesterenko@mariadb.com>	11 months ago
ParadoxV5	687377633d	Extract some of #3360 fixes to 10.11.x That PR uncovered countless issues on `my_snprintf` uses. This commit backports a squashed subset of their fixes. (Excludes previous parts #3485 and #3493)	1 year ago
Marko Mäkelä	c72221e2f8	MDEV-35411 innodb.log_file_size_online occasionally fails The test innodb.log_file_size_online was killing the server shortly after the completion of SET GLOBAL innodb_log_file_size. It is possible that log_t::write_checkpoint() would let mysqltest.cc proceed to kill the server before the message had been written to the server error log. Let us remove the occasionally failing check of that message, and instead ensure that SET GLOBAL innodb_log_file_size to a different size will result in an error log message when the server is not being killed.	11 months ago
Oleksandr Byelkin	a37f71bd10	Merge branch '10.11' into mariadb-10.11.10	12 months ago
Alexander Barkov	e60fd6c204	MDEV-28767 Collation "binary" is not accepted for databases, tables, columns MariaDB in a COLLATE clause supported 'binary' only as an identifier: COLLATE `binary` Fixing the parser to understand 'binary' as a keyword: COLLATE binary This is for MySQL compatibility.	12 months ago
Daniel Bartholomew	cca85eb16e	bump the VERSION	12 months ago
Oleksandr Byelkin	3d0fb15028	Merge branch '10.6' into 10.11	12 months ago
Oleksandr Byelkin	f00711bba2	Merge branch '10.5' into 10.6	12 months ago
Oleksandr Byelkin	6aa47fae30	MDEV-35276 Assertion failure in find_producing_item upon a query from a view Two problem solved: 1) Item_default_value makes a shallow copy so the copy should not delete field belong to the Item 2) Item_default_value should not inherit derived_field_transformer_for_having and derived_field_transformer_for_where (in this variant pushing DEFAULT(f) is prohibited (return NULL) but if return "this" it will be allowed (should go with a lot of tests))	12 months ago
Thirunarayanan Balathandayuthapani	db3be9b434	MDEV-35237 Bulk insert fails to apply buffered operation during CREATE..SELECT statement Problem: ======= - InnoDB fails to write the buffered insert operation during create..select operation. This happens when bulk_insert in transaction is reset to false while unlocking a source table. Fix: === - InnoDB should apply the previous buffered changes to all tables if we encounter any statement other than pure INSERT or INSERT..SELECT statement in ha_innobase::external_lock() and start_stmt(). - Remove the function bulk_insert_apply_for_table() start_stmt(), external_lock(): Assert that trx->duplicates should be enabled during bulk insert operation	12 months ago
Sergei Golubchik	953f847aed	Post-fix for MDEV-35236 when the option_list is initially empty, its value doesn't need to be restored, as it'll be shallow-copied every time. Furthermore, the CREATE_INFO is allocated on the stack, so it's even wrong to restore it after its frame was left. followup for `3cd706b107`	12 months ago
Vladislav Vaintroub	4b068b7fcb	MDEV-32387 - prevent output during temporary changes to STDOUT/STDERR create_process() temporarily changes STDOUT/STDERR output to error log file This might redirect mtr output on Windows, so avoid it by holding flush_lock.	12 months ago
Marko Mäkelä	63a7e4c96b	MDEV-35257 Backup fails during an ALTER TABLE with FULLTEXT INDEX In commit `1c55b845e0` (MDEV-32932) the test mariabackup.innodb_ddl_on_intermediate_table was introduced but disabled. xb_load_single_table_tablespace(): Properly handle missing FTS_ tables. backup_file_op_fail(): Properly handle FILE_DELETE records.	12 months ago
Sergei Petrunia	284593413f	MDEV-35253: xa_prepare_unlock_unmodified fails: shift exponent 32 is too large The code in best_access_path() uses PREV_BITS(uint, N) to compute a bitmap of all keyparts: {keypart0, ... keypart{N-1}). The problem is that PREV_BITS($type, N) macro code can't handle the case when N=<number of bits in $type). Also, why use PREV_BITS(uint, ...) for key part map computations when we could have used PREV_BITS(key_part_map) ? Fixed both: - Change PREV_BITS(type, N) to handle any N in [0; n_bits(type)]. - Change PREV_BITS() to use key_part_map when computing key_part_map bitmaps.	12 months ago
Yuchen Pei	b8c2bd9f69	MDEV-35249 Fix regression caused by MDEV-34447 MDEV-34447 Removed setting first_cond_optimization to 0 in update and delete when leaf_tables_saved. This can cause problems when two ps executions of an update go through different paths, where the first ps execution goes through single table update only and the second ps execution also goes through multi table update. When this happens, the first_cond_optimization of the outer query is not set to false during the first ps execution because optimize() is not called for the outer query. But then the second ps execution will call optimize() on the outer query, which with first_cond_optimization==true trips the 2nd ps mem leak detection. This is not a problem in higher version as both executions go through multi table updates, possibly due to MDEV-28883. We fix this problem by restoring the FALSE assignments to first_cond_optimization.	12 months ago
Marko Mäkelä	decdd4bf49	MDEV-29015/MDEV-29260/MDEV-34938: os_file_get_size() WSL work-around When MariaDB Server is run in a container under Windows Subsystem for Linux, the fstat(2) system calls that InnoDB invokes in os_file_set_size() or os_file_get_size() are causing a failure in case the file had been renamed in the past while the file handle was open. This affects at least ALTER TABLE and OPTIMIZE TABLE. os_file_get_size(): Invoke lseek(2) instead of fstat(2). We do not mind if the file pointer is moving to the end of the file, because InnoDB exclusively invokes positioned reads and writes, or in some rare cases, appends to an existing file. os_file_set_size(): Invoke os_file_get_size() instead of fstat(2). Define the POSIX and Windows versions separately. Formerly, the Windows version was called os_file_change_size_win32(). fil_node_t::read_page0(): Use os_file_get_size() to determine the size, and do not crash on error. fil_node_t::read_metadata(): Remove the non-Windows stat* parameter and always invoke fstat(2) outside Windows, but do tolerate errors. Because fstat(2) is more likely to fail than lseek(2), and this is not time critical code, we can afford the extra lseek(2) system call. Reviewed by: Vladislav Vaintroub	12 months ago
Sergei Golubchik	3cd706b107	MDEV-35236 Assertion `(mem_root->flags & 4) == 0' failed in safe_lexcstrdup_root Post-fix for MDEV-35144. Cannot allocate options values on the statement arena, because HA_CREATE_INFO is shallow-copied for every execution, so if the option_list was initially empty, it will be reset for every execution and any values allocated on the statement arena will be lost. Cannot allocate option values on the execution arena, because HA_CREATE_INFO is shallow-copied for every execution, so if the option_list was initially NOT empty, any values appended to the end will be preserved and if they're on the execution arena their content will be destroyed. Let's use thd->change_item_tree() to save and restore necessary pointers for every execution. followup for `3da565c41d`	12 months ago
Sergei Golubchik	eac33a23da	MDEV-32022 ERROR 1054 (42S22): Unknown column 'X' in 'NEW' in trigger add missing do_get_copy/do_build_clone	1 year ago
Vlad Lesin	8c7786e7d5	MDEV-34690 lock_rec_unlock_unmodified() causes deadlock lock_rec_unlock_unmodified() is executed either under lock_sys.wr_lock() or under a combination of lock_sys.rd_lock() + record locks hash table cell latch. It also requests page latch to check if locked records were changed by the current transaction or not. Usually InnoDB requests page latch to find the certain record on the page, and then requests lock_sys and/or record lock hash cell latch to request record lock. lock_rec_unlock_unmodified() requests the latches in the opposite order, what causes deadlocks. One of the possible scenario for the deadlock is the following: thread 1 - lock_rec_unlock_unmodified() is invoked under locks hash table cell latch, the latch is acquired; thread 2 - purge thread acquires page latch and tries to remove delete-marked record, it invokes lock_update_delete(), which requests locks hash table cell latch, held by thread 1; thread 1 - requests page latch, held by thread 2. To fix it we need to release lock_sys.latch and/or lock hash cell latch, acquire page latch and re-acquire lock_sys related latches. When lock_sys.latch and/or lock hash cell latch are released in lock_release_on_prepare() and lock_release_on_prepare_try(), the page on which the current lock is held, can be merged. In this case the bitmap of the current lock must be cleared, and the new lock must be added to the end of trx->lock.trx_locks list, or bitmap of already existing lock must be changed. The new field trx_lock_t::set_nth_bit_calls indicates if new locks (bits in existing lock bitmaps or new lock objects) were created during the period when lock_sys was released in trx->lock.trx_locks list iteration loop in lock_release_on_prepare() or lock_release_on_prepare_try(). And, if so, we traverse the list again. The block can be freed during pages merging, what causes assertion failure in buf_page_get_gen(), as btr_block_get() passes BUF_GET as page get mode to it. That's why page_get_mode parameter was added to btr_block_get() to pass BUF_GET_POSSIBLY_FREED from lock_release_on_prepare() and lock_release_on_prepare_try() to buf_page_get_gen(). As searching for id of trx, which modified secondary index record, is quite expensive operation, restrict its usage for master. System variable was added to remove the restriction for testing simplifying. The variable exists only either for debug build or for build with -DINNODB_ENABLE_XAP_UNLOCK_UNMODIFIED_FOR_PRIMARY option to increase the probability of catching bugs for release build with RQG. Note that the code, which does primary index lookup to find out what transaction modified secondary index record, is necessary only when there is no primary key and no unique secondary key on replica with row based replication, because only in this case extra X locks on unmodified records can be set during scan phase. Reviewed by Marko Mäkelä.	1 year ago
Vlad Lesin	92180ad513	MDEV-34466 XA prepare don't release unmodified records for some cases There is no need to exclude exclusive non-gap locks from the procedure of locks releasing on XA PREPARE execution in lock_release_on_prepare_try() after commit `17e59ed3aa` (MDEV-33454), because lock_rec_unlock_unmodified() should check if the record was modified with the XA, and release the lock if it was not. lock_release_on_prepare_try(): don't skip X-locks, let lock_rec_unlock_unmodified() to process them. lock_sec_rec_some_has_impl(): add template parameter for not acquiring trx_t::mutex for the case if a caller already holds the mutex, don't crash if lock's bitmap is clean. row_vers_impl_x_locked(), row_vers_impl_x_locked_low(): add new argument to skip trx_t::mutex acquiring. rw_trx_hash_t::validate_element(): don't acquire trx_t::mutex if the current thread already holds it. Thanks to Andrei Elkin for finding the bug. Reviewed by Marko Mäkelä, Debarun Banerjee.	1 year ago
Oleksandr Byelkin	83db978271	new CC 3.1	1 year ago
Marko Mäkelä	1cad1dbde6	MDEV-35235 innodb_snapshot_isolation=ON fails to signal transaction rollback convert_error_code_to_mysql(): Treat DB_DEADLOCK and DB_RECORD_CHANGED in the same way, that is, signal to the SQL layer that the transaction had been rolled back.	12 months ago
Jan Lindström	b3be3c2157	MDEV-30653 : With wsrep_mode=REPLICATE_ARIA only part of mixed-engine transactions is replicated Replication of non-transactional engines is experimental and uses TOI. This naturally means that if there is open transaction with transactional engine it's changes will be rolled back. Fixed by adding error message if non-transactional engine is part of multi-engine transaction with warning. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	1 year ago
Julius Goryavsky	2339f15a00	galera: wsrep-lib submodule update	12 months ago
Jan Lindström	7ffa7b6b01	MDEV-31888 : galera.galera_wan, galera.galera_vote_rejoin_* fail Clean up configuration and tests. Add wait conditions to make sure test continues from clean state. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	1 year ago
Marko Mäkelä	b38edd09ff	MDEV-34830 fixup: Relax an assertion This follows up `1067046b7f`	1 year ago
Kristian Nielsen	45537939e7	MDEV-34859: Pass thorugh -DWITH_BOOST_CONTEXT to libmariadb Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>	1 year ago
Oleksandr Byelkin	9b3413c71f	MDEV-8578: fix galera test	1 year ago
Oleksandr Byelkin	d29611afa1	MDEV-15497 fixed outdated syntax	1 year ago
Marko Mäkelä	1067046b7f	MDEV-34830 fixup: Relax an assertion It is possible that recv_sys.scanned_lsn is ahead of recv_sys.recovered_lsn by a few 512-byte log blocks in case the last mini-transaction in the log had not been written out completely before the server was killed. This is occasionally the case when running the test innodb.innodb-32k-crash.	1 year ago
Marko Mäkelä	bea4adcb5a	MDEV-35225 Bogus debug assertion failures in innodb.innodb-32k-crash log_sort_flush_list(): Correct some debug assertions that had been added in commit `0d175968d1` (MDEV-31354). The writes of some blocks may be completed and the oldest_modification() set to 1 at any time. The bogus assertion failures led to occasional failures of the test innodb.innodb-32k-crash.	1 year ago
Brandon Nesterenko	1ed30e08af	MDEV-34122: Assertion `entry' failed in Active_tranx::assert_thd_is_waiter If semi-sync is switched off then on while a transaction is in-between binlogging and waiting for an ACK, the semi-sync state of the transaction is removed, leading to a debug assertion that indicates the transaction tried to wait, but cannot receive an ACK signal. More specifically, when semi-sync is switched off, the Active_tranx list is cleared (where a transaction adds an entry to this list during binlogging), and each entry in this list saves the thread which will wait for an ACK, and the thread has the COND variable to signal to wake itself. So if the entry is lost, the Ack_receiver thread won’t be able to find the thread to wake up when an ACK comes in The fix is to ensure that the entry exists before awaiting the ACK, and if there is no entry, skip the wait. In debug builds, an informative message is written explaining that the transaction is skipping its wait. Additional debug-build only logic is added to ensure that the cause of the missing entry is due to semi-sync being turned off and on Reviewed By: ============ Kristian Nielsen <knielsen@knielsen-hq.org>	1 year ago
Vladislav Vaintroub	e8db5c8760	MDEV-35171 OS_FILE_NORMAL and OS_FILE_AIO are misleading Removed 'purpose' parameter from os_file_create() and related functions. Always use FILE_FLAG_OVERLAPPED when opening Windows files. No performance regression was measured, nor there is any measurable improvement.	1 year ago
Alexander Barkov	855c21eb99	Recording ctype_gbk_export_import.result according to MDEV-34883	1 year ago
Marko Mäkelä	7701ccb72d	MDEV-35149 Race condition around SET GLOBAL innodb_lru_scan_depth A debug assertion in buf_LRU_get_free_block() could fail if SET GLOBAL innodb_lru_scan_depth is being executed during a workload that involves allocating buffer pool pages. buf_pool_t::LRU_scan_depth: Replaces srv_LRU_scan_depth. buf_pool_t::flush_neighbors: Replaces srv_flush_neighbors. innodb_buf_pool_update<T>(): Update a parameter of buf_pool while holding buf_pool.mutex.	1 year ago
Thirunarayanan Balathandayuthapani	7f7d78bc18	MDEV-35183 ADD FULLTEXT INDEX unnecessarily DROPS FTS COMMON TABLES - InnoDB fulltext rebuilds the FTS COMMON table while adding the new fulltext index. This can be optimized by avoiding rebuilding the FTS COMMON table in case of FTS COMMON TABLE already exists. Reviewed-by: Marko Mäkelä <marko.makela@mariadb.com>	1 year ago
Sergei Golubchik	70d8ce63c7	update C/C	1 year ago
Kristian Nielsen	abc46259c6	MDEV-34753 memory pressure - erroneous termination condition Fix race condition in test case by waiting for the expected state to occur. Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>	1 year ago
Daniel Black	eb29190398	MDEV-34753 memory pressure - erroneous termination condition The 'if (!m_abort) break' condition was inverted by accident. Constrain the test case to environments where there is cgroupv2 runtime environment which is the same case that will pass a memory pressure initialization. Remove the explicit garbage_collection trigger as it hides the abnormal termination error on the event loop for memory pressure. This also means there is no support in non-cgroupv2 environments (possibly some container environments). As the trigger to memory pressure is via a different thread we need to wait until a "[mM]emory pressure" log message is there to know it has succeeded or failed. Thanks Kristian Nielsen for noticing and review.	1 year ago
Sergei Petrunia	a68e74b5a4	MDEV-35164: optimizer_join_limit_pref_ratio: assertion when the ORDER BY table becomes constant Assertion failure has happened due to this scenario: A query was ran with optimizer_join_limit_pref_ratio=1. The query had "ORDER BY t1.col LIMIT N". The optimizer set join->limit_shortcut_applicable=1. Then, table t1 was marked as constant. The code in choose_query_plan() still set join->limit_optimization_mode=1 which caused the optimizer to only consider t1 as the first non-const table. But t1 was already put into the join prefix as the constant table. The optimizer couldn't produce any join order at all and crashed. Fixed by not searching for shortcut plan if ORDER BY table is a constant. We will not try to do sorting anyway in this case (and LIMIT short-cutting will be done for any join order).	1 year ago
Rucha Deodhar	e14d2b7974	MDEV-8578: Wrong error code/message with enforce_storage_engine and NO_ENGINE_SUBSTITUTION Analysis: When the error is hit, wrong error code is passed in my_error Fix: Pass a better error code.	2 years ago
Sergei Petrunia	0540eac05c	MDEV-35180: ref_to_range rewrite causes poor query plan (Variant 2: only allow rewrite for ref(const)) make_join_select() has a "ref_to_range" rewrite: it would rewrite any ref access to a range access on the same index if the latter uses more keyparts. It seems, he initial intent of this was to fix poor query plan choice in cases like t.keypart1=const AND t.keypart2 < 'foo' Due to deficiency in cost model, ref access could be picked while range would enumerate fewer rows and be cheaper. However, the condition also forces a rewrite in cases like: t.keypart1=prev_table.col AND t.keypart1<='foo' AND t.keypart2<'bar' Here, it can be that * keypart1=prev_table.col is highly selective * (keypart1, keypart2) <= ('foo', 'bar') is not at all selective. Still, the rewrite would be made and poor query plan chosen. Fixed this by only doing the rewrite if ref access was ref(const) so we can be certain that quick select also used these restrictions and will scan a subset of rows that ref access would scan.	1 year ago
Marko Mäkelä	eca552a1a4	MDEV-34830: LSN in the future is not being treated as serious corruption The invariant of write-ahead logging is that before any change to a page is written to the data file, the corresponding log record must must first have been durably written. In crash recovery, there were some sloppy checks for this. Let us implement accurate checks and flag an inconsistency as a hard error, so that we can avoid further corruption of a corrupted database. For data extraction from the corrupted database, innodb_force_recovery can be used. Before recovery is reading any data pages or invoking buf_dblwr_t::recover() to recover torn pages from the doublewrite buffer, InnoDB will have parsed the log until the final LSN and updated log_sys.lsn to that. So, we can rely on log_sys.lsn at all times. The doublewrite buffer recovery has been refactored in such a way that the recv_sys.dblwr.pages may be consulted while discovering files and their page sizes, but nothing will be written back to data files before buf_dblwr_t::recover() is invoked. recv_max_page_lsn, recv_lsn_checks_on: Remove. recv_sys_t::validate_checkpoint(): Validate the write-ahead-logging condition at the end of the recovery. recv_dblwr_t::validate_page(): Keep track of the maximum LSN (if we are checking a non-doublewrite copy of a page) but do not complain LSN being in the future. The doublewrite buffer is a special case, because it will be read early during recovery. Besides, starting with commit `762bcb81b5` the dblwr=true copies of pages may legitimately be "too new". recv_dblwr_t::find_page(): Find a valid page with the smallest FIL_PAGE_LSN that is in the valid range for recovery. recv_dblwr_t::restore_first_page(): Replaced by find_page(). Only buf_dblwr_t::recover() will write to data files. buf_dblwr_t::recover(): Simplify the message output. Do attempt doublewrite recovery on user page read error. Ignore doublewrite pages whose FIL_PAGE_LSN is outside the usable bounds. Previously, we could wrongly recover a too new page from the doublewrite buffer. It is unlikely that this could have lead to an actual error. Write back all recovered pages from the doublewrite buffer here, including for the first page of any tablespace. buf_page_is_corrupted(): Distinguish the return values CORRUPTED_FUTURE_LSN and CORRUPTED_OTHER. buf_page_check_corrupt(): Return the error code DB_CORRUPTION in case the LSN is in the future. Datafile::read_first_page_flags(): Split from read_first_page(). Take a copy of the first page as a parameter. recv_sys_t::free_corrupted_page(): Take the file as a parameter and return whether a message was displayed. This avoids some duplicated and incomplete error messages. buf_page_t::read_complete(): Remove some redundant output and always display the name of the corrupted file. Never return DB_FAIL; use it only in internal error handling. IORequest::read_complete(): Assume that buf_page_t::read_complete() will have reported any error. fil_space_t::set_corrupted(): Return whether this is the first time the tablespace had been flagged as corrupted. Datafile::validate_first_page(), fil_node_open_file_low(), fil_node_open_file(), fil_space_t::read_page0(), fil_node_t::read_page0(): Add a parameter for a copy of the first page, and a parameter to indicate whether the FIL_PAGE_LSN check should be suppressed. Before buf_dblwr_t::recover() is invoked, we cannot validate the FIL_PAGE_LSN, but we can trust the FSP_SPACE_FLAGS and the tablespace ID that may be present in a potentially too new copy of a page. Reviewed by: Debarun Banerjee	1 year ago

1 2 3 4 5 ...

200760 Commits (d93934d7bc51db53c466178cd16e33d5a6c95a78) All Branches Search

200760 Commits (d93934d7bc51db53c466178cd16e33d5a6c95a78)

All Branches