mariadb

Tree: d93934d7bc

Author	SHA1	Message	Date
Sergei Golubchik	3a1cf2c85b	MDEV-34679 ER_BAD_FIELD uses non-localizable substrings	1 year ago
Sergei Golubchik	99178311ac	don't disable lto in DEB builds	2 years ago
Sergei Golubchik	a20c79da13	MDEV-25633 MariaDB crashes when compiled with link time optimizations don't force -static-libgcc in gcc builds gcc can decide automatically if it's needed. forcing static libgcc breaks lto.	2 years ago
Sergei Golubchik	3e3fdb25f1	better disable lto for libmysqld_exports.cc e.g. also when -flto is set in CMAKE_CXX_FLAGS_RELWITHDEBINFO	2 years ago
Sergei Golubchik	bfa15f9b34	C/C compilation failures under -flto	1 year ago
Sergei Golubchik	3693fb9581	MDEV-25199 cluster fails to start up if you need innodb in your test - enable it yourself	1 year ago
Sergei Golubchik	e1e836fc76	update results after the merge	1 year ago
Sergei Golubchik	3da565c41d	MDEV-35144 CREATE TABLE ... LIKE uses current innodb_compression_default instead of the create value When adding a column or index that uses plugin-defined sysvar-based options with CREATE ... LIKE the server was using the current value of the sysvar, not the default one. Because parse_option_list() function was used both in create and open and it tried to guess when it's create (need to use current sysvar value and add a new name=value pair to the list) or open (need to use default, without extending the list). Let's move the list extending functionality into a separate function and call it explicitly when needed. Operations that add new objects (CREATE, ALTER ... ADD) will extend the list, other operations (ALTER, CREATE ... LIKE, open) will not.	1 year ago
Marko Mäkelä	bb47e575de	MDEV-34830: LSN in the future is not being treated as serious corruption The invariant of write-ahead logging is that before any change to a page is written to the data file, the corresponding log record must must first have been durably written. On crash recovery, there were some sloppy checks for this. Let us implement accurate checks and flag an inconsistency as a hard error, so that we can avoid further corruption of a corrupted database. For data extraction from the corrupted database, innodb_force_recovery can be used. Before recovery is reading any data pages or invoking buf_dblwr_t::recover() to recover torn pages from the doublewrite buffer, InnoDB will have parsed the log until the final LSN and updated log_sys.lsn to that. So, we can rely on log_sys.lsn at all times. The doublewrite buffer recovery has been refactored in such a way that the recv_sys.dblwr.pages may be consulted while discovering files and their page sizes, but nothing will be written back to data files before buf_dblwr_t::recover() is invoked. A section of the test mariabackup.innodb_redo_overwrite that is parsing some mariadb-backup --backup output has been removed, because that output "redo log block is overwritten" would often be missing in a Microsoft Windows environment as a result of these changes. recv_max_page_lsn, recv_lsn_checks_on: Remove. recv_sys_t::validate_checkpoint(): Validate the write-ahead-logging condition at the end of the recovery. recv_dblwr_t::validate_page(): Keep track of the maximum LSN (if we are checking a non-doublewrite copy of a page) but do not complain LSN being in the future. The doublewrite buffer is a special case, because it will be read early during recovery. Besides, starting with commit `762bcb81b5` the dblwr=true copies of pages may legitimately be "too new". recv_dblwr_t::find_page(): Find a valid page with the smallest FIL_PAGE_LSN that is in the valid range for recovery. recv_dblwr_t::restore_first_page(): Replaced by find_page(). Only buf_dblwr_t::recover() will write to data files. buf_dblwr_t::recover(): Simplify the message output. Do attempt doublewrite recovery on user page read error. Ignore doublewrite pages whose FIL_PAGE_LSN is outside the usable bounds. Previously, we could wrongly recover a too new page from the doublewrite buffer. It is unlikely that this could have lead to an actual error. Write back all recovered pages from the doublewrite buffer here, including for the first page of any tablespace. buf_page_is_corrupted(): Distinguish the return values CORRUPTED_FUTURE_LSN and CORRUPTED_OTHER. buf_page_check_corrupt(): Return the error code DB_CORRUPTION in case the LSN is in the future. Datafile::read_first_page(): Handle FSP_SPACE_FLAGS=0xffffffff in the same way on both 32-bit and 64-bit architectures. Datafile::read_first_page_flags(): Split from read_first_page(). Take a copy of the first page as a parameter. recv_sys_t::free_corrupted_page(): Take the file as a parameter and return whether a message was displayed. This avoids some duplicated and incomplete error messages. buf_page_t::read_complete(): Remove some redundant output and always display the name of the corrupted file. Never return DB_FAIL; use it only in internal error handling. IORequest::read_complete(): Assume that buf_page_t::read_complete() will have reported any error. fil_space_t::set_corrupted(): Return whether this is the first time the tablespace had been flagged as corrupted. Datafile::validate_first_page(), fil_node_open_file_low(), fil_node_open_file(), fil_space_t::read_page0(), fil_node_t::read_page0(): Add a parameter for a copy of the first page, and a parameter to indicate whether the FIL_PAGE_LSN check should be suppressed. Before buf_dblwr_t::recover() is invoked, we cannot validate the FIL_PAGE_LSN, but we can trust the FSP_SPACE_FLAGS and the tablespace ID that may be present in a potentially too new copy of a page. Reviewed by: Debarun Banerjee	1 year ago
Oleksandr Byelkin	600c42ea86	MDEV-34883 LOAD DATA INFILE with geometry data fails We write field using field data charset, so we should read it using the field charset.	1 year ago
Oleksandr Byelkin	c00145de58	fix signed/unsigned and size_t issue	1 year ago
Sergei Golubchik	3b58c6b93f	MDEV-35079 Migrate MySQL5.7 to MariaDB 10.4, then to MariaDB 10.11 Failed correctly detect when partitioning is disabled	1 year ago
Sergei Golubchik	7842cab8c0	MDEV-34318 post-merge fix	1 year ago
Sergei Golubchik	6b436cba01	Revert "Fixes buildbot issue with plugin.fulltext_plugin" This reverts commit `a8010e7689`. The test doesn't require embedded after `ab15628bbc`	1 year ago
Marko Mäkelä	740519e15a	MDEV-35125: Unnecessary buf_pool.page_hash lookups dict_index_t::clear(), btr_drop_temporary_table(): Make use of the root page guess if it is available. btr_read_autoinc(): Invoke btr_root_block_get() to access the root page. btr_blob_free(): Retain a buffer-fix on the page across mtr_t::commit() in order to avoid a buf_pool.page_hash lookup. dict_load_table_one(): Remove a redundant check for page id. It was already validated in buf_page_t::read_complete(). trx_t::apply_log(): Make use of buf_pool.page_fix() to avoid some mtr_t related overhead. Reviewed by: Thirunarayanan Balathandayuthapani	1 year ago
Julius Goryavsky	41b036bff0	This commit adds package dependencies for socat which is needed for testing galera.	1 year ago
Monty	4955f6018a	MDEV-29351 SIGSEGV when doing forward reference of item in select list The reason for the crash was the code assumed that SELECT_LEX.ref_pointer_array would be initialized with zero, which was not the case. This cause the test of if (!select->ref_pointer_array[counter]) in item.cc to be unpredictable and causes crashes. Fixed by zero-filling ref_pointer_array on allocation.	1 year ago
Monty	7e5ad5dd9e	Replace some usage of safe_strcat() with strxnmov()	1 year ago
Monty	0403313bdb	Fixed connect to not call strlen() over and over again in a loop	1 year ago
Monty	864847d1cc	Fixed safe_strcpy_truncated() to get rid of compiler warnings.	1 year ago
Monty	8b057fee62	Fixed core dump in mysqltest in move-file when using wrong paths	1 year ago
Monty	0de2613e7a	Fixed that SHOW CREATE TABLE for sequences shows used table options	1 year ago
Monty	2c52fdd28a	MDEV-32350 Can't selectively restore sequences using innodb tables from backup Added support for sequences to do discard and import tablespace	1 year ago
Monty	ee908140ac	Fixed bug in main.connect test where Connection_errors showed wrong value	1 year ago
Monty	a8010e7689	Fixes buildbot issue with plugin.fulltext_plugin The test is using features not in the embedded server. Fixed by including not_embedded.inc	1 year ago
Monty	bddbef3573	MDEV-34533 asan error about stack overflow when writing record in Aria The problem was that when using clang + asan, we do not get a correct value for the thread stack as some local variables are not allocated at the normal stack. It looks like that for example clang 18.1.3, when compiling with -O2 -fsanitize=addressan it puts local variables and things allocated by alloca() in other areas than on the stack. The following code shows the issue Thread 6 "mariadbd" hit Breakpoint 3, do_handle_one_connection (connect=0x5080000027b8, put_in_cache=<optimized out>) at sql/sql_connect.cc:1399 THD thd; 1399 thd->thread_stack= (char) &thd; (gdb) p &thd (THD *) 0x7fffedee7060 (gdb) p $sp (void ) 0x7fffef4e7bc0 The address of thd is 24M away from the stack pointer (gdb) info reg ... rsp 0x7fffef4e7bc0 0x7fffef4e7bc0 ... r13 0x7fffedee7060 140737185214560 r13 is pointing to the address of the thd. Probably some kind of "local stack" used by the sanitizer I have verified this with gdb on a recursive call that calls alloca() in a loop. In this case all objects was stored in a local heap, not on the stack. To solve this issue in a portable way, I have added two functions: my_get_stack_pointer() returns the address of the current stack pointer. The code is using asm instructions for intel 32/64 bit, powerpc, arm 32/64 bit and sparc 32/64 bit. Supported compilers are gcc, clang and MSVC. For MSVC 64 bit we are using _AddressOfReturnAddress() As a fallback for other compilers/arch we use the address of a local variable. my_get_stack_bounds() that will return the address of the base stack and stack size using pthread_attr_getstack() or NtCurrentTed() with fallback to using the address of a local variable and user provided stack size. Server changes are: - Moving setting of thread_stack to THD::store_globals() using my_get_stack_bounds(). - Removing setting of thd->thread_stack, except in functions that allocates a lot on the stack before calling store_globals(). When using estimates for stack start, we reduce stack_size with MY_STACK_SAFE_MARGIN (8192) to take into account the stack used before calling store_globals(). I also added a unittest, stack_allocation-t, to verify the new code. Reviewed-by: Sergei Golubchik <serg@mariadb.org>	1 year ago
Vladislav Vaintroub	c1fc59277a	MDEV-34929 page-compressed tables do not work on Windows Remove workaround for MDEV-13941, it served for 5 years,and all affected pre-release 10.2 installation should have been already fixed in between. Apparently Innodb is using is_sparse parameter in os_file_set_size() inconsistently, and it passes is_sparse=false now during first file extension. With MDEV-13941 workaround in place, it would unsparse the file, which is makes compression not to work at all anymore.	1 year ago
Sergei Petrunia	89493a9980	MDEV-34993: fix merge into 10.6: OPTIMIZER_ADJ_FIX_CARD_MULT should be ON by default	1 year ago
Marko Mäkelä	a4d2cc931d	MDEV-35174 Possible hang in trx_undo_prev_version() In commit `b7b9f3ce82` (MDEV-34515) we accidentally made the InnoDB MVCC code acquire a shared purge_sys.latch twice. Recursive shared latch acquisition may cause a deadlock of InnoDB threads if another thread in between will start waiting for an exclusive latch. purge_sys_t::latch: In debug builds, use srw_lock_debug instead of srw_spin_lock, so that bugs like this will result in debug assertion failures. trx_undo_report_row_operation(): Pass the view_guard to trx_undo_prev_version() and the rest of the arguments in the same order, so that the work to permute argument registers is minimized.	1 year ago
Sergei Golubchik	5ebda30ccc	Revert "MDEV-35019 Provide a way to enable "rollback XA on disconnect" behavior we had before 10.5.2" This reverts commit `8ae462a220`.	1 year ago
Kristian Nielsen	8ae462a220	MDEV-35019 Provide a way to enable "rollback XA on disconnect" behavior we had before 10.5.2 Implement variable legacy_xa_rollback_at_disconnect to support backwards compatibility for applications that rely on the pre-10.5 behavior for connection disconnect, which is to rollback the transaction (in violation of the XA specification). Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>	1 year ago
Daniel Black	e927e28ebe	Remove HAVE_BROKEN_REALPATH Was only applicable to FreeBSD < ~5.1.9 per: `33173fbe82`	1 year ago
Thomas Klausner	3a4bc9aa35	MDEV-34340 mariadb-backup immediately dumps core on NetBSD Provided implementation for my_get_exepath for NetBSD to avoid segfaults in execution of mariadb-backup.	1 year ago
Daniel Black	f9f1d26f2a	MDEV-34340: MariaDB backup fail on NetBSD If argv0 is null to my_get_exe then don't let the fallback in my_realpath handle this. This was the cause of the original SEGV on NetBSD so we don't want this to be the path for any unimplemented ports of this function.	1 year ago
Daniel Black	171c4aa479	MDEV-34340 move get_exepath to mysys as my_get_exepath Original implementation was from MDEV-13466 (commit `d471469bd2`)	1 year ago
Dave Gosselin	e9c71f3a25	MDEV-34814 mysqld hangs on startup when --init-file target does not exist Set select_thread_in_use only when we're about to enter into the polling loop, not sooner, allowing early proces aborts to exist cleanly: the process won't be waiting for a polling loop that isn't yet polling.	1 year ago
Sergei Petrunia	9849e3f948	MDEV-35072: Assertion with optimizer_join_limit_pref_ratio and 1-table select Pre-11.0 variant: 1. In recompute_join_cost_with_limit(), add an assertion that that partial_join_cost >= 0.0. 2. best_extension_by_limited_search() subtracts COST_EPS from join->best_read. But it is not subtracted from join->positions[0].read_time, add it back. 2. We could get very small negative partial_join_cost due to rounding errors. For fraction=1.0, we were computing essentially this (denote as EXPR-1): $row_read_cost + $where_cost - ($row_read_cost + $where_cost) which should compute to 0. But the computation was done in the following order (left-to-right): EXPR-2: ($row_read_cost + $where_cost) - $row_read_cost - $where_cost this produced a value of -1.1102230246251565e-16 due to a rounding error. Change the computation use EXPR-1 instead of EXPR-2.	1 year ago
Sergei Petrunia	5619f29384	Replace 0.001 with symbolic name COST_EPS optimize_straight_join and best_extension_by_limited_search() use 0.001 to make choice between plans with identical cost deterministic. Use COST_EPS instead of 0.001, like it's done in newer versions.	1 year ago
Oleksandr Byelkin	649e08f8b3	new libfmt 11.0.2	1 year ago
Oleksandr Byelkin	7038382e1b	Fix grant5.test with view protocol	1 year ago
Oleksandr Byelkin	44804c667e	MDEV-18151 pam test result fix Fix result due to the new error message.	1 year ago
Yuchen Pei	d797c9879e	[fixup] Restore the Chinese error translation of ER_SET_PASSWORD_AUTH_PLUGIN It was removed in MDEV-18151	1 year ago
Oleksandr Byelkin	f27b69a447	fix MDEV-26459 test on 32bit systems. (where it test nothing but produce warnngs)	1 year ago
Thirunarayanan Balathandayuthapani	6aaae4c03b	MDEV-35122 Incorrect NULL value handling for instantly dropped BLOB columns Problem: ======= - Redundant table fails to insert into the table after instant drop blob column. Instant drop column only marking the column as hidden and consecutive insert statement tries to insert NULL value for the dropped BLOB column and returns the fixed length of the blob type as 65535. This lead to row size too large error. Fix: ==== For redundant table, if the non-fixed dropped column can be null then set the length of the field type as 0.	1 year ago
Yuchen Pei	cd5577ba4a	Merge branch '10.5' into 10.6	1 year ago
Yuchen Pei	77ed235d50	MDEV-26345 Spider GBH should execute original queries on the data node Stop skipping const items when selecting but skip them when storing their results to spider row to avoid storing in mismatching temporary table fields. Skip auxiliary fields in SELECTing, and do not store the (non-existing) results to the corresponding temporary table accordingly. When there are BOTH auxiliary fields AND const items in the auxiliary field items, do not use the spider GBH. This is a rare occasion if it happens at all and not worth the added complexity to cover it. Use the original item (item_ptr) in constructing GROUP BY and ORDER BY, which also means using item->name instead of field->field_name as aliases in constructing SELECT items. This fixes spurious regressions caused by the above changes in some tests using ORDER BY, such as mdev_24517.test. As a by-product, this also fixes MDEV-29546. Therefore we update mdev_29008.test to include the MDEV-29546 case.	1 year ago
Yuchen Pei	e6daff40e4	MDEV-32524 [fixup] Fixup of spider mem alloc enums missed in a previous merge The merge was 10.4.34->10.5.25	1 year ago
Nayuta Yanagisawa	6080e3af19	MDEV-26912 Spider: Remove dead code related to Oracle OCI Remove the dead-code, in Spider, which is related to the Spider's Oracle OCI support. The code has been disabled for a long time and it is unlikely that the code will be enabled.	4 years ago
Yuchen Pei	03a5c683f9	MDEV-27650 Spider: remove #ifdef SPIDER_HAS_GROUP_BY_HANDLER	1 year ago
Yuchen Pei	0a59aafc5f	MDEV-34659 Bound check in spider cast function query construction During spider query construction of certain cast functions, it locates the last occurrence of a keyword in the output of the Item::print() function and append from there to the constructed query so far. For example, consider the following query SELECT * FROM t2 ORDER BY CAST(c AS INET6); It constructs the following query and executes it at the data node (assuming the data node table is called t0). select cast(t0.`c` as inet6) ``,t0.`c` `c` from `test`.`t1` t0 order by `` When the construction has completed the initial part select cast(t0.`c` It then attempts to construct the " as inet6" part. To that end, it calls print() on the Item_typecast_fbt corresponding to the cast item, and obtains cast(`test`.`t2`.`c` as inet6) It then looks for " as ", and places cursor there for appending: cast(`test`.`t2`.`c` as inet6) ^ In this patch, if the search fails, i.e. there's no " as ...", we make sure that the cursor is not placed before the beginning of the string (out of bound). We also relax the search from " as char" to " as " in the case of CHAR_TYPECAST_FUNC, since there is more than one Item type with this func type. For example, "AS INET6" is an Item_typecast_fbt which has this func type.	1 year ago

1 2 3 4 5 ...

200760 Commits (d93934d7bc51db53c466178cd16e33d5a6c95a78) All Branches Search

200760 Commits (d93934d7bc51db53c466178cd16e33d5a6c95a78)

All Branches