mariadb

Tree: c8783757d6

Author	SHA1	Message	Date
ParadoxV5	c8783757d6	Tag rest of my_vsnprintf users w/ ATTRIBUTE_FORMAT This commit is the final batch of #3360’s `ATTRIBUTE_FORMAT` process, covering various insignificant (as in, requires few-to-no changes in addition to gaining this attribute) functions. One of the main focus of this PR is to enable GCC `-Wformat` (by tagging `ATTRIBUTE_FORMAT`) on ALL `my_snprintf` utilities. To be throughout, functions that delegate to `my_vsnprintf` must also inherit this attribute because `-Wformat` doesn’t trace argument across call stacks.	1 year ago
ParadoxV5	63b0ee26f7	Tag ALL `my_error_reporter`s with `ATTRIBUTE_FORMAT` The function pointer typedef `my_error_reporter` is already tagged. This commit inherits this attribute to all `my_getopt_error_reporter`s and `my_charset_error_reporter`s for consistency. (It future-proofs for deliberate direct uses of those functions.)	1 year ago
ParadoxV5	1c315b3fb1	Tag `myisamdef.h` printers with `ATTRIBUTE_FORMAT` Let GCC `-Wformat` check the formats sent to these `my_vsnprintf` users	1 year ago
ParadoxV5	302caa9549	Tag the `logger` service with `ATTRIBUTE_FORMAT` [Breaking] The `logger` service passes formats and args directly to `my_vsnprintf`. Just like the `my_snprintf` service, I increased this service’s major version because: * Custom suffixes are now a thing (and custom specifiers will soon no longer be). * GCC `-Wformat` now checks formats sent to them.	1 year ago
ParadoxV5	2392bd02d8	Tag the `sql/log.h` family with `ATTRIBUTE_FORMAT` Let GCC `-Wformat` check formats sent to these users of `my_vsnprintf_ex` users (heh)	11 months ago
ParadoxV5	21dfef474c	Reënable ATTRIBUTE_FORMAT on DBUG_PRINT & t/eprint (Re)ënable the `ATTRIBUTE_FORMAT` on `my_dbug.h`’s `_db_doprnt_` (better known by its frontend `DBUG_PRINT`) and `ma_recovery_util.h`’s `tprint` & `eprint` to leverage GCC `-Wformat` checking `c4bf4b7aef` introduced `WAITING_FOR_BUGFIX_TO_VSPRINTF` to conditionally (read: temporarily) disable their `ATTRIBUTE_FORMAT`s. Whatever that bug was aside, MDEV-21978 Zulip suggested that the preference for `%b` was probably intended, although `c52e62a76f` reverted the one in `storage/maria/ma_recovery.c` back to `%s`. All extension migrations (e.g., `%b` ➡ `%sB`) in this commit were on `DBUG_PRINT`.	1 year ago
ParadoxV5	d5ba6f71b9	Tag `push_warning_printf` with `ATTRIBUTE_FORMAT` * Let GCC `-Wformat` check formats sent to these `my_vsnprintf_ex` users * Migrate them from the old extension specifiers to the new `-Wformat`-compatible suffixes	11 months ago
ParadoxV5	2047483417	Tag `my_printf_error` with `ATTRIBUTE_FORMAT` [Breaking] The `my_print_error` service passes formats and args directly to `my_vsnprintf`. Just like the `my_snprintf` service, I increased this service’s major version because: * Custom suffixes are now a thing (and custom specifiers will soon no longer be). * GCC `-Wformat` now checks formats sent to them.	1 year ago
ParadoxV5	618afa32ce	Tag `mysqltest` formatters with `ATTRIBUTE_FORMAT` Let GCC `-Wformat` check the formats sent to these `my_vsnprintf` users and migrate them from the old `%b` to the new `%sB`	1 year ago
ParadoxV5	5100773ab9	Tag `my_vsnprintf.c` with `ATTRIBUTE_FORMAT` [Breaking] Good news: GCC now checks your `my_snprintf` (direct) calls (`-Wformat` was on); Bad news: The build process no longer lets your incorrect formats/arguments sneak past (`-Werror` was also on). As such, this commit also migrates all direct `my_snprintf` calls from the old specifiers to MDEV-21978’s new `-Wformat`-compatible suffixes. The next commits will cover non-direct calls to `my_snprintf`. (I call them “`my_snprintf` descendants”.) This commit does not update the ABI records because there’re more ABI “changes” to come – half a dozen `include/mysql/plugin_*.h.pp`s are now missing the new `__attribute__`s.	1 year ago
ParadoxV5	f3617981ad	`unittest/mytap/tap.h`: Use `ATTRIBUTE_FORMAT` Use `my_attribute.h` whereëver available for compatibility with non-GCC	10 months ago
ParadoxV5	ab50aad15d	Remove ``%`s`` `%b` `%M` `%T` from `my_vsnprintf` MDEV-21978 introduces more preferrable alternatives to those extensions. This commit removes the above old and deprecated syntax. With the code for the old extension formats gone, this commit also improves the code around the new extension suffixes: * Remove code for formatting ``%`T`` * Those code are now dead, for the new suffix-based syntax does not recognize `%sQT`/`%sTQ`. * `suffix_q= TRUE` now additionally replaces `…\|= ESCAPED_ARG`. * Flatten `flag= true if /%iE/` and `do_iE if flag` code together [Breaking] This commit removes obsolete features. Although my earlier work (should have) migrated every usages direct or indirect in the entire MariaDB/server, other codebases might still be using them. This final change will break everything in those outdated foreign lands.	1 year ago
ParadoxV5	6a182553ce	Rename `my_snprintf`’s `%uE` to `%iE` … and delete `%uU` (just use `%d` for that) The follow-up #3360 discovered `%M` usages that suggest that it was designed for `errno` and similar signed `int` (“errno_t”) variables. Besides convenience, if the old `%M` read a `signed int`, so should the new version to maintain compatibility. I only added `%iE` (no `%dE`) to keep the new suffix mechanics away from the popular `%d`. Beïng synonyms (originally), this decision on preserving `%d` also saves the need for `%iI`/`%dD`.	1 year ago
ParadoxV5	891177418e	Make service_my_snprintf.h doc more professional Per https://github.com/MariaDB/server/pull/3309#discussion_r1644436461, it is crucial that services’ headers have reliable and legible docs.	1 year ago
ParadoxV5	b668a960cd	MDEV-21978 Add `%sQ`, `%sB`, `%uE` & `%sT` to `my_vsnprintf` This is the first part of MDEV-21978 make my_vsnprintf to use gcc-compatible format extensions, which adds these alternatives to the MySQL extensions. There’s also the escapes `%sS` & `%uU` for any hippies needing them. These suffixes are compatible with the C standard and therefore as well as `printf` tools such as GCC checks. The old extension formats (e.g., `%M`) are now effectively deprecated, although they’re left intact for now. For a more sequential MDEV-21978 process, a separate commit will delete them after we migrate all `my_vsnprintf` usages to the new preferred syntax. The service’s major version bumped nonetheless for the new significance of suffixes. [Breaking] This commit may fail * on places needing the aforementioned escapes * because of the major version bump Reviewed-by: Andrew Hutchings <andrew@mariadb.org> Reviewed-by: Brandon Nesterenko <brandon.nesterenko@mariadb.com>	1 year ago
ParadoxV5	06851e7f77	Merge `vsnprintf` `%b`, `%T` & `%M` code into `%s`/`%u` This commit prepares for MDEV-21978 which wants to migrate extensions from specifiers to standard-compatible suffixes, complete with boolean local vars. In this new format, branches will land on `%s`/`%u` before processing the suffix. This commit contains non-breaking portions of MDEV-21978 work. This commit also changes an `if`-`else` chain to a `switch` block simply because it’s an eyesore.	1 year ago
Sergei Golubchik	9799777992	MDEV-35919 Server crashes in Item_func_vec_distance::fix_length_and_dec upon reading from I_S table	10 months ago
Sergei Golubchik	49821f21ce	MDEV-9158 post-merge fixes * format error messages (spaces, "bytes") * speed up "length too large" test from 12s to 70ms * fix it for --parallel * fix "named pipe" test to actually test a named pipe * add the standard header to tests, enable result log * fix for ASAN * read loop to workaround small (64K) pipe buffer size * clarified error message for the file too large	12 months ago
dingweiqing	4dee592450	MDEV-9158 Read max size bytes from encryption key file and ignore remain bytes Previously plugin check aes key file size to make sure its size isn't too large before reading it, this commit change the way to read only max aes key file size bytes. This way can support named pipe as a coproduct .	3 years ago
Sergei Golubchik	e7f7789482	cleanup: `select ... into` tests * automatically disable ps2 and cursor protocol when the select statement returns no result set * remove manual {disable\|enable}_{ps2\|cursor}_protocol from around `select ... into` in tests * other misc collateral test cleanups	12 months ago
Sergei Golubchik	9ee09a33bb	Merge branch '11.7' into 11.8	10 months ago
Sergei Petrunia	80067a69fe	MDEV-36057: Assertion failure on 2nd execution of parameterized PS Followup to fix for MDEV-35318: In Prepared_statement::execute_loop(), if we enter this function with lex->needs_reprepare=true, we need to re-prepare the statement. We also need to call set_parameters() to get PS parameter values. We failed to do this and that's the bug. Note that we need to also handle the other reprepare scenario: when we get into Prepared_statement::execute_loop(), call set_parameters() and then hit a "DDL was changed" error with reprepare_observer, we should NOT call set_parameters() again. The parameters have already been transferred to the reprepared statement in Prepared_statement::reprepare()\|swap_parameter_array().	10 months ago
Ian Gilfillan	c516bea30a	Update mariadb-import man page with --innodb-optimize-keys option	10 months ago
Sergei Golubchik	2d971709a8	MDEV-36026 Problem with INSERT SELECT on NOT NULL columns while having BEFORE UPDATE trigger MDEV-8605 and MDEV-19761 didn't handle INSERT (columns) SELECT followup for `a69da0c31e`	10 months ago
Sergei Golubchik	2b17265ae2	MDEV-35186 IGNORED attribute has no effect on vector keys	10 months ago
Sergey Vojtovich	55d1f6c229	MDEV-35069 IMPORT TABLESPACE does not work for tables with vector, although allowed Propagate discard/import tablespace request to hlindexes. Let FLUSH TABLES ... FOR EXPORT open/lock hlindexes, so that InnoDB prepares hlindexes for export. Moved reset_hlindexes() to external_lock(F_UNLCK), so that hlindexes are available for export until UNLOCK TABLES. Closes #3631	1 year ago
Sergei Golubchik	e240da3b19	MDEV-35146 Vector-related error messages worth improving when possible use THD::push_warning_truncated_value_for_field() to push the truncated warning consistently with other data types	10 months ago
Sergei Golubchik	a37eb6d013	MDEV-35792 Adding a regular index on a vector column leads to invalid table structure don't create a prefix key for types that don't support prefix keys	10 months ago
Sergei Golubchik	1ea79d1774	MDEV-35317 Server crashes in mhnsw_insert upon using vector key on a Spider table don't allow VECTOR indexes in SPIDER tables	10 months ago
Sergei Golubchik	40d39b1176	MDEV-35221 Vector values do not survive mariadb-dump / restore force --hex-dump for fields of GEOMETRY, BIT, and VECTOR types. Until MDEV-35831 is fixed, vector type is detected by name.	10 months ago
Daniel Black	9e3a541d1e	MDEV-35049: Use CRC-32C and avoid allocating heap (postfix) The n_pointers member of block is only defined (in the C++ meaning) under the 'if defined UNIV_AHI_DEBUG \|\| defined UNIV_DEBUG' condition. As without this change, this won't compile under WITH_MSAN=ON build for non-debug builds.	10 months ago
Monty	2e1ade5307	Added missing DROP PROCEDURE to mtr test main.log_state	10 months ago
Monty	74f70c3944	Fixed costs in JOIN_TAB::estimate_scan_time() and HEAP MDEV-35958 Cost estimates for materialized derived tables are poor Estimate_scan_time() calculates the cost of scanning a derivied table. The old code did not take into account that the temporary table heap table may be converted to Aria. Things fixed: - Added checking if the temporary tables data will fit in the heap. If not, then calculate the cost based on the designated internal temporary table engine (Aria). - Removed MY_MAX(records, 1000) and instead trust the optimizer's estimate of records. This reduces the cost of temporary tables a bit for small tables, which caused a few changes in mtr results. - Fixed cost calculation for HEAP. - HEAP costs->row_next_find_cost was not set. This does not affect old costs calculation as this cost slot was not used anywhere. Now HEAP cost->row_next_find_cost is set, which allowed me to remove some duplicated computation in ha_heap::scan_time() Reviewed by: Sergei Petrunia <sergey@mariadb.com>	10 months ago
Sergei Golubchik	a2f0234c82	MDEV-36011 Server crashes in Charset::mbminlen / Item_func_vec_fromtext::val_str upon mixing vector type with string	10 months ago
Sergei Golubchik	6fc75e0868	MDEV-35922 Server crashes in mhnsw_read_first upon using vector key with views	10 months ago
Sergei Golubchik	69041af67d	only enforce innodb_force_primary_key when a table is created not when a hlindex table is auto-discovered internally	10 months ago
Sergei Golubchik	5b8c087e84	MDEV-36005 Server crashes when checking/updating a table having vector key after enabling innodb_force_primary_key if creating a hlindex table failed, it should not unlock main table's plugin	10 months ago
Sergey Vojtovich	e928bf1c0e	MDEV-35292 - ALTER TABLE re-creating vector key is no-op with non-copying alter algorithms (default) ALTER TABLE didn't recognize VECTOR index options change and kept table intact. VECTOR indexes have their own options_struct, let ALTER TABLE use it.	1 year ago
Sergei Golubchik	c453391187	MDEV-35834 Server crash in FVector::distance_to upon concurrent SELECT a start node in the shared context must be atomically assigned to a valid and fully initialized node otherwise a concurrent thread might use it before it's safe	10 months ago
Sergei Golubchik	44d0f5864e	fix the test case	10 months ago
Sergei Golubchik	adc1beb868	relax the assert it is possible (rocksdb_rpl.mdev12179) to have innobase_xa_prepare called and then innobase_commit, not innobase_commit_ordered, in autocommit mode. for example, with two XA-capable engines and no binlog. Or (galera.galera_as_master), WSREP_EMULATE_BINLOG() enables binlogging but SQL_BIN_LOG=0 disables write_transaction_to_binlog().	10 months ago
Sergei Golubchik	fe31424e00	fix sporadic test failures caused by InnoDB #record estimation	10 months ago
Sergei Golubchik	ba01c2aaf0	Merge branch '11.4' into 11.7 * rpl.rpl_system_versioning_partitions updated for MDEV-32188 * innodb.row_size_error_log_warnings_3 changed error for MDEV-33658 (checks are done in a different order)	10 months ago
Dave Gosselin	edd52b7fc7	MDEV-30469 Feature rebase Upon rebase, some error codes changed order so record tests to update accordingly. Merge with trigger changes from MDEV-34724.	10 months ago
Dave Gosselin	5e07d1abd4	MDEV-35848, MDEV-35568 Reintroduce delete_while_scanning for multi_delete Reintroduces delete_while_scanning optimization for multi_delete. Reverse some test changes from the initial feature devlopment now that we delete-on-the-fly once again.	10 months ago
Sergei Petrunia	8ec275da16	MDEV-35955 Wrong result for UPDATE ... ORDER BY LIMIT which uses tmp.table (Variant 2) Multi-table UPDATE ... ORDER BY ... LIMIT could update the wrong rows when ORDER BY was resolved by Using temporary + Using filesort. == Background: ref_pointer_array == join->order[->next]->item point into join->ref_pointer_array, which has pointers to the used Item objects. This indirection is employed so that we can switch the ORDER BY expressions from using the original Items to using the values of their "image" fields in the temporary table. The variant of ref_pointer_array that has pointers to temp table fields is created when JOIN::make_aggr_tables_info() calls change_refs_to_tmp_fields(). == The problem == The created array didn't match element-by-element the original ref_pointer_array. When arrays were switched, ORDER BY elements started to point to the wrong temp.table fields, causing the wrong sorting. == The cause == The cause is JOIN::add_fields_for_current_rowid(). This function is called for UPDATE statements to make the rowids of rows in the original tables to be saved in the temporary tables. It adds extra columns to the select list in table_fields argument. However, select lists are organized in a way that extra elements must be added to the front* of the list, and then change_refs_to_tmp_fields() will add extra fields to the end of ref_pointer_array. So, add_fields_for_current_rowid() adds new fields to the back of table_fields list. This caused change_refs_to_tmp_fields() to produce ref_pointer_array slice with extra elements in the front, causing any references through ref_pointer_array to come to the wrong values. == The fix == Make JOIN::add_fields_for_current_rowid() add fields to the front of the select list.	10 months ago
Dave Gosselin	5001300bd4	MDEV-30469 Support ORDER BY and LIMIT for multi-table DELETE, index hints for single-table DELETE We now allow multitable queries with order by and limit, such as: delete t1., t2. from t1, t2 order by t1.id desc limit 3; To predict what rows will be deleted, run the equivalent select: select t1., t2. from t1, t2 order by t1.id desc limit 3; Additionally, index hints are now supported with single table delete statements: delete from t2 use index(xid) order by (id) limit 2; This approach changes the multi_delete SELECT result interceptor to use a temporary table to collect row ids pertaining to the rows that will be deleted, rather than directly deleting rows from the target table(s). Row ids are collected during send_data, then read during send_eof to delete target rows. In the event that the temporary table created in memory is not big enough for all matching rows, it is converted to an aria table. Other changes: - Deleting from a sequence now affects zero rows instead of emitting an error Limitations: - The federated connector does not create implicit row ids, so we to use a key when conditionally deleting. See the change in federated_maybe_16324629.test	12 months ago
Dave Gosselin	02dc8615f2	MDEV-30469 (refactoring) Support ORDER BY and LIMIT for multi-table DELETE... This patch includes a few changes to make the code easier to maintain: - Renamed SQL_I_List::link_in_list to SQL_I_List::insert. link_in_list was ambiguous as it could refer to a link or it could refer to a node - Remove field_name local variable in multi_update::initialize_tables because it is not used when creating the temporary tables - multi_update changes: - Move temp table callocs to init, a more natural location for them, and moved tables_to_update to const member variable so we don't recompute it. - Filter out jtbm tables and tables not in the update map, pushing those that will be updated into an update_targets container. This simplifies checks and loops in initialize_tables.	12 months ago
Sergei Petrunia	14a80f0929	MDEV-35318 Assertion `tl->jtbm_subselect' failed... - PART 2 After the fix in the previous commit, we should never end up in a situation where select_lex->first_cond_optimization=false (i.e, "it's done") but select_lex->leaf_tables_saved==false ("not done"). So, in setup_tables(), revert the the condition added in the fix for MDEV-25008. Add an assert instead.	10 months ago
Sergei Petrunia	0e21ff8ca4	MDEV-35318 Assertion `tl->jtbm_subselect' failed in JOIN::calc_allowed_top_level_tables Alternative, more general fix, Variant 2. The problem was as follows: Suppose we are running a PS/SP statement and we get an error while doing optimization that is done once per statement life. This may leave the statement data structures in an undefined state, where it is not safe to execute it again. The fix: introduce LEX::needs_reprepare and set it in such cases. Make PS and SP runtime check it and re-prepare the statement before executing it again. We do not use Reprepare_observer, because it turns out it is tightly tied to watching versions of statement's objects. For example, it must not be used when running the statement for the first time, exactly when the once-per-statement-lifetime optimizations are done.	10 months ago

1 2 3 4 5 ...

202734 Commits (c8783757d6c761291bd2fe9dcf85d2607ac005b3) All Branches Search

202734 Commits (c8783757d6c761291bd2fe9dcf85d2607ac005b3)

All Branches