Browse Source

Tag `myisamdef.h` printers with `ATTRIBUTE_FORMAT`

Let GCC `-Wformat` check the formats sent to these `my_vsnprintf` users
pull/3833/head
ParadoxV5 1 year ago
committed by Sergei Golubchik
parent
commit
1c315b3fb1
  1. 1
      storage/myisam/ha_myisam.cc
  2. 9
      storage/myisam/myisamdef.h

1
storage/myisam/ha_myisam.cc

@ -166,6 +166,7 @@ static void mi_check_print(HA_CHECK *param, const LEX_CSTRING* msg_type,
// collect errors printed by mi_check routines
ATTRIBUTE_FORMAT(printf, 3, 0)
static void mi_check_print_msg(HA_CHECK *param, const LEX_CSTRING *msg_type,
const char *fmt, va_list args)
{

9
storage/myisam/myisamdef.h

@ -754,9 +754,12 @@ static inline check_result_t mi_check_index_tuple(MI_INFO *info, uint keynr,
/* Functions needed by mi_check */
int killed_ptr(HA_CHECK *param);
void mi_check_print_error(HA_CHECK *param, const char *fmt, ...);
void mi_check_print_warning(HA_CHECK *param, const char *fmt, ...);
void mi_check_print_info(HA_CHECK *param, const char *fmt, ...);
void mi_check_print_error(HA_CHECK *param, const char *fmt, ...)
ATTRIBUTE_FORMAT(printf, 2, 3);
void mi_check_print_warning(HA_CHECK *param, const char *fmt, ...)
ATTRIBUTE_FORMAT(printf, 2, 3);
void mi_check_print_info(HA_CHECK *param, const char *fmt, ...)
ATTRIBUTE_FORMAT(printf, 2, 3);
pthread_handler_t thr_find_all_keys(void *arg);
extern void mi_set_index_cond_func(MI_INFO *info, index_cond_func_t check_func,
void *func_arg);

Loading…
Cancel
Save