mariadb

Tree: a79b033b35

Author	SHA1	Message	Date
Marko Mäkelä	a79b033b35	MDEV-16457 mariabackup 10.2+ should default to innodb_checksum_algorithm=crc32 Since MariaDB Server 10.2.2 (and MySQL 5.7), the default value of innodb_checksum_algorithm is crc32 (CRC-32C), not the inefficient "innodb" checksum. Change Mariabackup to use the same default, so that checksum validation (when using the default algorithm on the server) will take less time during mariabackup --backup. Also, mariabackup --prepare should be a little faster, and the server should read backups faster, because the page checksums would only be validated against CRC-32C.	7 years ago
Marko Mäkelä	2ca904f0ca	MDEV-13103 Deal with page_compressed page corruption fil_page_decompress(): Replaces fil_decompress_page(). Allow the caller detect errors. Remove duplicated code. Use the "safe" instead of "fast" variants of decompression routines. fil_page_compress(): Replaces fil_compress_page(). The length of the input buffer always was srv_page_size (innodb_page_size). Remove printouts, and remove the fil_space_t* parameter. buf_tmp_buffer_t::reserved: Make private; the accessors acquire() and release() will use atomic memory access. buf_pool_reserve_tmp_slot(): Make static. Remove the second parameter. Do not acquire any mutex. Remove the allocation of the buffers. buf_tmp_reserve_crypt_buf(), buf_tmp_reserve_compression_buf(): Refactored away from buf_pool_reserve_tmp_slot(). buf_page_decrypt_after_read(): Make static, and simplify the logic. Use the encryption buffer also for decompressing. buf_page_io_complete(), buf_dblwr_process(): Check more failures. fil_space_encrypt(): Simplify the debug checks. fil_space_t::printed_compression_failure: Remove. fil_get_compression_alg_name(): Remove. fil_iterate(): Allocate a buffer for compression and decompression only once, instead of allocating and freeing it for every page that uses compression, during IMPORT TABLESPACE. Also, validate the page checksum before decryption, and reduce the scope of some variables. fil_page_is_index_page(), fil_page_is_lzo_compressed(): Remove (unused). AbstractCallback::operator()(): Remove the parameter 'offset'. The check for it in FetchIndexRootPages::operator() was basically redundant and dead code since the previous refactoring.	7 years ago
Alexander Barkov	2cdb483bc4	MDEV-15352 AUTO_INCREMENT breaks after updating a column value to a negative number	7 years ago
Alexander Barkov	23ced2f846	MDEV-16311 Server crash when using a NAME_CONST() with a CURSOR Problem: The problem was most likely introduced by a fix for MDEV-11597 (commit `5f0c31f928`) which removed the assignment "killed= KILL_BAD_DATA" from THD::raise_condition(). Before MDEV-11597, sp_head::execute() tested thd->killed after looping through the SP instructions and exited with an error if thd->killed is set. After MDEV-11597, sp_head::execute() stopped to notice errors and set the OK status on top of the error status, which crashed on assert. Fix: Making sp_cursor::fetch() return -1 if server_side_cursor->fetch(1) left an error in the diagnostics area. This makes the statement "err_status= i->execute(thd, &ip)" in sp_head::execute() set the error code and correctly break the SP instruction loop and return on error without setting the OK status.	7 years ago
Sergei Petrunia	8662015c90	MDEV-15304: Server crash in print_keydup_error / key_unpack or unexpected ER_DUP_KEY Adjust the patch to match the variant accepted into the upstream: undo the changes in ha_rocksdb::load_hidden_pk_value().	7 years ago
Sergei Petrunia	931daaf79b	MDEV-15319: [SQL Layer] Server crashes in Field::set_null / myrocks::ha_rocksdb ... Added a testcase	7 years ago
Alexander Barkov	2412c15191	MDEV-15870 Using aggregate and window function in unexpected places can crash the server	7 years ago
Alexander Barkov	ae0aefb1c5	MDEV-12060 Crash in EXECUTE IMMEDIATE with an expression returning a GRANT command This problem was earlier fixed by MDEV-14603. Only adding 10.2 specific tests.	7 years ago
Marko Mäkelä	8f5f0575ab	MDEV-16456 InnoDB error "returned OS error 71" complains about wrong path When attempting to rename a table to a non-existing database, InnoDB would misleadingly report "OS error 71" when in fact the error code is InnoDB's own (OS_FILE_NOT_FOUND), and not report both pathnames. Errors on rename could occur due to reasons connected to either pathname. os_file_handle_rename_error(): New function, to report errors in renaming files.	7 years ago
Vicențiu Ciorbaru	d54d067601	Undo wrong my_free overflow	7 years ago
Vicențiu Ciorbaru	ecd4c2b4a9	Add missed change from `7ffa82b03c`	7 years ago
Vladislav Vaintroub	aba2d7301f	MDEV-13122 Backup myrocksdb with mariabackup.	7 years ago
Vladislav Vaintroub	ea70586282	MDEV-16300 : remove rocksdb checkpoint created by mariabackup. Add variable rocksdb_remove_mariabackup_checkpoint. If set, it will remove $rocksdb_datadir/mariabackup-checkpoint directory. The variable is to be used by exclusively by mariabackup, to remove temporary checkpoints.	7 years ago
Marko Mäkelä	dc9c555415	MDEV-16367 mariabackup: error: failed to copy enough redo log log_copying_thread(): Keep copying redo log until the end has been reached. (Previously, we would stop copying as soon as the first batch of xtrabackup_copy_logfile() returned.) log_copying: Remove. Use log_copying_running instead. copy_logfile: Remove. Log copying will now only be invoked from 2 places: from xtrabackup_backup_func() for the initial batch, and from log_copying_thread() until all of the log has been read. Use the global variable metadata_to_lsn for determining if the final part of the log is being copied. xtrabackup_copy_log(): Add diagnostic messages for terminating the copying. These messages should be dead code, because log_group_read_log_seg() should be checking for the same. xtrabackup_copy_logfile(): Correct the retrying logic. If anything was successfully read, process the portion that was read. On failure, let the caller close dst_log_file. io_watching_thread(): Stop throttling during the last phase of copying the log (metadata_to_lsn!=0). The final copying of the log will now be performed in log_copying_thread(). stop_backup_threads(): Clean up the message about stopping the log copying thread. xtrabackup_backup_low(): Read metadata_to_lsn from the latest checkpoint header page, even if it is the first page. Let the log_copying_thread take care of copying all of the redo log.	7 years ago
Marko Mäkelä	619c277a6c	Mariabackup: Make some globals static	7 years ago
Marko Mäkelä	df42830b28	Merge 10.1 into 10.2	7 years ago
Marko Mäkelä	1d4e1d3263	Merge 10.0 to 10.1	7 years ago
Marko Mäkelä	55abcfa7b7	MDEV-16124 fil_rename_tablespace() times out and crashes server during table-rebuilding ALTER TABLE InnoDB insisted on closing the file handle before renaming a file. Renaming a file should never be a problem on POSIX systems. Also on Windows it should work if the file was opened in FILE_SHARE_DELETE mode. fil_space_t::stop_ios: Remove. We no longer need to stop file access during rename operations. fil_mutex_enter_and_prepare_for_io(): Remove the wait for stop_ios. fil_rename_tablespace(): Remove the retry logic; do not close the file handle. Remove the unused fault injection that was added along with the DATA DIRECTORY functionality (MySQL WL#5980). os_file_create_simple_func(), os_file_create_func(), os_file_create_simple_no_error_handling_func(): Include FILE_SHARE_DELETE in the share_mode. (We will still prevent multiple InnoDB instances from using the same files by not setting FILE_SHARE_WRITE.)	7 years ago
Otto Kekäläinen	738c5c8424	MDEV-12642: Build deb source packages on buildbot, just not on Travis-CI	8 years ago
Marko Mäkelä	3b7da8a44c	MDEV-15824 innodb_defragment=ON trumps innodb_optimize_fulltext_only=ON in OPTIMIZE TABLE ha_innobase::optimize(): If both innodb_defragment and innodb_optimize_fulltext_only are at their default settings (OFF), fall back to ALTER TABLE. Else process one or both options.	7 years ago
Marko Mäkelä	f6376bfd1c	Add FLUSH TABLES to avoid corruption of MyISAM system tables	7 years ago
Marko Mäkelä	41cbe92bf1	Remove dead code that was added in MDEV-5834 ha_innobase::set_partition_owner_stats(): Remove (unused function). ha_innobase::ha_partition_stats: Remove (the variable is never read). Remove unused ut_timer functions.	7 years ago
Marko Mäkelä	8dc70c862b	MDEV-16376 ASAN: heap-use-after-free in gcol.innodb_virtual_debug After a failed ADD INDEX, dict_index_remove_from_cache_low() could iterate the index fields and dereference a freed virtual column object when trying to remove the index from the v_indexes of the virtual column. This regression was caused by a merge of MDEV-16119 InnoDB lock->index refers to a freed object. ha_innobase_inplace_ctx::clear_added_indexes(): Detach the indexes of uncommitted indexes from virtual columns, so that the iteration in dict_index_remove_from_cache_low() can be avoided. ha_innobase::prepare_inplace_alter_table(): Ignore uncommitted corrupted indexes when rejecting ALTER TABLE. (This minor bug was revealed by the extension of the test case.) dict_index_t::detach_columns(): Detach an index from virtual columns. Invoked by both dict_index_remove_from_cache_low() and ha_innobase_inplace_ctx::clear_added_indexes(). dict_col_t::detach(const dict_index_t& index): Detach an index from a column. dict_col_t::is_virtual(): Replaces dict_col_is_virtual(). dict_index_t::has_virtual(): Replaces dict_index_has_virtual().	7 years ago
Marko Mäkelä	5932a4e77d	MDEV-13834: Upgrade failure from 10.1 innodb_encrypt_log log_crypt_101_read_block(): Mimic MariaDB 10.1, and use the first encryption key if the key for the checkpoint cannot be found. Redo log encryption key rotation was ultimately disabled in MDEV-9422 (MariaDB 10.1.13) due to design issues. So, from MariaDB 10.1.13 onwards only one log encryption key should matter. recv_log_format_0_recover(): Add the parameter 'bool crypt'. Indicate when the log cannot be decrypted for upgrade, instead of making a possibly false claim that the log requires crash recovery. init_crypt_key(): Remove extra space from a message.	7 years ago
gvtek	40dc1a6846	Better Link Spacing Just spacing out the links on separate linkes, they were running together in a block of text and could be a little hard for some people to differentiate where one begins and the next ends. Seems silly, but just trying to help in the formatting a bit.	7 years ago
Igor Babaev	b2f86ebdd2	MDEV-16353 Server crash on query with CTE This bug caused crashes for queries with unreferenced non-recursive CTEs specified by unions.It happened because the function st_select_lex_unit::prepare() tried to use the value of the field 'derived' that could not be set for unferenced CTEs as there was no derived table associated with an unreferenced CTE.	7 years ago
Marko Mäkelä	a31e99a89c	Remove an unnecessary #include	7 years ago
Vladislav Vaintroub	c1698e8dc5	MDEV-16303 - do not install wsrep.ini on Windows	7 years ago
Marko Mäkelä	6f96ff7268	Allow tests to work with cmake -DPLUGIN_PARTITION=NO	7 years ago
Marko Mäkelä	7269c70821	Add an end-marker to ease future merges	7 years ago
Marko Mäkelä	18934fb583	Merge 10.1 into 10.2	7 years ago
Marko Mäkelä	6aa50bad39	MDEV-16283 ALTER TABLE...DISCARD TABLESPACE still takes long on a large buffer pool Also fixes MDEV-14727, MDEV-14491 InnoDB: Error: Waited for 5 secs for hash index ref_count (1) to drop to 0 by replacing the flawed wait logic in dict_index_remove_from_cache_low(). On DISCARD TABLESPACE, there is no need to drop the adaptive hash index. We must drop it on IMPORT TABLESPACE, and eventually on DROP TABLE or DROP INDEX. As long as the dict_index_t object remains in the cache and the table remains inaccessible, the adaptive hash index entries to orphaned pages would not do any harm. They would be dropped when buffer pool pages are reused for something else. btr_search_drop_page_hash_when_freed(), buf_LRU_drop_page_hash_batch(): Remove the parameter zip_size, and pass 0 to buf_page_get_gen(). buf_page_get_gen(): Ignore zip_size if mode==BUF_PEEK_IF_IN_POOL. buf_LRU_drop_page_hash_for_tablespace(): Drop the adaptive hash index even if the tablespace is inaccessible. buf_LRU_drop_page_hash_for_tablespace(): New global function, to drop the adaptive hash index. buf_LRU_flush_or_remove_pages(), fil_delete_tablespace(): Remove the parameter drop_ahi. dict_index_remove_from_cache_low(): Actively drop the adaptive hash index if entries exist. This should prevent InnoDB hangs on DROP TABLE or DROP INDEX. row_import_for_mysql(): Drop any adaptive hash index entries for the table. row_drop_table_for_mysql(): Drop any adaptive hash index for the table, except if the table resides in the system tablespace. (DISCARD TABLESPACE does not apply to the system tablespace, and we do no want to drop the adaptive hash index for other tables than the one that is being dropped.) row_truncate_table_for_mysql(): Drop any adaptive hash index entries for the table, except if the table resides in the system tablespace.	7 years ago
Marko Mäkelä	b7985a45a6	Fix type mismatch	7 years ago
Marko Mäkelä	35a9c90fff	MDEV-14589 InnoDB should not lock a delete-marked record When the transaction isolation level is SERIALIZABLE, or when a locking read is performed in the REPEATABLE READ isolation level, InnoDB must lock delete-marked records in order to prevent another transaction from inserting something. However, at READ UNCOMMITTED or READ COMMITTED isolation level or when the parameter innodb_locks_unsafe_for_binlog is set, the repeatability of the reads does not matter, and there is no need to lock any records. row_search_for_mysql(): Skip locks on delete-marked committed records upfront, instead of invoking row_unlock_for_mysql() afterwards. The unlocking never worked for secondary index records.	7 years ago
Marko Mäkelä	8a42ad7a5d	MDEV-13834 10.2 wrongly recognizes 10.1.10 innodb_encrypt_log=ON data as after-crash and refuses to start infos[]: Allocate enough entries to accommodate all keys from both checkpoint pages. infos_used: The size of infos[]. get_crypt_info(): Merge to the only caller, log_crypt_101_read_block(). log_crypt_101_read_block(): Do not validate the log block checksum, because it will not be valid when upgrading from MariaDB 10.1.10. Instead, check that the encryption key exists. log_crypt_101_read_checkpoint(): Append to infos[] instead of overwriting.	7 years ago
Sergei Petrunia	1a8afb4885	MDEV-16310: rocksdb.check_ignore_unknown_options fails on OS X Use a compatible xargs command-line arguments.	7 years ago
Monty	13c241c64f	Fixed memory overrun in binlog_encryption.encrypted_master Problem was that max_row_lengt() used different bitmap than pack_row()	7 years ago
Monty	2d62a4cb2f	Updated results for galera_encrypt_tmp_files	7 years ago
Monty	d8da920264	MDEV-10679 Crash in performance schema and partitioning with discovery Crash happened because in discover, table->work_part_info was not properly reset before execution. Fixed by resetting before calling execute alter table, create table or mysql_create_frm_image.	8 years ago
Monty	199517f501	Avoid warnings in String::copy when copying string on itself (ok to do)	8 years ago
Monty	5a16fe0e6f	Fixed compiler warnings When merging this with 10.2 and later, one can just use the 10.2 or later code	8 years ago
Monty	29dbb23fb7	MDEV-16093 Memory leak with triggers Problem was that blob memory allocated in Table_trigger_list was not properly freed	8 years ago
Sergei Golubchik	9e22cae1cf	embedded use-after-free ASAN error Close MYSQL (and destroy THD) in the same thread where it was used, because THD embeds MDL_context, that owns some LF_PINS, that remember a pointer to my_thread_var->stack_ends_here.	8 years ago
Vladislav Vaintroub	b8fdd56a4d	Fix conversion warnings/errors.	8 years ago
Monty	7a4f81b4c0	Extend debug_assert_on_not_freed_memory Don't check global_memory_used if debug_assert_on_not_freed_memory is not set	8 years ago
Monty	494c981d23	Merge remote-tracking branch 'origin/10.1' into 10.2	8 years ago
Monty	72a8d29e00	Fixed archive to work with record[1] ha_archive::max_row_length() and ha_archive::pack_row() didn't use record parameter properly. Especially testing of null was wrong for record[1]	8 years ago
Monty	4cd2a0eb56	MDEV-15243 Crash with virtual fields and row based binary logging The cause of this was several different bugs: - When using binary logging with binlog_row_image=FULL the all bits in read_set was set, which caused a different (wrong) pattern for marking vcol_set. - TABLE::mark_virtual_columns_for_write() didn't in all cases mark vcol_set with the vcol_field. - TABLE::update_virtual_fields() has to update all vcol fields on REPLACE if binary logging with FULL is used. - VCOL_UPDATE_INDEXED should update all vcol fields part of an index that was not updated by VCOL_UPDATE_FOR_READ - max_row_length() calculated length of NULL and not used fields. This didn't cause any crash, but used more memory than needed.	8 years ago
Marko Mäkelä	1c8c6bcd6f	MDEV-13779 InnoDB fails to shut down purge, causing hang thd_destructor_proxy(): Ensure that purge actually exits, like the logic should have been ever since MDEV-14080. srv_purge_shutdown(): A new function to wait for the purge coordinator to exit. Before exiting, the purge coordinator will ensure that all purge workers have exited.	8 years ago
Marko Mäkelä	bfed1bfe28	Add a missing dependency to a test	8 years ago

1 2 3 4 5 ...

180219 Commits (a79b033b359b882f2fe88051781c6e850bd71780) All Branches Search

180219 Commits (a79b033b359b882f2fe88051781c6e850bd71780)

All Branches