mariadb

Commit Graph

Author	SHA1	Message	Date
Marko Mäkelä	b432d4ad66	MDEV-16080 Crash in online table rebuild with concurrent DELETE of many BLOBs Merge a fix from MySQL 8.0.11. row_log_table_apply_delete(): Remove the unused parameter thr. (This removal was not part of the Oracle fix.)	8 years ago
Mayank Prasad	f47eac2882	Bug #25928471 : ONLINE ALTER AND CONCURRENT DELETE ON TABLE WITH MANY TEXT COLUMNS CAUSES CRASH Issue: ------ Prefix for externally stored columns were being stored in online_log when a table is altered and alter causes table to be rebuilt. Space in online_log is limited and if length of prefix of externally stored columns is very big, then it is being written to online log without making sure if it fits. This leads to memory corruption. Fix: ---- After fix for Bug#16544143, there is no need to store prefixes of externally stored columnd in online_log. Thus remove the code which stores column prefixes for externally stored columns. Also, before writing anything on online_log, make sure it fits to available memory to avoid memory corruption. Read RB page for more details. Reviewed-by: Annamalai Gurusami <annamalai.gurusami@oracle.com> RB: 18239	8 years ago
Jacob Mathew	da3c5c3c9a	MDEV-15698: Spider ignores syntax errors in connection string in COMMENT field When a comma separator is missing between COMMENT fields, Spider ignores the parameter values that are beyond the last expected parameter value. There are also some error messages that Spider does generate on COMMENT fields that are incorrectly formed. I have introduced additional infrastructure in Spider to fix these problems. Author: Jacob Mathew. Reviewer: Kentoku Shiba. Cherry-Picked: Commit `c10da98` on branch bb-10.3-MDEV-15698	8 years ago
Sergei Golubchik	42fac32413	Merge branch '5.5' into 10.0	8 years ago
Jacob Mathew	8fdeb079b9	MDEV-15712: If remote server used by Spider table is unavailable, some operations hang for a long time When an attempt to connect to the remote server fails, Spider retries to connect to the remote server 1000 times or until the connection attempt succeeds. This is perceived as a hang if the remote server remains unavailable. I have introduced changes in Spider's table status handler to fix this problem. Author: Jacob Mathew. Reviewer: Kentoku Shiba. Cherry-Picked: Commit `6ee6933` on branch bb-10.3-MDEV-15712	8 years ago
Sergei Golubchik	fab383aac0	Use after free in authentication	8 years ago
Sergei Golubchik	a52c46e069	Bug#25471090: MYSQL USE AFTER FREE a better fix	8 years ago
Jan Lindström	74abc32d30	Merge pull request #731 from codership/MDEV-15803 MDEV-15803 Fix and re-enable test galera_var_auto_inc_control_on	8 years ago
Jan Lindström	cf333b7fda	Merge branch '10.1' into MDEV-15803	8 years ago
Jan Lindström	89a7ad636c	Merge pull request #732 from codership/galera_gcs_fragment_auto_inc Save / restore auto_increment_offset in test galera_gcs_fragment	8 years ago
Sergei Golubchik	c4499a0391	Merge branch '5.5' into 10.0	8 years ago
Marko Mäkelä	bcc26dce3a	Revert "Fix mtr to be able to wait for >1 exited mysqld" This reverts commit `72deed5988` which was merged as commit `29d4ac2ceb`. The change caused regressions, such as mysql-test-run failing to run at all with --valgrind, or aborting on Windows on the first test failure.	8 years ago
Jan Lindström	ed1d9c802d	Merge pull request #729 from codership/MDEV-15794 MDEV-15794 Fix and re-enable test galera_var_retry_autocommit	8 years ago
Jan Lindström	e0208e51d0	Merge pull request #730 from codership/MDEV-13549-fixes-for-galera_ist_mysqldump MDEV-13549 Record and re-enable galera_ist_mysqldump	8 years ago
Daniele Sciascia	b8d4ae0838	Save / restore auto_increment_offset in test galera_gcs_fragment Test galera_gcs_fragment performs cluster reconfiguration, so `auto_increment_offset` may change, and check test case at the end of test fails.	8 years ago
Sergei Golubchik	5cfe52314e	Bug#25471090: MYSQL USE AFTER FREE fix another similar line followup for `7828ba0df4`	8 years ago
Daniele Sciascia	74f22939dc	MDEV-15803 Fix and re-enable test galera_var_auto_inc_control_on The test assumes that `@@global.auto_increment_offset` is equal to `wsrep_local_index + 1`. Which is normally the case if galera runs with option `wsrep_auto_increment_control` enabled. However, if some prior test performs a restart of a server, then `wsrep_local_index` may change, and galera will set the value of `auto_increment_offset` accordingly. However, if `auto_increment_offset` changes during a test run, then mtr will complain. To avoid that, tests that perform restarts include `auto_increment_offset_save.inc` and `auto_increment_offset_restore.inc`. Which reset the value of `auto_increment_offset`. And when that happens, `auto_increment_offset` will no longer be equal to `wsrep_local_index + 1`, and the test fails. To avoid this problem, simply check that the offsets are different on the nodes that compose the cluster.	8 years ago
Jan Lindström	e2c5283568	Merge pull request #723 from codership/10.1-MDEV-16005 MDEV-16005 sporadic failures with galera tests MW-328B and MW-328C	8 years ago
Marko Mäkelä	b4c5e4a717	Follow-up fix to MDEV-14705: Flush log at shutdown In the merge of commit `e7f4e61f6e` the call fil_flush_file_spaces(FIL_TYPE_LOG) is necessary. Tablespaces will be flushed as part of the redo log checkpoint, but the redo log will not necessarily be flushed, depending on innodb_flush_method.	8 years ago
Marko Mäkelä	a1ea8d6f81	Follow-up fix to MDEV-14705: Flush log at shutdown In commit `e7f4e61f6e` the call fil_flush_file_spaces(FIL_LOG) is necessary. Tablespaces will be flushed as part of the redo log checkpoint, but the redo log will not necessarily be flushed, depending on innodb_flush_method.	8 years ago
Elena Stepanova	d6dbe8e207	List of unstable tests for 10.0.35 release	8 years ago
Marko Mäkelä	5569b3eb09	MDEV-16041 Do not write for null update (properly fix MySQL Bug#29157) InnoDB takes a lot of time to perform null updates. The reason is that even though an empty update vector was created, InnoDB will go on to write undo log records and update the system columns DB_TRX_ID and DB_ROLL_PTR in the clustered index, and of course write redo log for all this. This could have been fixed properly in commit `54a492ecac` more than 10 years ago.	8 years ago
Sergei Golubchik	48636f0972	Merge branch 'merge-pcre' into 10.0	8 years ago
Sergei Golubchik	5ae2656b69	Squashed commit of connect/10.0: commit `c545d54437` Author: Olivier Bertrand <bertrandop@gmail.com> Date: Tue Mar 27 23:13:14 2018 +0200 - Fix MDEV-15577 CONNECT engine JDBC remote index prevents UPDATE Fixed in TDBJDBC::OpenDB because query can be null for updates modified: storage/connect/tabjdbc.cpp commit `c4f1fe2e8e` Author: Olivier Bertrand <bertrandop@gmail.com> Date: Wed Mar 14 12:21:17 2018 +0100 - Fix MDEV-15429 CONNECT engine JDBC handling Postgresql UUID type Also handle Postgresql sending type VARCHAR for TEXT column and setting length to b x7FFFFFF when the length is unknown. modified: storage/connect/Client.java modified: storage/connect/JavaWrappers.jar modified: storage/connect/JdbcInterface.java modified: storage/connect/PostgresqlInterface.java modified: storage/connect/global.h modified: storage/connect/ha_connect.cc modified: storage/connect/jdbconn.cpp modified: storage/connect/jdbconn.h modified: storage/connect/mysql-test/connect/r/jdbc_postgresql.result modified: storage/connect/mysql-test/connect/t/jdbc_postgresql.test modified: storage/connect/mysql-test/connect/t/jdbconn.inc modified: storage/connect/plgdbsem.h modified: storage/connect/tabjdbc.cpp modified: storage/connect/tabjdbc.h added: storage/connect/mysql-test/connect/std_data/JavaWrappers.jar commit `3068bb4882` Author: Olivier Bertrand <bertrandop@gmail.com> Date: Mon Feb 26 19:40:27 2018 +0100 Revert to old cmake file to avoid compile error commit `da8c1c0bd6` Author: Olivier Bertrand <bertrandop@gmail.com> Date: Mon Feb 26 16:13:39 2018 +0100 - Remove warning on not used tabtyp variable in connect_assisted_discovery modified: storage/connect/ha_connect.cc - Fix a bug causing CONNECT to loop when expanding a JSON column when the expanded column value is null or void array. - Adding the FullArray option to JSON tables. - Skipping expanded JSON lines when the expanded column value is null. modified: storage/connect/connect.cc modified: storage/connect/tabdos.h modified: storage/connect/tabjson.cpp modified: storage/connect/tabjson.h - Fix MDEV-13353 No file privilege for ODBC, JDBC, MONGO, MAC, WMI file types. modified: storage/connect/ha_connect.cc - Make some Json UDFs to accept a non JSON item as 1st parameter. modified: storage/connect/json.cpp modified: storage/connect/json.h modified: storage/connect/jsonudf.cpp modified: storage/connect/jsonudf.h - Update Json UDF tests to cope with above changes. modified: storage/connect/mysql-test/connect/r/json_udf.result modified: storage/connect/mysql-test/connect/r/json_udf_bin.result modified: storage/connect/mysql-test/connect/r/vcol.result modified: storage/connect/mysql-test/connect/t/json_udf.test modified: storage/connect/mysql-test/connect/t/vcol.test - Fix some compiler warning treated as error PlugSubAlloc no more exported because it does throw. modified: storage/connect/global.h modified: storage/connect/ha_connect.cc modified: storage/connect/jsonudf.cpp modified: storage/connect/tabjson.cpp modified: storage/connect/tabjson.h - Other files modified (?) when going back to wrong merge modified: storage/connect/CMakeLists.txt modified: storage/connect/array.cpp modified: storage/connect/colblk.cpp modified: storage/connect/connect.cc modified: storage/connect/csort.cpp modified: storage/connect/domdoc.cpp modified: storage/connect/filamap.cpp modified: storage/connect/filamgz.cpp modified: storage/connect/filamtxt.cpp modified: storage/connect/filamzip.cpp modified: storage/connect/filter.cpp modified: storage/connect/fmdlex.c modified: storage/connect/jdbconn.cpp modified: storage/connect/macutil.cpp modified: storage/connect/myconn.cpp modified: storage/connect/odbconn.cpp modified: storage/connect/plgdbutl.cpp modified: storage/connect/plugutil.cpp modified: storage/connect/preparse.h modified: storage/connect/rcmsg.c modified: storage/connect/rcmsg.h modified: storage/connect/reldef.cpp modified: storage/connect/tabdos.cpp modified: storage/connect/tabfmt.cpp modified: storage/connect/tabmac.cpp modified: storage/connect/tabmul.cpp modified: storage/connect/tabmysql.cpp modified: storage/connect/tabmysql.h modified: storage/connect/tabodbc.cpp modified: storage/connect/tabtbl.cpp modified: storage/connect/tabxml.cpp modified: storage/connect/value.cpp modified: storage/connect/xobject.cpp commit `5095628b31` Author: Olivier Bertrand <bertrandop@gmail.com> Date: Tue Feb 13 14:29:00 2018 +0100 - Fix a bug causing CONNECT to loop when expanding a JSON column when the expanded column value is null or void array. - Adding the FullArray option to JSON tables. - Skipping expanded JSON lines when the expanded column value is null. modified: storage/connect/connect.cc modified: storage/connect/tabdos.h modified: storage/connect/tabjson.cpp modified: storage/connect/tabjson.h commit `9896174328` Author: Olivier Bertrand <bertrandop@gmail.com> Date: Fri Feb 2 15:48:57 2018 +0100 - Remove warning on not used tabtyp variable in connect_assisted_discovery modified: storage/connect/ha_connect.cc commit `d7e254c05f` Author: Olivier Bertrand <bertrandop@gmail.com> Date: Wed Jan 31 14:42:45 2018 +0100 - Use delayed load for the MongoDB C Drive on Windows modified: storage/connect/CMakeLists.txt modified: storage/connect/cmgoconn.cpp modified: storage/connect/ha_connect.cc - Add FORCE to the connect_type_conv enum values This will translate binary values to TYPE_STRING modified: storage/connect/checklvl.h modified: storage/connect/ha_connect.cc modified: storage/connect/odbconn.cpp - Change the connect_xtrace variable to from int to set modified: storage/connect/array.cpp modified: storage/connect/blkfil.cpp modified: storage/connect/block.h modified: storage/connect/cmgoconn.cpp modified: storage/connect/colblk.cpp modified: storage/connect/connect.cc modified: storage/connect/filamap.cpp modified: storage/connect/filamdbf.cpp modified: storage/connect/filamfix.cpp modified: storage/connect/filamgz.cpp modified: storage/connect/filamtxt.cpp modified: storage/connect/filamvct.cpp modified: storage/connect/filamzip.cpp modified: storage/connect/filter.cpp modified: storage/connect/global.h modified: storage/connect/ha_connect.cc modified: storage/connect/inihandl.cpp modified: storage/connect/javaconn.cpp modified: storage/connect/jdbconn.cpp modified: storage/connect/jmgfam.cpp modified: storage/connect/jmgoconn.cpp modified: storage/connect/json.cpp modified: storage/connect/jsonudf.cpp modified: storage/connect/libdoc.cpp modified: storage/connect/mongo.cpp modified: storage/connect/mycat.cc modified: storage/connect/myconn.cpp modified: storage/connect/odbconn.cpp modified: storage/connect/plgdbutl.cpp modified: storage/connect/plugutil.cpp modified: storage/connect/reldef.cpp modified: storage/connect/tabcol.cpp modified: storage/connect/tabdos.cpp modified: storage/connect/tabext.cpp modified: storage/connect/tabfix.cpp modified: storage/connect/tabfmt.cpp modified: storage/connect/tabjdbc.cpp modified: storage/connect/tabjson.cpp modified: storage/connect/table.cpp modified: storage/connect/tabmul.cpp modified: storage/connect/tabmysql.cpp modified: storage/connect/tabodbc.cpp modified: storage/connect/tabpivot.cpp modified: storage/connect/tabsys.cpp modified: storage/connect/tabtbl.cpp modified: storage/connect/tabutil.cpp modified: storage/connect/tabvct.cpp modified: storage/connect/tabwmi.cpp modified: storage/connect/tabxml.cpp modified: storage/connect/user_connect.cc modified: storage/connect/valblk.cpp modified: storage/connect/value.cpp modified: storage/connect/xindex.cpp - Restore connect_enable_mongo variable (but undocumented) modified: storage/connect/ha_connect.cc modified: storage/connect/mycat.cc modified: storage/connect/mysql-test/connect/r/json_java_2.result modified: storage/connect/mysql-test/connect/r/json_java_3.result modified: storage/connect/mysql-test/connect/r/json_mongo_c.result modified: storage/connect/mysql-test/connect/r/mongo_c.result modified: storage/connect/mysql-test/connect/r/mongo_java_2.result modified: storage/connect/mysql-test/connect/r/mongo_java_3.result modified: storage/connect/mysql-test/connect/r/tbl_thread.result modified: storage/connect/mysql-test/connect/t/mongo.inc modified: storage/connect/mysql-test/connect/t/mongo_test.inc modified: storage/connect/mysql-test/connect/t/tbl_thread.test	8 years ago
Sergei Golubchik	1bd33ca82b	Merge branch 'merge-tokudb-5.6' into 10.0	8 years ago
Sergei Golubchik	c74848ba14	Merge branch 'merge-xtradb-5.6' into 10.0	8 years ago
Sergei Golubchik	584137879f	Merge branch 'merge-perfschema-5.6' into 10.0	8 years ago
Sergei Golubchik	15ec8c2f28	Merge branch 'merge-innodb-5.6' into 10.0	8 years ago
Sergei Golubchik	619afb151b	MDEV-15456 Server crashes upon adding or dropping a partition in ALTER under LOCK TABLE after ER_SAME_NAME_PARTITION followup for `bcb36ee21e` move reopening before trans_commit_stmt(thd);	8 years ago
Daniele Sciascia	9f9bce5f3e	MDEV-13549 Record and re-enable galera_ist_mysqldump Test works after fixes for galera_sst_mysqldump.	8 years ago
Monty	03da1253af	Fix compilation error when compiling with valgrind	8 years ago
Monty	e86c0a5f2a	Increase number of max table_open_cache instances This is a backport of MDEV-11429 from 10.1	8 years ago
Marko Mäkelä	c5ea43fc99	innobase_init(): Remove some dead code Remove the local variable srv_buf_pool_size_org, which was always 0. In MySQL 5.7, InnoDB was made a mandatory storage engine, which would force InnoDB to start up when executing mysqld --verbose --help which is what mysql-test-run.pl is doing as a first step. With a large innodb_buffer_pool_size, this would take a long time. So, MySQL 5.7 includes a hack that starts up InnoDB with a smaller buffer pool when the option --verbose is present.	8 years ago
Daniele Sciascia	58c03e8f30	MDEV-15794 Fix and re-enable test galera_var_retry_autocommit The test was not deterministic and would occasionally fail, due to the use of `sleep`. This patch is a complete rewrite of the test using proper sync points.	8 years ago
Marko Mäkelä	6e04af1b78	Remove dead code HAVE_LZO1X MariaDB uses HAVE_LZO, not HAVE_LZO1X (which was never defined). Also, the variable srv_lzo_disabled was never defined or read (only declared and assigned to, in unreachable code).	8 years ago
Jan Lindström	dc0613edc4	MDEV-15809: Test failure on galera.MW-44 Disable general log while truncating mysql.general_log to avoid queries to be inserted there.	8 years ago
Marko Mäkelä	c026e2c006	MDEV-15507 Assertion failed in dict_check_sys_tables on upgrade from 5.5 The InnoDB system table column SYS_TABLES.MIX_LEN was repurposed in InnoDB Plugin for MySQL 5.1, in commit `91111174ee` (MySQL 5.1.46). Until MySQL 5.6, it only contained a flag DICT_TF2_TEMPORARY. MySQL 5.6 introduced a number of flags that were transient in nature. One of these was introduced in 5.6.5, originally called DICT_TF2_USE_TABLESPACE and later renamed to DICT_TF2_USE_FILE_PER_TABLE. MySQL 5.7.6 introduced logic that insists that the flag be set for any table that does not reside in a shared tablespace, breaking upgrade from MySQL 5.5. MariaDB does not support shared tablespaces other than the InnoDB system tablespace. Also, some dependencies on SYS_TABLES.MIX_LEN were removed in an earlier fix: MDEV-13084 MariaDB 10.2 crashes on corrupted SYS_TABLES.MIX_LEN field (commit `e813fe8622`). dict_check_sys_tables(): Remove a bogus debug assertion, and add a comment that explains how DICT_TF2_USE_FILE_PER_TABLE is used. dict_table_is_file_per_table(): Remove a bogus debug assertion.	8 years ago
Igor Babaev	eb057dce20	MDEV-15035 Wrong results when calling a stored procedure multiple times with different arguments. If the ON expression of an outer join is an OR formula with one of the disjunct being a constant formula then the expression cannot be null-rejected if the constant formula is true. Otherwise it can be null-rejected and if so the outer join can be converted into inner join. This optimization was added in the patch for mdev-4817. Yet the code had a defect: if the query was used in a stored procedure with parameters and the constant item contained some of them then the value of this constant item depended on the values of the parameters. With some parameters it may be true, for others not. The validity of conversion to inner join is checked only once and it happens only for the first call of procedure. So if the parameters in the first call allowed the conversion it was done and next calls used the transformed query though there could be calls whose parameters made the conversion invalid. Fixed by cheking whether the constant disjunct in the ON expression originally contained an SP parameter. If so the expression is not considered as null-rejected. For this check a new item's attribute was intruduced: Item::with_param. It is calculated for each item by fix fields() functions. Also moved the call of optimize_constant_subqueries() in JOIN::optimize after the call of simplify_joins(). The reason for this is that after the optimization introduced by the patch for mdev-4817 simplify_joins() can use the results of execution of non-expensive constant subqueries and this is not valid.	8 years ago
Jan Lindström	779343235b	Merge pull request #722 from codership/MDEV-16006 MDEV-16006 Fix test galera_kill_nochanges	8 years ago
Oleksandr Byelkin	adaa891ae7	MDEV-13699: Assertion `!new_field->field_name.str \|\| strlen(new_field->field_name.str) == new_field->field_name.length' failed in create_tmp_table on 2nd execution of PS with semijoin The problem was that SJ (semi-join) used secondary list (array) of subquery select list. The items there was prepared once then cleaned up (but not really freed from memory because it was made in statement memory). Original list was not prepared after first execution because select was removed by conversion to SJ. The solution is to use original list but prepare it first.	8 years ago
Jan Lindström	2cdaa5696c	Merge pull request #719 from codership/MDEV-15811 MDEV-15811 Fix and re-enable test galera.galera_pc_ignore_sb	8 years ago
Igor Babaev	f033fbd9f2	Changed the test case for MDEV-15571 It has been done to demonstrate that the fix of this bug is good for 10.3 as well. The previous test case is not good for this purpose because 10.2 and 10.3 use different rules for determining the types of recursive CTEs.	8 years ago
Marko Mäkelä	7b5543b21d	MDEV-15030 Add ASAN instrumentation to trx_t Pool Pool::mem_free(): Poison the freed memory. Assert that it was fully initialized, because the reuse of trx_t objects will assume that the objects were previously initialized. Pool::~Pool(), Pool::get(): Unpoison the allocated memory, and mark it initialized. trx_free(): After invoking Pool::mem_free(), unpoison trx_t::mutex and trx_t::undo_mutex, because MutexMonitor will access these even for freed trx_t objects.	8 years ago
Sergei Golubchik	cf242aded5	8.42	8 years ago
Daniele Sciascia	dfb1fdabab	MDEV-16006 Fix test galera_kill_nochanges The test performs a restart and while doing so it occasionally fails with "Server did not transition to READY state" in `include/start_mysqld.inc". Fix is to wait for the cluster to shrink before restarting the node.	8 years ago
Sergei Golubchik	3cd4da3257	5.6.39-83.1	8 years ago
Sergei Golubchik	6b84fdb2f3	5.6.39-83.1	8 years ago
sjaakola	2f0b8f3e02	MDEV-16005 sporadic failures with galera tests MW-328B and MW-328C These test can sporadically show mutex deadlock warnings between LOCK_wsrep_thd and LOCK_thd_data mutexes. This means that these mutexes can be locked in opposite order by different threads, and thus result in deadlock situation. To fix such issue, the locking policy of these mutexes should be revised and enforced to be uniform. However, a quick code review shows that the number of lock/unlock operations for these mutexes combined is between 100-200, and all these mutex invocations should be checked/fixed. On the other hand, it turns out that LOCK_wsrep_thd is used for protecting access to wsrep variables of THD (wsrep_conflict_state, wsrep_query_state), whereas LOCK_thd_data protects query, db and mysys_var variables in THD. Extending LOCK_thd_data to protect also wsrep variables looks like a viable solution, as there should not be a use case where separate threads need simultaneous access to wsrep variables and THD data variables. In this commit LOCK_wsrep_thd mutex is refactored to be replaced by LOCK_thd_data. By bluntly replacing LOCK_wsrep_thd by LOCK_thd_data, will result in double locking of LOCK_thd_data, and some adjustements have been performed to fix such situations.	8 years ago
Daniele Sciascia	92cd6bb510	MDEV-15811 Fix and re-enable test galera.galera_pc_ignore_sb * After killing one galera node with include/kill_galera, wait for cluster to shrink * Remove unnecessary include/wait_until_connected_again.inc	8 years ago
Marko Mäkelä	8346acaf80	Pull request #522 : Remove C++ register keyword	8 years ago

... 3 4 5 6 7 ...

180219 Commits (a79b033b359b882f2fe88051781c6e850bd71780) All Branches Search

180219 Commits (a79b033b359b882f2fe88051781c6e850bd71780)

All Branches