mariadb

Tree: 74a0cde1c6

Author	SHA1	Message	Date
Sergei Golubchik	74a0cde1c6	mysql_install_db always has to pass --user=$user to the mysqld followup for `9d18b62467` strangely enough it only failed upgrade test on eoan	6 years ago
Igor Babaev	4de32015be	MDEV-21356 ERROR 1032 Can't find record when running simple, single-table query This bug could happen when both optimizer switches 'mrr' and 'mrr_sort_keys' are enabled and the optimizer decided to use a rowid filter when accessing an InnoDB table by a secondary key. With the above setting any access by a secondary is converted to the rndpos access. In InnoDB the rndpos access uses the primary key. Currently usage of a rowid filter within InnoDB engine is not supported if the table is accessed by the primary key. Do not use pushed rowid filter if the table is accessed actually by the primary key. Use the rowid filter outside the egine code instead.	6 years ago
Jan Lindström	057fbfa356	Disable Galera tests failing on bb and Azure until they are fixed.	6 years ago
Sergei Golubchik	51a9571256	MDEV-20205 mysql_install_db shouldn't execute chown Make chown error non-fatal. Just print a warning.	6 years ago
Sergei Golubchik	9d18b62467	rpm/deb and auth_pam_tool_dir/auth_pam_tool don't let mysql_install_db set SUID bit for auth_pam_tool in rpm/deb packages - instead package files with correct permissions and only fix the ownership of auth_pam_tool_dir (which can only be done after mysql user is created, so in post-install). keep old mysql_install_db behavior for bintars	6 years ago
Jan Lindström	7e378a8d31	Test requires debug build from galera library.	6 years ago
Gagan Goel	f0ca9bc669	MDEV-20732 Correctly set the length of the FORMAT() result for float data type as argument.	6 years ago
Igor Babaev	1c97cd339e	MDEV-21184 Assertion `used_tables_cache == 0' failed in Item_func::fix_fields with condition_pushdown_from_having This bug could manifest itself for queries with GROUP BY and HAVING clauses when the HAVING clause was a conjunctive condition that depended exclusively on grouping fields and at least one conjunct contained an equality of the form fld=sq where fld is a grouping field and sq is a constant subquery. In this case the optimizer tries to perform a pushdown of the HAVING condition into WHERE. To construct the pushable condition the optimizer first transforms all multiple equalities in HAVING into simple equalities. This has to be done for a proper processing of the pushed conditions in WHERE. The multiple equalities at all AND/OR levels must be converted to simple equalities because any multiple equality may refer to a multiple equality at the upper level. Before this patch the conversion was performed like this: multiple_equality(x,f1,...,fn) => x=f1 and ... and x=fn. When an equality item for x=fi was constructed both the items for x and fi were cloned. If x happened to be a constant subquery that could not be cloned the conversion failed. If the conversions of multiple equalities previously performed had succeeded then the whole condition became in an inconsistent state that could cause different failures. The solution provided by the patch is: 1. to use a different conversion rule if x is a constant multiple_equality(x,f1,...,fn) => f1=x and f2=f1 and ... and fn=f1 2. not to clone x if it's a constant. Such conversions cannot fail and besides the result of the conversion preserves the equivalence of f1,...,fn that can be used for other optimizations. This patch also made sure that expensive predicates are not pushed from HAVING to WHERE.	6 years ago
Marko Mäkelä	6a8a4c19e2	MDEV-21485 ASAN use-after-poison in dfield_get_len or Assertion `pos < index->n_def' failed The server would crash when instantly reordering the columns of a table whose all columns belong to the PRIMARY KEY.	6 years ago
Daniele Sciascia	2d4b6571ec	Wsrep position not updated in InnoDB after certification failures (#1432 ) A certification failure followed by a clean shutdown would cause an inconsistency between the sequence number stored in innodb and the sequence number stored in provider. This happened both in the case of local certification failure, and in the case where dummy writeset is applied. The fix consists of: - updating wsrep position after dummy writeset is delivered in `Wsrep_high_priority_service::log_dummy_write_set()` - updating wsrep position while releasing commit order in wsrep-lib side Added two tests which stress the situation where a server is shutdown after a certification failure.	6 years ago
Vladislav Vaintroub	983163209d	MDEV-21444 : Fix socket leak if AcceptEx() return WSAECONNRESET. Also, ignore/retry on ERROR_NETNAME_DELETED in addition to WSAECONNRESET. This is how golang handles failing AcceptEx(), see `c7ef348bad`	6 years ago
Sujatha	4032fc1d68	Merge branch '10.3' into 10.4	6 years ago
Sujatha	b365b6e7d8	Merge branch '10.2' into 10.3	6 years ago
Sujatha	8317f77ccc	Merge branch '10.1' into 10.2 MDEV-18046: Assortment of crashes, assertion failures and ASAN errors in mysql_show_binlog_events Problem: ======== SHOW BINLOG EVENTS FROM <pos> reports following assert when ASAN is enabled. uint32 binlog_get_uncompress_len(const char): Assertion `(buf[0] & 0xe0) == 0x80' failed Fix: === Part11: Converted debug assert to error handler code*	6 years ago
Sujatha	cb204e11ea	MDEV-18046: Assortment of crashes, assertion failures and ASAN errors in mysql_show_binlog_events Problem: ======== SHOW BINLOG EVENTS FROM <pos> reports following ASAN error. AddressSanitizer: heap-buffer-overflow on address READ of size 1 at 0x60e00009cf71 thread T28 #0 0x55e37e034ae2 in net_field_length Fix: === Part10: Avoid reading out of buffer	6 years ago
Sujatha	d05c511d34	MDEV-18046: Assortment of crashes, assertion failures and ASAN errors in mysql_show_binlog_events Problem: ======== SHOW BINLOG EVENTS FROM <pos> reports following assert when ASAN is enabled. Query_log_event::Query_log_event(const char, uint, const Format_description_log_event, Log_event_type): Assertion `(pos) + (6) <= (end)' failed Fix: === Part9: Removed additional DBUG_ASSERT	6 years ago
Sujatha	bac3353361	MDEV-18046: Assortment of crashes, assertion failures and ASAN errors in mysql_show_binlog_events Problem: ======== SHOW BINLOG EVENTS FROM <pos> reports following ASAN error AddressSanitizer: SEGV on unknown address The signal is caused by a READ memory access. User_var_log_event::User_var_log_event(char const, unsigned int, Format_description_log_event const) Implemented part of upstream patch. commit: mysql/mysql-server@a3a497ccf7ecacc900551fb1e47ea4078b45c351 Fix: === Part8: added checks to avoid reading out of buffer limits	6 years ago
Sujatha	2187f1c2ca	MDEV-18046: Assortment of crashes, assertion failures and ASAN errors in mysql_show_binlog_events Problem: ======== SHOW BINLOG EVENTS FROM <pos> reports following ASAN error "heap-buffer-overflow on address" and some times it asserts. Table_map_log_event::Table_map_log_event(const char, uint, const Format_description_log_event) Assertion `m_field_metadata_size <= (m_colcnt * 2)' failed. Fix: === Part7: Avoid reading out of buffer Converted debug assert to error handler code.	6 years ago
Sujatha	d6fa69e4be	MDEV-18046: Assortment of crashes, assertion failures and ASAN errors in mysql_show_binlog_events Problem: ======== SHOW BINLOG EVENTS FROM <pos> reports following ASAN error AddressSanitizer: heap-buffer-overflow on address 0x60400002acb8 Load_log_event::copy_log_event(char const, unsigned long, int, Format_description_log_event const) Fix: === Part6: Moved the event_len validation to the begin of copy_log_event function	6 years ago
Sujatha	15781283eb	MDEV-18046: Assortment of crashes, assertion failures and ASAN errors in mysql_show_binlog_events Problem: ======== SHOW BINLOG EVENTS FROM <pos> reports following ASAN error AddressSanitizer: heap-buffer-overflow on address String::append(char const, unsigned int) Query_log_event::pack_info(Protocol) Fix: === Part5: Added check to catch buffer overflow	6 years ago
Sujatha	a42ef10815	MDEV-18046: Assortment of crashes, assertion failures and ASAN errors in mysql_show_binlog_events Problem: ======== SHOW BINLOG EVENTS FROM <pos> reports following ASAN error heap-buffer-overflow within "my_strndup" in Rotate_log_event my_strndup /mysys/my_malloc.c:254 Rotate_log_event::Rotate_log_event(char const, unsigned int, Format_description_log_event const) Fix: === Part4: Improved the check for event_len validation	6 years ago
Sujatha	5a54e84e5d	MDEV-18046: Assortment of crashes, assertion failures and ASAN errors in mysql_show_binlog_events Problem: ======== SHOW BINLOG EVENTS FROM <pos> reports following crash when ASAN is enabled. SEGV on unknown address in inline_mysql_mutex_destroy in my_bitmap_free in Update_rows_log_event::~Update_rows_log_event() Fix: === Part3: Initialize m_cols_ai.bitmap to NULL	6 years ago
Sujatha	913f405d95	MDEV-18046: Assortment of crashes, assertion failures and ASAN errors in mysql_show_binlog_events Problem: ======== SHOW BINLOG EVENTS FROM <pos> reports following assert when ASAN is enabled. Rows_log_event::Rows_log_event(const char, uint, const Format_description_log_event): Assertion `var_header_len >= 2' Implemented part of upstream patch. commit: mysql/mysql-server@a3a497ccf7ecacc900551fb1e47ea4078b45c351 Fix: === Part2: Avoid reading out of buffer limits	6 years ago
Sujatha	a6dd827a4d	MDEV-18046: Assortment of crashes, assertion failures and ASAN errors in mysql_show_binlog_events Problem: ======== SHOW BINLOG EVENTS FROM <pos> causes a variety of failures, some of which are listed below. It is not a race condition issue, but there is some non-determinism in it. Analysis: ======== "show binlog events from <pos>" code considers the user given position as a valid event start position. The code starts reading data from this event start position onwards and tries to map it to a set of known events. Each event has a specific event structure and asserts have been added to ensure that read event data satisfies the event specific requirements. When a random position is supplied to "show binlog events command" the event structure specific checks will fail and they result in assert. Fix: ==== The fix is split into different parts. Each part addresses either an ASAN issue or an assert/crash. Part1: Checksum based position validation when checksum is enabled Using checksum validate the very first event read at the user specified position. If there is a checksum mismatch report an appropriate error for the invalid event.	6 years ago
Marko Mäkelä	0b4ae6724f	Fixup MDEV-21429: Correct a definition INNOBASE_ALTER_NOVALIDATE: Remove the set of operations INNOBASE_ONLINE_CREATE that was accidentally included in the definition. In the merge of `82187a1221` to 10.3 (in commit `eda719793a`) the flags were defined correctly. This bug was caught by the test innodb_zip.index_large_prefix.	6 years ago
Marko Mäkelä	d2697dfbc6	MDEV-20839 encryption.innodb-redo-badkey sporadically fails on buildbot with page dump The test encryption.innodb-redo-badkey will by design cause access to pages that appear corrupted (due to incorrect encryption key). Let us disable the page dumps by requiring the test to be run on a debug server. Page dumps on debug builds were already disabled in MDEV-19766.	6 years ago
Elena Stepanova	d3e52ff24d	MDEV-21288 innodb.full_crc32_import fails due to the use of optional compression algorithm	6 years ago
Marko Mäkelä	d60dcabd0f	Merge 10.3 into 10.4	6 years ago
Marko Mäkelä	eda719793a	Merge 10.2 into 10.3	6 years ago
Marko Mäkelä	82187a1221	MDEV-21429 TRUNCATE and OPTIMIZE are being refused due to "row size too large" By default (innodb_strict_mode=ON), InnoDB attempts to guarantee at DDL time that any INSERT to the table can succeed. MDEV-19292 recently revised the "row size too large" check in InnoDB. The check still is somewhat inaccurate; that should be addressed in MDEV-20194. Note: If a table contains multiple long string columns so that each column is part of a column prefix index, then an UPDATE that attempts to modify all those columns at once may fail, because the undo log record might not fit in a single undo log page (of innodb_page_size). In the worst case, the undo log record would grow by about 3KiB of for each updated column. The DDL-time check (since the InnoDB Plugin for MySQL 5.1) is optional in the sense that when the maximum B-tree record size or undo log record size would be exceeded, the DML operation will fail and the transaction will be properly rolled back. create_table_info_t::row_size_is_acceptable(): Add the parameter 'bool strict' so that innodb_strict_mode=ON can be overridden during TRUNCATE, OPTIMIZE and ALTER TABLE...FORCE (when the storage format is not changing). create_table_info_t::create_table(): Perform a sloppy check for TRUNCATE TABLE (create_fk=false). prepare_inplace_alter_table_dict(): Perform a sloppy check for simple operations. trx_is_strict(): Remove. The function became unused in commit `98694ab0cb` (MDEV-20949).	6 years ago
Jan Lindström	5824e9f8df	MDEV-13569: wsrep_info.plugin failed in buildbot with "no nodes coming from prim view Modify configuration so that all nodes are part of galera cluster i.e. wsrep_on=ON. Add missing wait conditions. test changes only.	6 years ago
Marko Mäkelä	e99ba4ba51	Merge 10.1 into 10.2	6 years ago
Monty	8a6863002c	Fixed that mtr --extern works again	6 years ago
Eugene Kosov	fd899b3bbd	Lets add another intrusive double linked list! Features: * STL-like interface * Fast modification: no branches on insertion or deletion * Fast iteration: one pointer dereference and one pointer comparison * Your class can be a part of several lists Modeled after std::list<T> but currently has fewer methods (not complete yet) For even more performance it's possible to customize list with templates so it won't have size counter variable or won't NULLify unlinked node. How existing lists differ? No existing lists support STL-like interface. I_List: * slower iteration (one more branch on iteration) * element can't be a part of two lists simultaneously I_P_List: * slower modification (branches, except for the fastest push_back() case) * slower iteration (one more branch on iteration) UT_LIST_BASE_NODE_T: * slower modification (branches) Three UT_LISTs were replaced: two in fil_system_t and one in dyn_buf_t.	6 years ago
Varun Gupta	1adc559370	Making group_by test stable	6 years ago
Oleksandr Byelkin	9d036f840a	Merge branch '10.3' into 10.4	6 years ago
Oleksandr Byelkin	7753a29064	Merge branch '10.2' into 10.3	6 years ago
Oleksandr Byelkin	b35290e19b	Merge branch '10.1' into 10.2	6 years ago
Oleksandr Byelkin	4d7f073506	Merge branch '5.5' into 10.1	6 years ago
Oleksandr Byelkin	3c94c5b8fa	MDEV-21416: main.events_bugs fails due to 2020-01-01 date Moved to the next problematic year (2038).	6 years ago
Jan Lindström	ef1e488be3	MDEV-13569: wsrep_info.plugin failed in buildbot with "no nodes coming from prim view Modify configuration so that all nodes are part of galera cluster i.e. wsrep_on=ON.	6 years ago
Varun Gupta	faf2a6e5f0	MDEV-20922: Adding an order by changes the query results For Item_direct_view_ref , get value from val_* methods instead of result* family The val_* methods gets value from the item on which it is referred.	6 years ago
Jan Lindström	2cff807d3f	Add have_debug to MDEV-20793 and add wait condition to galera_parallel_autoinc_largetrx to stabilize it.	6 years ago
Teemu Ollakka	13b3d7f1f1	MDEV-20793 Assertion failed after replay. Assertion failed in wsrep-lib after transaction replay which failed due to conflict in certification. - Implemented reproducible test case MDEV-20793 to reproduce the crash. - Fixed wsrep-lib to deal with certification error during replay.	6 years ago
Marko Mäkelä	59d4f2a373	Cleanup after MDEV-12026 buf_flush_init_for_writing(): If innodb_checksum_algorithm=full_crc32, return even earlier. The logic to reset garbage FIL_PAGE_TYPE fields applies to data pages in old data files that were last written before commit `3926673ce7` was introduced. When innodb_checksum_algorithm=full_crc32 is in effect, it only applies to newly created data files. A file that was created in full_crc32 format will keep that format. Other files will keep some other format than full_crc32. Hence, the garbage-resetting logic does not apply full_crc32 files.	6 years ago
Marko Mäkelä	4a012ce2f4	Post-fix for MDEV-12253: Remove redundant log writes The 8 bytes at FIL_PAGE_FILE_FLUSH_LSN_OR_KEY_VERSION will be overwritten at page flush, in buf_page_encrypt_before_write(), ever since commit `765a43605a` (MariaDB 10.1.23, 10.2.6, 10.3.1). btr_store_big_rec_extern_fields(): Remove useless writes to the page header (and to the redo log) for ROW_FORMAT=COMPRESSED BLOB pages.	6 years ago
Marko Mäkelä	ffc0a08d05	Merge 10.3 into 10.4	6 years ago
Marko Mäkelä	02e3006957	MDEV-21405 Assertion failed on instant ADD COLUMN btr_cur_pessimistic_insert(): Relax a too strict debug assertion that would fail when the function is invoked by btr_cur_pessimistic_update() during innobase_add_instant_try(), that is, when updating the hidden metadata record during a subsequent ADD COLUMN operation involves splitting the leftmost clustered index leaf page. This is a partial backport of `301bd62b25` from 10.4.	6 years ago
Nikita Malyavin	4923604ee2	MDEV-18865 Assertion `t->first->versioned_by_id()' failed in innodb_prepare_commit_versioned Cause: * row_start != 0 treated as it exists. Probably, possible row permutations had not been taken in mind. Solution: * Checking both row_start and row_end is correct, so versioned() function is used	7 years ago
Nikita Malyavin	720e9bd5be	MDEV-18875 Assertion `thd->transaction.stmt.ha_list == __null \|\| trans == &thd->transaction.stmt' failed or bogus ER_DUP_ENTRY upon ALTER TABLE with versioning Cause: * when autocommit=0 (or transaction is issued by user), `ha_commit_trans` is called twice on ALTER TABLE, causing a duplicated insert into `transaction_registry` (ER_DUP_ENTRY). Solution: * ALTER TABLE makes an implicit commit by a second call. We actually need to make an insert only when it is a real commit. So is_real variable is additionally checked.	7 years ago

1 2 3 4 5 ...

187699 Commits (74a0cde1c612a1549320c5c74146a0763d5916fb) All Branches Search

187699 Commits (74a0cde1c612a1549320c5c74146a0763d5916fb)

All Branches