mariadb

Tree: 74a0cde1c6

Author	SHA1	Message	Date
Vladislav Vaintroub	32ce5301a9	Update libmariadb	6 years ago
Marko Mäkelä	3826178da8	Fix the Windows non-debug build warning C4390: ';': empty controlled statement found; is this the intent?	6 years ago
Sergei Golubchik	0d345ec2e3	Fix upgrade errors on eoan mariadb packages conflict with mysql-8.0	6 years ago
Sergei Golubchik	dc7d0b5030	RPM packaging fixes for FC31 Obsoletes: cannot contain (x86-64) anymore Python shebang must be specific	6 years ago
Marko Mäkelä	4beace3316	MDEV-21171 InnoDB is unnecessarily resetting FIL_PAGE_TYPE for full_crc32 files Before commit `c0f47a4a58` (MDEV-12026) introduced the innodb_checksum_algorithm=full_crc32 format, it was impossible to tell if InnoDB data files contained garbage in the FIL_PAGE_TYPE header field (and possibly other fields). This is because before commit `3926673ce7` in MySQL 5.1.48, InnoDB would write uninitialized data to some fields, and because there was no way to tell with which InnoDB version a data file was created. If fil_space_t::full_crc32() holds, the data file cannot contain uninitialized garbage or invalid FIL_PAGE_TYPE, and thus fil_block_check_type() should not be invoked to correct anything.	6 years ago
Sergei Golubchik	576e85ad99	fix ssl_crl test failures on newer OpenSSL generalize the replacement	6 years ago
Vladislav Vaintroub	ba95c303e3	MDEV-21167 LF_PINS::stack_ends_here inaccurate, leading to alloca() larger than stack Use my_thread_var::stack_ends_here inside lf_pinbox_real_free() for address where thread stack ends. Remove LF_PINS::stack_ends_here. It is not safe to assume that mysys_var that was used during pin allocation, remains correct during free. E.g with binlog group commit in Innodb, that frees pins for multiple Innodb transactions, it does not work correctly.	6 years ago
Eugene Kosov	2855edf9ee	try to fix data races in DBUG init_settings.keywords and it's pointee are shared data. Protect them with mutex too.	6 years ago
Vladislav Vaintroub	584ffa02f1	MDEV-19669 - fix matching CIDR address for proxy protocol. Prior to this fix, when matching addresses using mask, extra bits could be used for comparison, e.g to match with "a.b.c.d/24" , 27 bits were compared rather than 24. The patch fixes the calculation.	6 years ago
Vladislav Vaintroub	96c6b2b649	MDEV-19781 fixups - It is not enough to have and DeleteSymlinks actions because within the same installation some exes executables can be both added and removed, which needs both adding and removing some symlinks. Instead of CreateSymlinks, there is now FixSymlinks function, which goes through the list, and adds or removes the symlinks as needed. - Implemented rollback for symlink custom action. - Generate list of symlinks in C++ file, using CMake, rather than storing lists as MSI properties.	6 years ago
Marko Mäkelä	3fc1f6260f	MDEV-21158 trx_undo_seg_free() is never redo-logged As part of commit `3c09f148f3` trx_undo_commit_cleanup() was always invoked with noredo=true. The impact of this should be that some undo log pages may not be correctly freed if the server is killed and crash recovery will be performed. Similarly, if mariabackup --backup is being executed concurrently with user transaction commits, it could happen that some undo log pages in the backup will never be marked as free for reuse. It seems that this bug should not have any user-visible impact other than some undo pages being wasted.	6 years ago
Alexey Botchkov	bfa6db38cd	MENT-510 Failing test(s): perfschema.threads_insert_delayed. The thread_id of the INSERT DELAYED thread should not be set to 0.	6 years ago
Alexey Botchkov	0e403db2c8	MENT-237 Audit to show INSERT DELAYED for the executing user. Add notifications about the user and connection that actually did the DELAYED insert.	6 years ago
Igor Babaev	ed355f59dd	MDEV-20407 mysqld got signal 11; rowid filter If a joined table is accessed by a full text index then now no range rowid filter can be used when accessing the records of this table. This bug was fixed by the patch for mdev-20056. This commit adds only a test case with a query using a full text index and a range condition for another index.	6 years ago
Vicențiu Ciorbaru	6218bf1b41	cracklib-runtime needs a comma after to parse properly	6 years ago
Marko Mäkelä	3eda03d0fe	MDEV-21148: Assertion index->n_core_fields + n_add >= index->n_fields Revert part of commit `6cedb671e9` because it turns out to be theoretically impossible to parse a ROW_FORMAT=COMPACT or ROW_FORMAT=DYNAMIC metadata record where the variable-length fields in the PRIMARY KEY have been written as nonempty strings.	6 years ago
Olivier Bertrand	f0da39be7f	- Fix MDEV-13782 Problem with NOT LIKE queries. modified: storage/connect/ha_connect.cc modified: sql/item_cmpfunc.h - Fix MDEV-21084 Misusage of strncat could cause buffer overflow. modified: storage/connect/reldef.cpp modified: storage/connect/tabcmg.cpp modified: storage/connect/tabjson.cpp modified: storage/connect/tabrest.cpp modified: storage/connect/tabxml.cpp	6 years ago
Vicențiu Ciorbaru	427eedd012	MDEV-13288: Proper fix for cracklib-runtime The required dependencies should be added through the autobake script, to also cover distributions that do not support libcrack2.	6 years ago
Igor Babaev	4d4b2867a2	MDEV-20056 Assertion `!prebuilt->index->is_primary()' failed in row_search_idx_cond_check When usage of rowid filter is evaluated by the optimizer to join a table to the current partial join employing a certain index it should be checked that a key for at least the major component of this index can be constructed using values from the columns of the partial join.	6 years ago
Eugene Kosov	49ed1ae320	fix double io_destroy() + cleanup	6 years ago
Rasmus Johansson	b6f7ec6a5b	MDEV-19781 Create MariaDB named commands on Windows Added CreateSymlinks and DeleteSymlinks functions to CustomAction.cpp. Extra.wxs.in calls them.	6 years ago
Marko Mäkelä	a8395853cc	MDEV-21152 Bogus debug assertion btr_pcur_is_after_last_in_tree() in ibuf code As noted in commit `abd45cdc38` a search with PAGE_CUR_GE may land on the supremum record on a leaf page that is not the rightmost leaf page. This could occur when all keys on the current page are smaller than the search key, and the smallest key on the successor page is larger than the search key. Hence, after a failed PAGE_CUR_GE search, assertions btr_pcur_is_after_last_in_tree() are bogus and should be replaced with btr_pcur_is_after_last_on_page().	6 years ago
Vicențiu Ciorbaru	ed2379f983	MDEV-13288: Upstream debian patch	6 years ago
Seth Shelnutt	23664bc7a5	Fix incorrect DBUG_ENTER message for join_read_last	6 years ago
seppo	38839854b7	MDEV-19572 async slave node fails to apply MyISAM only writes (#1418 ) The problem happens when MariaDB master replicates writes for only non InnoDB tables (e.g. writes to MyISAM table(s)). Async slave node, in Galera cluster, can apply these writes successfully, but it will, in the end, write gtid position in mysql.gtid_slave_pos table. mysql.gtid_slave_pos table is InnoDB engine, and this write makes innodb handlerton part of the replicated "transaction". Note that wsrep patch identifies that write to gtid_slave_pos should not be replicated and skips appending wsrep keys for these writes. However, as InnoDB was present in the transaction, and there are replication events (for MyISAM table) in transaction cache, but there are no appended keys, wsrep raises an error, and this makes the söave thread to stop. The fix is simply to not treat it as an error if async slave tries to replicate a write set with binlog events, but no keys. We just skip wsrep replication and return successfully. This commit contains also a mtr test which forces mysql.gtid_slave_pos table isto be of InnoDB engine, and executes MyISAM only write through asyn replication. There is additional fix for declaring IO and background slave threads as non wsrep. These threads should not write anything for wsrep replication, and this is just a safeguard to make sure nothing leaks into cluster from these slave threads.	6 years ago
willhan	3551cd32a8	MDEV-17508 Fix bug for spider when using "not like" fix bug for spider where using "not like" (#890) test case: t1 is a spider engine table; CREATE TABLE `t1` ( `id` int(11) NOT NULL DEFAULT '0', `name` char(64) DEFAULT NULL, PRIMARY KEY (`id`) ) ENGINE=SPIDER query: "select * from t1 where name not like 'x%' " would dispatch "select xxx name name like 'x%' " to remote mysqld, is wrong	7 years ago
Marko Mäkelä	f9ceb0a67f	MDEV-20190 Instant operation fails when add column and collation change on non-indexed column We must relax too strict debug assertions. For latin1_swedish_ci, mtype=DATA_CHAR or mtype=DATA_VARCHAR will be used instead of mtype=DATA_MYSQL or mtype=DATA_VARMYSQL. Likewise, some changes of dtype_get_charset_coll() do not affect the data type encoding, but only any indexes that are defined on the column. Charset::same_encoding(): Check whether two charset-collations have the same character set encoding. dict_col_t::same_encoding(): Check whether two character columns have the same character set encoding. dict_col_t::same_type(): Check whether two columns have a compatible data type encoding. dict_col_t::same_format(), dict_table_t::instant_column(): Do not compare mtype or the charset-collation of prtype directly. Rely on dict_col_t::same_type() instead. dtype_get_charset_coll(): Narrow the return type to uint16_t. This is a refined version of a fix that was developed by Thirunarayanan Balathandayuthapani.	6 years ago
Aleksey Midenkov	a34c34d9a8	Merge 10.3 into 10.4	6 years ago
Aleksey Midenkov	33f55789d3	MDEV-18727 improve DML operation of System Versioning (10.4) UPDATE, DELETE: replace linear search of current/historical records with vers_setup_conds(). Additional DML cases in view.test	6 years ago
Aleksey Midenkov	bf58ec77a1	MDEV-18727 cleanup	6 years ago
seppo	4111a53079	MDEV-21096 async slave crash with gtid_log_pos table access (#1413 ) The original crash happened when async replication IO thread was updating mysql.gtid_slave_pos table. Operations on this table should remain node local, but it appears that protection (THD::wsrep_ignore_table flag) to prevent wsrep replication for this table mas missing for innodb write_row() and update_row(). It was somewhat difficult to reproduce the issue, because mtr seems to create the affected table mysql.gtid_log_pos as of Aria engine type, and Aria engine operations will not be replicated anyhow. It looks, though, that in release installation, mysql.gtid_slave_pos table is of InnoDB engine. It was possible to trigger somewhat related problem by running test galera.galera_as_slave_gtid with configuration: gtid_pos_auto_engines=InnoDB. However, this test mode, causes earlier crash when replication background thread creates aditional table: mysql.gtid_slave_pos_InnoDB, and this table create triggered wsrep TOI replication, which also failed for assertion. Actually, async replication IO and background threads should not replicate anything to cluster. This pull request contains new test galera.galera_as_slave_gtid_auto_engine, which basically just runs galera.galera_as_slave_gtid with configuration of gtid_pos_auto_engines=InnoDB. Test galera.galera_as_slave_gtid is also modified for better code reuse. Actual fix for MDEV-21096 is in storage/innobase/handler/ha_innodb.cc, where THD::wsrep_ignore_table flag is now honored before wsrep key population. There is additional fix in sql/service_wsrep.cc where async replication IO and background threads are marked as non-local. This fences these threads out of wsrep replication altogether. Note that this change, actually makes the use of THD::wsrep_ignore-table redundant. We may want to refactor THD::wsrep_ignore_table out in the future, if there is no other use case for it in sight.	6 years ago
Olivier Bertrand	fb91774e4e	These changed were made after pulling 10.2.30 from origin --------------------------------------------------------- - Temporarily fix MDEV-13782 by commenting out LIKE_FUNC in CondFilter modified: storage/connect/ha_connect.cc - Remove use of hack tables modified: storage/connect/connect.cc modified: storage/connect/connect.h modified: storage/connect/ha_connect.cc modified: storage/connect/xtable.h	6 years ago
Igor Babaev	f95288211c	MDEV-19919 Assertion `!prebuilt->index->is_primary()' failed in row_search_idx_cond_check For a single table query with ORDER BY and several sargable range conditions the optimizer may choose an execution plan that employs a rowid filter. In this case it is important to build the filter before calling the function JOIN_TAB::sort_table() that creates sort index for the result set, because when this is index created the filter has to be already filled. After the sort index has been created the filter must be deactivated. If not to do this the innodb function row_search_idx_cond_check() is getting confused when it has to read rows from the created sort index by using ha_rnd_pos(). The order of actions mentioned above is needed also when processing a join query if sorting is performed for the first non constant table in the chosen execution plan.	6 years ago
Hashir Sarwar	d8ace23d26	Fixed some typos in mysql.cc Closes #1403	6 years ago
Aleksey Midenkov	1d5f6a0073	MDEV-21049 Segfault in create federatedx table with empty hostname Use my_localhost instead of NULL for share->hostname.	6 years ago
Aleksey Midenkov	0076dce2c8	MDEV-18727 improve DML operation of System Versioning MDEV-18957 UPDATE with LIMIT clause is wrong for versioned partitioned tables UPDATE, DELETE: replace linear search of current/historical records with vers_setup_conds(). Additional DML cases in view.test	6 years ago
Seth Shelnutt	cb6d7c3ee3	MDEV-20972: `or` alterative operator breaking windows build Closes #1405	6 years ago
Olivier Bertrand	b4bfa12b00	Fix compile error (missing declaration) in tabrest.cpp	6 years ago
Olivier Bertrand	420789512f	Fix compile error (missing declaration) in tabrest.cpp	6 years ago
Olivier Bertrand	7a9eca1191	Fix compile error (imcomplete switch) in ha_connect.cc	6 years ago
Olivier Bertrand	3ad054170c	These changed were made after pulling 10.2.30 from origin --------------------------------------------------------- - Temporarily fix MDEV-13782 by commenting out LIKE_FUNC i, CondFilter modified: storage/connect/ha_connect.cc - Make Rest available for MariaDB binary distributed versions. modified: storage/connect/CMakeLists.txt - Remove unused declaration modified: storage/connect/filter.h	6 years ago
Eugene Kosov	d30e51fafb	cleanup Linux AIO Replace all io_context* occurrences with io_context_t Even in release mode die immediately when some io_* functions return EINVAL. This always means some programming bug and it's better to fail fast. LinuxAIOHandler::resubmit(): fix condition. Stop ignoring -1 return code which corresponds to EPERM and io_submit() really can return this one. Use io_destroy() to stop leaking io_context_t. Make m_aio_ctx std::vector instead of C array. I think that internal check for index overflow might be useful. Add debug assertions for EFAULT because for me receiving it looks like a programming bug.	6 years ago
Eugene Kosov	a14544260c	MDEV-21045 AddressSanitizer: use-after-poison in mem_heap_dup / row_log_table_get_pk_col row_log_table_get_pk_col(): read instant field value from instant alter table when it's required.	6 years ago
Eugene Kosov	a51f3b09bb	cleanup DBUG DbugParse(): removed mutex lock/unlock which should protect file writes only. And no file writes happen in this function. DbugFlush(): move mutex_unlock out of this method because fflush() doesn't need any locking. Slow stuff like mutex lock/unlock and accessing errno (TLS) is moved to a more narrow scope.	6 years ago
Eugene Kosov	899c5bd5aa	MDEV-20832 Don't print "row size too large" warnings in error log if innodb_strict_mode=OFF and log_warnings<=2 create_table_info_t::row_size_is_acceptable(): add condition for log writing	6 years ago
Vlad Lesin	24a279bb27	Merge branch '10.2' into 10.3	6 years ago
Marko Mäkelä	6cedb671e9	MDEV-21088 Table cannot be loaded after instant ADD/DROP COLUMN btr_cur_instant_init_low(): Accurately parse the metadata record header for ROW_FORMAT=DYNAMIC and ROW_FORMAT=COMPACT. CHAR columns used to be unnecessarily written as nonempty strings of bytes.	6 years ago
Marko Mäkelä	1c92406337	Merge 10.3 into 10.4	6 years ago
Marko Mäkelä	aa3d28ac34	MDEV-21088: Follow-up fix for ROW_FORMAT=REDUNDANT For ROW_FORMAT=REDUNDANT, we must reserve fixed-length dummy values for the CHAR columns in the metadata record. This is because in MariaDB Server 10.4, btr_cur_instant_init_low() will rely on dict_index_t::trx_id_offset being accurate for the metadata record.	6 years ago
Marko Mäkelä	89f487f2e2	MDEV-21088 Table cannot be loaded after instant ADD/DROP COLUMN In MariaDB Server 10.4, btr_cur_instant_init_low() assumes that all PRIMARY KEY columns that are internally variable-length will be encoded in 0 bytes in the metadata record. Sometimes, CHAR columns can be encoded as variable-length. We should not unnecessarily reserve space for a dummy string value in the metadata record.	6 years ago

... 3 4 5 6 7 ...

187699 Commits (74a0cde1c612a1549320c5c74146a0763d5916fb) All Branches Search

187699 Commits (74a0cde1c612a1549320c5c74146a0763d5916fb)

All Branches