mariadb

Tree: 23debf214f

Author	SHA1	Message	Date
Marko Mäkelä	23debf214f	MDEV-28091 fixup: Fix another pfs_malloc() stub In commit `0f56e21efa` only one pfs_malloc() stub was fixed to return aligned memory. Also, the MSVC _aligned_malloc() pairs with _aligned_free().	1 year ago
Daniel Black	1f7898f686	mroonga: remove -Wunused-but-set-variable warnings There where unused variable. They were not conditional on defines, so removed them. Added an error handing in proc_object if there was no db as subsequent operations would have failed.	1 year ago
Daniel Black	3723fd1573	MDEV-35007 mroonga should modify source files during build CMake rewriting the tests causes Mroonga to be un-buildable on build environments where there source directory is read only. In the test results, the version wasn't particularly important. Remove the version dependence of tests.	1 year ago
Sergei Petrunia	1cda4726ca	MDEV-34993, part2: backport optimizer_adjust_secondary_key_costs ...and make the fix for MDEV-34993 switchable. It is enabled by default and controlled with @optimizer_adjust_secondary_key_costs=fix_card_multiplier	1 year ago
Sergei Petrunia	8166a5d33d	MDEV-34993: Incorrect cardinality estimation causes poor query plan When calculate_cond_selectivity_for_table() takes into account multi- column selectivities from range access, it tries to take-into account that selectivity for some columns may have been already taken into account. For example, for range access on IDX1 using {kp1, kp2}, the selectivity of restrictions on "kp2" might have already been taken into account to some extent. So, the code tries to "discount" that using rec_per_key[] estimates. This seems to be wrong and unreliable: the "discounting" may produce a rselectivity_multiplier number that hints that the overall selectivity of range access on IDX1 was greater than 1. Do a conservative fix: if we arrive at conclusion that selectivity of range access on condition in IDX1 >1.0, clip it down to 1.	1 year ago
Sergei Golubchik	9021f40b8e	MDEV-35050 Found wrong usage of mutex upon setting plugin session variables	1 year ago
Sergei Golubchik	b1bbdbab9e	cleanup: remove redundant if() likely, a result of auto-merge of two fixes in different versions	1 year ago
Sergei Golubchik	813e592763	compilation failure in CONNECT storage/connect/tabfmt.cpp:419:24: error: '%.3d' directive writing between 3 and 10 bytes into a region of size 5 [-Werror=format-overflow=] 419 \| sprintf(buf, "COL%.3d", i+1);	1 year ago
Sergei Golubchik	5bf543fd43	MDEV-24193 UBSAN: sql/sql_acl.cc:9985:29: runtime error: member access within null pointer of type 'struct TABLE' , ASAN: use-after-poison in handle_grant_table privilege tables do not always have to exist	1 year ago
Sergei Golubchik	2cdcfb644c	MDEV-26314 ST_EQUALS listed twice in information_schema.SQL_FUNCTIONS	1 year ago
Marko Mäkelä	464055fe65	MDEV-34078 Memory leak in InnoDB purge with 32-column PRIMARY KEY row_purge_reset_trx_id(): Reserve large enough offsets for accomodating the maximum width PRIMARY KEY followed by DB_TRX_ID,DB_ROLL_PTR. Reviewed by: Thirunarayanan Balathandayuthapani	1 year ago
Oleksandr Byelkin	8d810e9426	MDEV-29537 Creation of view with UNION and SELECT ... FOR UPDATE in definition is failed with error lock_type is writen in the last SELECT of the unit even if it parsed last, so it should be printed last from the last select of the unit.	1 year ago
Thirunarayanan Balathandayuthapani	cc810e64d4	MDEV-34392 Inplace algorithm violates the foreign key constraint Don't allow the referencing key column from NULL TO NOT NULL when 1) Foreign key constraint type is ON UPDATE SET NULL 2) Foreign key constraint type is ON DELETE SET NULL 3) Foreign key constraint type is UPDATE CASCADE and referenced column declared as NULL Don't allow the referenced key column from NOT NULL to NULL when foreign key constraint type is UPDATE CASCADE and referencing key columns doesn't allow NULL values get_foreign_key_info(): InnoDB sends the information about nullability of the foreign key fields and referenced key fields. fk_check_column_changes(): Enforce the above rules for COPY algorithm innobase_check_foreign_drop_col(): Checks whether the dropped column exists in existing foreign key relation innobase_check_foreign_low() : Enforce the above rules for INPLACE algorithm dict_foreign_t::check_fk_constraint_valid(): This is used by CREATE TABLE statement to check nullability for foreign key relation.	1 year ago
Max Kellermann	45298b730b	sql/handler: referenced_by_foreign_key() returns bool The method was declared to return an unsigned integer, but it is really a boolean (and used as such by all callers). A secondary change is the addition of "const" and "noexcept" to this method. In ha_mroonga.cpp, I also added "inline" to the two helper methods of referenced_by_foreign_key(). This allows the compiler to flatten the method.	1 year ago
Sergei Golubchik	b88f1267e4	MDEV-33373 part 2: Unexpected ER_FILE_NOT_FOUND upon reading from logging table after crash recovery CSV engine shoud set my_errno if use it.	1 year ago
Oleksandr Byelkin	20f57a8529	MDEV-33373 part 1: Unexpected ER_FILE_NOT_FOUND upon reading from logging table after crash recovery We have found that my_errno can be "passed" to the next commad in some cases. It is practically impossible to check/fix all cases of my_errno in the server, plugins and engines so we will reset it as we reset other errors. The test case will be fixed by CSV engine fix so will be added with it (see part2).	1 year ago
Yuchen Pei	282b92f0a2	MDEV-34589 Do not execute before queries in spider_db_mbase::rollback() Rollback is not supposed to fail. This prevents false failures in spider rollback.	1 year ago
Yuchen Pei	42735c557e	MDEV-34636 Spider: reset wide_handler->trx in two occasions ha_spider::update_create_info() ha_spider::append_lock_tables_list()	1 year ago
Yuchen Pei	f43ea935a1	MDEV-34636 Remove implementation of ha-spider::extra() with MERGE flags	1 year ago
Yuchen Pei	69874ee95c	MDEV-34828 Remove some obsolete cmake code related to the removed spider handlersocket support A fixup of MDEV-26858	1 year ago
Julius Goryavsky	95d285fb75	MDEV-30307 addendum: support for compilation in release mode	1 year ago
sjaakola	cf0c3ec274	MDEV-30307 KILL command inside a transaction causes problem for galera replication Added new test scenario in galera.galera_bf_kill test to make the issue surface. The tetst scenario has a multi statement transaction containing a KILL command. When the KILL is submitted, another transaction is replicated, which causes BF abort for the KILL command processing. Handling BF abort rollback while executing KILL command causes node hanging, in this scenario. sql_kill() and sql_kill_user() functions have now fix, to perform implicit commit before starting the KILL command execution. BEcause of the implicit commit, the KILL execution will not happen inside transaction context anymore. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	3 years ago
Vladislav Vaintroub	78e640ea3e	MDEV-34808 Update HeidiSQL to v12.8	1 year ago
Vladislav Vaintroub	2c0b7ff2b4	Windows : support Wix toolset 3.14 Chocolatey package manager installs this one.	1 year ago
Tony Chen	be164fc401	ssl_cipher parameter cannot configure TLSv1.3 and TLSv1.2 ciphers at the same time SSL_CTX_set_ciphersuites() sets the TLSv1.3 cipher suites. SSL_CTX_set_cipher_list() sets the ciphers for TLSv1.2 and below. The current TLS configuration logic will not perform SSL_CTX_set_cipher_list() to configure TLSv1.2 ciphers if the call to SSL_CTX_set_ciphersuites() was successful. The call to SSL_CTX_set_ciphersuites() is successful if any TLSv1.3 cipher suite is passed into `--ssl-cipher`. This is a potential security vulnerability because users trying to restrict specific secure ciphers for TLSv1.3 and TLSv1.2, would unknowingly still have the database support insecure TLSv1.2 ciphers. For example: If setting `--ssl_cipher=TLS_AES_128_GCM_SHA256:ECDHE-RSA-AES128-GCM-SHA256`, the database would still support all possible TLSv1.2 ciphers rather than only ECDHE-RSA-AES128-GCM-SHA256. The solution is to execute both SSL_CTX_set_ciphersuites() and SSL_CTX_set_cipher_list() even if the first call succeeds. This allows the configuration of exactly which TLSv1.3 and TLSv1.2 ciphers to support. Note that there is 1 behavior change with this. When specifying only TLSv1.3 ciphers to `--ssl-cipher`, the database will not support any TLSv1.2 cipher. However, this does not impose a security risk and considering TLSv1.3 is the modern protocol, this behavior should be fine. All TLSv1.3 ciphers are still supported if only TLSv1.2 ciphers are specified through `--ssl-cipher`. All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.	1 year ago
Denis Protivensky	9f61aa4f8a	MDEV-34822 pre-fix: Make wsrep_ready flag read lock-free It's read for every command execution, and during slave replication for every applied event. It's also planned to be used during write set applying, so it means mostly every server thread is going to compete for the mutex covering this variable, especially considering how rarely it changes. Converting wsrep_ready to atomic relaxes the things. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	1 year ago
Jan Lindström	024e95128b	MDEV-32996 : galera.galera_var_ignore_apply_errors -> [ERROR] WSREP: Inconsistency detected Add wait_until_ready waits after wsrep_on is set on again to make sure that node is ready for next step before continuing. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	1 year ago
Jan Lindström	0ce5603b86	MDEV-33035 : Galera test case MDEV-16509 unstable Stabilize test by reseting DEBUG_SYNC and add wait_condition for expected table contents. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	1 year ago
Teemu Ollakka	b2429e2025	MDEV-34976 Server crash report broken if Galera is not loaded The crash report terminates prematurely when Galera library was not loaded. As a fix, check whether the provider is loaded before shutting down Galera connections. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	1 year ago
Dave Gosselin	f7c5182b7c	MDEV-31636 Memory leak in Sys_var_gtid_binlog_state::do_check() Move memory allocations performed during Sys_var_gtid_binlog_state::do_check to Sys_var_gtid_binlog_state::global_update where they will be freed before the latter method returns.	1 year ago
Sergei Petrunia	d67c88946f	Debugging: add dbug_print_join_prefix() to use in best_access_path A call to dbug_print_join_prefix(join_positions, idx, s) returns a const char* ponter to string with current join prefix, including the table being added to it.	1 year ago
Daniel Black	42eb64e64d	MDEV-34996 Buildbot MSAN options should be in server All the options that where in buildbot, should be in the server making it accessible to all without any special invocation. If WITH_MSAN=ON, we want to make sure that the compiler options are supported and it will result in an error if not supported. We make the -WITH_MSAN=ON append -stdlib=libc++ to the CXX_FLAGS if supported. With SECURITY_HARDENING options the bootstrap currently crashes, so for now, we disable SECRUITY_HARDENING if there is MSAN enable. Option WITH_DBUG_TRACE has no effect in MSAN builds.	1 year ago
Lena Startseva	ad5b9c207c	MDEV-27944: View-protocol fails if database was changed This is a limitation of the view protocol. Tests were fixed with workaround (via disable/enable service connection)	1 year ago
Max Kellermann	53f5ee7929	MDEV-34994: sql/mysqld: stop accept() loop after the first EAGAIN Each time a listener socket becomes ready, MariaDB calls accept() ten times (MAX_ACCEPT_RETRY), even if all but the first one return EAGAIN because there are no more connections. This causes unnecessary CPU usage - on our server, the CPU load of that thread, which does nothing but accept(), saturates one CPU core by ~45%. The loop should stop after the first EAGAIN. Perf report: 11.01% mariadbd libc.so.6 [.] accept4 6.42% mariadbd [kernel.kallsyms] [k] finish_task_switch.isra.0 5.50% mariadbd [kernel.kallsyms] [k] _raw_spin_unlock_irqrestore 5.50% mariadbd [kernel.kallsyms] [k] syscall_enter_from_user_mode 4.59% mariadbd [kernel.kallsyms] [k] __fget_light 3.67% mariadbd [kernel.kallsyms] [k] kmem_cache_alloc 2.75% mariadbd [kernel.kallsyms] [k] fput 2.75% mariadbd [kernel.kallsyms] [k] mod_objcg_state 1.83% mariadbd [kernel.kallsyms] [k] __inode_wait_for_writeback 1.83% mariadbd [kernel.kallsyms] [k] __sys_accept4 1.83% mariadbd [kernel.kallsyms] [k] _raw_spin_unlock_irq 1.83% mariadbd [kernel.kallsyms] [k] alloc_inode 1.83% mariadbd [kernel.kallsyms] [k] call_rcu	1 year ago
Sergei Golubchik	8fd1b060f8	reformat galera sst error messages put the command line at the end. so that when a very long command line is truncated, it doesn't take the actual error message with it	1 year ago
Sergei Golubchik	dd1cad7e5f	galera_3nodes.MDEV-29171 fails set transferfmt in .cnf file like other galera tests do. otherwise it defaults to socat when mtr detected that only nc is available	1 year ago
Oleksandr Byelkin	c9f54e20d4	MDEV-33990: SHOW STATUS counts ER_CON_COUNT_ERROR as Connection_errors_internal Bring info about cause of closing connection in the place where we increment statistics to do it correctly.	1 year ago
Sergei Golubchik	bbc62b1b9e	clarify --thread-pool-mode usage	1 year ago
Sergei Golubchik	99837b6df6	restore --clent-rr after `7d86751de5`	1 year ago
Alexander Barkov	681609d8a0	MDEV-32891 Assertion `value <= ((ulonglong) 0xFFFFFFFFL) * 10000ULL' failed in str_to_DDhhmmssff_internal Fixing the wrong assert.	1 year ago
Alexander Barkov	607fc15393	MDEV-31302 Assertion `mon > 0 && mon < 13' failed in my_time_t sec_since_epoch(int, int, int, int, int, int) The code erroneously called sec_since_epoch() for dates with zeros, e.g. '2024-00-01'. Fixi: adding a test that the date does not have zeros before calling TIME_to_native().	1 year ago
Alexander Barkov	9ac8172ac3	MDEV-31221 UBSAN runtime error: negation of -9223372036854775808 cannot be represented in type 'long long int' in my_strtoll10_utf32 The code in my_strtoll10_mb2 and my_strtoll10_utf32 could hit undefinite behavior by negation of LONGLONG_MIN. Fixing to avoid this. Also, fixing my_strtoll10() in the same style. The previous reduction produced a redundant warning on CAST(_latin1'-9223372036854775808' AS SIGNED)	1 year ago
Alexander Barkov	841dc07ee1	MDEV-28386 UBSAN: runtime error: negation of -X cannot be represented in type 'long long int'; cast to an unsigned type to negate this value to itself in my_strntoull_8bit on SELECT ... OCT The code in my_strntoull_8bit() and my_strntoull_mb2_or_mb4() could hit undefinite behavior by negating of LONGLONG_MIN. Fixing the code to avoid this.	1 year ago
Lena Startseva	0a5e4a0191	MDEV-31005: Make working cursor-protocol Updated tests: cases with bugs or which cannot be run with the cursor-protocol were excluded with "--disable_cursor_protocol"/"--enable_cursor_protocol" Fix for v.10.5	1 year ago
Lena Startseva	ab569524dc	MDEV-31005: Make working cursor-protocol Added ability to disable/enable (--disable_cursor_protocol/ --enable_cursor_protocol) cursor-protocol in tests. If "--disable_cursor_protocol" is used then ps-protocol is also disabled. With cursor-protocol prepare statement is executed only once. For "--cursor-protocol" added filter for queries: it is executed only for "SELECT" queries.	1 year ago
Daniel Black	450040e0da	MDEV-34952 main.log_slow test failure on opensuse builder The loose regex for the MDEV-34539 test ended up matching the opensuse in the path in buildbot. Adjust to more complete regex including space, backtick and \n, which becomes much less common as a path name.	1 year ago
Brandon Nesterenko	68938d2b42	MDEV-33500 (part 2): rpl.rpl_parallel_sbm can still fail The failing test case validates Seconds_Behind_Master for a delayed slave, while STOP SLAVE is executed during a delay. The test fixes initially added to the test (commit `b04c857596`) added a table lock to ensure a transaction could not finish before validating the Seconds_Behind_Master field after SLAVE START, but did not address a possibility that the transaction could finish before running the STOP SLAVE command, which invalidates the validations for the rest of the test case. Specifically, this would result in 1) a timeout in “Waiting for table metadata lock” on the replica, which expects the transaction to retry after slave restart and hit a lock conflict on the locked tables (added in `b04c857596`), and 2) that Seconds_Behind_Master should have increased, but did not. The failure can be reproduced by synchronizing the slave to the master before the MDEV-32265 echo statement (i.e. before the SLAVE STOP). This patch fixes the test by adding a mechanism to use DEBUG_SYNC to synchronize a MASTER_DELAY, rather than continually increase the duration of the delay each time the test fails on buildbot. This is to ensure that on slow machines, a delay does not pass before the test gets a chance to validate results. Additionally, it decreases overall test time because the test can continue immediately after validation, thereby bypassing the remainder of a full delay for each transaction.	1 year ago
Alexander Barkov	a1adabdd5c	MDEV-25900 Assertion `octets < 1024' failed in Binlog_type_info_fixed_string::Binlog_type_info_fixed_string OR Assertion `field_length < 1024' failed in Field_string::save_field_metadata A CHAR column cannot be longer than 1024, because Binlog_type_info_fixed_string::Binlog_type_info_fixed_string replies on this fact - it cannot store binlog metadata for longer columns. In case of the filename character set mbmaxlen is equal to 5, so only 1024/5=204 characters can fit into the 1024 limit. - In strict mode: Disallowing creation of a CHAR column with octet length grater than 1024. - In non-strict mode: Automatically convert CHAR with octet length>1024 into VARCHAR.	1 year ago
Julius Goryavsky	222744c54e	galera SST scripts: fixing glitchy sockstat issues for FreeBSD	1 year ago
Julius Goryavsky	45be538cf4	galera SST scripts: added missing 'datadir' parameter for mysqldump method	1 year ago

1 2 3 4 5 ...

196582 Commits (23debf214fff3b3f03cf98f6298d06f552d93b37) All Branches Search

196582 Commits (23debf214fff3b3f03cf98f6298d06f552d93b37)

All Branches