mariadb

Tree: 23debf214f

Author	SHA1	Message	Date
Vladislav Vaintroub	4a67bd5105	Fix server on windows, so it does not write to error log byte-by-byte fprintf() on Windows, when used on unbuffered FILE*, writes bytewise. This can make crash handler messages harder to read, if they are mixed up with other error log output. Fixed , on Windows, by using a small buffer for formatting, and fwrite instead of fprintf, if buffer is large enough for message.	1 year ago
Vladislav Vaintroub	62fd7b4cd2	OpenSSL - set all heap functions in CRYPTO_set_mem_functions. The reason is that on Windows, OpenSSL can be built with different C runtime than the server (e.g Debug runtime in debug vcpkg build). Overwriting only malloc(), with CRT that server is using can cause mixup of incompatible malloc() and free() inside openssl. To fix, overwrite all memory functions.	1 year ago
Vladislav Vaintroub	b619be3569	Support -DCONC_WITH_SSL parameter passed to CMake Usually it is not needed, but sometimes we need to testing interoperability, e.g OpenSSL server / SCHANNEL client, or WolfSSL server / OpenSSL client.	1 year ago
Vladislav Vaintroub	d1713666b0	Fix incorrect setting of opt_local_file in mysqlimport, for named pipe For named pipe, server and client are on the same machine, and opt_local_infile just adds unnecessary copying via "load data local infile"	1 year ago
Daniel Bartholomew	56fb04aa7c	bump the VERSION	1 year ago
Nikita Malyavin	25e2d0a6bb	MDEV-34632 Assertion failed in handler::assert_icp_limitations Assertion `table->field[0]->ptr >= table->record[0] && table->field[0]->ptr <= table->record[0] + table->s->reclength' failed in handler::assert_icp_limitations. table->move_fields has some limitations: 1. It cannot be used in cascade 2. It should always have a restoring pair. Rule 1 is covered by assertions in handler::assert_icp_limitations and handler::ptr_in_record (commit `30894fe9a9`). Rule 2 should be manually maintained with care. Hopefully, the rule 1 assertions may sometimes help as well. In ha_myisam::repair, both rules are broken. table->move_fields is used asymmetrically there: it is set on every param->fix_record call (i.e. in compute_vcols) but is restored only once, in the end of repair. The reason to updating field ptr's for every call is that compute_vcols can (supposedly) be called in parallel, that is, with the same table, but different records. The condition to "unmove" the pointers in ha_myisam::restore_vcos_after_repair is incorrect, when stored vcols are available, and myisam stores a VIRTUAL field if it's the only field in the table (the record cannot be of zero length). This patch solves the problem by "unmoving" the pointers symmetrically, in compute_vcols. That is, both rules will be preserved maintained.	1 year ago
Yuchen Pei	bce3f3f628	MDEV-34682 Reset spider_hton_ptr in error mode of spider_db_init()	1 year ago
Jan Lindström	8b51d34462	MDEV-34640 : galera_var_ignore_apply_errors test freezes Test improvements only to make test more robust. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	1 year ago
Jan Lindström	71f289e5d1	MDEV-25614 : Galera test failure on GCF-354 Modified node config with longer timeouts for suspect, inactive, install and wait_prim timeout. Increased node_1 weight to keep it primary component when other nodes are voted out. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	1 year ago
Jan Lindström	eb30a9d633	MDEV-34647 : 'INSERT...SELECT' on MyISAM table suddenly replicated by Galera Replication of MyISAM and Aria DML is experimental and best effort only. Earlier change make INSERT SELECT on both MyISAM and Aria to replicate using TOI and STATEMENT replication. Replication should happen only if user has set needed wsrep_mode setting. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	1 year ago
Jan Lindström	cb80ef93a9	MDEV-32778 : galera_ssl_reload failed with warning message Fixed used configuration and added suppression for warning message. Test case changes only. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	1 year ago
Jan Lindström	0ba6068a82	MDEV-32782 : galera_sst_mysqldump_with_key test failed Modified test configuration file to use wsrep_sync_wait to make sure committed transactions are replicated before next operation. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	1 year ago
Andre F de Miranda	83040474dc	MDEV-34234: make lsof optional on RPM Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	2 years ago
Oleg Smirnov	cf202decde	MDEV-34683 Types mismatch when cloning items causes debug assertion New runtime type diagnostic (MDEV-34490) has detected that classes Item_func_eq, Item_default_value and Item_date_literal_for_invalid_dates incorrectly return an instance of its ancestor classes when being cloned. This commit fixes that. Additionally, it fixes a bug at Item_func_case_simple::do_build_clone() which led to an endless loop of cloning functions calls. Reviewer: Oleksandr Byelkin <sanja@mariadb.com>	1 year ago
Oleksandr Byelkin	7a5b8bf0f5	lost in editinig line added	1 year ago
Thirunarayanan Balathandayuthapani	37119cd256	MDEV-29010 Table cannot be loaded after instant ALTER Reason: ====== - InnoDB fails to load the instant alter table metadata from clustered index while loading the table definition. The reason is that InnoDB metadata blob has the column length exceeds maximum fixed length column size. Fix: === - InnoDB should treat the long fixed length column as variable length fields that needs external storage while initializing the field map for instant alter operation	1 year ago
Galina Shalygina	d072a29601	MDEV-23983: Crash caused by query containing constant having clause Before this patch the crash occured when a single row dataset is used and Item::remove_eq_conds() is called for HAVING. This function is not supposed to be called after the elimination of multiple equalities. To fix this problem instead of Item::remove_eq_conds() Item::val_int() is used. In this case the optimizer tries to evaluate the condition for the single row dataset and discovers impossible HAVING immediately. So, the execution phase is skipped. Approved by Igor Babaev <igor@maridb.com>	1 year ago
Brandon Nesterenko	001608de7e	MDEV-15393: Fix rpl_mysqldump_gtid_slave_pos The slave would try to sync_with_master_gtid.inc, but the master never actually saved its gtid position so the test would move on too quickly.	1 year ago
Thirunarayanan Balathandayuthapani	533e6d5d13	MDEV-34670 IMPORT TABLESPACE unnecessary traverses tablespace list Problem: ======== - After the commit `ada1074bb1` (MDEV-14398) fil_crypt_set_encrypt_tables() iterates through all tablespaces to fill the default_encrypt tables list. This was a trigger to encrypt or decrypt when key rotation age is set to 0. But import tablespace does call fil_crypt_set_encrypt_tables() unnecessarily. The motivation for the call is to signal the encryption threads. Fix: ==== ha_innobase::discard_or_import_tablespace: Remove the fil_crypt_set_encrypt_tables() and add the import tablespace to the default encrypt list if necessary	1 year ago
Sergei Petrunia	fdda8171b2	MDEV-34580: Assertion `(key_part->key_part_flag & 4) == 0' failed key_hashnr Remove an assert added by fix for MDEV-34417. BNL-H join can be used with prefix keys. This happens when there are real prefix indexes on the equi-join columns (although it probably doesn't make a lot of sense). Anyway, remove the assert. The code receives properly truncated key values for hashing/comparison so it can handle them just fine.	1 year ago
Thirunarayanan Balathandayuthapani	c038b3c05e	MDEV-34181 Instant table aborts after discard tablespace - commit `85db534731` (MDEV-33400) retains the instantness in the table definition after discard tablespace. So there is no need to assign n_core_null_bytes during instant table preparation unless they are not initialized.	1 year ago
Rex	48b256a7e2	MDEV-34506 2nd execution name resolution problem with pushdown into unions Statements affected by this bug need all the following to be true 1) a derived table table or view whose specification contains a set operation at the top level. 2) a grouping operator (group by/having) operating on a column alias other than in the first select of the union/intersect 3) an outer condition that will be pushed into all selects in this union/intersect, either into the where or having clause When pushing a condition into all selects of a unit with more than one select, pushdown_cond_for_derived() renames items so we can re-use the condition being pushed. These names need to be saved and reset for correct name resolution on second execution of prepared statements. Reviewed by Igor Babaev (igor@mariadb.com)	1 year ago
Marko Mäkelä	7e5c9ccda5	MDEV-34502 fixup: Do not cripple MSAN We need to work around deficiencies of Valgrind, and apparently the previous work-around attempts (such as `d247d64988`) do not work anymore, definitely not on recent clang-based compilers. MemorySanitizer should be fine; unfortunately we set HAVE_valgrind for it as well.	1 year ago
Marko Mäkelä	232d7a5e2d	MDEV-34565: SIGILL due to OS not supporting AVX512 It is not sufficient to check that the CPU supports the necessary instructions. Also the operating system (or virtual machine hypervisor) must enable all the AVX registers to be saved and restored on a context switch. Because clang 8 does not support the compiler intrinsic _xgetbv() we will require clang 9 or later for enabling the use of VPCLMULQDQ and the related AVX512 features.	1 year ago
Daniel Black	0939bfc093	MDEV-19052 main.win postfix --view-protocol compat Correct compatibility with view-protocol. Thanks Lena Startseva	1 year ago
Daniel Black	7788593547	MDEV-19052 Range-type window frame supports only numeric datatype When there is no bounds on the upper or lower part of the window, it doesn't matter if the type is numeric. It also doesn't matter how many ORDER BY items there are in the query. Reviewers: Sergei Petrunia and Oleg Smirnov	1 year ago
Oleksandr Byelkin	26f31bdd52	The test should be not for AddressSanitizer used becouse stack check tests and this check switched off	1 year ago
Oleg Smirnov	c91aeb3771	MDEV-34634 Types mismatch when cloning items causes debug assertion New runtime diagnostic introduced with MDEV-34490 has detected that `Item_int_with_ref` incorrectly returns an instance of its ancestor class `Item_int`. This commit fixes that. In addition, this commit reverts a part of the diagnostic related to `clone_item()` checks. As it turned out, `clone_item()` is not required to return an object of the same class as the cloned one. For example, look at `Item_param::clone_item()`: it can return objects of `Item_null`, `Item_int`, `Item_string`, etc, depending on the object state. So the runtime type diagnostic is not applicable to `clone_item()` and is disabled with this commit. As the similar diagnostic failures are expected to appear again in the future, this commit introduces a new test file in the main suite: item_types.test, and new test cases may be added to this file Reviewer: Oleksandr Byelkin <sanja@mariadb.com>	1 year ago
Andrei	b8f92ade57	MDEV-15393 gtid_slave_pos duplicate key errors after mysqldump restore When mysqldump is run to dump the `mysql` system database, it generates INSERT statements into the table `mysql.gtid_slave_pos`. After running the backup script those inserts did not produce the expected gtid state on slave. In particular the maximum of mysql.gtid_slave_pos.sub_id did not make into rpl_global_gtid_slave_state.last_sub_id an in-memory object that is supposed to match the current state of the table. And that was regardless of whether --gtid option was specified or not. Later when the backup recipient server starts as slave in non-gtid mode this desychronization may lead to a duplicate key error. This effect is corrected for --gtid mode mysqldump/mariadb-dump only as the following. The fixes ensure the insert block of the dump script is followed with a "summing-up" SET @global.gtid_slave_pos assignment. For the implemenation part, note a deferred print-out of SET-gtid_slave_pos and associated comments is prefered over relocating of the entire blocks if (opt_master,slave_data && do_show_master,slave_status) ... because of compatiblity concern. Namely an error inside do_show_*() is handled in the new code the same way, as early as, as before. A regression test can be run in how-to-reproduce mode as well. One affected mtr test observed. rpl_mysqldump_slave.result "mismatch" shows now the new deferring print of SET-gtid_slave_pos policy in action.	1 year ago
Oleksandr Byelkin	b8b6cab2d7	Fix view protocol	1 year ago
Alexander Barkov	9dafde575f	Additional tests for MDEV-28345 ASAN: use-after-poison or unknown-crash in my_strtod_int from charset_info_st::strntod or test_if_number	1 year ago
Brandon Nesterenko	a061ae1079	MDEV-33921: Fix rpl_xa_empty_transaction.test The test was missing a save_master_gtid.inc on the master, leading to the slave thinking it was in sync after executing sync_with_master_gtid.inc, despite not having executed the latest transaction. This skipped transaction, XA COMMIT, was supposed to error-to-be-ignored because its XID could not be found, but be thrown out because the replication filters would filter out the target database. However, if the slave was able to stop before executing the transaction, then the replication filer is reset (to empty), and when the slave is later restarted, that transactions error would no longer be ignored. Additionally, as the test cases added in MDEV-33921 rely on GTID synchronization, the test cases now force master_use_gtid=slave_pos for consistency	1 year ago
Sergei Golubchik	36b867ad50	MDEV-34353 Revert "don't wait indefinitely for signal handler in --bootstrap" This reverts commit `938b929372`. Not needed after `90d376e017`.	1 year ago
Sergei Golubchik	8d813f080b	MDEV-34539 Invalid "use" and "Schema" in slow query log file with multi-line schema quote a database name in the slow log	1 year ago
Sergei Golubchik	f12634f5a4	MDEV-34530 dead code in the thr_rwlock.c remove it	1 year ago
Sergei Golubchik	7ba12d42de	MDEV-34434 Hide password passed on commandline from xtrabackup_info refine mariadb-backup password zapping check	1 year ago
Sergei Golubchik	d20518168a	also protect the /*!999999 sandbox comment	1 year ago
Sergei Golubchik	d60f5c11ea	MDEV-34318 mariadb-dump SQL syntax error with MAX_STATEMENT_TIME against Percona MySQL server protect MariaDB conditional comments from a bug in Percona MySQL comment parser	1 year ago
Sergei Golubchik	dea5746de2	MDEV-32155 MariaDB Server crashes with ill-formed partitions for ALTER_PARTITION_ADMIN (CHECK/REPAIR/LOAD INDEX/CACHE INDEX/etc) partitioning marks affected partitions with PART_ADMIN state. The assumption is that the server will call a corresponding method of ha_partition which will reset the state back to PART_NORMAL. This assumption is invalid, the server is not required to do so, indeed, in CHECK ... FOR UPGRADE the server might decide early that the table is fine and won't call ha_partition::check(), leaving partitions in the wrong state. It will thus leak into the next statement confusing the engine about what it is doing (see ha_partition::create_handler_file()), causing a crash later. Let's force all partitions into PART_NORMAL state after the admin operation succeeded, in case it did so without consulting the engine.	1 year ago
Sergei Golubchik	8ac30517af	MDEV-34384 restorecon call in RPM POSTIN script has hardcoded datadir path	1 year ago
Rucha Deodhar	1f28350b59	MDEV-32456: incorrect result of gis function in view protocol There are 3 diff in result: 1) NULL value from SELECT Due to incorrect truncating of the hex value, incorrect value is written instead of original value to the view frm. This results in reading incorrect value from frm, so eventual result is NULL. 2) 'Name_exp1' in column name (in gis.test) This was because the identifier in SELECT is longer than 64 characters, so 'Name_exp1' alias is also written to the view frm. 3)diff in explain extended This was because the query plan for view protocol doesn't contain database name. As a fix, disable view protocol for that particular query.	1 year ago
Souradeep Saha	4a89f79b6a	Refactor import * with only required imports Import only the required functions instead of all the functions from the module to reduce the unnecessary functions in the namespace and prevent shadowing. Note: All code changes are non-functional. All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.	1 year ago
Robin Newhouse	008bddaa6c	GitLab CI Upgrade CentOS 8 to CentOS 9 build > After May 31, 2024, CentOS Stream 8 will be archived and no further updates will be provided. [1] CentOS Stream 8 is now EOL and should be updated to using CentOS Stream 9 for compatibility testing in GitLab CI. [1] https://blog.centos.org/2023/04/end-dates-are-coming-for-centos-stream-8-and-centos-linux-7/ https://www.centos.org/centos-linux-eol/ All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services.	1 year ago
Oleksandr Byelkin	e7c2e25ba8	new CC version	1 year ago
Oleksandr Byelkin	7478fabcff	new PCRE2-10.44	1 year ago
Alexander Barkov	b777b749ad	MDEV-28345 ASAN: use-after-poison or unknown-crash in my_strtod_int from charset_info_st::strntod or test_if_number This patch fixes two problems: - The code inside my_strtod_int() in strings/dtoa.c could test the byte behind the end of the string when processing the mantissa. Rewriting the code to avoid this. - The code in test_if_number() in sql/sql_analyse.cc called my_atof() which is unsafe and makes the called my_strtod_int() look behind the end of the string if the input string is not 0-terminated. Fixing test_if_number() to use my_strtod() instead, passing the correct end pointer.	1 year ago
Sutou Kouhei	383d53edbc	MDEV-21166 Add Mroonga initialized check to Mroonga UDFs Mroonga UDFs can't be used without loading Mroonga.	1 year ago
PinkFreud	49dff5a4b6	MDEV-34604 mytop - fix specifying filters in .mytop Specifying filters (filter_status, filter_user, etc) in the mytop config previously wouldn't work, because any filter specified here was added to the config hash as a literal string. This change fixes that - if filter_* is defined in the config and matches an existing filter_* key, then run the value through StringOrRegex() and assign to the config hash.	2 years ago
Yuchen Pei	03a350378a	MDEV-30408 Reset explicit_limit in exists2in Item_exists_subselect::fix_length_and_dec() sets explicit_limit to 1. In the exists2in transformation it resets select_limit to NULL. For consistency we should reset explicity_limit too. This fixes a bug where spider table returns wrong results for queries that gets through exists2in transformation when semijoin is off.	1 year ago
Yuchen Pei	8416fd323c	MDEV-32627 [fixup] Spider: Fix conn key length To avoid off-by-one in spider_get_share. And document conn key and conn key length.	1 year ago

... 2 3 4 5 6 ...

196582 Commits (23debf214fff3b3f03cf98f6298d06f552d93b37) All Branches Search

196582 Commits (23debf214fff3b3f03cf98f6298d06f552d93b37)

All Branches