mariadb

Tree: 19cea73834

Author	SHA1	Message	Date
Vladislav Vaintroub	19cea73834	Cleanup - make sure all members of table_load_params are initialized Alexey Botchkov complains there are problems with empty curly brackets initializer in old-ish gcc(4.9) Can't verify, but making all members are initialized by default constructor is easy enough.	1 year ago
Marko Mäkelä	a5b80531fb	Merge 11.4 into 11.6	1 year ago
Marko Mäkelä	44733aa8cf	Merge 11.2 into 11.4	1 year ago
Marko Mäkelä	e91a799458	Merge 10.11 into 11.2	1 year ago
Marko Mäkelä	984606d747	MDEV-34750 SET GLOBAL innodb_log_file_size is not crash safe The recent commit `4ca355d863` (MDEV-33894) caused a serious regression for online InnoDB ib_logfile0 resizing, breaking crash-safety unless the memory-mapped log file interface is being used. However, the log resizing was broken also before this. To prevent such regressions in the future, we extend the test innodb.log_file_size_online with a kill and restart of the server and with some writes running concurrently with the log size change. When run enough many times, this test revealed all the bugs that are being fixed by the code changes. log_t::resize_start(): Do not allow the resized log to start before the current log sequence number. In this way, there is no need to copy anything to the first block of resize_buf. The previous logic regarding that was incorrect in two ways. First, we would have to copy from the last written buffer (buf or flush_buf). Second, we failed to ensure that the mini-transaction end marker bytes would be 1 in the buffer. If the source ib_logfile0 had wrapped around an odd number of times, the end marker would be 0. This was occasionally observed when running the test innodb.log_file_size_online. log_t::resize_write_buf(): To adjust for the resize_start() change, do not write anything that would be before the resize_lsn. Take the buffer (resize_buf or resize_flush_buf) as a parameter. Starting with commit `4ca355d863` we no longer swap buffers when rewriting the last log block. log_t::append(): Define as a static function; only some debug assertions need to refer to the log_sys object. innodb_log_file_size_update(): Wake up the buf_flush_page_cleaner() if needed, and wait for it to complete a batch while waiting for the log resizing to be completed. If the current LSN is behind the resize target LSN, we will write redundant FILE_CHECKPOINT records to ensure that the log resizing completes. If the buf_pool.flush_list is empty or the buf_flush_page_cleaner() is stuck for some reason, our wait will time out in 5 seconds, so that we can periodically check if the execution of SET GLOBAL innodb_log_file_size was aborted. Previously, we could get into a busy loop here while the buf_flush_page_cleaner() would remain idle.	1 year ago
Oleksandr Byelkin	3a1ff7398a	Merge branch '10.6' into 10.11	1 year ago
Oleksandr Byelkin	a4654ecceb	Merge branch '10.5' into 10.6	1 year ago
Oleksandr Byelkin	03a5455cb3	MDEV-34833 Assertion failure in Item_float::do_build_clone (Item_static_float_func) Added missing method of Item_static_float_func	1 year ago
Marko Mäkelä	cfcf27c6fe	Merge 10.6 into 10.11	1 year ago
Oleksandr Byelkin	872dbec935	MDEV-34704 Quick mode produces the bug for mariadb client --quick-max-column-width parameter added to limit field width in --quick mode.	1 year ago
Marko Mäkelä	0e76c1ba94	Merge 10.5 into 10.6	1 year ago
Marko Mäkelä	1ff6b6f0b4	MDEV-34802 Recovery fails to note some log corruption recv_recovery_from_checkpoint_start(): Abort startup due to log corruption if we were unable to parse the entire log between the latest log checkpoint and the corresponding FILE_CHECKPOINT record. Also, reduce some code bloat related to log output and log_sys.mutex. Reviewed by: Debarun Banerjee	1 year ago
Alexander Barkov	c67149b859	MDEV-34829 LOCALTIME returns a wrong data type Changing the alias LOCALTIME->CURRENT_TIMESTAMP to LOCALTIME->CURRENT_TIME. This changes the return type of LOCALTIME from DATETIME to TIME, according to the SQL Standard.	1 year ago
Yuchen Pei	18d3f63a4e	MDEV-32627 Spider: use CONNECTION string in SQLDriverConnect This is the CS part of the implementation of MENT-2070.	1 year ago
Marko Mäkelä	bda40ccb85	MDEV-34803 innodb_lru_flush_size is no longer used In commit `fa8a46eb68` (MDEV-33613) the parameter innodb_lru_flush_size ceased to have any effect. Let us declare the parameter as deprecated and additionally as MARIADB_REMOVED_OPTION, so that there will be a warning written to the error log in case the option is specified in the command line. Let us also do the same for the parameter innodb_purge_rseg_truncate_frequency that was deprecated&ignored earlier in MDEV-32050. Reviewed by: Debarun Banerjee	1 year ago
Daniel Black	fea36b1905	MDEV-34754 packaging prep for Oracular Add Oracular to the allowed Ubuntu names.	1 year ago
Marko Mäkelä	e7bb9b7c55	MDEV-24923 fixup: Correct a function comment	1 year ago
Marko Mäkelä	48becffd07	Merge 10.5 into 10.6	1 year ago
Marko Mäkelä	8cc822283e	MDEV-34515 fixup: innodb.innodb_defrag_concurrent fails Let us avoid EXTENDED in the CHECK TABLE after a defragmentation, because it would occasionally report an orphan delete-marked record in the index "third". That error does not seem to be reproducible when using the regular OPTIMIZE TABLE. Also, let us make the test --repeat safe by removing the defragmentation related statistics after DROP TABLE. The defragmentation feature was removed in later releases in commit `7ca89af6f8` (MDEV-30545) along with this test case.	1 year ago
Yuchen Pei	58bc83e1a7	[fixup] Spider: Restored lines accidentally deleted in MDEV-32157 Also restored a change that resulted in off-by-one, as well as appending the correctly indexed key_hint.	1 year ago
Marko Mäkelä	36ab75a498	MDEV-34515: Fix a bogus debug assertion purge_sys_t::stop_FTS(): Fix an incorrect debug assertion that commit `d58734d781` added. The assertion would fail if there had been prior invocations of purge_sys.stop_SYS() without purge_sys.resume_SYS(). The intention of the assertion is to check that number of pending stop_FTS() stays below 65536.	1 year ago
Kristian Nielsen	8642453ce6	Fix sporadic failure of test case rpl.rpl_start_stop_slave The test was expecting the I/O thread to be in a specific state, but thread scheduling may cause it to not yet have reached that state. So just have a loop that waits for the expected state to occur. Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>	1 year ago
Kristian Nielsen	25e0224814	Skip mariabackup.slave_provision_nolock in --valgrind, it uses a lot of CPU Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>	1 year ago
Kristian Nielsen	214e6c5b3d	Fix sporadic failure of test case rpl.rpl_old_master Remove the test for MDEV-14528. This is supposed to test that parallel replication from pre-10.0 master will update Seconds_Behind_Master. But after MDEV-12179 the SQL thread is blocked from even beginning to fetch events from the relay log due to FLUSH TABLES WITH READ LOCK, so the test case is no longer testing what is was intended to. And pre-10.0 versions are long since out of support, so does not seem worthwhile to try to rewrite the test to work another way. The root cause of the test failure is MDEV-34778. Briefly, depending on exact timing during slave stop, the rli->sql_thread_caught_up flag may end up with different value. If it ends up as "true", this causes Seconds_Behind_Master to be 0 during next slave start; and this caused test case timeout as the test was waiting for Seconds_Behind_Master to become non-zero. Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>	1 year ago
Kristian Nielsen	7dc4ea5649	Fix sporadic test failure in rpl.rpl_create_drop_event Depending on timing, an extra event run could start just when the event scheduler is shut down and delay running until after the table has been dropped; this would cause the test to fail with a "table does not exist" error in the log. Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>	1 year ago
Kristian Nielsen	33854d7324	Restore skiping rpl.rpl_mdev6020 under Valgrind (Revert a change done by mistake when XtraDB was removed.) Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>	1 year ago
Kristian Nielsen	b4c2e23954	MDEV-34696: do_gco_wait() completes too early on InnoDB dict stats updates Before doing mark_start_commit(), check that there is no pending deadlock kill. If there is a pending kill, we won't commit (we will abort, roll back, and retry). Then we should not mark the commit as started, since that could potentially make the following GCO start too early, before we completed the commit after the retry. This condition could trigger in some corner cases, where InnoDB would take temporarily table/row locks that are released again immediately, not held until the transaction commits. This happens with dict_stats updates and possibly auto-increment locks. Such locks can be passed to thd_rpl_deadlock_check() and cause a deadlock kill to be scheduled in the background. But since the blocking locks are held only temporarily, they can be released before the background kill happens. This way, the kill can be delayed until after mark_start_commit() has been called. Thus we need to check the synchronous indication rgi->killed_for_retry, not just the asynchroneous thd->killed. Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>	1 year ago
Marko Mäkelä	76f6b6d818	MDEV-34515: Reduce context switching in purge Before this patch, the InnoDB purge coordinator task submitted innodb_purge_threads-1 tasks even if there was not sufficient amount of work for all of them. For example, if there are undo log records only for 1 table, only 1 task can be employed, and that task had better be the purge coordinator. srv_purge_worker_task_low(): Split from purge_worker_callback(). trx_purge_attach_undo_recs(): Remove the parameter n_purge_threads, and add the parameter n_work_items, to keep track of the amount of work. trx_purge(): Launch purge worker tasks only if necessary. The work of one thread will be executed by this purge coordinator thread. que_fork_scheduler_round_robin(): Merged to trx_purge(). Thanks to Vladislav Vaintroub for supplying a prototype of this. Reviewed by: Debarun Banerjee	1 year ago
Marko Mäkelä	b7b9f3ce82	MDEV-34515: Contention between purge and workload In a Sysbench oltp_update_index workload that involves 1 table, a serious contention between the workload and the purge of history was observed. This was the worst when the table contained only 1 record. This turned out to be fixed by setting innodb_purge_batch_size=128, which corresponds to the number of usable persistent rollback segments. When we go above that, there would be contention between row_purge_poss_sec() and the workload, typically on the clustered index page latch, sometimes also on a secondary index page latch. It might be that with smaller batches, trx_sys.history_size() will end up pausing all concurrent transaction start/commit frequently enough so that purge will be able to make some progress, so that there would be less contention on the index page latches between purge and SQL execution. In commit `aa719b5010` (part of MDEV-32050) the interpretation of the parameter innodb_purge_batch_size was slightly changed. It would correspond to the maximum desired size of the purge_sys.pages cache. Before that change, the parameter was referring to a number of undo log pages, but the accounting might have been inaccurate. To avoid a regression, we will reduce the default value to innodb_purge_batch_size=127, which will also be compatible with innodb_undo_tablespaces>1 (which will disable rollback segment 0). Additionally, some logic in the purge and MVCC checks is simplified. The purge tasks will make use of purge_sys.pages when accessing undo log pages to find out if a secondary index record can be removed. If an undo page needs to be looked up in buf_pool.page_hash, we will merely buffer-fix it. This is correct, because the undo pages are append-only in nature. Holding purge_sys.latch or purge_sys.end_latch or the fact that the current thread is executing as a part of an in-progress purge batch will prevent the contents of the undo page from being freed and subsequently reused. The buffer-fix will prevent the page from being evicted form the buffer pool. Thanks to this logic, we can refer to the undo log record directly in the buffer pool page and avoid copying the record. buf_pool_t::page_fix(): Look up and buffer-fix a page. This is useful for accessing undo log pages, which are append-only by nature. There will be no need to deal with change buffer or ROW_FORMAT=COMPRESSED in that case. purge_sys_t::view_guard::view_guard(): Allow the type of guard to be acquired: end_latch, latch, or no latch (in case we are a purge thread). purge_sys_t::view_guard::get(): Read-only accessor to purge_sys.pages. purge_sys_t::get_page(): Invoke buf_pool_t::page_fix(). row_vers_old_has_index_entry(): Replaced with row_purge_is_unsafe() and row_undo_mod_sec_unsafe(). trx_undo_get_undo_rec(): Merged to trx_undo_prev_version_build(). row_purge_poss_sec(): Add the parameter mtr and remove redundant or unused parameters sec_pcur, sec_mtr, is_tree. We will use the caller's mtr object but release any acquired page latches before returning. btr_cur_get_page(), page_cur_get_page(): Do not invoke page_align(). row_purge_remove_sec_if_poss_leaf(): Return the value of PAGE_MAX_TRX_ID to be checked against the page in row_purge_remove_sec_if_poss_tree(). If the secondary index page was not changed meanwhile, it will be unnecessary to invoke row_purge_poss_sec() again. trx_undo_prev_version_build(): Access any undo log pages using the caller's mini-transaction object. row_purge_vc_matches_cluster(): Moved to the only compilation unit that needs it. Reviewed by: Debarun Banerjee	1 year ago
Marko Mäkelä	d58734d781	MDEV-34520 purge_sys_t::wait_FTS sleeps 10ms, even if it does not have to There were two separate Atomic_counter<uint32_t>, purge_sys.m_SYS_paused and purge_sys.m_FTS_paused. In purge_sys.wait_FTS() we have to read both atomically. We used to use an overkill solution for this, acquiring purge_sys.latch and waiting 10 milliseconds between samples. To make matters worse, the 10-millisecond wait was unconditional, which would unnecessarily suspend the purge_coordinator_task every now and then. It turns out that we can fold both "reference counts" into a single Atomic_relaxed<uint32_t> and avoid the purge_sys.latch. To assess whether std::memory_order_relaxed is acceptable, we should consider the operations that read these "reference counts", that is, purge_sys_t::wait_FTS(bool) and purge_sys_t::must_wait_FTS(). Outside debug assertions, purge_sys.must_wait_FTS() is only invoked in trx_purge_table_acquire(), which is covered by a shared dict_sys.latch. We would increment the counter as part of a DDL operation, but before acquiring an exclusive dict_sys.latch. So, a purge_sys_t::close_and_reopen() loop could be triggered slightly prematurely, before a problematic DDL operation is actually executed. Decrementing the counter is less of an issue; purge_sys.resume_FTS() or purge_sys.resume_SYS() would mostly be invoked while holding an exclusive dict_sys.latch; ha_innobase::delete_table() does it outside that critical section. Still, this would only cause some extra wait in the purge_coordinator_task, just like at the start of a DDL operation. There are two calls to purge_sys_t::wait_FTS(bool): in the above mentioned purge_sys_t::close_and_reopen() and in purge_sys_t::clone_oldest_view(), both invoked by the purge_coordinator_task. There is also a purge_sys.clone_oldest_view<true>() call at startup when no DDL operation can be in progress. purge_sys_t::m_SYS_paused: Merged into m_FTS_paused, using a new multiplier PAUSED_SYS = 65536. purge_sys_t::wait_FTS(): Remove an unnecessary sleep as well as the access to purge_sys.latch. It suffices to poll purge_sys.m_FTS_paused. purge_sys_t::stop_FTS(): Do not acquire purge_sys.latch. Reviewed by: Debarun Banerjee	1 year ago
Sergei Petrunia	9020baf126	Trivial fix: Make test_if_cheaper_ordering() use actual_rec_per_key() Discovered this while working on MDEV-34720: test_if_cheaper_ordering() uses rec_per_key, while the original estimate for the access method is produced in best_access_path() by using actual_rec_per_key(). Make test_if_cheaper_ordering() also use actual_rec_per_key(). Also make several getter function "const" to make this compile. Also adjusted the testcase to handle this (the change backported from 11.0)	1 year ago
Marko Mäkelä	9db2b327d4	MDEV-34759: buf_page_get_low() is unnecessarily acquiring exclusive latch buf_page_ibuf_merge_try(): A new, separate function for invoking ibuf_merge_or_delete_for_page() when needed. Use the already requested page latch for determining if the call is necessary. If it is and if we are currently holding rw_latch==RW_S_LATCH, upgrading to an exclusive latch may involve waiting that another thread acquires and releases a U or X latch on the page. If we have to wait, we must recheck if the call to ibuf_merge_or_delete_for_page() is still needed. If the page turns out to be corrupted, we will release and fail the operation. Finally, the exclusive page latch will be downgraded to the originally requested latch. ssux_lock_impl::rd_u_upgrade_try(): Attempt to upgrade a shared lock to an update lock. sux_lock::s_x_upgrade_try(): Attempt to upgrade a shared lock to exclusive. sux_lock::s_x_upgrade(): Upgrade a shared lock to exclusive. Return whether a wait was elided. ssux_lock_impl::u_rd_downgrade(), sux_lock::u_s_downgrade(): Downgrade an update lock to shared.	1 year ago
Brandon Nesterenko	9e845107f8	MDEV-34765: rpl.master_last_event_time_stmt fails with Result Length Mismatch When executing a Query_log_event that is a COMMIT query, gtid_slave_pos is updated before other replication status variables, so when an MTR test syncs a replica with primaries via GTID, there is a slight window where accessing status variables, e.g. via SHOW ALL SLAVES STATUS, results in "stale" values because gtid_slave_pos has been updated before the *_last_event_time fields have been updated. This patch only fixes the test by switching from using GTIDs to using binlog file coordinates when synchronizing replicas with their primaries.	1 year ago
Brandon Nesterenko	bd54475efa	MDEV-34779: Sporadic test failure in rpl.rpl_semi_sync_cond_var_per_thd In a merge, an mtr.call_suppression was erroneously removed for "Got an error writing communication packets". So when the error would expectedly occur, the test would fail. This patch adds this suppression back. Note that the test will still fail due MDEV-34799, which is to be fixed in 10.6.	1 year ago
Brandon Nesterenko	3e5e97b26f	MDEV-34799: "Could not write packet" err message args off by 1 MDEV-33582 (`3541bd63f0`) changed the "Could not write packet" error message in net_serv.cc to use the function sql_print_warning(), instead of my_printf_error(). The flags argument was not removed in this change though, so the old flags were printed in place of the file descriptor, and all other args are presenting for the wrong field (and length is never showed). This patch removes flags as a parameter to sql_print_warning().	1 year ago
Monty	1f040ae048	MDEV-34043 Drastically slower query performance between CentOS (2sec) and Rocky (48sec) One cause of the slowdown is because the ftruncate call can be much slower on some systems. ftruncate() is called by Aria for internal temporary tables, tables created by the optimizer, when the upper level asks Aria to delete the previous result set. This is needed when some content from previous tables changes. I have now changed Aria so that for internal temporary tables we don't call ftruncate() anymore for maria_delete_all_rows(). I also had to update the Aria repair code to use the logical datafile size and not the on-disk datafile size, which may contain data from a previous result set. The repair code is called to create indexes for the internal temporary table after it is filled. I also replaced a call to mysql_file_size() with a pwrite() in _ma_bitmap_create_first(). Reviewer: Sergei Petrunia <sergey@mariadb.com> Tester: Dave Gosselin <dave.gosselin@mariadb.com>	1 year ago
Oleksandr Byelkin	eadf0f63a2	fix MDEV-34771 & MDEV-34776 removed duplicated methods	1 year ago
Oleksandr Byelkin	0b7d19d500	MDEV-34785: Assertion failure in Item_func_or_sum::do_build_clone (Item_func_not_all) Missed method added.	1 year ago
Thirunarayanan Balathandayuthapani	22b48bb393	MDEV-34756 Validation of new foreign key skipped if innodb_alter_copy_bulk=ON - During copy algorithm, InnoDB should disable bulk insert operation if the table has foreign key relation and foreign key check is enabled.	1 year ago
Oleksandr Byelkin	492a7c2430	Merge branch '11.5' into 11.6	1 year ago
Oleksandr Byelkin	342fa29615	Merge branch '11.4' into 11.5	1 year ago
Oleksandr Byelkin	eb70e0d6e2	Merge branch '11.2' into 11.4	1 year ago
Oleksandr Byelkin	6197e6abc4	Merge branch '10.11' into 11.2	1 year ago
Marko Mäkelä	b68c100076	MDEV-34565 MariaDB crashes with SIGILL because the OS does not support AVX512 In commit `232d7a5e2d` we almost got the detection logic right. However, the XGETBV instruction would crash if Linux was started up with the option noxsave. have_vpclmulqdq(): Check for the XSAVE flag at the correct position and also for the AVX flag. This was tested on Ubuntu 22.04 by starting up its Linux 5.15 kernel with and without the noxsave option.	1 year ago
Oleksandr Byelkin	2b11450d09	Merge branch '11.1' into 11.2	1 year ago
Oleksandr Byelkin	70afc62750	Merge branch '10.6' into 10.11	1 year ago
Oleksandr Byelkin	fc5772ce17	Merge branch '10.5' into 10.6	1 year ago
Kristian Nielsen	7318fa180d	Fix sporadic test failure of mariabackup.slave_provision_nolock The test requires a larger innodb log file size; this was lost as a side-effect of `d7699c51eb`. Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>	1 year ago
Kristian Nielsen	78fcb9474c	Fix sporadic failure in test rpl.rpl_rotate_logs Clarify confusing comments in the previous commit, and note that the failure started after push of MDEV-34504. Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>	1 year ago
Oleksandr Byelkin	ae02999cdb	MDEV-34776 Assertion failure in Item_string::do_build_clone Added missed methods to Item_string child.	1 year ago

1 2 3 4 5 ...

201574 Commits (19cea738342737503f47cfe6ff67d5248b0a0961) All Branches Search

201574 Commits (19cea738342737503f47cfe6ff67d5248b0a0961)

All Branches