mariadb

Tree: 19cea73834

Author	SHA1	Message	Date
Monty	25b5c63905	MDEV-33856: Alternative Replication Lag Representation via Received/Executed Master Binlog Event Timestamps This commit adds 3 new status variables to 'show all slaves status': - Master_last_event_time ; timestamp of the last event read from the master by the IO thread. - Slave_last_event_time ; Master timestamp of the last event committed on the slave. - Master_Slave_time_diff: The difference of the above two timestamps. All the above variables are NULL until the slave has started and the slave has read one query event from the master that changes data. - Added information_schema.slave_status, which allows us to remove: - show_master_info(), show_master_info_get_fields(), send_show_master_info_data(), show_all_master_info() - class Sql_cmd_show_slave_status. - Protocol::store(I_List<i_string_pair>* str_list) as it is not used anymore. - Changed old SHOW SLAVE STATUS and SHOW ALL SLAVES STATUS to use the SELECT code path, as all other SHOW ... STATUS commands. Other things: - Xid_log_time is set to time of commit to allow slave that reads the binary log to calculate Master_last_event_time and Slave_last_event_time. This is needed as there is not 'exec_time' for row events. - Fixed that Load_log_event calculates exec_time identically to Query_event. - Updated RESET SLAVE to reset Master/Slave_last_event_time - Updated SQL thread's update on first transaction read-in to only update Slave_last_event_time on group events. - Fixed possible (unlikely) bugs in sql_show.cc ...old_format() functions if allocation of 'field' would fail. Reviewed By: Brandon Nesterenko <brandon.nesterenko@mariadb.com> Kristian Nielsen <knielsen@knielsen-hq.org>	2 years ago
Daniel Black	7788593547	MDEV-19052 Range-type window frame supports only numeric datatype When there is no bounds on the upper or lower part of the window, it doesn't matter if the type is numeric. It also doesn't matter how many ORDER BY items there are in the query. Reviewers: Sergei Petrunia and Oleg Smirnov	1 year ago
Oleksandr Byelkin	26f31bdd52	The test should be not for AddressSanitizer used becouse stack check tests and this check switched off	1 year ago
Souradeep Saha	4dde925f54	Cleanup Whitespace in unittest/ directory Cleanup unnecessary whitespace at the end of lines and end of files in the unittest/ directory. Note that all code changes are non-functional. All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.	1 year ago
Oleksandr Byelkin	2844895766	disabling view protcol untill fix	1 year ago
Dmitry Shulga	ba5a0ff4f8	MDEV-34517: Memory leak on re-compilation of a failing statement inside a stored routine SP instructions, consisting a body of a stored routine, had the same memory root as an instance of the class sp_head, representing abstraction for stored routine itself. It resulted in memory leaks on re-parsing a failed statement of a stored routine in case the statement re-compilation has to be performed by the reason of changes in metadata of tables, triggers, etc. the stored routine depends on. To fix this kind of memory leaks, every SP instruction requiring access to a LEX object must do re-parsing of a failed statement on its own memory root. These memory roots are allocated on sp_head's memory root and every instance of the sp_lex_instr class has a pointer to allocated memory root in case re-parsing of the correspondiong SP instruction was requested. On every subsequent re-parsing of the failed statement, a memory allocated on SP instruction's memory root is released and the memory root re-initialized. Following memory allocations taken place on re-parsing the SP instruction's statement is performed on the dedicated memory root. So, no memory leaks will happen on SP statement re-parsing.	1 year ago
Thirunarayanan Balathandayuthapani	3359ac09a4	MDEV-34066 Output of SHOW ENGINE INNODB STATUS uses the nanoseconds suffix for microseconds - This issue is caused by commit `e71e613353` (MDEV-24671). Change the output of transaction lock wait time in microseconds suffix.	1 year ago
Oleg Smirnov	c91aeb3771	MDEV-34634 Types mismatch when cloning items causes debug assertion New runtime diagnostic introduced with MDEV-34490 has detected that `Item_int_with_ref` incorrectly returns an instance of its ancestor class `Item_int`. This commit fixes that. In addition, this commit reverts a part of the diagnostic related to `clone_item()` checks. As it turned out, `clone_item()` is not required to return an object of the same class as the cloned one. For example, look at `Item_param::clone_item()`: it can return objects of `Item_null`, `Item_int`, `Item_string`, etc, depending on the object state. So the runtime type diagnostic is not applicable to `clone_item()` and is disabled with this commit. As the similar diagnostic failures are expected to appear again in the future, this commit introduces a new test file in the main suite: item_types.test, and new test cases may be added to this file Reviewer: Oleksandr Byelkin <sanja@mariadb.com>	1 year ago
Andrei	c944cd6fec	MDEV-15393 post-push: complete rpl_mysqldump_gtid_slave_pos fixes. Added a missed --source include/save_master_gtid.inc by the previous commit.	1 year ago
Dave Gosselin	216fdb1556	MDEV-33971 fix --view-protocol test failure Allow the NAME_CONST unwrap optimization when the client is not in the PREPARE step of prepared statement nor in the view analysis mode.	1 year ago
Oleksandr Byelkin	0fe39d368a	Merge branch '10.6' into 10.11	1 year ago
Oleksandr Byelkin	a938503cfb	Merge branch '10.5' into 10.6	1 year ago
Andrei	b8f92ade57	MDEV-15393 gtid_slave_pos duplicate key errors after mysqldump restore When mysqldump is run to dump the `mysql` system database, it generates INSERT statements into the table `mysql.gtid_slave_pos`. After running the backup script those inserts did not produce the expected gtid state on slave. In particular the maximum of mysql.gtid_slave_pos.sub_id did not make into rpl_global_gtid_slave_state.last_sub_id an in-memory object that is supposed to match the current state of the table. And that was regardless of whether --gtid option was specified or not. Later when the backup recipient server starts as slave in non-gtid mode this desychronization may lead to a duplicate key error. This effect is corrected for --gtid mode mysqldump/mariadb-dump only as the following. The fixes ensure the insert block of the dump script is followed with a "summing-up" SET @global.gtid_slave_pos assignment. For the implemenation part, note a deferred print-out of SET-gtid_slave_pos and associated comments is prefered over relocating of the entire blocks if (opt_master,slave_data && do_show_master,slave_status) ... because of compatiblity concern. Namely an error inside do_show_*() is handled in the new code the same way, as early as, as before. A regression test can be run in how-to-reproduce mode as well. One affected mtr test observed. rpl_mysqldump_slave.result "mismatch" shows now the new deferring print of SET-gtid_slave_pos policy in action.	1 year ago
Oleksandr Byelkin	0f6f1114d4	new libfmt 11.0.1	1 year ago
Oleksandr Byelkin	88711ee509	New columnstore 23.10.2	1 year ago
Oleksandr Byelkin	a94fd87420	New CC 3.3	1 year ago
Oleksandr Byelkin	b8b6cab2d7	Fix view protocol	1 year ago
Oleksandr Byelkin	9af2caca33	Merge branch '10.5' into 10.6	1 year ago
Alexander Barkov	9dafde575f	Additional tests for MDEV-28345 ASAN: use-after-poison or unknown-crash in my_strtod_int from charset_info_st::strntod or test_if_number	1 year ago
Brandon Nesterenko	a061ae1079	MDEV-33921: Fix rpl_xa_empty_transaction.test The test was missing a save_master_gtid.inc on the master, leading to the slave thinking it was in sync after executing sync_with_master_gtid.inc, despite not having executed the latest transaction. This skipped transaction, XA COMMIT, was supposed to error-to-be-ignored because its XID could not be found, but be thrown out because the replication filters would filter out the target database. However, if the slave was able to stop before executing the transaction, then the replication filer is reset (to empty), and when the slave is later restarted, that transactions error would no longer be ignored. Additionally, as the test cases added in MDEV-33921 rely on GTID synchronization, the test cases now force master_use_gtid=slave_pos for consistency	1 year ago
Sergei Golubchik	36b867ad50	MDEV-34353 Revert "don't wait indefinitely for signal handler in --bootstrap" This reverts commit `938b929372`. Not needed after `90d376e017`.	1 year ago
Sergei Golubchik	8d813f080b	MDEV-34539 Invalid "use" and "Schema" in slow query log file with multi-line schema quote a database name in the slow log	1 year ago
Sergei Golubchik	f12634f5a4	MDEV-34530 dead code in the thr_rwlock.c remove it	1 year ago
Sergei Golubchik	7ba12d42de	MDEV-34434 Hide password passed on commandline from xtrabackup_info refine mariadb-backup password zapping check	1 year ago
Sergei Golubchik	d20518168a	also protect the /*!999999 sandbox comment	1 year ago
Sergei Golubchik	d60f5c11ea	MDEV-34318 mariadb-dump SQL syntax error with MAX_STATEMENT_TIME against Percona MySQL server protect MariaDB conditional comments from a bug in Percona MySQL comment parser	1 year ago
Sergei Golubchik	dea5746de2	MDEV-32155 MariaDB Server crashes with ill-formed partitions for ALTER_PARTITION_ADMIN (CHECK/REPAIR/LOAD INDEX/CACHE INDEX/etc) partitioning marks affected partitions with PART_ADMIN state. The assumption is that the server will call a corresponding method of ha_partition which will reset the state back to PART_NORMAL. This assumption is invalid, the server is not required to do so, indeed, in CHECK ... FOR UPGRADE the server might decide early that the table is fine and won't call ha_partition::check(), leaving partitions in the wrong state. It will thus leak into the next statement confusing the engine about what it is doing (see ha_partition::create_handler_file()), causing a crash later. Let's force all partitions into PART_NORMAL state after the admin operation succeeded, in case it did so without consulting the engine.	1 year ago
Sergei Golubchik	8ac30517af	MDEV-34384 restorecon call in RPM POSTIN script has hardcoded datadir path	1 year ago
Rucha Deodhar	1f28350b59	MDEV-32456: incorrect result of gis function in view protocol There are 3 diff in result: 1) NULL value from SELECT Due to incorrect truncating of the hex value, incorrect value is written instead of original value to the view frm. This results in reading incorrect value from frm, so eventual result is NULL. 2) 'Name_exp1' in column name (in gis.test) This was because the identifier in SELECT is longer than 64 characters, so 'Name_exp1' alias is also written to the view frm. 3)diff in explain extended This was because the query plan for view protocol doesn't contain database name. As a fix, disable view protocol for that particular query.	1 year ago
Souradeep Saha	4a89f79b6a	Refactor import * with only required imports Import only the required functions instead of all the functions from the module to reduce the unnecessary functions in the namespace and prevent shadowing. Note: All code changes are non-functional. All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.	1 year ago
Robin Newhouse	008bddaa6c	GitLab CI Upgrade CentOS 8 to CentOS 9 build > After May 31, 2024, CentOS Stream 8 will be archived and no further updates will be provided. [1] CentOS Stream 8 is now EOL and should be updated to using CentOS Stream 9 for compatibility testing in GitLab CI. [1] https://blog.centos.org/2023/04/end-dates-are-coming-for-centos-stream-8-and-centos-linux-7/ https://www.centos.org/centos-linux-eol/ All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services.	2 years ago
Oleksandr Byelkin	e7c2e25ba8	new CC version	1 year ago
Oleksandr Byelkin	7478fabcff	new PCRE2-10.44	1 year ago
Alexander Barkov	b777b749ad	MDEV-28345 ASAN: use-after-poison or unknown-crash in my_strtod_int from charset_info_st::strntod or test_if_number This patch fixes two problems: - The code inside my_strtod_int() in strings/dtoa.c could test the byte behind the end of the string when processing the mantissa. Rewriting the code to avoid this. - The code in test_if_number() in sql/sql_analyse.cc called my_atof() which is unsafe and makes the called my_strtod_int() look behind the end of the string if the input string is not 0-terminated. Fixing test_if_number() to use my_strtod() instead, passing the correct end pointer.	1 year ago
Sutou Kouhei	383d53edbc	MDEV-21166 Add Mroonga initialized check to Mroonga UDFs Mroonga UDFs can't be used without loading Mroonga.	2 years ago
Tuukka Pasanen	d94f34c1ed	MDEV-33750: Brand some mysql stuff to mariadb As is everywhere in mariadbd is used it more than convienient to use mariadbd-safe than mysql_safe in init script also in upstream test use output mariadb-test-run-junit.xml than mysql-test-run-junit.xml	1 year ago
Tuukka Pasanen	c22d01c91d	MDEV-33750: Conflict with Debian libmariadbd19t64 Conflict with Debian package libmariadbd19t64 as it marks that package is compliant with 64-bit time and does not suffer from year 2038 effect	2 years ago
Tuukka Pasanen	91336f6a18	MDEV-33750: Update Salsa-CI file Update changes from Debian Salsa that they are in sync	2 years ago
Tuukka Pasanen	74aea60d92	MDEV-33750: Update few Debian Salsa-CI tests from upstream to make smoke test pass autopkgtests from package are not passing currently and make them pass with upgrading Salsa-CI YAML file.	2 years ago
Tuukka Pasanen	89a638f4b8	MDEV-33750: Sync smoke test from newer version of Debian Salsa-CI For making smoke test work sync current Debian Salsa-CI version for making needed changes	2 years ago
Tuukka Pasanen	4c1e4ba62e	MDEV-33750: Remove seq in Debian init.d for-loop Make all init.d script for loops to use new {1..5} syntax and rework one not to use seq as all the rest use new Bash syntax.	2 years ago
Tuukka Pasanen	7ae9505106	MDEV-33750: Rework MyISAM recovery script Make small adjustment to MyISAM recovery function SQL statement and how to handle it.	2 years ago
Otto Kekäläinen	af124c4f1c	MDEV-33750: Make SysV init more verbose in case of MariaDB start failures MariaDB installs/upgrades in Docker containers (and elsewhere where systemd is not used) occasionally fail with output like: Starting MariaDB database server: mariadbd . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . failed! invoke-rc.d: initscript mariadb, action "start" failed. dpkg: error processing package mariadb-server-10.5 (--configure): installed mariadb-server-10.5 package post-installation script subprocess returned error exit status 1 This is not very helpful. Thus extend the init script to try the server start/restart one more time but with error log defined separately, and then print out the error log contents of this single start attempt. ... Starting MariaDB database server: mariadbd . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . 230103 01:06:48 mysqld_safe Can't log to error log and syslog at the same time. Remove all --log-error configuration options for --syslog to take effect. 230103 01:06:48 mysqld_safe Logging to '/tmp/tmp.JlE4sdUMZz.err'. 230103 01:06:49 mysqld_safe Starting mariadbd daemon with databases from /var/lib/mysql Running '/etc/init.d/mariadb start' failed with error log: 230103 01:06:49 mysqld_safe Starting mariadbd daemon with databases from /var/lib/mysql 2023-01-03 1:06:49 0 [Note] /usr/sbin/mariadbd (mysqld 10.5.18-MariaDB-0+deb11u1) starting as process 10417 ... 2023-01-03 1:06:49 0 [Note] InnoDB: Uses event mutexes 2023-01-03 1:06:49 0 [Note] InnoDB: Compressed tables use zlib 1.2.11 2023-01-03 1:06:49 0 [Note] InnoDB: Number of pools: 1 2023-01-03 1:06:49 0 [Note] InnoDB: Using crc32 + pclmulqdq instructions 2023-01-03 1:06:49 0 [Note] InnoDB: Using Linux native AIO 2023-01-03 1:06:49 0 [Note] InnoDB: Initializing buffer pool, total size = 134217728, chunk size = 134217728 2023-01-03 1:06:49 0 [Note] InnoDB: Completed initialization of buffer pool 2023-01-03 1:06:49 0 [ERROR] InnoDB: Invalid flags 0x4800 in ./ibdata1 ...	3 years ago
Otto Kekäläinen	3f44efaa17	MDEV-33750: Make sure that datadir always has some value and exists Adapted from upstream commit `8171f9da87` but separated only the datadir section from the commit and wrote it in a way that does not trigger Shellcheck or English grammar nags. This check is intentionally not added to the preinst script as was done upstream in `30fb72ca6e` as the preinst script will always create the data directory if missing, and thus checking for it right after the creation is moot.	2 years ago
Otto Kekäläinen	2adaf5c261	MDEV-33750: Sync maintainer scripts etc with latest downstream 10.11.5 in Debian Fix a large amount of minor fixes to maintainer scripts and other done downstream in the official Debian packaging. Changes include: `38198d0b9e` > Limit check of running mysqld/mariadbd to system users (Closes: #1032047) > > If a random user has their own copy of mysqld/mariadbd running, the > dpkg maintainer script should not care about it. `8116354d22` > Make error more helpful in case server restart fails (Related: #1033234) > > Bugs such as https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1033234 > and https://bugs.launchpad.net/ubuntu/+source/mariadb-10.6/+bug/2011293 > show that currently dpkg stopping on service stop/start does not have > a very helpful error message. `8675e97202` > Complement upstream commits with more complete mysql->mariadb conversion > > The upstream commit `952af4a1` missed some places where 'mysql' or > 'MySQL' can and should be converted to use 'mariadb' or 'MariaDB'. `c983613300` > Fix indentation in Debian post and pre scripts > > There is several misindentation inside Debian post and pre > installation scripts. False indentation with space as indent space > should be 2 and indentation with tabs. > > Adopt upstream commit `7cbb45d1` in Debian by conserving customizations > in: > - debian/mariadb-server.postinst > - debian/mariadb-server.postrm > - debian/mariadb-server.preinst `d0bcab443f` > Ensure spaces are used everywhere instead of tabs for indentation `0300a9157c` > Complement previous upstream commits to fix Shellcheck issues > > - Unify if/then and while/do on separate lines > - Fix indentation to be consistent > - Use "$()" instead of backticks for subshells > - Exit code cannot be -1, must be 0-255 > - Remove unused variables MYCHECK and MYCHECK_PARAMS > - Rewrite messy command-line database calls to an easier to read form > that does exactly the same > - Use 'command -v' test instead of 'which' > > With this commit, all of debian/* is Shellcheck clean. Also * Update mariadb.conf.d template to tell users where to create logdir if they are not using journald * Remove use of work 'slave' * Add minor workaround for Debian Bug #1022994 if TMPDIR is empty * Make start/stop in maintainer scripts correctly check mariadbd ownership and only start/stop processes owned by root or 'mysql' * Remove obsolete 'NO_UPDATE_BUILD_VERSION=1' as it did not affect the RocksDB build reproducibility as previously assumed * Run 'wrap-and-sort -av'	2 years ago
Otto Kekäläinen	5000d1ba6e	MDEV-33750: Increase MTR verbosity and unify skip test lists usage - Unify on MTR_SKIP_TEST_LIST in both d/rules and autopkgtests - Unify MTR command in both d/rules and autopkgtests - Make d/rules section more verbose to help debugging why tests sometimes ran and sometimes not - If MTR fails, make the log a bit more verbose (inspired by https://github.com/MariaDB/buildbot/pull/76/files)	2 years ago
Otto Kekäläinen	f79f3ada24	MDEV-33750: Fix DPKG_GENSYMBOLS_CHECK_LEVEL so it actually takes effect The way DPKG_GENSYMBOLS_CHECK_LEVEL was exported did not actually have any effect on the build. Fix the syntax so that build will indeed fail if there there are new symbols in new upstream version.	3 years ago
Otto Kekäläinen	b11892c9fb	MDEV-33750: Fix Lintian warnings - mariadb-server: recursive-privilege-change "chown -R" - use correct URL https://jira.mariadb.org everywhere - dependency-is-not-multi-archified libmariadb-dev-compat depends on libmariadb-dev (multi-arch: no) - dependency-is-not-multi-archified mariadb-plugin-gssapi-client depends on mariadb-client (multi-arch: no)	3 years ago
Otto Kekäläinen	9e9211215c	MDEV-33750: Enable mariadb-plugin-rocksdb for riscv64 Based on riscv64 build logs the RocksDB plugin currently builds fine on it, and the riscv64 platform is 64-bit and has correct endianness for RocksDB, so all the pre-requisites for it working exist, so it should work.	3 years ago
PinkFreud	49dff5a4b6	MDEV-34604 mytop - fix specifying filters in .mytop Specifying filters (filter_status, filter_user, etc) in the mytop config previously wouldn't work, because any filter specified here was added to the config hash as a literal string. This change fixes that - if filter_* is defined in the config and matches an existing filter_* key, then run the value through StringOrRegex() and assign to the config hash.	2 years ago

... 2 3 4 5 6 ...

201574 Commits (19cea738342737503f47cfe6ff67d5248b0a0961) All Branches Search

201574 Commits (19cea738342737503f47cfe6ff67d5248b0a0961)

All Branches