9c0727f28e
We need to clamp the index to max - 1
What did we think this was? Pascal?
Fixes https://gitlab.com/kicad/code/kicad/issues/21750
3 weeks ago
c8f04af55a
Do not leave stale edges floating around
We assume that all net edges are valid in too many places
Fixes https://gitlab.com/kicad/code/kicad/-/issues/21745
(cherry picked from commit b89d77bf36
3 weeks ago
89af3c34b9
Support vector graphics drag-and-drop in PCB and schematic editors.
This just shows the import dialogs with filename pre-populated.
3 weeks ago
425b77b34c
wxString::both goes with Strip(), not Trim().
But Strip() is deprecated, so we shouldn't use it
(or wxString::leading/trailing/both) at all.
3 weeks ago
87739c8ac7
wxStringTokenizer usage cleanup.
1) Always be explicit about what the delimiters are
2) If space is a delimiter, we probably want to skip
empty fields (wxTOKEN_STRTOK)
3) If space is not a delimiter, we often need to
trim the resultant tokens
4) Be more lenient about \t\r\n (and when they are
included, include them in the same order)
3 weeks ago
bad00cdceb
Fix the panel setup rules not being committed properly
3 weeks ago
aefaa521d1
Fix up arm assembly compiling on windows
3 weeks ago
4fcc2ac7e2
Ensure new symbols obey the observed sheet number
Internal numerology will not make sense when annotating, so use the
observed sheet number and let the algo ensure that numbers are not
duplicated
Fixes https://gitlab.com/kicad/code/kicad/-/issues/21637
Fixes https://gitlab.com/kicad/code/kicad/-/issues/19138
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16632
3 weeks ago
bda994c00a
Edit ConfigurePlatform.cmake
3 weeks ago
e02008630f
Also set CMAKE_SYSTEM_PROCESSOR in win cross compile
3 weeks ago
9ddb5465e1
Don't overwrite footprint filters created from multiple tokens in footprint column.
3 weeks ago
91405ae34d
ADDED: support for multiple footprints in the footprint json from HTTP libraries
These are semi-colon-separated.
This is different from the footprint_filters dict entry, which is space-separated.
The first footprint in the footprint dict entry
will go into the "Footprint" field, while the rest
will go into the symbol's footprint filters.
3 weeks ago
427c9da2f3
Parallelize copper graphic checking.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/21744
3 weeks ago
c0a659a792
Formatting.
3 weeks ago
8b525671b1
Only use front/back layer notation "F&B" for zone definitions.
This prevents false positive DRC footprint parity errors caused by commit
088e0e80a1
3 weeks ago
1f1f490887
ADDED: handling of meta-data items in REST libraries.
"description" and "keywords" must hold string values;
"footprint_filters" can either hold a (space-
separated) string value, or an array of strings.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/20750
3 weeks ago
2eb3518e49
Formatting and naming conventions.
3 weeks ago
175e8a4a94
ADDED: "bridged_mask" constraint.
The constraint takes no values, but can have a severity
assigned. This allows solder mask bridges that meet
certain criteria to be ignored.
For a mask aperture, only the aperture must pass the
DRC rule conditional. For bridges between two copper
items, both items must pass the conditional.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/21732
3 weeks ago
80ca30ac37
Repair missing handling of solder mask expansion on copper shapes.
3 weeks ago
4ec497e28a
Formatting.
3 weeks ago
05f979071d
Fix spelling in error message.
Also regularizes syntax of error messages.
4 weeks ago
b4fdcfd461
DIALOG_PIN_PROPERTIES: fix issue: new pins were not shown on canvas.
3 weeks ago
e5da92dcc6
Always enable PYBIND11_USE_CROSSCOMPILING (paired in pybind11 with CMAKE_CROSSCOMPILING_LATER)
In what world would you ever not want the PYBIND11_USE_CROSSCOMPILING flag???????????
3 weeks ago
accb0ddcd1
Manually set CMAKE_CROSSCOMPILING on MSVC.
3 weeks ago
4aa3576a4c
Fix build warnings
Use detach_task since we don't need the return values
3 weeks ago
fbbc051983
gendrill_gerber_writer: do not generate useless mask files of special vias.
Now, only mask layers of vias actually using a IPC4761 feature are created.
3 weeks ago
1e9025a4dc
Move to a fixed enum for page sizes as well as well as holding a list of types accessible in a vector.
Drops some hardcoded size names in places among other bits.
Woooo committed pushed at 36000 feet.
4 weeks ago
ca7059b487
Honour flip when checking front/back courtyards.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/21670
4 weeks ago
fb1cfee39c
Compil warnings fixes
4 weeks ago
36e38cd60a
ADDED: Sort the templates alphabetically, leaving the default template at the top.
4 weeks ago
5fdfff2b9c
Prevent lines from drawing on netclass layer
Only wires and busses get netclasses
Fixes https://gitlab.com/kicad/code/kicad/issues/21731
4 weeks ago
733a379ca3
Unify sheet name validators and apply to properties
Properties panel and properties dialog now share a validator with shared
strings
Fixes https://gitlab.com/kicad/code/kicad/issues/21689
4 weeks ago
497afffd48
Properly order netlist pages
We cannot reorder these without updating the defines. So, keep the GUI
in line with the definitions
Fixes https://gitlab.com/kicad/code/kicad/issues/21730
4 weeks ago
89be756d1a
Ensure that we are checking case differences
When comparing symbols, look for case differences in values since
netlists are indeed case sensitive
4 weeks ago
a6decf15b5
Don't assert on stderr messages
These can be things like missing library tables, directory creation, etc
4 weeks ago
4229b3cc76
Update cli golden files with new output format
4 weeks ago
32ee4ebdfa
Fix QA.
QA was built with pin names outside but this was a bug. For now, we
only want to test outside pin names. The test can be expanded in the
future
4 weeks ago
2c102a62e0
Auto-convert numeric values in fields when referencing them in expressions.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/21723
4 weeks ago
aa4de22ef4
EDA_3D_CANVAS: fix crash when used in dialogs and clicking in the 3D shape
It was due to the fact a message (using ExpressMail) was sent to the board
and schematic editor, but it is possible only if the manager of this canvas
is a EDA_3D_VIEWER_FRAME, because only this kind of frame has ExpressMail stuff
Fixes https://gitlab.com/kicad/code/kicad/-/issues/21728
4 weeks ago
79a3b7ac5f
Add missing header to compil on msys2
4 weeks ago
56ad08cdd8
Prevent backannotation from changing variables
Updating to PCB always resolves text variables from the schematic. This
means that back annotation will always start from resolved variables if
they exist in the schematic. So to avoid this, we prevent overwriting
any text variables that exist in the schematic.
This does prevent the user from updating a text variable in a pcbnew
field and backannotating this variable change into the schematic where
the schematic had a text variable already. Text variables are forward
annotation only until we add an additional property to each field to
include the unresolved text
Fixes https://gitlab.com/kicad/code/kicad/issues/21724
4 weeks ago
accbee3c6e
Move git stuff to kicommon to fix build
And do other cool stuff
4 weeks ago
29025882fc
Fix typo in pad table
4 weeks ago
c64f99c57a
ADDED: VCSHASH and VCSSHORTHASH
Right now, git hashes only resolved by the variables ${VCSHASH} or
${VCSSHORTHASH}
4 weeks ago
5952c2fb9a
ADDED: Pad edit table
Allows editing common pad properties in table format
Fixes https://gitlab.com/kicad/code/kicad/issues/10789
4 weeks ago
0b6de964fd
Fix initialization order.
4 weeks ago
976278e5a6
ADDED: extra info for shape, pin and field differences.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/21647
4 weeks ago
8d8bd7253f
Windows CI: custom vcpkg triplet to ensure shareable binary cache
4 weeks ago
5dc6d43f43
Add via tenting/plugging representation to 3d-viewer
Fixes https://gitlab.com/kicad/code/kicad/issues/21704
4 weeks ago
98dd5a68eb
Fix a compil issue on gcc/msys2
gcc does not like implicit conversion from wxString to char*
4 weeks ago
Seth Hillbrand
Alex Shvartzkop
Jeff Young
Mark Roszko
Wayne Stambaugh
jean-pierre charras
Jan Wichmann
Roberto Fernandez Bautista