Fix user_ldap unit tests

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

apps/user_ldap/lib/GroupPluginManager.php

@@ -88,7 +88,7 @@ class GroupPluginManager {
 	}
 
 	public function canDeleteGroup(): bool {
-		return !$this->suppressDeletion && ($this->which[GroupInterface::DELETE_GROUP] !== null);
+		return !$this->suppressDeletion && $this->implementsActions(GroupInterface::DELETE_GROUP);
 	}
 
 	/**
@@ -102,11 +102,10 @@ class GroupPluginManager {
 
 	/**
 	 * Delete a group
-	 * @param string $gid Group Id of the group to delete
-	 * @return bool
+	 *
 	 * @throws \Exception
 	 */
-	public function deleteGroup($gid) {
+	public function deleteGroup(string $gid): bool {
 		$plugin = $this->which[GroupInterface::DELETE_GROUP];
 
 		if ($plugin) {

apps/user_ldap/tests/GroupLDAPPluginTest.php

@@ -108,10 +108,10 @@ class GroupLDAPPluginTest extends \Test\TestCase {
 			->method('deleteGroup')
 			->with(
 				$this->equalTo('group')
-			);
+			)->willReturn(true);
 
 		$pluginManager->register($plugin);
-		$pluginManager->deleteGroup('group');
+		$this->assertTrue($pluginManager->deleteGroup('group'));
 	}
 
 

apps/user_ldap/tests/Group_LDAPTest.php

@@ -1092,7 +1092,7 @@ class Group_LDAPTest extends TestCase {
 		$pluginManager->expects($this->once())
 			->method('deleteGroup')
 			->with('gid')
-			->willReturn('result');
+			->willReturn(true);
 
 		$mapper = $this->getMockBuilder(GroupMapping::class)
 			->setMethods(['unmap'])
@@ -1108,7 +1108,7 @@ class Group_LDAPTest extends TestCase {
 
 		$ldap = new GroupLDAP($access, $pluginManager);
 
-		$this->assertEquals($ldap->deleteGroup('gid'), 'result');
+		$this->assertTrue($ldap->deleteGroup('gid'));
 	}