Browse Source

Fix memcache factory unit tests

remotes/origin/handlebars-approach
Robin McCorkell 10 years ago
parent
commit
8efa23c895
  1. 4
      lib/private/memcache/factory.php
  2. 6
      tests/lib/memcache/factory.php

4
lib/private/memcache/factory.php

@ -82,7 +82,7 @@ class Factory implements ICacheFactory {
$missingCacheMessage = 'Memcache {class} not available for {use} cache';
$missingCacheHint = 'Is the matching PHP module installed and enabled?';
if (!$localCacheClass::isAvailable()) {
if (\OC::$CLI) {
if (\OC::$CLI && !defined('PHPUNIT_RUN')) {
// CLI should not hard-fail on broken memcache
$this->logger->info($missingCacheMessage, [
'class' => $localCacheClass,
@ -97,7 +97,7 @@ class Factory implements ICacheFactory {
}
}
if (!$distributedCacheClass::isAvailable()) {
if (\OC::$CLI) {
if (\OC::$CLI && !defined('PHPUNIT_RUN')) {
// CLI should not hard-fail on broken memcache
$this->logger->info($missingCacheMessage, [
'class' => $distributedCacheClass,

6
tests/lib/memcache/factory.php

@ -114,7 +114,8 @@ class Test_Factory extends \Test\TestCase {
*/
public function testCacheAvailability($localCache, $distributedCache, $lockingCache,
$expectedLocalCache, $expectedDistributedCache, $expectedLockingCache) {
$factory = new \OC\Memcache\Factory('abc', $localCache, $distributedCache, $lockingCache);
$logger = $this->getMockBuilder('\OCP\ILogger')->getMock();
$factory = new \OC\Memcache\Factory('abc', $logger, $localCache, $distributedCache, $lockingCache);
$this->assertTrue(is_a($factory->createLocal(), $expectedLocalCache));
$this->assertTrue(is_a($factory->createDistributed(), $expectedDistributedCache));
$this->assertTrue(is_a($factory->createLocking(), $expectedLockingCache));
@ -125,6 +126,7 @@ class Test_Factory extends \Test\TestCase {
* @expectedException \OC\HintException
*/
public function testCacheNotAvailableException($localCache, $distributedCache) {
new \OC\Memcache\Factory('abc', $localCache, $distributedCache);
$logger = $this->getMockBuilder('\OCP\ILogger')->getMock();
new \OC\Memcache\Factory('abc', $logger, $localCache, $distributedCache);
}
}
Loading…
Cancel
Save