Browse Source

fix(files): Remove dead code from files controllers

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
pull/43532/head
Ferdinand Thiessen 2 years ago
parent
commit
5e124c4a8a
No known key found for this signature in database GPG Key ID: 45FAE7268762B400
  1. 20
      apps/files/lib/Controller/ViewController.php
  2. 5
      apps/files/tests/Controller/ViewControllerTest.php

20
apps/files/lib/Controller/ViewController.php

@ -115,26 +115,6 @@ class ViewController extends Controller {
$this->viewConfig = $viewConfig;
}
/**
* @param string $appName
* @param string $scriptName
* @return string
*/
protected function renderScript($appName, $scriptName) {
$content = '';
$appPath = \OC_App::getAppPath($appName);
$scriptPath = $appPath . '/' . $scriptName;
if (file_exists($scriptPath)) {
// TODO: sanitize path / script name ?
ob_start();
include $scriptPath;
$content = ob_get_contents();
@ob_end_clean();
}
return $content;
}
/**
* FIXME: Replace with non static code
*

5
apps/files/tests/Controller/ViewControllerTest.php

@ -71,9 +71,9 @@ class ViewControllerTest extends TestCase {
private $eventDispatcher;
/** @var ViewController|\PHPUnit\Framework\MockObject\MockObject */
private $viewController;
/** @var IUser */
/** @var IUser|\PHPUnit\Framework\MockObject\MockObject */
private $user;
/** @var IUserSession */
/** @var IUserSession|\PHPUnit\Framework\MockObject\MockObject */
private $userSession;
/** @var IAppManager|\PHPUnit\Framework\MockObject\MockObject */
private $appManager;
@ -135,7 +135,6 @@ class ViewControllerTest extends TestCase {
])
->setMethods([
'getStorageInfo',
'renderScript'
])
->getMock();
}

Loading…
Cancel
Save