mariadb

Tree: 7bb6a72593

unknown 7bb6a72593 Bug#27590: Wrong DATE/DATETIME comparison. DATE and DATETIME can be compared either as strings or as int. Both methods have their disadvantages. Strings can contain valid DATETIME value but have insignificant zeros omitted thus became non-comparable with other DATETIME strings. The comparison as int usually will require conversion from the string representation and the automatic conversion in most cases is carried out in a wrong way thus producing wrong comparison result. Another problem occurs when one tries to compare DATE field with a DATETIME constant. The constant is converted to DATE losing its precision i.e. losing time part. This fix addresses the problems described above by adding a special DATE/DATETIME comparator. The comparator correctly converts DATE/DATETIME string values to int when it's necessary, adds zero time part (00:00:00) to DATE values to compare them correctly to DATETIME values. Due to correct conversion malformed DATETIME string values are correctly compared to other DATE/DATETIME values. As of this patch a DATE value equals to DATETIME value with zero time part. For example '2001-01-01' equals to '2001-01-01 00:00:00'. The compare_datetime() function is added to the Arg_comparator class. It implements the correct comparator for DATE/DATETIME values. Two supplementary functions called get_date_from_str() and get_datetime_value() are added. The first one extracts DATE/DATETIME value from a string and the second one retrieves the correct DATE/DATETIME value from an item. The new Arg_comparator::can_compare_as_dates() function is added and used to check whether two given items can be compared by the compare_datetime() comparator. Two caching variables were added to the Arg_comparator class to speedup the DATE/DATETIME comparison. One more store() method was added to the Item_cache_int class to cache int values. The new is_datetime() function was added to the Item class. It indicates whether the item returns a DATE/DATETIME value. sql/item.cc: Bug#27590: Wrong DATE/DATETIME comparison. One more store() method was added to the Item_cache_int class to cache int values. The new is_datetime() function was added to the Item class. It indicates whether the item returns a DATE/DATETIME value. sql/item.h: Bug#27590: Wrong DATE/DATETIME comparison. One more store() method was added to the Item_cache_int class to cache int values. The new is_datetime() function was added to the Item class. It indicates whether the item returns a DATE/DATETIME value. sql/item_cmpfunc.cc: Bug#27590: Wrong DATE/DATETIME comparison. The compare_datetime() function is added to the Arg_comparator class. It implements the correct comparator for DATE/DATETIME values. Two supplementary functions called get_date_from_str() and get_datetime_value() are added. The first one extracts DATE/DATETIME value from a string and the second one retrieves the correct DATE/DATETIME value from an item. The new Arg_comparator::can_compare_as_dates() function is added and used to check whether two given items can be compared by the compare_datetime() comparator. sql/item_cmpfunc.h: Bug#27590: Wrong DATE/DATETIME comparison. The compare_datetime() function is added to the Arg_comparator class. It implements the correct comparator for DATE/DATETIME values. Two supplementary functions called get_date_from_str() and get_datetime_value() are added. The first one extracts DATE/DATETIME value from a string and the second one retrieves the correct DATE/DATETIME value from an item. The new Arg_comparator::can_compare_as_dates() function is added and used to check whether two given items can be compared by the compare_datetime() comparator. Two caching variables were added to the Arg_comparator class to speedup the DATE/DATETIME comparison. mysql-test/include/ps_conv.inc: Test case adjusted after fix for bug#27590. mysql-test/r/distinct.result: Test cases results are corrected after fix for bug#27590. sql/sql_select.cc: Bug#27590: Wrong DATE/DATETIME comparison. The test_if_equality_guarantees_uniqueness() function now uses Arg_comparator::can_compare_as_dates() to detect comparable DATE/DATETIME items. mysql-test/r/ps_2myisam.result: The result of the adjusted test case after fix for bug#27590. mysql-test/r/ps_3innodb.result: The result of the adjusted test case after fix for bug#27590. mysql-test/r/ps_4heap.result: The result of the adjusted test case after fix for bug#27590. mysql-test/r/ps_5merge.result: The result of the adjusted test case after fix for bug#27590. mysql-test/r/subselect.result: Test cases results are corrected after fix for bug#27590. mysql-test/r/type_datetime.result: Added a test case for the bug#27590: Wrong DATE/DATETIME comparison. mysql-test/t/type_datetime.test: Added a test case for the bug#27590: Wrong DATE/DATETIME comparison. tests/mysql_client_test.c: Test case adjusted after fix for bug#27590.		19 years ago
..
.cvsignore	Import changeset	26 years ago
CMakeLists.txt	my_strtoll10-x86.s:	19 years ago
Makefile.am	Remove test/udf_test and test/udf_test.res, since udf's are nowadays	19 years ago
auto_increment.res	Import changeset	26 years ago
auto_increment.tst	Import changeset	26 years ago
big_record.pl	Safety fix to enable RAID in max binaries	23 years ago
connect_test.c	Many files:	19 years ago
deadlock_test.c	my_strtoll10-x86.s:	19 years ago
drop_test.pl	Bug fixes for 3.23.23	25 years ago
export.pl	Fixed bug in send in mysqltest	25 years ago
fork2_test.pl	Don't do signal() on windows (Causes instability problems)	24 years ago
fork_big.pl	Don't do signal() on windows (Causes instability problems)	24 years ago
fork_big2.pl	Save and clear run context before executing a stored function or trigger and restore it afterwards.	20 years ago
function.res	Arjens LOG functions changes with small changes and tests added to mysql-test	24 years ago
function.tst	Arjens LOG functions changes with small changes and tests added to mysql-test	24 years ago
grant.pl	Fixed two bugs in MySQL ACL.	21 years ago
grant.res	Merge with 4.0.18	22 years ago
index_corrupt.pl	Fixed core dump bug when hot link list in key cache was empty. Bug #10167	21 years ago
insert_and_repair.pl	Don't do signal() on windows (Causes instability problems)	24 years ago
insert_test.c	Many files:	19 years ago
list_test.c	Many files:	19 years ago
lock_test.pl	Import changeset	26 years ago
lock_test.res	Import changeset	26 years ago
mail_to_db.pl	New versions of mail_to_db.pl and pmail.pl.	21 years ago
myisam-big-rows.tst	Fix for MyISAM records > 16M	24 years ago
mysql_client_test.c	Bug#27590: Wrong DATE/DATETIME comparison.	19 years ago
pmail.pl	New versions of mail_to_db.pl and pmail.pl.	21 years ago
rename_test.pl	Don't do signal() on windows (Causes instability problems)	24 years ago
restore-lock.smack	sql/slave.cc	25 years ago
select_test.c	Many files:	19 years ago
showdb_test.c	Many files:	19 years ago
ssl_test.c	Many files:	19 years ago
table_types.pl	Safety fix to enable RAID in max binaries	23 years ago
test_delayed_insert.pl	Don't do signal() on windows (Causes instability problems)	24 years ago
thread_test.c	Many files:	19 years ago
truncate.pl	Fixed mutex problem in TRUNCATE TABLE	24 years ago