mariadb

Tree: 7bb6a72593

Author	SHA1	Message	Date
unknown	7bb6a72593	Bug#27590: Wrong DATE/DATETIME comparison. DATE and DATETIME can be compared either as strings or as int. Both methods have their disadvantages. Strings can contain valid DATETIME value but have insignificant zeros omitted thus became non-comparable with other DATETIME strings. The comparison as int usually will require conversion from the string representation and the automatic conversion in most cases is carried out in a wrong way thus producing wrong comparison result. Another problem occurs when one tries to compare DATE field with a DATETIME constant. The constant is converted to DATE losing its precision i.e. losing time part. This fix addresses the problems described above by adding a special DATE/DATETIME comparator. The comparator correctly converts DATE/DATETIME string values to int when it's necessary, adds zero time part (00:00:00) to DATE values to compare them correctly to DATETIME values. Due to correct conversion malformed DATETIME string values are correctly compared to other DATE/DATETIME values. As of this patch a DATE value equals to DATETIME value with zero time part. For example '2001-01-01' equals to '2001-01-01 00:00:00'. The compare_datetime() function is added to the Arg_comparator class. It implements the correct comparator for DATE/DATETIME values. Two supplementary functions called get_date_from_str() and get_datetime_value() are added. The first one extracts DATE/DATETIME value from a string and the second one retrieves the correct DATE/DATETIME value from an item. The new Arg_comparator::can_compare_as_dates() function is added and used to check whether two given items can be compared by the compare_datetime() comparator. Two caching variables were added to the Arg_comparator class to speedup the DATE/DATETIME comparison. One more store() method was added to the Item_cache_int class to cache int values. The new is_datetime() function was added to the Item class. It indicates whether the item returns a DATE/DATETIME value. sql/item.cc: Bug#27590: Wrong DATE/DATETIME comparison. One more store() method was added to the Item_cache_int class to cache int values. The new is_datetime() function was added to the Item class. It indicates whether the item returns a DATE/DATETIME value. sql/item.h: Bug#27590: Wrong DATE/DATETIME comparison. One more store() method was added to the Item_cache_int class to cache int values. The new is_datetime() function was added to the Item class. It indicates whether the item returns a DATE/DATETIME value. sql/item_cmpfunc.cc: Bug#27590: Wrong DATE/DATETIME comparison. The compare_datetime() function is added to the Arg_comparator class. It implements the correct comparator for DATE/DATETIME values. Two supplementary functions called get_date_from_str() and get_datetime_value() are added. The first one extracts DATE/DATETIME value from a string and the second one retrieves the correct DATE/DATETIME value from an item. The new Arg_comparator::can_compare_as_dates() function is added and used to check whether two given items can be compared by the compare_datetime() comparator. sql/item_cmpfunc.h: Bug#27590: Wrong DATE/DATETIME comparison. The compare_datetime() function is added to the Arg_comparator class. It implements the correct comparator for DATE/DATETIME values. Two supplementary functions called get_date_from_str() and get_datetime_value() are added. The first one extracts DATE/DATETIME value from a string and the second one retrieves the correct DATE/DATETIME value from an item. The new Arg_comparator::can_compare_as_dates() function is added and used to check whether two given items can be compared by the compare_datetime() comparator. Two caching variables were added to the Arg_comparator class to speedup the DATE/DATETIME comparison. mysql-test/include/ps_conv.inc: Test case adjusted after fix for bug#27590. mysql-test/r/distinct.result: Test cases results are corrected after fix for bug#27590. sql/sql_select.cc: Bug#27590: Wrong DATE/DATETIME comparison. The test_if_equality_guarantees_uniqueness() function now uses Arg_comparator::can_compare_as_dates() to detect comparable DATE/DATETIME items. mysql-test/r/ps_2myisam.result: The result of the adjusted test case after fix for bug#27590. mysql-test/r/ps_3innodb.result: The result of the adjusted test case after fix for bug#27590. mysql-test/r/ps_4heap.result: The result of the adjusted test case after fix for bug#27590. mysql-test/r/ps_5merge.result: The result of the adjusted test case after fix for bug#27590. mysql-test/r/subselect.result: Test cases results are corrected after fix for bug#27590. mysql-test/r/type_datetime.result: Added a test case for the bug#27590: Wrong DATE/DATETIME comparison. mysql-test/t/type_datetime.test: Added a test case for the bug#27590: Wrong DATE/DATETIME comparison. tests/mysql_client_test.c: Test case adjusted after fix for bug#27590.	19 years ago
unknown	6073ae712d	Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt into magare.gmz:/home/kgeorge/mysql/autopush/B19372-5.0-opt	19 years ago
unknown	8e72b760aa	Bug #19372 : Added a test case. The problem was fixed by the fix for bug #17379. The problem was that because of some conditions the optimizer always preferred range or full index scan access methods to lookup access methods even when the latter were much cheaper. mysql-test/r/select.result: Bug #19372: test case. The problem was fixed by the patch for bug #17379 mysql-test/t/select.test: Bug #19372: test case. The problem was fixed by the patch for bug #17379	19 years ago
unknown	b518d2a8bd	Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt into magare.gmz:/home/kgeorge/mysql/autopush/B27659-5.0-opt	19 years ago
unknown	041767e123	Bug #27659 : The optimizer transforms DISTINCT into a GROUP BY when possible. It does that by constructing the same structure (a list of ORDER instances) the parser makes when parsing GROUP BY. While doing that it also eliminates duplicates. But if a duplicate is found it doesn't advance the pointer to ref_pointer array, so the next (and subsequent) ORDER structures point to the wrong element in the SELECT list. Fixed by advancing the pointer in ref_pointer_array even in the case of a duplicate. mysql-test/r/distinct.result: Bug #27659: test case mysql-test/t/distinct.test: Bug #27659: test case sql/sql_select.cc: Bug #27659: use correct ref_pointer_array element	19 years ago
unknown	a41b81e3a4	Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt into mysql.com:/home/gluh/MySQL/Bugs/5.0.27069 sql/sql_table.cc: Auto merged	19 years ago
unknown	5ded16c5d0	Bug#27069 set with identical elements are created(additional fix) issue an error in strict mode if enum\|set column has duplicates members in 'create table' mysql-test/r/strict.result: test case mysql-test/t/strict.test: test case sql/sql_table.cc: issue an error in strict mode if enum\|set has duplicates members	19 years ago
unknown	d2667d1a6e	Merge bk@192.168.21.1:mysql-5.0-opt into mysql.com:/d2/hf/mrg/mysql-5.0-opt	19 years ago
unknown	6d9a796944	Merge bk@192.168.21.1:mysql-5.0 into mysql.com:/d2/hf/mrg/mysql-5.0-opt sql/sql_table.cc: Auto merged	19 years ago
unknown	ddaeead8fc	Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-5.0 into mysql.com:/home/kent/bk/tmp4/mysql-5.0-engines sql/item_func.cc: Auto merged sql/sql_table.cc: Auto merged	19 years ago
unknown	1f8dbdaf3a	Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt into moonbone.local:/mnt/gentoo64/work/27586-bug-5.0-opt-mysql sql/sql_load.cc: Auto merged	19 years ago
unknown	a978d84cbc	Merge mysql.com:/d2/hf/mrg/mysql-4.1-opt into mysql.com:/d2/hf/mrg/mysql-5.0-opt	19 years ago
unknown	b3f9c88826	Merge bk@192.168.21.1:mysql-5.0 into mysql.com:/d2/hf/mrg/mysql-5.0-opt sql/field.cc: Auto merged sql/sql_table.cc: Auto merged	19 years ago
unknown	2911bcd8e3	Merge bk@192.168.21.1:mysql-4.1 into mysql.com:/d2/hf/mrg/mysql-4.1-opt	19 years ago
unknown	b5cf43c902	Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt into moonbone.local:/mnt/gentoo64/work/27586-bug-5.0-opt-mysql	19 years ago
unknown	35a0f47234	Bug#27586: Wrong autoinc value assigned by LOAD DATA in the NO_AUTO_VALUE_ON_ZERO mode. The table->auto_increment_field_not_null variable wasn't reset after reading a row which may lead to inserting a wrong value to the auto-increment field to the following row. The table->auto_increment_field_not_null variable is reset now right after a row is being written in the read_fixed_length() and the read_sep_field() functions. Removed wrong setting of the table->auto_increment_field_not_null variable in the read_sep_field() function. mysql-test/t/loaddata.test: Added a test case for the bug#27586: Wrong autoinc value assigned by LOAD DATA in the NO_AUTO_VALUE_ON_ZERO mode. mysql-test/r/loaddata.result: Added a test case for the bug#27586: Wrong autoinc value assigned by LOAD DATA in the NO_AUTO_VALUE_ON_ZERO mode. sql/sql_load.cc: Bug#27586: Wrong autoinc value assigned by LOAD DATA in the NO_AUTO_VALUE_ON_ZERO mode. The table->auto_increment_field_not_null variable is reset now right after a row is being written in the read_fixed_length() and the read_sep_field() functions. Remove wrong setting of the table->auto_increment_field_not_null variable in the read_sep_field() function.	19 years ago
unknown	d6a78be9f2	Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0 into whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-ndb	19 years ago
unknown	e8a8d5df60	Merge acurtis@bk-internal:/home/bk/mysql-5.0-engines into xiphis.org:/home/antony/work2/mysql-5.0-engines.merge sql/item_func.cc: Auto merged sql/item_func.h: Auto merged sql/sql_table.cc: Auto merged	19 years ago
unknown	52b86a6e0a	Polishing: note added.	19 years ago
unknown	9bc5135f81	Polishing: add comments. sql/parse_file.cc: Add comments.	19 years ago
unknown	23e92aca5a	Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0-ndb into whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-ndb sql/item_func.cc: Auto merged	19 years ago
unknown	8f21b31d67	Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0-maint into whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-ndb	19 years ago
unknown	9170a3c184	Merge mskold@bk-internal.mysql.com:/home/bk/mysql-5.0-ndb into mysql.com:/windows/Linux_space/MySQL/mysql-5.0-ndb sql/ha_ndbcluster.cc: Auto merged	19 years ago
unknown	f6a9b254af	Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0-ndb into whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-ndb	19 years ago
unknown	a3d8d943b9	set name for ndb tools	19 years ago
unknown	e8a0ac29a7	Bug#27644 ndb: connecting api node/mysqld may "steal" node_id from running mysqld - test case workaround to avoid random failures	19 years ago
unknown	499d058c2d	Merge mysql.com:/windows/Linux_space/MySQL/mysql-5.0 into mysql.com:/windows/Linux_space/MySQL/mysql-5.0-ndb include/my_base.h: Auto merged sql/ha_ndbcluster.h: Auto merged sql/mysql_priv.h: Auto merged sql/sql_delete.cc: Auto merged sql/sql_insert.cc: Auto merged sql/sql_load.cc: Auto merged sql/sql_trigger.h: Auto merged sql/sql_update.cc: Auto merged sql/ha_ndbcluster.cc: Merge	19 years ago
unknown	865cd0108a	Merge mskold@bk-internal.mysql.com:/home/bk/mysql-5.0-ndb into mysql.com:/windows/Linux_space/MySQL/mysql-5.0-ndb sql/item_func.cc: Auto merged	19 years ago
unknown	cfe2d1da88	Removed compiler warnings	19 years ago
unknown	4c0f3c50f8	Fixed compilation error on Windows	19 years ago
unknown	bb8fb9e9e6	Merge dev3-240.dev.cn.tlan:/home/justin.he/mysql/mysql-5.0/mysql-5.0-ndb into dev3-240.dev.cn.tlan:/home/justin.he/mysql/mysql-5.0/mysql-5.0-ndb-bj.merge sql/ha_ndbcluster.cc: Auto merged sql/handler.cc: Auto merged sql/sql_table.cc: Auto merged	19 years ago
unknown	b651aa038c	Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0 into whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-ndb	19 years ago
unknown	2efc0f51cf	Bug #26242 UPDATE with subquery and triggers failing with cluster tables In certain cases AFTER UPDATE/DELETE triggers on NDB tables that referenced subject table didn't see the results of operation which caused invocation of those triggers. In other words AFTER trigger invoked as result of update (or deletion) of particular row saw version of this row before update (or deletion). The problem occured because NDB handler in those cases postponed actual update/delete operations to be able to perform them later as one batch. This fix solves the problem by disabling this optimization for particular operation if subject table has AFTER trigger for this operation defined. To achieve this we introduce two new flags for handler::extra() method: HA_EXTRA_DELETE_CANNOT_BATCH and HA_EXTRA_UPDATE_CANNOT_BATCH. These are called if there exists AFTER DELETE/UPDATE triggers during a statement that potentially can generate calls to delete_row()/update_row(). This includes multi_delete/multi_update statements as well as insert statements that do delete/update as part of an ON DUPLICATE statement. include/my_base.h: Added HA_EXTRA_DELETE_CANNOT_BATCH and HA_EXTRA_UPDATE_CANNOT_BATCH to inform handler when batching of delete/update is not possible. mysql-test/r/ndb_trigger.result: Bug #26242 UPDATE with subquery and triggers failing with cluster tables --- Added new test cases mysql-test/t/ndb_trigger.test: Bug #26242 UPDATE with subquery and triggers failing with cluster tables --- Added new test cases sql/ha_ndbcluster.cc: Bug #26242 UPDATE with subquery and triggers failing with cluster tables: Use HA_EXTRA_DELETE_CANNOT_BATCH and HA_EXTRA_UPDATE_CANNOT_BATCH to inform handler when batching of delete/update is not possible sql/ha_ndbcluster.h: Bug #26242 UPDATE with subquery and triggers failing with cluster tables: Added member variables for handling of HA_EXTRA_DELETE_CANNOT_BATCH and HA_EXTRA_UPDATE_CANNOT_BATCH to inform handler when batching of delete/update is not possible sql/mysql_priv.h: Added new method prepare_triggers_for_insert_stmt to check if batching of delete/update must be disallowed. sql/sql_delete.cc: Use HA_EXTRA_DELETE_CANNOT_BATCH to inform handler when batching of delete is not possible sql/sql_insert.cc: Added method prepare_triggers_for_insert_stmt to check if batching of delete/update must be dissallowed. Use HA_EXTRA_DELETE_CANNOT_BATCH and HA_EXTRA_UPDATE_CANNOT_BATCH to inform handler when batching of delete/update is not possible sql/sql_load.cc: Call prepare_triggers_for_insert_stmt to check if batching of delete/update must be dissallowed and mark fields used by triggers for the insert statement. sql/sql_trigger.h: Added has_triggers to support what particular triggers exist on a table. sql/sql_update.cc: Use HA_EXTRA_UPDATE_CANNOT_BATCH to inform handler when batching of update is not possible	19 years ago
unknown	89aa5548ce	Merge magare.gmz:/home/kgeorge/mysql/work/B27513-5.0-opt into magare.gmz:/home/kgeorge/mysql/autopush/B27513-5.0-opt	19 years ago
unknown	dbd125fd90	BUG 27513: fixed left-over sql mode from a test case.	19 years ago
unknown	1895cdb34d	Merge tsmith@bk-internal.mysql.com:/home/bk/mysql-5.0 into quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/maint/mrg04/50 sql/item_func.cc: Auto merged	19 years ago
unknown	7603ed9f27	Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt into magare.gmz:/home/kgeorge/mysql/autopush/B27513-5.0-opt	19 years ago
unknown	201a343a71	Merge olga.mysql.com:/home/igor/mysql-4.1-opt into olga.mysql.com:/home/igor/mysql-5.0-opt mysql-test/r/order_by.result: Manual merge mysql-test/t/order_by.test: Manual merge	19 years ago
unknown	e488e6f23a	Improved coverage for the code added to fix bug 27532.	19 years ago
unknown	da037917b2	Fix after manual merge	19 years ago
unknown	5fb8970129	Merge olga.mysql.com:/home/igor/mysql-4.1-opt into olga.mysql.com:/home/igor/mysql-5.0-opt sql/item_cmpfunc.cc: Auto merged mysql-test/r/order_by.result: Manual merge mysql-test/t/order_by.test: Manual merge sql/item_cmpfunc.h: Manual merge	19 years ago
unknown	0ee34b1ca2	Fixed bug #27532 : wrong results with ORDER/GROUP BY queries containing IN/BETWEEN predicates in sorting expressions. Wrong results may occur when the select list contains an expression with IN/BETWEEN predicate that differs from a sorting expression by an additional NOT only. Added the method Item_func_opt_neg::eq to compare correctly expressions containing [NOT] IN/BETWEEN. The eq method inherited from the Item_func returns TRUE when comparing 'a IN (1,2)' with 'a NOT IN (1,2)' that is not, of course, correct. mysql-test/r/order_by.result: Added a test case for bug #27532. mysql-test/t/order_by.test: Added a test case for bug #27532. sql/item_cmpfunc.cc: Fixed bug #27532. Added the method Item_func_opt_neg::eq to compare correctly expressions containing [NOT] IN/BETWEEN. The eq method inherited from the Item_func returns TRUE when comparing 'a IN (1,2)' with 'a NOT IN (1,2)' that is not, of course, correct. sql/item_cmpfunc.h: Added the method Item_func_opt_neg::eq to compare correctly expressions containing [NOT] IN/BETWEEN. The eq method inherited from the Item_func returns TRUE when comparing 'a IN (1,2)' with 'a NOT IN (1,2)' that is not, of course, correct.	19 years ago
unknown	7bf304a6bd	Bug #27513 : test case added to make sure this crash bug doesn't reappear. mysql-test/r/errors.result: Bug #27513: test case mysql-test/t/errors.test: Bug #27513: test case	19 years ago
unknown	fda365101f	Merge mskold@bk-internal.mysql.com:/home/bk/mysql-5.0-ndb into mysql.com:/windows/Linux_space/MySQL/mysql-5.0-ndb sql/ha_ndbcluster.cc: Auto merged sql/item_func.cc: Auto merged	19 years ago
unknown	5203ea6ccb	BUG#18676 when cluster storage engine is down, misleading error message on create table with 4009. mysql-test/r/ndb_autodiscover.result: changes ndbd error code to mysqld error code when no cluster connection sql/ha_ndbcluster.cc: map 4009 error code to mysql not connected error sql/handler.cc: define return codes to ha_table_exists_in_engine to something useful NOTE: in 5.1 this should call a handlerton method, not horrible ifdef ndb stuff sql/sql_table.cc: clearly define what happens on create table if exits/not exists/not connected to engine	19 years ago
unknown	e95357d72f	Merge svojtovich@bk-internal.mysql.com:/home/bk/mysql-5.0-engines into mysql.com:/home/svoj/devel/mysql/BUG25729/mysql-5.0-engines sql/item_func.cc: Auto merged	19 years ago
unknown	91ab5b4f25	Merge bk-internal.mysql.com:/home/bk/mysql-5.0-maint into recycle.(none):/src/bug23491_ii/my50-bug23491_ii	19 years ago
unknown	c457e2b88b	Merge tulin@bk-internal.mysql.com:/home/bk/mysql-5.0 into whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-ndb	19 years ago
unknown	f7417a299e	Minor test cleanup. mysql-test/t/mysqldump.test: Fix for failing Windows test.	19 years ago
unknown	29fe12509c	Merge bk-internal.mysql.com:/home/bk/mysql-5.0 into bodhi.local:/opt/local/work/mysql-5.0-runtime sql/item_func.cc: Auto merged	19 years ago

1 2 3 4 5 ...

35845 Commits (7bb6a7259377239c3befdc27d39cfacc2b132c30) All Branches Search

35845 Commits (7bb6a7259377239c3befdc27d39cfacc2b132c30)

All Branches