mariadb

Tree: 7299858763

Sunny Bains 7299858763 Fix bug#54583. This change reverses rsvn:1350 by getting rid of a bogus assertion and clarifies the invariant in dict_table_get_on_id(). In Mar 2007 Marko observed a crash during recovery, the crash resulted from an UNDO operation on a system table. His solution was to acquire an X lock on the data dictionary, this in hindsight was an overkill. It is unclear what caused the crash, current hypothesis is that it was a memory corruption. The X lock results in performance issues by when undoing changes due to rollback during normal operation on regular tables. Why the change is safe: ====================== The InnoDB code has changed since the original X lock change was made. In the new code we always lock the data dictionary in X mode during startup when UNDOing operations on the system tables (this is a given). This ensures that the crash Marko observed cannot happen as long as all transactions that update the system tables follow the standard rules by setting the appropriate DICT_OP flag when writing the log records when they make the changes. If transactions violate the above mentioned rule then during recovery (at startup) the rollback code (see trx0roll.c) will not acquire the X lock and we will see the crash again. This will however be a different bug.		16 years ago
..
row0ext.c	Adding innodb_plugin-1.0.4 as storage/innodb_plugin.	17 years ago
row0ins.c	Formatting changes	16 years ago
row0merge.c	Fix Bug#47991 InnoDB Dictionary Cache memory usage increases indefinitely	16 years ago
row0mysql.c	Bug#53674: InnoDB: Error: unlock row could not find a 4 mode lock on the record	16 years ago
row0purge.c	Formatting changes	16 years ago
row0row.c	Applying InnoDB snapshot	16 years ago
row0sel.c	Bug#38999 valgrind warnings for update statement in function compare_record()	16 years ago
row0uins.c	Formatting changes	16 years ago
row0umod.c	Formatting changes	16 years ago
row0undo.c	Fix bug#54583. This change reverses rsvn:1350 by getting rid of a bogus assertion	16 years ago
row0upd.c	Formatting changes	16 years ago
row0vers.c	Adding innodb_plugin-1.0.4 as storage/innodb_plugin.	17 years ago