mariadb

Commit Graph

Author	SHA1	Message	Date
Sunny Bains	7299858763	Fix bug#54583. This change reverses rsvn:1350 by getting rid of a bogus assertion and clarifies the invariant in dict_table_get_on_id(). In Mar 2007 Marko observed a crash during recovery, the crash resulted from an UNDO operation on a system table. His solution was to acquire an X lock on the data dictionary, this in hindsight was an overkill. It is unclear what caused the crash, current hypothesis is that it was a memory corruption. The X lock results in performance issues by when undoing changes due to rollback during normal operation on regular tables. Why the change is safe: ====================== The InnoDB code has changed since the original X lock change was made. In the new code we always lock the data dictionary in X mode during startup when UNDOing operations on the system tables (this is a given). This ensures that the crash Marko observed cannot happen as long as all transactions that update the system tables follow the standard rules by setting the appropriate DICT_OP flag when writing the log records when they make the changes. If transactions violate the above mentioned rule then during recovery (at startup) the rollback code (see trx0roll.c) will not acquire the X lock and we will see the crash again. This will however be a different bug.	16 years ago
Vasil Dimov	ba04d53826	Fix Bug#47991 InnoDB Dictionary Cache memory usage increases indefinitely when renaming tables Allocate the table name using ut_malloc() instead of table->heap because the latter cannot be freed. Adjust dict_sys->size calculations all over the code. Change dict_table_t::name from const char* to char* because we need to ut_malloc()/ut_free() it. Reviewed by: Inaam, Marko, Heikki (rb://384) Approved by: Heikki (rb://384)	16 years ago
Jimmy Yang	69bc6dd01c	Fix an overly asserted assertion during previous checkin for bug #54330 .	16 years ago
Jimmy Yang	3c0be2c7b3	Fix Bug #54330 Broken fast index creation. Add additional array to account for each merge run's start offset, so correct offsets are paired up for multiple merge runs. rb://377 approved by Marko	16 years ago
Inaam Rana	e40c3b9763	Formatting changes	16 years ago
Sergey Glukhov	022e2ef800	Bug#38999 valgrind warnings for update statement in function compare_record() (InnoDB plugin branch) mysql-test/suite/innodb_plugin/r/innodb_mysql.result: test case mysql-test/suite/innodb_plugin/t/innodb_mysql.test: test case storage/innodb_plugin/row/row0sel.c: init null bytes with default values as they might be left uninitialized in some cases and these uninited bytes might be copied into mysql record buffer that leads to valgrind warnings on next use of the buffer.	16 years ago
Inaam Rana	28187edf33	Add call to log_free_check() in the DML code paths that were missing this before.	16 years ago
Marko Mäkelä	c84c4b107c	Bug#53674: InnoDB: Error: unlock row could not find a 4 mode lock on the record In semi-consistent read, only unlock freshly locked non-matching records. lock_rec_lock_fast(): Return LOCK_REC_SUCCESS, LOCK_REC_SUCCESS_CREATED, or LOCK_REC_FAIL instead of TRUE/FALSE. enum db_err: Add DB_SUCCESS_LOCKED_REC for indicating a successful operation where a record lock was created. lock_sec_rec_read_check_and_lock(), lock_clust_rec_read_check_and_lock(), lock_rec_enqueue_waiting(), lock_rec_lock_slow(), lock_rec_lock(), row_ins_set_shared_rec_lock(), row_ins_set_exclusive_rec_lock(), sel_set_rec_lock(), row_sel_get_clust_rec_for_mysql(): Return DB_SUCCESS_LOCKED_REC if a new record lock was created. Adjust callers. row_unlock_for_mysql(): Correct the function documentation. row_prebuilt_t::new_rec_locks: Correct the documentation.	16 years ago
Marko Mäkelä	90cb7fa432	Minor cleanup. lock_rec_unlock(): Cache first_lock and rewrite while() loops as for(). btr_cur_optimistic_update(): Use common error handling return. row_create_prebuilt(): Add Valgrind instrumentation.	16 years ago
Marko Mäkelä	2caade5053	Bug#53812: assert row/row0umod.c line 660 in txn rollback after crash recovery row_undo_mod_upd_exist_sec(): Tolerate a failure to build the index entry for a DYNAMIC or COMPRESSED table during crash recovery.	16 years ago
Jimmy Yang	602bb5c0fe	Fix Bug #53592 in plugin code, "crash replacing duplicates into table after fast alter table added unique key". Look up MySQL index number should go through index translation table. rb://347, approved by Marko	16 years ago
Marko Mäkelä	268e38753b	row_search_for_mysql(): Add assertions to track down Bug #53627 .	16 years ago
Vasil Dimov	10f9434f12	Fix comments on row_merge_write() This is a port of vasil.dimov@oracle.com-20100521175337-c1b1lqxgizqegb0w and vasil.dimov@oracle.com-20100521180951-mef23h24k023xuwq from mysql-trunk-innodb	16 years ago
Marko Mäkelä	d4fd7bb95e	Bug#53578: assert on invalid page access, in fil_io() Store the max_space_id in the data dictionary header in order to avoid space_id reuse. DICT_HDR_MIX_ID: Renamed to DICT_HDR_MAX_SPACE_ID, DICT_HDR_MIX_ID_LOW. dict_hdr_get_new_id(): Return table_id, index_id, space_id or a subset of them. fil_system_t: Add ibool space_id_reuse_warned. fil_create_new_single_table_tablespace(): Get the space_id from the caller. fil_space_create(): Issue a warning if the fil_system->max_assigned_id is exceeded. fil_assign_new_space_id(): Return TRUE/FALSE and take a pointer to the space_id as a parameter. Make the function public. fil_init(): Initialize all fil_system fields by mem_zalloc(). Remove explicit initializations of certain fields to 0 or NULL.	16 years ago
Vasil Dimov	56586334f1	Merge from mysql-trunk-innodb into mysql-5.1-innodb/storage/innodb_plugin: ------------------------------------------------------------ revno: 3094 revision-id: vasil.dimov@oracle.com-20100513074652-0cvlhgkesgbb2bfh parent: vasil.dimov@oracle.com-20100512173700-byf8xntxjur1hqov committer: Vasil Dimov <vasil.dimov@oracle.com> branch nick: mysql-trunk-innodb timestamp: Thu 2010-05-13 10:46:52 +0300 message: Followup to Bug#51920, fix binlog.binlog_killed This is a followup to the fix of Bug#51920 Innodb connections in row lock wait ignore KILL until lock wait timeout in that fix (rb://279) the behavior was changed to honor when a trx is interrupted during lock wait, but the returned error code was still "lock wait timeout" when it should be "interrupted". This change fixes the non-deterministically failing test binlog.binlog_killed, that failed like this: binlog.binlog_killed 'stmt' [ fail ] Test ended at 2010-05-12 11:39:08 CURRENT_TEST: binlog.binlog_killed mysqltest: At line 208: query 'reap' failed with wrong errno 1205: 'Lock wait timeout exceeded; try restarting transaction', instead of 0... Approved by: Sunny Bains (rb://344) ------------------------------------------------------------	16 years ago
Marko Mäkelä	54f59fb55e	Make the InnoDB FOREIGN KEY parser understand multi-statements. (Bug #48024 ) Also make InnoDB thinks that // only starts a comment. (Bug #53644). This fixes the bugs in the InnoDB Plugin. ha_innodb.h: Use trx_query_string() instead of trx_query() when available (MySQL 5.1.42 or later). innobase_get_stmt(): New function, to retrieve the currently running SQL statement. struct trx_struct: Remove mysql_query_str. Use innobase_get_stmt() instead. dict_strip_comments(): Add and observe the parameter sql_length. Treat // as the start of a comment. dict_create_foreign_constraints(), row_table_add_foreign_constraints(): Add the parameter sql_length.	16 years ago
Marko Mäkelä	2c889b9dbc	row_merge_drop_temp_indexes(): Do not reference freed memory. (Bug #53471)	16 years ago
Marko Mäkelä	326d75bd41	Merge a contribution from Ryan Mack at Facebook: Bugfix for 53290, fast unique index creation fails on duplicate null values Summary: Bug in the fast index creation code incorrectly considers null values to be duplicates during block merging. Innodb policy is that multiple null values are allowed in a unique index. Null duplicates were correctly ignored while sorting individual blocks and with slow index creation. Test Plan: mtr, including new test, load dbs using deferred index creation DiffCamp Revision: 110840 Reviewed By: mcallaghan CC: mcallaghan, mysql-devel@lists Revert Plan: OK	16 years ago
Marko Mäkelä	3f8a812d7a	row_merge_drop_temp_indexes(): Load the table via the dictionary cache. Allow multiple indexes to be dropped. (Bug #53256)	16 years ago
Marko Mäkelä	d4b1117768	Add Valgrind diagnostics to track down Bug #38999 .	16 years ago
Marko Makela	74ae1326c9	Reduce the next-key locking of READ UNCOMMITTED to match that of READ COMMITTED in the InnoDB Plugin. (Bug #48607)	16 years ago
Marko Mäkelä	a5b4285132	row_merge_drop_temp_indexes(): Remove a bogus char-to-ulint cast.	16 years ago
Marko Mäkelä	063928ba05	row_search_for_mysql(): Never try semi-consistent read in unique searches. They are only useful in table scans. (Bug #52663)	16 years ago
Sergey Vojtovich	0aa607e414	Applying InnoDB snapshot Detailed revision comments: r6891 \| vdimov \| 2010-03-26 16:19:01 +0200 (Fri, 26 Mar 2010) \| 5 lines Non-functional change: update copyright year to 2010 of the files that have been modified after 2010-01-01 according to svn. for f in $(svn log -v -r{2010-01-01}:HEAD \|grep "^ M " \|cut -b 16- \|sort -u) ; do sed -i "" -E 's/(Copyright $c$ [0-9]{4},) [0-9]{4}, (.*Innobase Oy.+All Rights Reserved)/\1 2010, \2/' $f ; done	16 years ago
Sergey Vojtovich	3b3686b543	Applying InnoDB snapshot Detailed revision comments: r6773 \| marko \| 2010-03-03 15:31:54 +0200 (Wed, 03 Mar 2010) \| 2 lines branches/zip: row_raw_format(): Silence a GCC 4.4.2 warning of possibly uninitialized variable format_in_hex.	16 years ago
Sergey Vojtovich	17f8a9f2ac	Applying InnoDB snapshot Detailed revision comments: r6754 \| marko \| 2010-02-24 10:56:43 +0200 (Wed, 24 Feb 2010) \| 17 lines branches/zip: Allocate the merge sort buffers from a heap, not stack. The merge sort can use up to 48KiB of buffers when merging blocks. That can cause a stack overflow, especially on 64-bit systems when not building with inlined functions. This was reported as Issue #462. row_merge_dup_report(): Allocate buf and offsets from a heap. row_merge_heap_create(): Allocate space for buf[3] too. Fix bogus sizeof arithmetics that happened to work, because sizeof(ulint)==sizeof(void*). row_merge_blocks(), row_merge_blocks_copy(): Allocate buf[3] from heap. row_merge_insert_index_tuples(): Allocate buf from graph_heap. rb://258 approved and tested by Sunny Bains	16 years ago
Sergey Vojtovich	236d0369c0	Applying InnoDB snapshot Detailed revision comments: r6750 \| marko \| 2010-02-22 08:57:23 +0200 (Mon, 22 Feb 2010) \| 2 lines branches/zip: row_fetch_store_uint4(): Remove unused function. This was added to trunk in r435.	16 years ago
Sergey Vojtovich	44a0ff6c76	Applying InnoDB snapshot Detailed revision comments: r6749 \| vasil \| 2010-02-20 18:45:41 +0200 (Sat, 20 Feb 2010) \| 5 lines Non-functional change: update copyright year to 2010 of the files that have been modified after 2010-01-01 according to svn. for f in $(svn log -v -r{2010-01-01}:HEAD \|grep "^ M " \|cut -b 16- \|sort -u) ; do sed -i "" -E 's/(Copyright $c$ [0-9]{4},) [0-9]{4}, (.*Innobase Oy.+All Rights Reserved)/\1 2010, \2/' $f ; done	16 years ago
Sergey Vojtovich	84eb19081f	Applying InnoDB snapshot Detailed revision comments: r6675 \| marko \| 2010-02-11 22:41:11 +0200 (Thu, 11 Feb 2010) \| 1 line branches/zip: Remove bogus debug assertions introduced in r6660.	16 years ago
Sergey Vojtovich	08ed716d85	Applying InnoDB snapshot Detailed revision comments: r6673 \| marko \| 2010-02-11 13:09:48 +0200 (Thu, 11 Feb 2010) \| 9 lines branches/zip: Relax a debug assertion about a missing BLOB. (Issue #452) When rolling back an incomplete transaction in purge, tolerate missing BLOBs also in update undo, when undoing an INSERT by updating a delete-marked record, and the delete-marked record is no longer needed. Previously, we only tolerated missing BLOBs in insert undo. This merely fixes a debug assertion; the code performed correctly without UNIV_DEBUG. rb://249 approved by Sunny Bains.	16 years ago
Sergey Vojtovich	d4c7bd2f40	Applying InnoDB snapshot Detailed revision comments: r6672 \| marko \| 2010-02-11 13:01:18 +0200 (Thu, 11 Feb 2010) \| 1 line branches/zip: Introduce thr_is_recv().	16 years ago
Sergey Vojtovich	4ccf8bff5d	Applying InnoDB snapshot Detailed revision comments: r6660 \| marko \| 2010-02-11 11:21:11 +0200 (Thu, 11 Feb 2010) \| 7 lines branches/zip: Clarify the rollback of INSERT by UPDATE of delete-marked rec. row_undo_mod_remove_clust_low(): Augment the function comment. row_undo_mod_remove_clust_low(), row_undo_mod_del_mark_or_remove_sec_low(), row_undo_mod_del_mark_or_remove_sec(), row_undo_mod_upd_del_sec(): Add ut_ad(node->rec_type == TRX_UNDO_UPD_DEL_REC);	16 years ago
Sergey Vojtovich	6f31e79af1	Applying InnoDB snapshot Detailed revision comments: r6635 \| marko \| 2010-02-10 11:07:05 +0200 (Wed, 10 Feb 2010) \| 4 lines branches/zip: Clean up after r6559. Now that btr_pcur_open_with_no_init() is a macro, do not mix preprocessor directives in the macro invocation, because it is implementation-defined whether that is going to work.	16 years ago
Sergey Vojtovich	54ed7dc2bb	Applying InnoDB snapshot Detailed revision comments: r6610 \| marko \| 2010-02-09 13:53:59 +0200 (Tue, 09 Feb 2010) \| 17 lines branches/zip: When dropping temporary indexes and tables at startup, first load them to the data dictionary cache and use the normal routines for dropping tables or indexes. This should reduce the risk of bugs and also make the code compatible with the upcoming TablespaceDictionary implementation. DICT_SYS_INDEXES_NAME_FIELD: The clustered index position of SYS_INDEXES.NAME. row_merge_drop_temp_indexes(): Scan SYS_INDEXES for tables containing temporary indexes, and load the tables as needed. Invoke row_merge_drop_index() to drop the indexes. row_mysql_drop_temp_tables(): Scan SYS_TABLES for temporary tables, load them with dict_load_table() and drop them with row_drop_table_for_mysql(). rb://251, not yet reviewed	16 years ago
Sergey Vojtovich	1a9d1bf94a	Applying InnoDB snapshot Detailed revision comments: r6591 \| marko \| 2010-02-08 10:06:39 +0200 (Mon, 08 Feb 2010) \| 3 lines branches/zip: row_merge_drop_index(): Remove redundant condition on SYS_INDEXES.TABLE_ID. INDEX_ID must be instance-widely unique, because SYS_FIELDS is not indexed by TABLE_ID.	16 years ago
Sergey Vojtovich	30ddb931ef	Applying InnoDB snapshot Detailed revision comments: r6559 \| marko \| 2010-02-04 13:21:18 +0200 (Thu, 04 Feb 2010) \| 14 lines branches/zip: Pass the file name and line number of the caller of the b-tree cursor functions to the buffer pool requests, in order to make the latch diagnostics more accurate. buf_page_optimistic_get_func(): Renamed to buf_page_optimistic_get(). btr_page_get_father_node_ptr(), btr_insert_on_non_leaf_level(), btr_pcur_open(), btr_pcur_open_with_no_init(), btr_pcur_open_on_user_rec(), btr_pcur_open_at_rnd_pos(), btr_pcur_restore_position(), btr_cur_open_at_index_side(), btr_cur_open_at_rnd_pos(): Rename the function to _func and add the parameters file, line. Define wrapper macros with __FILE__, __LINE__. btr_cur_search_to_nth_level(): Add the parameters file, line.	16 years ago
Sergey Vojtovich	82f3117eea	Applying InnoDB snapshot Detailed revision comments: r6547 \| marko \| 2010-02-03 14:43:38 +0200 (Wed, 03 Feb 2010) \| 14 lines branches/zip: Clean up CHECK TABLE error handling. (Issue #220) ha_innobase::change_active_index(): Clean up code formatting. ha_innobase::check(): Incorporate the code from row_check_table_for_mysql(). Report errors to the client connection instead of writing them to the error log. row_check_table_for_mysql(): Remove. row_check_index_for_mysql(): Renamed from row_scan_and_check_index(). Let the caller initialize prebuilt, and assume that the index is usable. rb://178 approved by Sunny Bains	16 years ago
Sergey Vojtovich	eb6f014f99	Applying InnoDB snapshot Detailed revision comments: r6527 \| vasil \| 2010-01-29 14:39:48 +0200 (Fri, 29 Jan 2010) \| 6 lines branches/zip: Extend the comment about row_mysql_handle_errors(). Suggested by: Heikki	16 years ago
Sergey Vojtovich	0ce70c050b	Applying InnoDB snapshot, fixes BUG#41609. Detailed revision comments: r6521 \| marko \| 2010-01-27 10:49:01 +0200 (Wed, 27 Jan 2010) \| 17 lines branches/zip: Drop temporary tables at startup. This addresses the third aspect of Bug #41609. row_mysql_drop_temp_tables(): New function, to drop all temporary tables. These can be distinguished by the least significant bit of MIX_LEN. However, we will skip ROW_FORMAT=REDUNDANT tables, because in the records for those tables, that bit may be garbage. recv_recovery_from_checkpoint_finish(): Invoke row_mysql_drop_temp_tables(). Normally, if the .frm files for the temporary tables exist at startup, MySQL will ask InnoDB to drop the temporary tables. However, if the files are deleted, for instance, by the boot scripts of the operating system, the tables would remain in the InnoDB data dictionary unless someone digs them up by innodb_table_monitor and creates .frm files for dropping the tables. rb://221 approved by Sunny Bains.	16 years ago
Sergey Vojtovich	fb454deccd	Applying InnoDB snapshot Detailed revision comments: r6447 \| marko \| 2010-01-13 17:43:44 +0200 (Wed, 13 Jan 2010) \| 5 lines branches/zip: row_sel_get_clust_rec_for_mysql(): On the READ UNCOMMITTED isolation level, do not attempt to access a clustered index record that has been marked for deletion. This fixes Issue #433. Approved by Heikki over the IM.	16 years ago
Sergey Vojtovich	944fd108b4	Applying InnoDB snapshot Detailed revision comments: r6426 \| marko \| 2010-01-12 15:36:14 +0200 (Tue, 12 Jan 2010) \| 2 lines branches/zip: row_sel_sec_rec_is_for_clust_rec(): Document the return value more accurately.	16 years ago
Sergey Vojtovich	a8c583f810	Applying InnoDB snapshot Detailed revision comments: r6425 \| marko \| 2010-01-12 13:47:11 +0200 (Tue, 12 Jan 2010) \| 45 lines branches/zip: Merge revisions 6350:6424 from branches/5.1: ------------------------------------------------------------------------ r6421 \| jyang \| 2010-01-12 07:59:16 +0200 (Tue, 12 Jan 2010) \| 8 lines Changed paths: M /branches/5.1/row/row0mysql.c branches/5.1: Fix bug #49238: Creating/Dropping a temporary table while at 1023 transactions will cause assert. Handle possible DB_TOO_MANY_CONCURRENT_TRXS when deleting metadata in row_drop_table_for_mysql(). rb://220, approved by Marko ------------------------------------------------------------------------ r6422 \| marko \| 2010-01-12 11:34:27 +0200 (Tue, 12 Jan 2010) \| 3 lines Changed paths: M /branches/5.1/handler/ha_innodb.cc M /branches/5.1/handler/ha_innodb.h branches/5.1: Non-functional change: Make innobase_get_int_col_max_value() a static function. It does not access any fields of class ha_innobase. ------------------------------------------------------------------------ r6424 \| marko \| 2010-01-12 12:22:19 +0200 (Tue, 12 Jan 2010) \| 16 lines Changed paths: M /branches/5.1/handler/ha_innodb.cc M /branches/5.1/handler/ha_innodb.h branches/5.1: In innobase_initialize_autoinc(), do not attempt to read the maximum auto-increment value from the table if innodb_force_recovery is set to at least 4, so that writes are disabled. (Bug #46193) innobase_get_int_col_max_value(): Move the function definition before ha_innobase::innobase_initialize_autoinc(), because that function now calls this function. ha_innobase::innobase_initialize_autoinc(): Change the return type to void. Do not attempt to read the maximum auto-increment value from the table if innodb_force_recovery is set to at least 4. Issue ER_AUTOINC_READ_FAILED to the client when the auto-increment value cannot be read. rb://144 by Sunny, revised by Marko ------------------------------------------------------------------------	16 years ago
Sergey Vojtovich	cbeff93f09	Applying InnoDB snapshot Detailed revision comments: r6348 \| marko \| 2009-12-22 11:04:34 +0200 (Tue, 22 Dec 2009) \| 37 lines branches/zip: Merge a change from MySQL: r6351 \| marko \| 2009-12-22 11:11:18 +0200 (Tue, 22 Dec 2009) \| 1 line branches/zip: Remove an obsolete declaration of LOCK_thread_count. r6352 \| marko \| 2009-12-22 12:33:01 +0200 (Tue, 22 Dec 2009) \| 104 lines branches/zip: Merge revisions 6206:6350 from branches/5.1, except r6347, r6349, r6350 which were committed separately to both branches, and r6310, which was backported from zip to 5.1. ------------------------------------------------------------------------ r6206 \| jyang \| 2009-11-20 09:38:43 +0200 (Fri, 20 Nov 2009) \| 3 lines Changed paths: M /branches/5.1/handler/ha_innodb.cc branches/5.1: Non-functional change, fix formatting. ------------------------------------------------------------------------ r6230 \| sunny \| 2009-11-24 23:52:43 +0200 (Tue, 24 Nov 2009) \| 3 lines Changed paths: M /branches/5.1/mysql-test/innodb-autoinc.result branches/5.1: Fix autoinc failing test results. (this should be skipped when merging 5.1 into zip) ------------------------------------------------------------------------ r6231 \| sunny \| 2009-11-25 10:26:27 +0200 (Wed, 25 Nov 2009) \| 7 lines Changed paths: M /branches/5.1/mysql-test/innodb-autoinc.result M /branches/5.1/mysql-test/innodb-autoinc.test M /branches/5.1/row/row0sel.c branches/5.1: Fix BUG#49032 - auto_increment field does not initialize to last value in InnoDB Storage Engine. We use the appropriate function to read the column value for non-integer autoinc column types, namely float and double. rb://208. Approved by Marko. ------------------------------------------------------------------------ r6232 \| sunny \| 2009-11-25 10:27:39 +0200 (Wed, 25 Nov 2009) \| 2 lines Changed paths: M /branches/5.1/row/row0sel.c branches/5.1: This is an interim fix, fix white space errors. ------------------------------------------------------------------------ r6233 \| sunny \| 2009-11-25 10:28:35 +0200 (Wed, 25 Nov 2009) \| 2 lines Changed paths: M /branches/5.1/include/mach0data.h M /branches/5.1/include/mach0data.ic M /branches/5.1/mysql-test/innodb-autoinc.result M /branches/5.1/mysql-test/innodb-autoinc.test M /branches/5.1/row/row0sel.c branches/5.1: This is an interim fix, fix tests and make read float/double arg const. ------------------------------------------------------------------------ r6234 \| sunny \| 2009-11-25 10:29:03 +0200 (Wed, 25 Nov 2009) \| 2 lines Changed paths: M /branches/5.1/row/row0sel.c branches/5.1: This is an interim fix, fix whitepsace issues. ------------------------------------------------------------------------ r6235 \| sunny \| 2009-11-26 01:14:42 +0200 (Thu, 26 Nov 2009) \| 9 lines Changed paths: M /branches/5.1/handler/ha_innodb.cc M /branches/5.1/mysql-test/innodb-autoinc.result M /branches/5.1/mysql-test/innodb-autoinc.test branches/5.1: Fix Bug#47720 - REPLACE INTO Autoincrement column with negative values. This bug is similiar to the negative autoinc filter patch from earlier, with the additional handling of filtering out the negative column values set explicitly by the user. rb://184 Approved by Heikki. ------------------------------------------------------------------------ r6242 \| vasil \| 2009-11-27 22:07:12 +0200 (Fri, 27 Nov 2009) \| 4 lines Changed paths: M /branches/5.1/export.sh branches/5.1: Minor changes to support plugin snapshots. ------------------------------------------------------------------------ r6306 \| calvin \| 2009-12-14 15:12:46 +0200 (Mon, 14 Dec 2009) \| 5 lines Changed paths: M /branches/5.1/mysql-test/innodb-autoinc.result M /branches/5.1/mysql-test/innodb-autoinc.test branches/5.1: fix bug#49267: innodb-autoinc.test fails on windows because of different case mode There is no change to the InnoDB code, only to fix test case by changing "T1" to "t1". ------------------------------------------------------------------------ r6324 \| jyang \| 2009-12-17 06:54:24 +0200 (Thu, 17 Dec 2009) \| 8 lines Changed paths: M /branches/5.1/handler/ha_innodb.cc M /branches/5.1/include/lock0lock.h M /branches/5.1/include/srv0srv.h M /branches/5.1/lock/lock0lock.c M /branches/5.1/log/log0log.c M /branches/5.1/srv/srv0srv.c M /branches/5.1/srv/srv0start.c branches/5.1: Fix bug #47814 - Diagnostics are frequently not printed after a long lock wait in InnoDB. Separate out the lock wait timeout check thread from monitor information printing thread. rb://200 Approved by Marko. ------------------------------------------------------------------------ r6364 \| marko \| 2009-12-26 21:06:31 +0200 (Sat, 26 Dec 2009) \| 4 lines branches/zip: ibuf_bitmap_get_map_page(): Define a wrapper macro that passes __FILE__, __LINE__ of the caller to buf_page_get_gen(). This will ease the diagnosis of the likes of Issue #135.	16 years ago
Sergey Vojtovich	af071005f9	Applying InnoDB snapshot Detailed revision comments: r6321 \| marko \| 2009-12-16 16:16:33 +0200 (Wed, 16 Dec 2009) \| 4 lines branches/zip: row_merge_drop_temp_indexes(): Revert a hack to transaction isolation level that was made unnecessary by r5826 (Issue #337). When this function is called, any active data dictionary transaction should have been rolled back.	16 years ago
Sergey Vojtovich	a404d9939b	Applying InnoDB snapshot Detailed revision comments: r6305 \| marko \| 2009-12-14 13:03:57 +0200 (Mon, 14 Dec 2009) \| 2 lines branches/zip: row_undo_mod_del_unmark_sec_and_undo_update(): Add a missing const qualifier.	16 years ago
Sergey Vojtovich	f6466bb8c6	Applying InnoDB snapshot Detailed revision comments: r6285 \| marko \| 2009-12-09 09:24:50 +0200 (Wed, 09 Dec 2009) \| 13 lines branches/zip: row_sel_fetch_columns(): Remove redundant code that was accidentally added in r1591, which introduced dfield_t::ext in order to make the merge sort of fast index creation support externally stored columns, Initially, I tried to allocate the bit for dfield_t::ext from dfield_t::len by making the length 31 bits and mapping UNIV_SQL_NULL to something that would fit in it. Then I decided that it would be too risky. The redundant check was part of the mapping. The condition may have been dfield_is_null() initially. This redundant code was noticed by Sergey Petrunya on the MySQL internals list. r6288 \| marko \| 2009-12-09 09:51:00 +0200 (Wed, 09 Dec 2009) \| 15 lines branches/zip: row_upd_copy_columns(): Remove redundant code that was accidentally added in r1591, which introduced dfield_t::ext in order to make the merge sort of fast index creation support externally stored columns. Initially, I tried to allocate the bit for dfield_t::ext from dfield_t::len by making the length 31 bits and mapping UNIV_SQL_NULL to something that would fit in it. Then I decided that it would be too risky. The redundant check was part of the mapping. The condition may have been dfield_is_null() initially. This is similar to the redundant code in row_sel_fetch_columns() that was noticed by Sergey Petrunya on the MySQL internals list and removed in r6285. As far as I can tell, there are no redundant UNIV_SQL_NULL assignments remaining after this change.	16 years ago
Sergey Vojtovich	31143f1cf8	Applying InnoDB snapshot, fixes BUG#41609. Detailed revision comments: r6252 \| marko \| 2009-11-30 12:50:11 +0200 (Mon, 30 Nov 2009) \| 23 lines branches/zip: Suppress errors about non-found temporary tables. Write the is_temp flag to SYS_TABLES.MIX_LEN. dict_table_t:🎏 Add a flag for is_temporary, DICT_TF2_TEMPORARY. Unlike other flags, this will not be written to the tablespace flags or SYS_TABLES.TYPE, but only to SYS_TABLES.MIX_LEN. dict_build_table_def_step(): Only pass DICT_TF_BITS to tablespaces. dict_check_tablespaces_and_store_max_id(), dict_load_table(): Suppress errors about temporary tables not being found. dict_create_sys_tables_tuple(): Write the DICT_TF2_TEMPORARY flag to SYS_TABLES.MIX_LEN. fil_space_create(), fil_create_new_single_table_tablespace(): Add assertions about space->flags. row_drop_table_for_mysql(): Do not complain about non-found temporary tables. rb://160 approved by Heikki Tuuri. This addresses the second part of Bug #41609 Crash recovery does not work for InnoDB temporary tables.	16 years ago
Satya B	1e26b2c26b	Applying InnoDB Plugin 1.0.6 snapshot, part 8. Fixes BUG#48782 applied revisions: r6185, r6186, r6189, r6194 r6185 - only code changes incorporated, changesets which change innodb tests in the main mysql suite are discarded r61889 - Fixes BUG#48782 Detailed revision comments: r6185 \| marko \| 2009-11-17 16:44:20 +0200 (Tue, 17 Nov 2009) \| 16 lines branches/zip: Report duplicate table names to the client connection, not to the error log. This change will allow innodb-index.test to be re-enabled. It was previously disabled, because mysql-test-run does not like output in the error log. row_create_table_for_mysql(): Do not output anything to the error log when reporting DB_DUPLICATE_KEY. Let the caller report the error. Add a TODO comment that the dict_table_t object is apparently not freed when an error occurs. create_table_def(): Convert InnoDB table names to the character set of the client connection for reporting. Use my_error(ER_WRONG_COLUMN_NAME) for reporting reserved column names. Report my_error(ER_TABLE_EXISTS_ERROR) when row_create_table_for_mysql() returns DB_DUPLICATE_KEY. rb://206 r6186 \| vasil \| 2009-11-17 16:48:14 +0200 (Tue, 17 Nov 2009) \| 4 lines branches/zip: Add ChangeLog entry for r6185. r6189 \| marko \| 2009-11-18 11:36:18 +0200 (Wed, 18 Nov 2009) \| 5 lines branches/zip: ha_innobase::add_index(): When creating the primary key and the table is being locked by another transaction, do not attempt to drop the table. (Bug #48782) Approved by Sunny Bains over IM r6194 \| vasil \| 2009-11-19 09:24:45 +0200 (Thu, 19 Nov 2009) \| 5 lines branches/zip: Increment version number from 1.0.5 to 1.0.6 since 1.0.5 was just released by MySQL and we will soon release 1.0.6.	16 years ago
Satya B	444c6d0d73	Applying InnoDB Plugin 1.0.6 snapshot, part 6. Add Testcase for BUG#46676 1. add testcase for BUG#46676 2. Allow CREATE INDEX to be interrupted 3. ha_innobase::change_active_index(): When the history is missing, report it to the client, not to the error log 4. ChangeLog entries appplied revisions:r6169, r6170, r6175, r6177, r6179 Detailed revision comments: r6169 \| calvin \| 2009-11-12 14:40:43 +0200 (Thu, 12 Nov 2009) \| 6 lines branches/zip: add test case for bug#46676 This crash is reproducible with InnoDB plugin 1.0.4 + MySQL 5.1.37. But no longer reproducible after MySQL 5.1.38 (with plugin 1.0.5). Add test case to catch future regression. r6170 \| marko \| 2009-11-12 15:49:08 +0200 (Thu, 12 Nov 2009) \| 4 lines branches/zip: Allow CREATE INDEX to be interrupted. (Issue #354) rb://183 approved by Heikki Tuuri r6175 \| vasil \| 2009-11-16 20:07:39 +0200 (Mon, 16 Nov 2009) \| 4 lines branches/zip: Wrap line at 78th char in the ChangeLog r6177 \| calvin \| 2009-11-16 20:20:38 +0200 (Mon, 16 Nov 2009) \| 2 lines branches/zip: add an entry to ChangeLog for r6065 r6179 \| marko \| 2009-11-17 10:19:34 +0200 (Tue, 17 Nov 2009) \| 2 lines branches/zip: ha_innobase::change_active_index(): When the history is missing, report it to the client, not to the error log.	16 years ago
Sergey Vojtovich	976696fe4f	Applying InnoDB plugin snashot Detailed revision comments: r6113 \| vasil \| 2009-10-29 18:15:50 +0200 (Thu, 29 Oct 2009) \| 93 lines branches/zip: Merge r5912:6112 from branches/5.1: (after this merge the innodb-autoinc test starts to fail, but I commit anyway because it would be easier to investigate the failure this way) ------------------------------------------------------------------------ r5952 \| calvin \| 2009-09-22 19:45:07 +0300 (Tue, 22 Sep 2009) \| 7 lines Changed paths: M /branches/5.1/handler/ha_innodb.cc branches/5.1: fix bug#42383: Can't create table 'test.bug39438' For embedded server, MySQL may pass in full path, which is currently disallowed. It is needed to relax the condition by accepting full paths in the embedded case. Approved by: Heikki (on IM) ------------------------------------------------------------------------ r6032 \| vasil \| 2009-10-01 15:55:49 +0300 (Thu, 01 Oct 2009) \| 8 lines Changed paths: M /branches/5.1/handler/ha_innodb.cc branches/5.1: Fix Bug#38996 Race condition in ANALYZE TABLE by serializing ANALYZE TABLE inside InnoDB. Approved by: Heikki (rb://175) ------------------------------------------------------------------------ r6045 \| jyang \| 2009-10-08 02:27:08 +0300 (Thu, 08 Oct 2009) \| 7 lines Changed paths: M /branches/5.1/handler/ha_innodb.cc A /branches/5.1/mysql-test/innodb_bug47777.result A /branches/5.1/mysql-test/innodb_bug47777.test branches/5.1: Fix bug #47777. Treat the Geometry data same as Binary BLOB in ha_innobase::store_key_val_for_row(), since the Geometry data is stored as Binary BLOB in Innodb. Review: rb://180 approved by Marko Makela. ------------------------------------------------------------------------ r6051 \| sunny \| 2009-10-12 07:05:00 +0300 (Mon, 12 Oct 2009) \| 6 lines Changed paths: M /branches/5.1/handler/ha_innodb.cc M /branches/5.1/mysql-test/innodb-autoinc.result M /branches/5.1/mysql-test/innodb-autoinc.test branches/5.1: Ignore negative values supplied by the user when calculating the next value to store in dict_table_t. Setting autoincrement columns top negative values is undefined behavior and this change should bring the behavior of InnoDB closer to what users expect. Added several tests to check. rb://162 ------------------------------------------------------------------------ r6052 \| sunny \| 2009-10-12 07:09:56 +0300 (Mon, 12 Oct 2009) \| 4 lines Changed paths: M /branches/5.1/handler/ha_innodb.cc M /branches/5.1/mysql-test/innodb-autoinc.result M /branches/5.1/mysql-test/innodb-autoinc.test branches/5.1: Reset the statement level autoinc counter on ROLLBACK. Fix the test results too. rb://164 ------------------------------------------------------------------------ r6053 \| sunny \| 2009-10-12 07:37:49 +0300 (Mon, 12 Oct 2009) \| 6 lines Changed paths: M /branches/5.1/handler/ha_innodb.cc M /branches/5.1/mysql-test/innodb-autoinc.result M /branches/5.1/mysql-test/innodb-autoinc.test branches/5.1: Copy the maximum AUTOINC value from the old table to the new table when MySQL does a CREATE INDEX ON T. This is required because MySQL does a table copy, rename and drops the old table. Fix Bug#47125: auto_increment start value is ignored if an index is created and engine=innodb rb://168 ------------------------------------------------------------------------ r6076 \| vasil \| 2009-10-14 19:30:12 +0300 (Wed, 14 Oct 2009) \| 4 lines Changed paths: M /branches/5.1/row/row0mysql.c branches/5.1: Fix typo. ------------------------------------------------------------------------	16 years ago

1 2

64 Commits (7299858763289eab8c9fbe8048f86abebdf4d50d)