mariadb

Tree: fd3295e0ac

Author	SHA1	Message	Date
unknown	fd3295e0ac	Fix bug lp:893486 Analysis: The bug is a result of an incomplete fix for bug lp:869036. That fix didn't take into account that there may be a case when ther are no NULLs in the materialized subquery, however all columns without NULLs may not be grouped in the only non-null index. This is the case when the left subquery expression has nullable columns. Solution: The patch handles two missing sub-cases of the case when there are no value (non-null matches) for any outer expression, and there are both NULLs and non-NUll values in the outer reference. a) If the materialized subquery contains no NULLs there cannot be a partial match, because there are no NULLs in those columns where the outer reference has no NULLs. b) If the materialized subquery contains NULLs, but there exists a column, such that its corresponding outer expression has no NULL, and this column also has no NULL. Then there cannot be a partial match either.	14 years ago
Alexey Botchkov	12e60c4989	Small fixes to make compilers happy.	14 years ago
Alexey Botchkov	ae0ebd8a6b	Windows has no 'nearbyint' in libraries. So removed.	14 years ago
unknown	eabcd6205c	Merge default materialization=on.	14 years ago
unknown	3e7bcc80c1	Correct test file.	14 years ago
unknown	b9d6bff883	Fix test to pass on 32-bit machines by reducing the depth of subquery nestedness to less than 31 (sizeof(ulong)-1).	14 years ago
Igor Babaev	76d03e7af5	Merge.	14 years ago
Igor Babaev	b2e5a3f603	Fixed LP bug #887496 . This bug in the function Loose_scan_opt::check_ref_access_part1 could lead to choosing an invalid execution plan employing a loose scan access to a semi-join table even in the cases when such access could not be used at all. This could result in wrong answers for some queries with IN subqueries.	14 years ago
unknown	f8dbbc010f	Fix bug lp:833777 Analysis: The optimizer distinguishes two kinds of 'constant' conditions: expensive ones, and non-expensive ones. The non-expensive conditions are evaluated inside make_join_select(), and if false, already the optimizer detects empty query results. In order to avoid arbitrarily expensive optimization, the evaluation of expensive constant conditions is delayed until execution. These conditions are attached to JOIN::exec_const_cond and evaluated in the beginning of JOIN::exec. The relevant execution logic is: JOIN::exec() { if (! join->exec_const_cond->val_int()) { produce an empty result; stop execution } continue execution execute the original WHERE clause (that contains exec_const_cond) ... } As a result, when an expensive constant condition is TRUE, it is evaluated twice - once through JOIN::exec_const_cond, and once through JOIN::cond. When the expensive constant condition is a subquery, predicate, the subquery is evaluated twice. If we have many levels of subqueries, this logic results in a chain of recursive subquery executions that walk a perfect binary tree. The result is that for subquries with depth N, JOIN::exec is executed O(2^N) times. Solution: Notice that the second execution of the constant conditions happens inside do_select(), in the branch: if (join->table_count == join->const_tables) { ... } In this case exec_const_cond is equivalent to the whole WHERE clause, therefore the WHERE clause has already been checked in the beginnig of JOIN::exec, and has been found to be true. The bug is addressed by not evaluating the WHERE clause if there was exec_const_conds, and it was TRUE.	14 years ago
unknown	e9a6502f26	Merge enabling materialization=on by default.	14 years ago
Igor Babaev	0693f4d916	Corrected the patch that made the optimizer switch for index condition pushdown set to 'on' by default.	14 years ago
unknown	f0d9908fc3	Merge enabling of materialization=on by default with main tree.	14 years ago
Igor Babaev	af3d1da31d	Made the optimizer switch for index condition pushdown set to 'on' by default.	14 years ago
Igor Babaev	3c496ea9ad	Fixed LP bug #892725 . A non-first execution of a prepared statement missed a call of the TABLE_LIST::process_index_hints() method in the code of the function setup_tables(). At some scenarios this could lead to the choice of a quite inefficient execution plan for the base query of the prepared statement.	14 years ago
Alexey Botchkov	5a4c91003a	Fix for bug #809849 spatial operations must be KILL-able. Checks for thd->killed state added to the long loops in geometry calculations. per-file comments: sql/gcalc_slicescan.cc Fix for bug #809849 spatial operations must be KILL-able. checks for TERMINATED_STATE added. sql/gcalc_slicescan.h Fix for bug #809849 spatial operations must be KILL-able. defines added to include checks for termination in the library. sql/gcalc_tools.cc Fix for bug #809849 spatial operations must be KILL-able. checks for TERMINATED_STATE added. sql/gcalc_tools.h Fix for bug #809849 spatial operations must be KILL-able. TERMINATED_STATE pointers added. sql/item_geofunc.cc Fix for bug #809849 spatial operations must be KILL-able. sql/item_geofunc.h Fix for bug #809849 spatial operations must be KILL-able.	14 years ago
Igor Babaev	8ea398292e	Fixed LP bug #891995 . This bug in the function setup_semijoin_dups_elimination() could lead to invalid choice of the sequence of tables for which semi-join duplicate elimination was applied.	14 years ago
Igor Babaev	6ed9c13643	Fixed LP bug #891953 . Due to this bug the function SEL_IMERGE::or_sel_tree_with_checks() could build an inconsistent merge tree if one of the SEL_TREEs in the resulting index merge happened to contain a full key range. This could trigger an assertion failure.	14 years ago
Alexey Botchkov	fbb22ca4a7	unused variable removed.	14 years ago
Alexey Botchkov	47022d2ee2	GCALC_CHECK_WITH_FLOAT disabled. That's not a good option for an onrdinary user.	14 years ago
Igor Babaev	3433cf3e4f	Fixed LP bug #800184 . The function key_and() erroneously called SEL_ARG::increment_use_count() when SEL_ARG::incr_refs() should had been called. This could lead to wrong values of use_count for some SEL_ARG trees.	14 years ago
Igor Babaev	e31887b592	Merge.	14 years ago
Alexey Botchkov	9cde33f9ef	small fixes to make compiler happy.	14 years ago
Alexey Botchkov	b525abefb2	test results updated.	14 years ago
Igor Babaev	6bb5bc2044	Corrected the fix for bug 891052.	14 years ago
Alexey Botchkov	b2b035134f	merging.	14 years ago
Igor Babaev	fdeaedb43b	Fixed LP bug #891052 . Some optimizer switches were missing in the help lists of mysqld.	14 years ago
unknown	42221abaed	Fix bug lp:869036 Apart from the fix, the patch also adds few more unrelated test cases for partial matching, and fixes few typos. Analysis: This bug uncovered that partial matching via rowid intersection didn't handle the case when: - the left IN argument has some NULLs, - there are no non-null value matches, and there is no non-null column, - the subquery columns that are not covered with the NULLs in the left IN argument contain at least one row, such that it has NULL values in all columns where the left IN operand has no NULLs. In this case there is a partial match. In addition the analysis of the related code uncovered incorrect handling of few other related cases. Solution: The solution for the bug is to check if there exists a row with NULLs in all columns other than the ones having NULL in the let IN operand. The check is implemented via checking whether the bitmaps that store NULL information in class Ordered_key have a non-empty intersection for the relevant columns. The intersection itself is implemented via the function bitmap_exists_intersection() in my_bitmap.c.	14 years ago
Igor Babaev	c05e5b9c65	Fixed LP bug #887479 . The function setup_semijoin_dups_elimination erroneously assumed that if join_cache_level is set to 3 or 4 then the type of the access to a table cannot be JT_REF or JT_EQ_REF. This could lead to wrong query result sets.	14 years ago
Igor Babaev	4d358f48c9	Merge.	14 years ago
Igor Babaev	b4b7d941fe	Fixed LP bug #889750 . If the optimizer switch 'semijoin_with_cache' is set to 'off' then join cache cannot be used to join inner tables of a semijoin. Also fixed a bug in the function check_join_cache_usage() that led to wrong output of the EXPLAIN commands for some test cases.	14 years ago
unknown	147721bbb6	Fix bug lp:889744 MariaDB 5.5 merges changes from MySQL 5.5 where all constant expressions are wrapped into an Item_cache. As a result, constant single-row subqueries were also wrapped in an Item_cache. When analyzing the where clause for constant expressions that can be evaluated during optimization, subqueries wrapped into an Item_cache did not appear as expensive, and were therefore evaluated during optimization. Such evaluation is against the current architecture of MariaDB 5.3 where subquries are executed during the execute phase. The patch adds the is_expensive() predicate to Item_cache. This makes Item_cache consistent with other wrapping Item classes that need to look at the properties of the wrapped object.	14 years ago
Sergei Golubchik	c25f472599	5.2->5.3 merge	14 years ago
Sergei Golubchik	b5d41c1c11	5.1->5.2 merge	14 years ago
Sergei Golubchik	ac20f84e7e	don't make feedback_plugin_send.test as 'big' don't assume that the http reply packet will arrive in all in one piece	14 years ago
unknown	f76bfc40ea	Fix for LP BUG#824425: Prohibiting subqueries in rows for left part of IN/ALL/ANY Fix for walk() method of subqueries: always call the method on the subquery.	14 years ago
Sergei Golubchik	3fb60b1df0	5.2->5.3 merge	14 years ago
Sergei Golubchik	0d6a25fcc8	5.1-5.2 merge	14 years ago
Sergei Golubchik	f967575457	increase feedback plugin version	14 years ago
Sergei Golubchik	557f0d3ad0	5.2->5.3 merge	14 years ago
Alexey Botchkov	7c7269d372	merging.	14 years ago
Sergei Golubchik	27095a24f6	5.1 merge	14 years ago
Sergei Golubchik	5c7aa5f2ae	feedback plugin: fix for mem_total on windows report the time of the data snapshot	14 years ago
Igor Babaev	db0aed9348	Merge.	14 years ago
Igor Babaev	28b2eaa81a	Fixed LP bug #823301 . A bug in the code of the function key_or could lead to a situation when performing of an OR operation for one index changes the result the operation for another index. This bug is fixed with this patch. Also corrected the specification and the code of the function or_sel_tree_with_checks.	14 years ago
unknown	7ab789ef33	Remove unused variable detected by GCC 4.6.1.	14 years ago
unknown	1d721d0106	Fix MySQL BUG#12329653 In MariaDB, when running in ONLY_FULL_GROUP_BY mode, the server produced in incorrect error message that there is an aggregate function without GROUP BY, for artificially created MIN/MAX functions during subquery MIN/MAX optimization. The fix introduces a way to distinguish between artifially created MIN/MAX functions as a result of a rewrite, and normal ones present in the query. The test for ONLY_FULL_GROUP_BY violation now tests in addition if a MIN/MAX function was part of a MIN/MAX subquery rewrite. In order to be able to distinguish these MIN/MAX functions, the patch introduces an additional flag in Item_in_subselect::in_strategy - SUBS_STRATEGY_CHOSEN. This flag is set when the optimizer makes its final choice of a subuqery strategy. In order to make the choice consistent, access to Item_in_subselect::in_strategy is provided via new class methods. ****** Fix MySQL BUG#12329653 In MariaDB, when running in ONLY_FULL_GROUP_BY mode, the server produced in incorrect error message that there is an aggregate function without GROUP BY, for artificially created MIN/MAX functions during subquery MIN/MAX optimization. The fix introduces a way to distinguish between artifially created MIN/MAX functions as a result of a rewrite, and normal ones present in the query. The test for ONLY_FULL_GROUP_BY violation now tests in addition if a MIN/MAX function was part of a MIN/MAX subquery rewrite. In order to be able to distinguish these MIN/MAX functions, the patch introduces an additional flag in Item_in_subselect::in_strategy - SUBS_STRATEGY_CHOSEN. This flag is set when the optimizer makes its final choice of a subuqery strategy. In order to make the choice consistent, access to Item_in_subselect::in_strategy is provided via new class methods.	14 years ago
Igor Babaev	b91a6bd88b	Fixed LP bug #879871 . The function add_ref_to_table_cond missed updating the value of join_tab->pre_idx_push_select_cond after having updated the value of join_tab->select->pre_idx_push_select_cond.	14 years ago
Igor Babaev	402258ff95	Merge of the maria-5.3-icp tree into the 5.3 tree	14 years ago
unknown	32d230d67b	Fixed PBXT test cases.	14 years ago
unknown	30b396ad4c	- Removed a comment that is not true any more. - Consistent use of the SUBS_NOT_TRANSFORMED constant for in_strategy.	14 years ago

1 2 3 4 5 ...

67784 Commits (fd3295e0acb782790eb185352a401473fd4eba99) All Branches Search

67784 Commits (fd3295e0acb782790eb185352a401473fd4eba99)

All Branches