mariadb

Commit Graph

Author	SHA1	Message	Date
Sergei Petrunia	e4af72bd5d	MDEV-33281 Optimizer hints cleanup: add `const` specifiers, comments	1 year ago
Oleg Smirnov	cd9ac306c3	MDEV-33281 Make BNL() hint work for join_cache_level=0 join_cache_level=0 disables join cache buffers, but the hint BNL() now allows to employ BNL(H) buffers for particular tables or query blocks. This commit also adds a number of test cases including OUTER JOINs to make sure hints do not break the rules of join buffers application	1 year ago
Oleg Smirnov	1cd928c297	MDEV-33281 Implement optimizer hints Forbid adding optimizer hints to view definitions. In the case when optimizer hints are added to the view definition at a `CREATE (OR REPLACE) VIEW`/`ALTER VIEW` statement, a warning is generated and the hints are ignored. This commit also disables ps-protocol for test cases where `Unresolved table/index name` warnings are generated. The reason for this is such warnings are generated during both PREPARE and EXECUTE stages. Since opt_hints.test has `--enable_prepare_warnings`, running it with `--ps-protocol` causes duplication of warning messages	1 year ago
Oleg Smirnov	4bb2669d18	MDEV-33281 Optimizer hints Cleanup: fix formatting, rename objects	1 year ago
Alexander Barkov	bd30c796fa	MDEV-33281 Implement optimizer hints - Using Lex_ident_sys to scan identifiers, like the SQL parser does. This fixes handling of double-quote-delimited and backtick-delimited identifiers, as well as handling of non-ASCII identifiers. Unescaping and converting from the client character set to the system character set is now done using Lex_ident_cli_st and Lex_ident_sys, like it's done in the SQL tokenizer/parser. Adding helper methods to_ident_cli() and to_ident_sys() in Optimizer_hint_parser::Token. - Fixing the hint parser to report a syntax error when an empty identifiers: SELECT /+ BKA(``) / * FROM t1; - Moving a part of the code from opt_hints_parser.h to opt_hints_parser.cc Moving these method definitions: - Optimizer_hint_tokenizer::find_keyword() - Optimizer_hint_tokenizer::get_token() to avoid huge pieces of the code in the header file. - A Lex_ident_cli_st cleanup Fixing a few Lex_ident_cli_st methods to return Lex_ident_cli_st & instead of void, to use them easier in the caller code. - Fixing the hint parser to display the correct line number Adding a new data type Lex_comment_st (a combination of LEX_CSTRING and a line number) Using it in sql_yacc.yy - Getting rid of redundant dependencies on sql_hints_parser.h Moving void LEX::resolve_optimizer_hints() from sql_lex.h to sql_lex.cc Adding a class Optimizer_hint_parser_output, deriving from Optimizer_hint_parser::Hint_list. Fixing the hint parser to return a pointer to an allocated instance of Optimizer_hint_parser_output rather than an instance of Optimizer_hint_parser::Hint_list. This allows to use a forward declaration of Optimizer_hint_parser_output in sql_lex.h and thus avoid dependencies on sql_hints_parser.h.	1 year ago
Oleg Smirnov	877e4a386c	MDEV-33281 Implement optimizer hints This commit introduces: - the infrastructure for optimizer hints; - hints for join buffering: BNL(), NO_BNL(), BKA(), NO_BKA(); - NO_ICP() hint for disabling index condition pushdown; - MRR(), MO_MRR() hint for multi-range reads control; - NO_RANGE_OPTIMIZATION() for disabling range optimization; - QB_NAME() for assigning names for query blocks.	1 year ago
Alexander Barkov	6340c23933	MDEV-33281 Implement optimizer hints Implementing a recursive descent parser for optimizer hints.	1 year ago
Yuchen Pei	495d96709f	MDEV-35866 CHECK TABLE get number of rows without HA_STATS_RECORDS_IS_EXACT Call ha_rnd_init followed by two ha_rnd_next's to find whether there is more than one row.	6 months ago
Yuchen Pei	d52ddae57b	MDEV-22491 Support mariadb-check and CHECK TABLE with SEQUENCE The check go through the following steps: 1. Run check on the underlying engine. If not ok, then return. 2. Check that there's only one row in the table, and 2.1 warn if more than one row 2.2 return HA_ADMIN_CORRUPT if fewer than one row (i.e. 0 rows) 3. If the sequence is not initialised (e.g. after an ALTER TABLE ... SEQUENCE=1), initialise the sequence by reading the sequence metadata from the table. This will also flush the next_free_value, i.e. set it to the next not cached value (SEQUENCE::reserved_until) 4. Check that the sequence metadata is valid, i.e. nothing out of order e.g. minvalue < maxvalue etc. If invalid it reports HA_ERR_SEQUENCE_INVALID_DATA 5. Check that the sequence has not been exhausted. It reports ER_SEQUENCE_RUN_OUT as a warning if and only if a SELECT NEXTVAL would do so Limitations: 1. The check is independent of flags, so the vanilla check is the same as CHECK ... EXTENDED or CHECK ... FOR UPGRADE etc. 2. When the check discovers invalid metadata from the table, subsequent SELECT NEXTVAL will carry on (or fail) without this piece of knowledge, independent of the CHECK. This is to ensure consistency, i.e. CHECK does not modify behaviour of SELECT, and if anything it makes more sense that SELECT reports HA_ERR_SEQUENCE_INVALID_DATA in this case, regardless of prior CHECK	6 months ago
Sergei Golubchik	26ea37be5d	MDEV-36405 Session tracking does not report changes from COM_CHANGE_USER report all sysvar tracker changes, as for the new login. also report db and other session state changes.	6 months ago
Sergei Golubchik	07de0ac69e	MDEV-20299 SET SESSION AUTHORIZATION a.k.a. "sudo"	8 months ago
Sergei Golubchik	0f4a35a327	cleanup: extract reusable code chunks move user_name parser rule out of user_maybe_role extract setting privileges on login from acl_authenticate() into a separate function	8 months ago
Sergei Golubchik	78d23a3e60	fix error messages when a definer for SP/view is wrong - it shold be ER_MALFORMED_DEFINER, not ER_NO_SUCH_USER when one uses current_role as a definer or grantee but there's no current role - it should be ER_INVALID_ROLE not ER_MALFORMED_DEFINER when a non-existent user is specified - it should be ER_NO_SUCH_USER, which should say "The user does not exist", not "Definer does not exist" clarify ER_CANT_CHANGE_TX_CHARACTERISTICS to say what cannot be changed	8 months ago
Sergei Golubchik	02b81afff8	cleanup: THD::change_user	8 months ago
Sergei Golubchik	fa47c73561	MDEV-12182 post-merge * fix plugin version * don't print :unavaliable for localhost	7 months ago
Hashim Syed	1aba30b8f9	MDEV-12182 Add Client TCP Port Number to MySQL Audit Plugin Logs In environments with load balancers or proxies, the audit plugin logs only the IP address, making it difficult to differentiate individual client connections from the same IP. Add a new 'port' field to the appropriate event objects to capture the client's TCP port number. Populate the port field with thd->port in the appropriate functions. The audit plugin receives and logs this port field along with other connection information, enabling better identification of individual client connections. All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.	1 year ago
Sergei Golubchik	c1f2b5a141	MDEV-33834 post-merge * move TLS version into the "object" column * show that TLS version follows db name * correctly check for have_ssl	7 months ago
Meng-Hsiu Chiang	2b464774f2	MDEV-33834 Extend audit plugin to include tls_version and tls_version_length variables Add tls_version and tls_version_length variables to the audit plugin so they can be logged. This is useful to help identify suspicious or malformed connections attempting to use unsupported TLS versions. A log with this information will allow to detect and block more malicious connection attempts. Users with 'server_audit_events' empty will have these two new variables automatically visible in their logs, but if users don't want them, they can always configure what fields to include by listing the fields in 'server_audit_events'. In connection event, The TLS version will be populated in `object` field in key=value format, and the key-value pair will be omitted when the value is empty. To ensure the MTR test result matches in all environments, the TLS version string is replaced with a general `TLS_VERSION` to avoid the MTR test failing unexpectedly. It stores the version with query `SHOW STATUS LIKE 'Ssl_version'` and replace the output with `replace_result` command. All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc. [1]: https://docs.openssl.org/3.2/man3/SSL_get_version/	2 years ago
Brandon Nesterenko	88cc11dc54	MDEV-36714: Rows_log_event::write_data_header overallocates buffer size Nothing is broken by this, but the function Rows_log_event::write_data_header slightly over-allocates its buf by 2 bytes. It allocates 10 (ROWS_HEADER_LEN_V2), but only 8 are ever written. This patch fixes the buf size to match what is written (i.e. ROWS_HEADER_LEN_V1, or 8 bytes). Reviewed By: ============ Kristian Nielsen <knielsen@knielsen-hq.org>	6 months ago
Sergei Golubchik	3e9e1a25b7	MDEV-36566 SELECT create_temporary_table_binlog_formats should show exactly what it is SET to added a warning	6 months ago
Sergei Golubchik	ee9359de89	MDEV-36425 fix test results followup for `ce8a74f235`	6 months ago
ParadoxV5	c29e83f226	MDEV-30189 Add remaining replication options as system variables Promote the last few SQL-inaccessible replication options (command line or `mariadb.cnf`) as these GLOBAL read-only system variables: ``` @@master_info_file @@replicate_same_server_id @@show_slave_auth_info ``` Side effect: The latter two options changed from no argument to optional argument. Quote `include/my_getopt.h`: > It should be noted that for historical reasons variables with the > combination arg_type=NO_ARG, my_option::var_type=GET_BOOL still > accepts arguments. This is someone counter intuitive and care should > be taken if the code is refactored. Reviewed-by: Brandon Nesterenko <brandon.nesterenko@mariadb.com>	7 months ago
Brandon Nesterenko	74c189c312	MDEV-35304: Fix multi_source.connects_tried Test multi_source.connects tried would sporadically fail with a result mismatch resembling the following diff: @@ -29,6 +29,7 @@ SELECT @time_begin, CURRENT_TIMESTAMP(1) WHERE TIMESTAMPDIFF(SECOND, @time_begin, CURRENT_TIMESTAMP(1)) < 1; @time_begin CURRENT_TIMESTAMP(1) +2025-04-28 17:10:08.3 2025-04-28 17:10:09.2 CREATE TEMPORARY TABLE status_sleep AS SELECT 'named' Connection_name, Connects_Tried Connects_Tried; SET @@SESSION.default_master_connection= ''; include/wait_for_slave_param.inc [Connects_Tried] This happened due to the reference variable @time_begin being set _after_ the slave was started. That is, @time_begin was used as the anchor point at which the time should start ticking for when Connects_Tried should be incremented; however, MTR may not actually be able to set it for some time after the slave had started due to OS scheduling or heavy server load. The failure can be reproduced by adding a 0.1s sleep statement in-between the aformentioned statements. The fix is to set @time_begin before starting the slave so it is at least always valid to reference as the start of the test case.	6 months ago
Sergei Golubchik	e1da2c3d67	increase tolerance in socket_summary_check.inc for approx. stat P_S calculations. fixes perfschema.socket_summary_by_instance_func	6 months ago
Sergei Golubchik	16c4621400	remove unused non-standard tokens from the parser keep unused standard tokens, like LOCATOR or INSENSITIVE	8 months ago
Sergei Golubchik	11f6b9d12a	remove features that were deprecated in 10.5 --big-tables --large-page-size --storage-engine performance_schema.setup_timers (WL#10986)	8 months ago
Sergei Golubchik	24fd8c7856	update deprecation.h to match the latest policy changes	8 months ago
Daniel Black	068fc787ee	MDEV-36168 ASAN error in Item_func_latlongfromgeohash::decode_geohash (postfix) pppc64le, aarch64, and s390x have char defined as unsigned so a < 0 comparison is a compile error. The CHAR_MIN defined in limits.h is 0 on these platforms, false, meaning the if condition is only on signed char platforms. To make the interface cleaner we return true on out == 255 to simplify the calling function.	6 months ago
Krishna Teja	36dfe08672	Clarify .frm field parsing comments: use C-style block comments, reposition loop comment, and add end marker	7 months ago
Vasilii Lakhin	1b95e46524	Fix typos in mysql-test/	6 months ago
Vasilii Lakhin	40c5b62531	Fix remaining typos	6 months ago
Dave Gosselin	bc87abc381	MDEV-36694 spatial_utility_function{_collect,_isvalid} broken for --view-protocol In spatial_utility_function_collect, temporarily exclude the two affected queries because the DISTINCT flag isn't consistently passed to the Item_func_collect class. Created MDEV-36695 to address that bug. In spatial_utility_function_isvalid, add an alias for queries to allow the test to pass under view protocol.	6 months ago
Monty	4042652d7f	Improvements to mtr - Added option $backup_on_restart to store a backup of the var/ directory after restart. This is useful for debugging recovery. - The list_files option in mysqltest is now returning the number of found files in $sys_files. This is useful to break test if there are unknown or lost files in the data directory.	6 months ago
Monty	ce8a74f235	MDEV-36425 Extend read_only to also block share locks and super user The main purpose of this allow one to use the --read-only option to ensure that no one can issue a query that can block replication. The --read-only option can now take 4 different values: 0 No read only (as before). 1 Blocks changes for users without the 'READ ONLY ADMIN' privilege (as before). 2 Blocks in addition LOCK TABLES and SELECT IN SHARE MODE for not 'READ ONLY ADMIN' users. 3 Blocks in addition 'READ_ONLY_ADMIN' users for all the previous statements. read_only is changed to an enum and one can use the following names for the lock levels: OFF, ON, NO_LOCK, NO_LOCK_NO_ADMIN Too keep things compatible with older versions config files, one can still use values FALSE and TRUE, which are mapped to OFF and ON. The main visible changes are: - 'show variables like "read_only"' now returns a string instead of a number. - Error messages related to read_only violations now contains the current value off readonly. Other things: - is_read_only_ctx() renamed to check_read_only_with_error() - Moved TL_READ_SKIP_LOCKED to it's logical place Reviewed by: Sergei Golubchik <serg@mariadb.org>	7 months ago
Monty	595e834946	Galera mtr results updated	7 months ago
Monty	23eb9d6821	Improve mtr replication setup - Log slave state if sync_with_master_gtid fails, like we do in sync_with_master.inc - Increase master-retry-count to 30 for slow builders	7 months ago
Monty	bb5ae63aef	Add memory allocated by my_once_alloc() to memory status Global Memory_used and global Memory_used_initial now includes memory allocated by mysys libraries during server startup.	7 months ago
Monty	2c4fee8376	Fixed that HA_EXTRA_FLUSH in Aria and MyISAM flushes all data to disk This is needed to support Atomic CREATE TABLE t1 SELECT * FROM ... on non transactional tables.	8 months ago
Monty	7728b90a0d	Removed possible deadlock betwen LOCK_log and LOCK_global_system_variables The lock order of the mutex must be LOCK_log followed by LOCK_global_system_variables as InnoDB can lock LOCK_global_system_variables during a transaction commit when LOCK_log is hold. Fix is to temporarly unlock LOCK_global_system_variables when setting global binlog variables that needs to use LOCK_log.	8 months ago
Monty	f099f778b3	Do not log ALTER table to ddl log for REPAIR REPAIR of InnoDB tables was logging ALTER TABLE and REPAIR to ddl log. ALTER TABLE contained the new tableid and REPAIR, wrongly, contained the old rowid. Now only REPAIR is logged ddl.log changes: REPAIR TABLE and OPTIMIZE TABLE that are done through ALTER TABLE will now contain the old and new table id. If not done through ALTER TABLE, only the current rowid will be shown (as before).	9 months ago
Monty	aae9b50a53	Added VALGRIND_YIELD to be able to abort from busy loops Valgrind is single threaded and only changes threads as part of system calls or waits. I found some busy loops where the server assumes that some other thread will change the state, which will not happen with valgrind. Added VALGRIND_YIELD to the loops, which calls pthread_yield() if HAVE_VALGRIND is defined. Added pthread_yield() to the loops in table_cache. We should consider changing some of the VALGRIND_YIELD calls to call pthread_yield() as busy loop without any sleep() is usually a bad thing. Reviewer: svojtovich@gmail.com	9 months ago
Monty	d9c3b775b8	Comment and indentation improvements	9 months ago
Monty	4992aaf9a2	Always use all arguments for ddl_log_write_execute_entry() Remove not anymore used bool ddl_log_write_execute_entry(uint first_entry, DDL_LOG_MEMORY_ENTRY **active_entry) Simple transformations, no logic changes.	9 months ago
Monty	c234a312d7	Added make_tmp_table_name() to simplify creating temporary table names	9 months ago
Monty	efc5d3f84d	rename binlog_show_create_table_() to binlog_show_create_table() Other things: - Removed not existing binlog_show_create_table() declaration in class select_create()	9 months ago
Aleksey Midenkov	1f85eeeb53	MDEV-25292 Refactoring: moved select_field_count into Alter_info. There is a need in MDEV-25292 to have both C_ALTER_TABLE and select_field_count in one call. Semantically creation mode and field count are two different things. Making creation mode negative constants and field count positive variable into one parameter seems to be a lazy hack for not making the second parameter. select_count does not make sense without alter_info->create_list, so the natural way is to hold it in Alter_info too. select_count is now stored in member select_field_count. Merged and updated by: Monty	3 years ago
Monty	f8ba5ced55	MDEV-36099 Ensure that creation and usage of temporary tables in replication is predictable MDEV-36563 Assertion `!mysql_bin_log.is_open()' failed in THD::mark_tmp_table_as_free_for_reuse The purpose of this commit is to ensure that creation and changes of temporary tables are properly and predicable logged to the binary log. It also fixes some bugs where ROW logging was used in MIXED mode, when STATEMENT would be a better (and expected) choice. In this comment STATEMENT stands for logging to binary log in STATEMENT format, MIXED stands for MIXED binlog format and ROW for ROW binlog format. New rules for logging of temporary tables - CREATE of temporary tables are now by default binlogged only if STATEMENT binlog format is used. If it is binlogged, 1 is stored in TABLE_SHARE->table_creation_was_logged. The user can change this behavior by setting create_temporary_table_binlog_formats to MIXED,STATEMENT in which case the create is logged in statement format also in MIXED mode (as before). - Changes to temporary tables are only binlogged if and only if the CREATE was logged. The logging happens under STATEMENT or MIXED. If binlog_format=ROW, temporary table changes are not binlogged. A temporary table that are changed under ROW are marked as 'not up to date in binlog' and no future row changes are logged. Any usage of this temporary table will force row logging of other tables in any future statements using the temporary table to be row logged. - DROP TEMPORARY is binlogged only of the CREATE was binlogged. Changes done: - Row logging is forced for any statement using temporary tables that are not up to date in the binary log. (Before the row logging was forced if the user has a temporary table) - If there is any changes to the temporary table that is not binlogged, the table is marked as not up to date. - TABLE_SHARE->table_creation_was_logged has a new definition for temporary tables: 0 Table creating was not logged to binary log 1 Table creating was logged to binary log and table is up to date. 2 Table creating was logged to binary log but some changes where not logged to binary log. Table is not up to date in binary log is defined as value 0 or 2. - If a multi-table-update or multi-table-delete fails then all updated temporary tables are marked as not up to date. - Enforce row logging if the query is using temporary tables that are not up to date. Before row logging was enforced if the user had any temporary tables. - When dropping temporary tables use IF EXISTS. This ensures that slave will not stop if it had crashed and lost the temporary tables. - Remove comment and version from DROP /*!4000 TEMPORARY.. generated when a connection closes that has open temporary tables. Added 'generated by server' at the end of the DROP. Bugs fixed: - When using temporary tables with commands that forced row based, like INSERT INTO temporary_table VALUES (UUID()), this was never logged which causes the temporary table to be inconsistent on master and slave. - Used binlog format is now clearly defined. It is now only depending on the current binlog_format and the tables used. Before it was depending on the user had ANY temporary tables and the state of 'current_stmt_binlog_format' set by previous queries. This also caused temporary tables to be logged to binary log in some cases. - CREATE TABLE t1 LIKE not_logged_temporary_table caused replication to stop. - Rename of not binlogged temporary tables where binlogged to binary log which caused replication to stop. Changes in behavior: - By default create_temporary_table_binlog_formats=STATEMENT, which means that CREATE TEMPORARY is not logged to binary log under MIXED binary logging. This can be changed by setting create_temporary_table_binlog_formats to MIXED,STATEMENT. - Using temporary tables that was not logged to the binary log will cause any query using them for updating other tables to be logged in ROW format. Before all queries was logged in ROW format if the user had any temporary tables, even if they were not used by the query. - Generated DROP TEMPORARY TABLE is now always using IF EXISTS and has a "generated by server" comment in the binary log. The consequences of the above is that manipulations of a lot of rows through temporary tables will by default be be slower in mixed mode. For example: BEGIN; CREATE TEMPORARY TABLE tmp AS SELECT a, b, c FROM large_table1 JOIN large_table2 ON ...; INSERT INTO other_table SELECT b, c FROM tmp WHERE a <100; DROP TEMPORARY TABLE tmp; COMMIT; By default this will create a huge entry in the binary log, compared to just a few hundred bytes in statement mode. However the change in this commit will make usage of temporary tables more reliable and predicable and is thus worth it. Using statement mode or create_temporary_table_binlog_formats can be used to avoid this issue.	8 months ago
Yuchen Pei	a9bdfccbc6	MDEV-34712 Add support to sha2 and pbkdf2 key derivation in file_key_management Add two new variables: file_key_management_digest={sha1\|sha224\|sha256\|sha384\|sha512} This specify the digest function to use in key derivation of the key used for decryption of the keyfile. file_key_management_use_pbkdf2=N This specify whether pbkdf2 is used in the key derivation, and if so (N != 0), how many iterations.	7 months ago
Yuchen Pei	ec6f320883	MDEV-32732 Support DESC indexes in loose scan optimization Extend loose index scan to support descending indexes. This is achieved by removing a block skipping creating loose index scan plan for descending index, as well as generalising the execution of such plans. The generalisation applies to all levels looking for min/max in loose index scan. In the highest level (get_next), generalise min and max to first and last, so that it still proceeds in the direction agreeing with the index parity. In the lower levels, combine next_min and next_max methods into next_min_max, and combine next_min_in_range and next_max_in_range into next_min_max_in_range. This retains existing logic of these functions and reduces code duplication, while allowing handling of all four combinations (min, max) x (asc index, desc index).	6 months ago
Vladislav Vaintroub	8c6a606429	Workaround ICC compiler bug	6 months ago

1 2 3 4 5 ...

203094 Commits (e4af72bd5d2aeb16a343e4160843eb1d10203bc7) All Branches Search

203094 Commits (e4af72bd5d2aeb16a343e4160843eb1d10203bc7)

All Branches