mariadb

Tree: e44ca6cc9c

Author	SHA1	Message	Date
Marko Mäkelä	e44ca6cc9c	MDEV-14825 Assertion `col->ord_part' in row_build_index_entry_low upon ROLLBACK or DELETE with concurrent ALTER on partitioned table If creating a secondary index fails (typically, ADD UNIQUE INDEX fails due to duplicate key), it is possible that concurrently running UPDATE or DELETE will access the index stub and hit the debug assertion. It does not make any sense to keep updating an uncommitted index whose creation has failed. dict_index_t::is_corrupted(): Replaces dict_index_is_corrupted(). Also take online_status into account. Replace some calls to dict_index_is_clust() with calls to dict_index_t::is_primary().	8 years ago
Marko Mäkelä	d257c425f2	MDEV-15764 InnoDB may write uninitialized garbage to redo log log_sys_init(), log_buffer_extend(): Add TRASH_ALLOC() instrumentation log_write_up_to(): Correctly calculate the byte offset.	8 years ago
Jacob Mathew	da3c5c3c9a	MDEV-15698: Spider ignores syntax errors in connection string in COMMENT field When a comma separator is missing between COMMENT fields, Spider ignores the parameter values that are beyond the last expected parameter value. There are also some error messages that Spider does generate on COMMENT fields that are incorrectly formed. I have introduced additional infrastructure in Spider to fix these problems. Author: Jacob Mathew. Reviewer: Kentoku Shiba. Cherry-Picked: Commit `c10da98` on branch bb-10.3-MDEV-15698	8 years ago
Jacob Mathew	8fdeb079b9	MDEV-15712: If remote server used by Spider table is unavailable, some operations hang for a long time When an attempt to connect to the remote server fails, Spider retries to connect to the remote server 1000 times or until the connection attempt succeeds. This is perceived as a hang if the remote server remains unavailable. I have introduced changes in Spider's table status handler to fix this problem. Author: Jacob Mathew. Reviewer: Kentoku Shiba. Cherry-Picked: Commit `6ee6933` on branch bb-10.3-MDEV-15712	8 years ago
Marko Mäkelä	bcc26dce3a	Revert "Fix mtr to be able to wait for >1 exited mysqld" This reverts commit `72deed5988` which was merged as commit `29d4ac2ceb`. The change caused regressions, such as mysql-test-run failing to run at all with --valgrind, or aborting on Windows on the first test failure.	8 years ago
Marko Mäkelä	b4c5e4a717	Follow-up fix to MDEV-14705: Flush log at shutdown In the merge of commit `e7f4e61f6e` the call fil_flush_file_spaces(FIL_TYPE_LOG) is necessary. Tablespaces will be flushed as part of the redo log checkpoint, but the redo log will not necessarily be flushed, depending on innodb_flush_method.	8 years ago
Marko Mäkelä	5569b3eb09	MDEV-16041 Do not write for null update (properly fix MySQL Bug#29157) InnoDB takes a lot of time to perform null updates. The reason is that even though an empty update vector was created, InnoDB will go on to write undo log records and update the system columns DB_TRX_ID and DB_ROLL_PTR in the clustered index, and of course write redo log for all this. This could have been fixed properly in commit `54a492ecac` more than 10 years ago.	8 years ago
Marko Mäkelä	c5ea43fc99	innobase_init(): Remove some dead code Remove the local variable srv_buf_pool_size_org, which was always 0. In MySQL 5.7, InnoDB was made a mandatory storage engine, which would force InnoDB to start up when executing mysqld --verbose --help which is what mysql-test-run.pl is doing as a first step. With a large innodb_buffer_pool_size, this would take a long time. So, MySQL 5.7 includes a hack that starts up InnoDB with a smaller buffer pool when the option --verbose is present.	8 years ago
Marko Mäkelä	6e04af1b78	Remove dead code HAVE_LZO1X MariaDB uses HAVE_LZO, not HAVE_LZO1X (which was never defined). Also, the variable srv_lzo_disabled was never defined or read (only declared and assigned to, in unreachable code).	8 years ago
Marko Mäkelä	c026e2c006	MDEV-15507 Assertion failed in dict_check_sys_tables on upgrade from 5.5 The InnoDB system table column SYS_TABLES.MIX_LEN was repurposed in InnoDB Plugin for MySQL 5.1, in commit `91111174ee` (MySQL 5.1.46). Until MySQL 5.6, it only contained a flag DICT_TF2_TEMPORARY. MySQL 5.6 introduced a number of flags that were transient in nature. One of these was introduced in 5.6.5, originally called DICT_TF2_USE_TABLESPACE and later renamed to DICT_TF2_USE_FILE_PER_TABLE. MySQL 5.7.6 introduced logic that insists that the flag be set for any table that does not reside in a shared tablespace, breaking upgrade from MySQL 5.5. MariaDB does not support shared tablespaces other than the InnoDB system tablespace. Also, some dependencies on SYS_TABLES.MIX_LEN were removed in an earlier fix: MDEV-13084 MariaDB 10.2 crashes on corrupted SYS_TABLES.MIX_LEN field (commit `e813fe8622`). dict_check_sys_tables(): Remove a bogus debug assertion, and add a comment that explains how DICT_TF2_USE_FILE_PER_TABLE is used. dict_table_is_file_per_table(): Remove a bogus debug assertion.	8 years ago
Igor Babaev	f033fbd9f2	Changed the test case for MDEV-15571 It has been done to demonstrate that the fix of this bug is good for 10.3 as well. The previous test case is not good for this purpose because 10.2 and 10.3 use different rules for determining the types of recursive CTEs.	8 years ago
Marko Mäkelä	7b5543b21d	MDEV-15030 Add ASAN instrumentation to trx_t Pool Pool::mem_free(): Poison the freed memory. Assert that it was fully initialized, because the reuse of trx_t objects will assume that the objects were previously initialized. Pool::~Pool(), Pool::get(): Unpoison the allocated memory, and mark it initialized. trx_free(): After invoking Pool::mem_free(), unpoison trx_t::mutex and trx_t::undo_mutex, because MutexMonitor will access these even for freed trx_t objects.	8 years ago
Marko Mäkelä	8346acaf80	Pull request #522 : Remove C++ register keyword	8 years ago
Eugene Kosov	7b2bdd8984	register keyword c++17 warning	8 years ago
Marko Mäkelä	39a4985520	Remove most 'register' use in C++ Modern compilers (such as GCC 8) emit warnings that the 'register' keyword is deprecated and not valid C++17. Let us remove most use of the 'register' keyword. Code in 'extra/' is not touched.	8 years ago
Marko Mäkelä	2a00bdeb4a	Remove unused function FixNull()	8 years ago
Marko Mäkelä	36d28f210a	MDEV-15865 Crash in dict_index_set_merge_threshold() on CREATE TABLE Apply the contributed patch from MySQL Bug #89126 create table panic on innobase_parse_hint_from_comment by Yan Huang.	8 years ago
Marko Mäkelä	4cd7979c56	Merge 10.1 into 10.2	8 years ago
Marko Mäkelä	9c34a4124d	Merge 10.0 into 10.1	8 years ago
Marko Mäkelä	5b79303b40	MDEV-15988 Crash in ./mtr mariabackup.undo_space_id xb_assign_undo_space_start(): Correctly pass the length of the buffer, so that the file name will not be truncated.	8 years ago
Marko Mäkelä	c7bb337248	MDEV-15723 Crash in INFORMATION_SCHEMA.INNODB_SYS_TABLES when accessing corrupted record dict_load_table_low(): When flagging an error, assign *table = NULL. Failure to do so could cause a crash if an error was flagged when accessing INFORMATION_SCHEMA.INNODB_SYS_TABLES.	8 years ago
Jan Lindström	82d4f08186	Merge pull request #713 from codership/MDEV-15948 MDEV-15948 Fix error "Lost connection to MySQL server..." in test gal…	8 years ago
Marko Mäkelä	fcaf619400	Remove the "register" keyword	8 years ago
Marko Mäkelä	88b1905eda	Fix -Wimplicit-fallthrough	8 years ago
Marko Mäkelä	01b2e773ef	MDEV-15937 Assertion failure 'key->flags & 1' on ALTER TABLE While the test case crashes a MariaDB 10.2 debug build only, let us apply the fix to the earliest applicable MariaDB series (10.0) to avoid any data corruption on a table-rebuilding ALTER TABLE using ALGORITHM=INPLACE. innobase_create_key_defs(): Use altered_table->s->primary_key when a new primary key is being created.	8 years ago
Daniele Sciascia	63e5307afd	MDEV-15948 Followup commit * Increased timeout counter in galera_wait_ready.inc * Replaced useless include/wait_until_ready.inc after start_mysqld.inc in galera_st_*.inc with wait_condition on cluster size.	8 years ago
Marko Mäkelä	619dc2b24f	Fix test results after merge from 10.1	8 years ago
Thirunarayanan Balathandayuthapani	211842dd86	MDEV-15374 Server hangs and aborts with long semaphore wait or assertion `len < ((ulint) srv_page_size)' fails in trx_undo_rec_copy upon ROLLBACK on temporary table Problem: ======= InnoDB cleans all temporary undo logs during commit. During rollback of secondary index entry, InnoDB tries to build the previous version of clustered index. It leads to access of freed undo page during previous transaction commit and it leads to undo log corruption. Solution: ========= During rollback, temporary undo logs should not try to build the previous version of the record.	8 years ago
Jan Lindström	31a19683f5	Merge pull request #711 from codership/MDEV-15929 MDEV-15929 Fix lock wait timeout on `SELECT @@GLOBAL.WSREP_ON`	8 years ago
Marko Mäkelä	469a4b02ce	Fix an intermittent test failure	8 years ago
Sergei Golubchik	f2433b8dd3	MDEV-10824 - Crash in CREATE OR REPLACE TABLE t1 AS SELECT spfunc() followup for `a3c980b381` same change in Locked_tables_list::unlink_from_list(), otherwise thd->locked_tables_list will keep pointers to a free'd TABLE if prelocked under lock tables. This fixes a crash in main.create_or_replace on debug Win builds after `bcb36ee21e`	8 years ago
Marko Mäkelä	ea94717983	Merge 10.1 into 10.2	8 years ago
Sergei Golubchik	9fffa9374c	mysqltest: use do_stmt_close() not mysql_stmt_close() do_stmt_close() is embedded-aware. this fixes the failure of innodb.innodb_bug48024 --ps --embed	8 years ago
Daniele Sciascia	9e5671f1cc	MDEV-15948 Fix error "Lost connection to MySQL server..." in test galera_sst_mysqldump Test galera_sst_mysqldump often fails with error "2013: Lost connection to MySQL server during query". The connection is lost after the test restart one of the nodes. This happens because the server closes client connections if it is joining a cluster through SST method mysqldump. On unlucky runs of the test it is possible that mysqld is restarted, and then mtr client is disconnected while it tries to determine if galera is ready before going on with the test. This patch rewrites galera_wait_ready.inc so that it is immune to being disconnected.	8 years ago
Sergei Golubchik	587568b72a	Merge branch '5.5' into 10.0	8 years ago
Sergei Golubchik	bcb36ee21e	MDEV-15456 Server crashes upon adding or dropping a partition in ALTER under LOCK TABLE after ER_SAME_NAME_PARTITION ALTER TABLE ... ADD PARTITION modifies the open TABLE structure, and sets table->need_reopen=1 to reset these modifications in case of an error. But under LOCK TABLES the table isn't get reopened, despite need_reopen. Fixed by reopening need_reopen tables under LOCK TABLE.	8 years ago
Sergei Golubchik	86718fda4e	compiler warning bad merge	8 years ago
Sergei Golubchik	51c415d97d	Merge branch 'merge/merge-xtradb-5.5' into 5.5	8 years ago
Sergei Golubchik	4fd1c7e453	5.5.59-38.11	8 years ago
Sergei Golubchik	7828ba0df4	Bug#25471090: MYSQL USE AFTER FREE in a specially crafted invalid packet, one can get end_pos < pos here	8 years ago
Sergei Golubchik	149c993b2c	BUG#27216817: INNODB: FAILING ASSERTION: PREBUILT->TABLE->N_MYSQL_HANDLES_OPENED == 1 disable online alter add primary key for innodb, if the table is opened/locked more than once in the current connection (see assert in ha_innobase::add_index())	8 years ago
Sergei Golubchik	f1258e7cd2	BUG#26881798: SERVER EXITS WHEN PRIMARY KEY IN MYSQL.PROC IS DROPPED test case	8 years ago
Sergei Golubchik	1a019d0801	Merge branch 'mysql/5.5' into 5.5	8 years ago
Sergei Petrunia	0c02c91bc1	MyRocks: MDEV-15911: Reduce debug logging on default levels in error log MyRocks internally will print non-critical messages to sql_print_verbose_info() which will do what InnoDB does in similar cases: check if (global_system_variables.log_warnings > 2).	8 years ago
Sachin Setiya	efae12680e	MDEV-15611 Due to the failure of foreign key detection, Galera... slave node killed himself. Problem:- If we try to delete table with foreign key and table whom it is referring with wsrep_slave_threads>1 then galera tries to execute both Delete_rows_log-event in parallel, which should not happen. Solution:- This is happening because we do not have foreign key info in write set. Upto version 10.2.7 it used to work fine. Actually it happening because of issue in commit `2f342c4`. wsrep_must_process_fk has changed to make it similar to original condition.	8 years ago
Daniele Sciascia	3aa5f00e69	MDEV-15929 Fix lock wait timeout on `SELECT @@GLOBAL.WSREP_ON` This patch fixes a lock wait timeout error on `SELECT @@GLOBAL.WSREP_ON` in `wait_wsrep_ready.inc`: ``` --connection node_2 ... --source include/kill_galera.inc --connection node_1 --source include/wait_until_connected_again.inc # This includes wait_wsrep_ready.inc ``` The problem is that on node_2, kill_galera.inc may return before the node is killed. So node_1 may still see that node_1 is alive and will attempt to sync wait when doing those `SELECT` statements. But sync wait is doomed to fail given that node_1 is killed, hence the lock wait timeout. One possible fix is to disable wsrep_sync_wait before including wait_until_connected_again. However, it appears that including wait_until_connected_again is not necessary at all in node_1, so this patch removes it altogether.	8 years ago
Thirunarayanan Balathandayuthapani	66c14d3a8d	MDEV-14377 innodb_zip.cmp_per_index failed in buildbot, result length mismatch - If select query chooses the index 'b' over clustered index then the issue can happen. Changed the test case to use primary index for the select query.	8 years ago
Thirunarayanan Balathandayuthapani	341edddc3d	MDEV-15826 Purge attempts to free BLOB page after BEGIN;INSERT;UPDATE;ROLLBACK - During rollback, redo segments priorities over no-redo rollback segments and it leads to failure of redo rollback segment undo logs truncation.	8 years ago
Igor Babaev	1d98333ad9	MDEV-15894 Error, while using aggregated functions/window functions in anchor part Usage of aggregate/window functions in non-recursive parts of recursive CTEs is allowed. Error messages complaining about this were reported by mistake.	8 years ago
Sergei Golubchik	4f5dd1d40e	ASAN error in main.statistics_index_crash-7362 one cannot do keyread on spatial indexes.	8 years ago

1 2 3 4 5 ...

179951 Commits (e44ca6cc9c300cbdf93c64110bd8cf2be8125379) All Branches Search

179951 Commits (e44ca6cc9c300cbdf93c64110bd8cf2be8125379)

All Branches