mariadb

Tree: b393e2cb0c

Author	SHA1	Message	Date
Nikita Malyavin	b393e2cb0c	add innodb_debug_sync var to support DEBUG_SYNC from purge threads	6 years ago
Marko Mäkelä	6d7a826953	MDEV-20788: Bogus assertion failure for PAGE_FREE list In MDEV-11369 (instant ADD COLUMN) in MariaDB Server 10.3, we introduced the hidden metadata record that must be the first record in the clustered index if and only if index->is_instant() holds. To catch MDEV-19783, in commit `ed0793e096` and commit `99dc40d6ac` we added some assertions to find cases where the metadata record is missing while it should not be, or a record exists when it should not. Those assertions were invalid when traversing the PAGE_FREE list. That list can contain anything; we must only be able to determine the successor and the size of each garbage record in it. page_validate(), page_simple_validate_old(), page_simple_validate_new(): Do not invoke page_rec_get_next_const() for traversing the PAGE_FREE list, but instead use a lower-level accessor that does not attempt to validate the REC_INFO_MIN_REC_FLAG. page_copy_rec_list_end_no_locks(), page_copy_rec_list_start(), page_delete_rec_list_start(): Add assertions. btr_page_get_split_rec_to_left(): Remove a redundant return value, and make the output parameter the return value. btr_page_get_split_rec_to_right(), btr_page_split_and_insert(): Clean up.	6 years ago
Michael Widenius	726b1998fc	Fixed feedback_plugin_load to work with staticly loaded plugin	6 years ago
Marko Mäkelä	6fde0073bf	Rename log_make_checkpoint_at() to log_make_checkpoint() The function was always called with lsn=LSN_MAX. Remove that redundant parameter. Spotted by Thirunarayanan Balathandayuthapani.	6 years ago
Thirunarayanan Balathandayuthapani	c65cb244b3	MDEV-19335 Remove buf_page_t::encrypted The field buf_page_t::encrypted was added in MDEV-8588. It was made mostly redundant in MDEV-12699. Remove the field.	6 years ago
Marko Mäkelä	24232ec12c	Merge 10.1 into 10.2	6 years ago
Eugene Kosov	ed0793e096	MDEV-19783: Add more REC_INFO_MIN_REC_FLAG checks btr_cur_pessimistic_delete(): code changed in a way that allows to put more REC_INFO_MIN_REC_FLAG assertions inside btr_set_min_rec_mark(). Without that change tests innodb.innodb-table-online, innodb.temp_table_savepoint and innodb_zip.prefix_index_liftedlimit fail. Removed basically duplicated page_zip_validate() calls which fails because of temporary(!) invariant violation. That fixed innodb_zip.wl5522_debug_zip and innodb_zip.prefix_index_liftedlimit	6 years ago
Eugene Kosov	99dc40d6ac	MDEV-19783 Random crashes and corrupt data in INSTANT-added columns The bug affects MariaDB Server 10.3 or later, but it makes sense to improve CHECK TABLE in earlier versions already. page_validate(): Check REC_INFO_MIN_REC_FLAG in the records. This allows CHECK TABLE to catch more bugs.	6 years ago
Marko Mäkelä	d480d28f4f	Add page_has_prev(), page_has_next(), page_has_siblings() Until now, InnoDB inefficiently compared the aligned fields FIL_PAGE_PREV, FIL_PAGE_NEXT to the byte-order-agnostic value FIL_NULL. This is a backport of `32170f8c6d` from MariaDB Server 10.3.	6 years ago
Marko Mäkelä	d95f96ad1b	Merge 5.5 into 10.1	6 years ago
Sachin Setiya	27664ef29d	MDEV-20574 Position of events reported by mysqlbinlog is wrong with encrypted binlogs, SHOW BINLOG EVENTS reports the correct one. Analysis Mysqlbinlog output for encrypted binary log #Q> insert into tab1 values (3,'row 003') #190912 17:36:35 server id 10221 end_log_pos 980 CRC32 0x53bcb3d3 Table_map: `test`.`tab1` mapped to number 19 # at 940 #190912 17:36:35 server id 10221 end_log_pos 1026 CRC32 0xf2ae5136 Write_rows: table id 19 flags: STMT_END_F Here we can see Table_map_log_event ends at 980 but Next event starts at 940. And the reason for that is we do not send START_ENCRYPTION_EVENT to the slave Solution:- Send Start_encryption_log_event as Ignorable_log_event to slave(mysqlbinlog), So that mysqlbinlog can update its log_pos. Since Slave can request multiple FORMAT_DESCRIPTION_EVENT while master does not have so We only update slave master pos when master actually have the FORMAT_DESCRIPTION_EVENT. Similar logic should be applied for START_ENCRYPTION_EVENT. Also added the test case when new server reads the data from old server which does not send START_ENCRYPTION_EVENT to slave. Master Slave Upgrade Scenario. When Slave is updated first, Slave will have extra logic of handling START_ENCRYPTION_EVENT But master willnot be sending START_ENCRYPTION_EVENT. So there will be no issue. When Master is updated first, It will send START_ENCRYPTION_EVENT to slave , But slave will ignore this event in queue_event.	6 years ago
Marko Mäkelä	db9a4d928d	Remove orphan declaration buf_flush_wait_batch_end_wait_only() The function was declared but not defined in commit `9d6d1902e0`	6 years ago
Sergey Vojtovich	adefaeffcc	MDEV-19536 - Server crash or ASAN heap-use-after-free in is_temporary_table / read_statistics_for_tables_if_needed Regression after `279a907`, read_statistics_for_tables_if_needed() was called after open_normal_and_derived_tables() failure. Fixed by moving read_statistics_for_tables() call to a branch of get_schema_stat_record() where result of open_normal_and_derived_tables() is checked. Removed THD::force_read_stats, added read_statistics_for_tables() instead. Simplified away statistics_for_command_is_needed().	6 years ago
Oleksandr Byelkin	13535b2713	Fix problem with warnings of new compilers.	6 years ago
Eugene Kosov	5e65c67cfc	fix clang warning	6 years ago
Sergey Vojtovich	e43791d4dc	Cleanup EITS Moved EITS allocation inside read_statistics_for_tables_if_needed(). Removed redundant is_safe argument.	6 years ago
Vlad Lesin	edda2fd149	MDEV-20703: mariabackup creates binlog files in server binlog directory on --prepare --export step When "--export" mariabackup option is used, mariabackup starts the server in bootstrap mode to generate .cfg files for the certain innodb tables. The started instance of the server reads options from the file, pointed out in "--defaults-file" mariabackup option. If the server uses the same config file as mariabackup, and binlog is switched on in that config file, then "mariabackup --prepare --export" will create binary log files in the server's binary log directory, what can cause issues. The fix is to add "--skip-log-bin" in mysld options when the server is started to generate .cfg files.	6 years ago
Alexander Barkov	f203245e9e	Merge remote-tracking branch 'origin/10.1' into 10.2	6 years ago
Alexander Barkov	4bcf524482	Merge remote-tracking branch 'origin/5.5' into 10.1	6 years ago
Alexander Barkov	d481f69a7d	MDEV-20704 An index on a double column erroneously uses prefix compression	6 years ago
Robert Bindar	576a5f091e	MDEV-20647 Fix and enable SphinxSE tests	6 years ago
Marko Mäkelä	46b785262b	Fix -Wunused for CMAKE_BUILD_TYPE=RelWithDebInfo For release builds, do not declare unused variables. unpack_row(): Omit a debug-only variable from WSREP diagnostic message. create_wsrep_THD(): Fix -Wmaybe-uninitialized for the PSI_thread_key.	6 years ago
Sujatha	9b80f9300d	MDEV-20645: Replication consistency is broken as workers miss the error notification from an earlier failed group. Analysis: ======== In general if there are three groups. 1 - Inserts 32 which fails due to local entry '32' on slave. 2 - Inserts 33 3 - Inserts 34 Each group considers itself as a waiter and it waits for prior group 'waitee'. This is done in 'register_wait_for_prior_event_group_commit'. If there is no other parallel group being scheduled then no waitee will be there. Let us assume 3 groups are being scheduled in parallel. 3-> waits for 2-> waits for->1 '1' upon completion it checks is there any registered subsequent waiter. If so it wakes up the subsequent waiter with its execution status. This execution status is stored in wakeup_error. If '1' failed then it sends corresponding wakeup_error to 2. Then '2' aborts and it propagates error to '3'. So all further commits are aborted. This mechanism works only when all transactions reach a stage where they are waiting for their prior commit to complete. In case of optimistic following scenario occurs. 1,2,3 are scheduled in parallel. 3 - Reaches group_commit_code waits for 2 to complete. 1 - errors out sets stop_on_error_sub_id=1. When a group execution results in error its corresponding sub_id is set to 'stop_on_error_sub_id'. Any new groups queued for execution will check if their sub_id is > stop_on_error_sub_id. If it is true their execution will be skipped as prior group execution failed. 'skip_event_group=1' will be set. Since the execution of SQL thread is about to stop we just skip execution of all the following event groups. We still do all the normal waiting and wakeup processing between the event groups as a simple way to ensure that everything is stopped and cleaned up correctly. Upon error '1' transaction checks for registered waiters. Since no one is there it simply goes away. 2 - Starts the execution. It checks do I have a waitee. Since wait_commit_sub_id == entry->last_committed_sub_id no waitee is set. Secondly: 'entry->stop_on_error_sub_id' is set by '1'st execution. Now 'handle_parallel_thread' code checks if the current group 'sub_id' is greater than the 'sub_id' set within 'stop_on_error_sub_id'. Since the above is true 'skip_event_group=true' is set. Simply call 'wait_for_prior_commit' to wakeup all waiters. Group '2' didn't had any waitee and its execution is skipped. Hence its wakeup_error=0.It sends a positive wakeup signal to '3'. Which commits. This results in a missed transaction. i.e 33 is missed and 34 is committed. Fix: === When a worker learns that an earlier transaction execution has failed, and it should not proceed for further execution, it should mark its own execution status as failed so that it alerts its followers to abort as well.	6 years ago
Julius Goryavsky	bc70862e13	MDEV-20614: Syntax error, and option put in wrong place A syntax error in the mysqld_multi.sh script has been fixed here + a "--defaults-group-suffix" option has been moved to the top of the mysqld options list.	6 years ago
Thirunarayanan Balathandayuthapani	c76873f23d	MDEV-20688 Recovery crashes after unnecessarily reading a corrupted page The test encryption.innodb-redo-badkey was accidentally disabled until commit `23657a2101` enabled it recently. Once it was enabled, it started failing randomly. recv_recover_corrupt_page(): Do not assume that any redo log exists for the page. A page may be unnecessarily read by read-ahead. When noting the corruption, reset recv_addr->state to RECV_PROCESSED, so that even if the same page is re-read again, we will only decrement recv_sys->n_addrs once.	6 years ago
Marko Mäkelä	d874cdeccc	dict_load_table(): Remove constant parameter cached=true Spotted by Thirunarayanan Balathandayuthapani.	6 years ago
Marko Mäkelä	718fcee0a3	Reduce rw_lock_debug_mutex contention rw_lock_own(), rw_lock_own_flagged(): Traverse the rw_lock_t::debug_list only after quickly checking if the thread is holding X-latch or SX-latch.	6 years ago
Sergei Golubchik	677cc64428	chkconfig in RPM server scriptlets chkconfig --add and --del [might] invoke /sbin/insserv and even if chkconfig exists, insserv might not (SLES15). Ignore chkconfig --del errors - it's a "best effort" cleanup anyway	6 years ago
Marko Mäkelä	4ec0c346b8	Remove a useless large test, and add a debug assertion The test innodb_fts.fulltext_table_evict was only creating 1000 tables with fulltext indexes, only to check that no tables with fulltext indexes are being evicted. The reason why tables containing fulltext indexes cannot be evicted is that fts_optimize_init() invokes dict_table_prevent_eviction().	6 years ago
Marko Mäkelä	ca9e0089d5	MDEV-19740: Fix GCC 9.2.1 -Wmaybe-uninitialized on AMD64 For CMAKE_BUILD_TYPE=Debug, the default MYSQL_MAINTAINER_MODE=AUTO implies -Werror along with other flags in cmake/maintainer.cmake, which would break the debug builds when CMAKE_CXX_FLAGS include -O2. This fix includes a backport of `6dd3f24090` from MariaDB 10.3.	6 years ago
Marko Mäkelä	2d6719d7ee	MDEV-19514 preparation: Extend innodb.innodb-change-buffer-recovery Test innodb_read_only startup (which will be refused after a crash), and test also innodb_force_recovery=5, and extract some change buffer merge statistics. Omit any statistics about delete (purge) buffering, because purge could happen at any time. Use the sequence storage engine for populating the table.	6 years ago
Marko Mäkelä	23d675453f	MDEV-20675 Crash in SHOW ENGINE INNODB STATUS with innodb_force_recovery=5 Add a test case. MariaDB Server 10.2 is not affected.	6 years ago
Marko Mäkelä	574ff87f2a	Merge 10.1 into 10.2	6 years ago
Julius Goryavsky	144217339d	MDEV-20614: Syntax error, and option put in wrong place A syntax error in the mysqld_multi.sh script has been fixed here + a "--defaults-group-suffix" option has been moved to the top of the mysqld options list.	6 years ago
Marko Mäkelä	516f7c111b	Speed up main.sum_distinct-big Eliminate one InnoDB table with 128*16384 rows, and use the sequence engine instead. Also, run everything in a single transaction, to prevent purge from running concurrently unnecessarily. (Starting with MariaDB Server 10.3, purge would reset the DB_TRX_ID after INSERT.)	6 years ago
Alexander Barkov	102bc7beb0	Fixing tests according to MDEV-20655 maturity stable for user_variables	6 years ago
Alexander Barkov	0a359d7627	Merge remote-tracking branch 'origin/10.1' into 10.2	6 years ago
Rasmus Johansson	fa9e012a34	MDEV-20655 maturity stable for user_variables	6 years ago
Marko Mäkelä	ef701bfd07	Remove the unused function btr_page_get() btr_block_get(): Remove #ifdef around the definition	6 years ago
Alexander Barkov	5f118b26c8	Merge remote-tracking branch 'origin/5.5' into 10.1	6 years ago
Alexander Barkov	67b0faa29e	MDEV-20495 Assertion `precision > 0' failed in decimal_bin_size upon CREATE .. SELECT with zerofilled decimal Also fixes: MDEV-20560 Assertion `precision > 0' failed in decimal_bin_size upon SELECT with MOD short unsigned decimal Changing the way how Item_func_mod calculates its max_length. It now uses decimal_precision(), decimal_scale() and unsigned_flag of its arguments, like all other Item_num_op descendants do.	6 years ago
Varun Gupta	ab9f378b0b	Backporting `273d8eb12c` Proper fix for disabling warnings in read_statistics_for_table()	6 years ago
Marko Mäkelä	2931fd2917	After-merge fix: Adjust a result	6 years ago
Marko Mäkelä	60cb5559a9	MDEV-17614 post-fix: Remove dead dup_chk_only=true code. The parameter dup_chk_only was always passed as a constant false. Remove the parameter and the dead code related to it.	6 years ago
Marko Mäkelä	44c5144943	Merge 10.1 into 10.2	6 years ago
Varun Gupta	896974fc3d	MDEV-18094: Query with order by limit picking index scan over filesort In the function test_if_cheaper_ordering we make a decision if using an index is better than using filesort for ordering. If we chose to do range access then in test_quick_select we should make sure that cost for table scan is set to DBL_MAX so that it is not picked.	6 years ago
Christian Hesse	7a4019a1c7	MDEV-19207 systemd service: add instance name in description The unit files made systemd print: systemd[1]: Started MariaDB 10.3.13 database server (multi-instance). Let's add the instance name, so starting mariadb@foo.service makes it print: systemd[1]: Started MariaDB 10.3.13 database server (multi-instance foo).	7 years ago
rantal	fd3ad41eed	Update mysqld_safe.sh - introduce defaults-group-suffix handling "--defaults-group-suffix" must be be given as the first argument on the command-line of mysqld	6 years ago
Vicențiu Ciorbaru	6a7d51b1cb	MDEV-19211 Fix mysqld_safe --dry-run mysqld_safe --dry-run needs to either call exit or return, depending if it is being sourced or not, otherise return can lead to the error: return: can only `return' from a function or sourced script The original fix suggestion was proposed by FaramosCZ <mschorm@centrum.cz>	6 years ago
chriscalender	13274032af	MDEV-4968 Old advices in mysql-log-rotate script * Change the comments in mysql-log-rotate.sh to refer to mysqld, not mysqld_safe as that's what most distros are using. * Change err-log to log-error as err-log is no longer valid. * Convert tab to space for consistency.	7 years ago

1 2 3 4 5 ...

182768 Commits (b393e2cb0c079b30563dcc87a62002c9c778643c) All Branches Search

182768 Commits (b393e2cb0c079b30563dcc87a62002c9c778643c)

All Branches