mariadb

Tree: b101f19d29

Author	SHA1	Message	Date
Marko Mäkelä	b101f19d29	MDEV-23974 fixup: rpl.rpl_gtid_stop_start fails The call mtr.add_suppression() that was added in commit `75b7cd680b` for MemorySanitizer and Valgrind runs is causing a result difference for the test rpl.rpl_gtid_stop_start. Let us disable the binlog for executing that statement. Also, the test perfschema.statement_program_lost_inst would fail due to the changes to have_innodb.inc in this commit. To compensate for that, we will make more --suite=perfschema tests run without InnoDB, and explicitly enable InnoDB in those tests that depend on a transactional storage engine.	4 years ago
Sergei Golubchik	d2c019b200	MDEV-28107 S3 doesn't build if CURL is in non-default location	4 years ago
Sergei Golubchik	2ca3861b55	MDEV-28106 S3 tries to include thread.h while compiling on Windows S3 engine and libmarias3 don't compile on Windows also fixes: MDEV-28104 Typo in storage/maria/s3_func.c: 'FN_DECVHAR	4 years ago
Marko Mäkelä	75b7cd680b	MDEV-23974 Tests fail due to [Warning] InnoDB: Trying to delete tablespace A few regression tests invoke heavy flushing of the buffer pool and may trigger warnings that tablespaces could not be deleted because of pending writes. Those warnings are to be expected during the execution of such tests. The warnings are also frequently seen with Valgrind or MemorySanitizer. For those, the global suppression in have_innodb.inc does the trick.	4 years ago
Marko Mäkelä	44231dc6d5	Cleanup: have_sanitizer='ASAN,UBSAN' This was suggested by Sergei Golubhick. Fixes up commit `b91a123d8c`	4 years ago
Otto Kekäläinen	9595ea8992	Deb: Sync Salsa-CI from Debian MariaDB 10.5 repository Since Debian Sid now has MariaDB 10.6, we can't do any upgrade tests in Debian Sid for the 10.5 branch anymore. It would just fail with downgrade errors. Also, since MariaDB 10.5 is no longer in Sid, we can't even test 10.5.x to 10.5.y upgrades in Sid. Instead the 10.5 branch salsa-ci.yml should run all builds and tests based on Debian Bullseye, which has MariaDB 10.5 (only). To achieve this, essentially sync most the the salsa-ci.yml contents from https://salsa.debian.org/mariadb-team/mariadb-10.5/-/tree/bullseye Also add a couple Lintian overrides to make Salsa-CI pass. NOTE TO MERGERS: This commit is intended for the 10.5 branch only, do not merge anything from it on 10.6 or any other branch.	4 years ago
Marko Mäkelä	06e3bc4390	MDEV-17841 fixup: GCC -Wmaybe-uninitialized In commit `ab38b7511b` an added "goto err" would seemingly cause a read of an uninitialized variable old_info if errpos>=5. However, because we would have errpos=0 at that point, there was no real error.	4 years ago
Daniel Black	b73d852779	Merge 10.4 to 10.5	4 years ago
Daniel Black	069139a549	Merge 10.3 to 10.4 extra2_read_len resolved by keeping the implementation in sql/table.cc by exposed it for use by ha_partition.cc Remove identical implementation in unireg.h (ref: `bfed2c7d57`)	4 years ago
Daniel Black	6a2d88c132	Merge 10.2 to 10.3	4 years ago
Alexander Barkov	0e63023cb8	Merge branch 10.2 into 10.3	4 years ago
Daniel Black	57dbe8785d	MDEV-23915 ER_KILL_DENIED_ERROR not passed a thread id (part 2) Per Marko's comment in JIRA, sql_kill is passing the thread id as long long. We change the format of the error messages to match, and cast the thread id to long long in sql_kill_user.	4 years ago
Daniel Black	99837c61a6	MDEV-23915 ER_KILL_DENIED_ERROR not passed a thread id The 10.5 test error main.grant_kill showed up a incorrect thread id on a big endian architecture. The cause of this is the sql_kill_user function assumed the error was ER_OUT_OF_RESOURCES, when the the actual error was ER_KILL_DENIED_ERROR. ER_KILL_DENIED_ERROR as an error message requires a thread id to be passed as unsigned long, however a user/host was passed. ER_OUT_OF_RESOURCES doesn't even take a user/host, despite the optimistic comment. We remove this being passed as an argument to the function so that when MDEV-21978 is implemented one less compiler format warning is generated (which would have caught this error sooner). Thanks Otto for reporting and Marko for analysis.	4 years ago
Marko Mäkelä	73fee39ea6	MDEV-27985 buf_flush_freed_pages() causes InnoDB to hang buf_flush_freed_pages(): Assert that neither buf_pool.mutex nor buf_pool.flush_list_mutex are held. Simplify the loops. Return the tablespace and the number of pages written or punched. buf_flush_LRU_list_batch(), buf_do_flush_list_batch(): Release buf_pool.mutex before invoking buf_flush_space(). buf_flush_list_space(): Acquire the mutexes only after invoking buf_flush_freed_pages(). Reviewed by: Thirunarayanan Balathandayuthapani	4 years ago
Marko Mäkelä	00896db1c5	MDEV-25214 Crash in fil_space_t::try_to_close fil_space_t::try_to_close(): Tolerate a tablespace that has no data files attached. The function fil_ibd_create() initially creates and attaches a tablespace with no files, and invokes fil_space_t::add() later. fil_node_open_file(): After releasing and reacquiring fil_system.mutex, check if the file was already opened by another thread. This avoids an assertion failure !node->is_open() in fil_node_open_file_low(). These failures were reproduced with the test innodb.table_definition_cache_debug and the fix of MDEV-27985.	4 years ago
Marko Mäkelä	e1246775a9	Merge 10.4 into 10.5	4 years ago
Marko Mäkelä	9c6135e81f	Merge 10.3 into 10.4	4 years ago
Daniel Black	a950086036	Merge 10.2 (part) into 10.3 commit '6de482a6fefac0c21daf33ed465644151cdf879f' 10.3 no longer errors in truncate_notembedded.test but per comments, a non-crash is all that we are after.	4 years ago
Thirunarayanan Balathandayuthapani	1c43660aea	MDEV-28060 Online DDL fails while checking for instant alter condition - InnoDB fails to skip newly created column while checking for change column when table is in redundant row format. This issue is caused the MDEV-18035 (`ccb1acbd3c`)	4 years ago
Alexander Barkov	03c3dc6365	MDEV-23210 Assertion `(length % 4) == 0' failed in my_lengthsp_utf32 on ALTER TABLE, SELECT and INSERT Problem: Parse-time conversion from binary to tricky character sets like utf32 produced ill-formed strings. So, later a chash happened in debug builds, or a wrong SHOW CREATE TABLE was returned in release builds. Fix: 1. Backporting a few methods from 10.3: - THD::check_string_for_wellformedness() - THD::convert_string() overloads - THD::make_text_string_connection() 2. Adding a new method THD::reinterpret_string_from_binary(), which makes sure to either returns a well-formed string (optionally prepending with zero bytes), or returns an error.	4 years ago
Marko Mäkelä	258c34f17c	MDEV-28050: clang -Wtypedef-redefinition when PLUGIN_S3=NO Let us remove the redundant typedef. This problem was revealed by commit `77c184df7c`	4 years ago
Marko Mäkelä	c2146ce774	MDEV-24841: More workarounds For some reason, the tests of the MemorySanitizer build on 10.5 failed with both clang 13 and clang 14 with SIGSEGV. On 10.6 where it worked better, some more places to work around were identified.	4 years ago
Sergei Golubchik	f217c76189	mtr: fix --source lines detection mysqltest allows leading spaces before `--`, so mtr should too	4 years ago
Sergei Golubchik	bfed2c7d57	MDEV-27753 Incorrect ENGINE type of table after crash for CONNECT table whenever possible, partitioning should use the full partition plugin name, not the one byte legacy code. Normally, ha_partition can get the engine plugin from table_share->default_part_plugin. But in some cases, e.g. in DROP TABLE, the table isn't opened, table_share is NULL, and ha_partition has to parse the frm, much like dd_frm_type() does. temporary_tables.cc, sql_table.cc: When dropping a table, it must be deleted in the engine first, then frm file. Because frm can be the only true source of metadata that the engine might need for DROP. table.cc: when opening a partitioned table, if the engine for partitions is not found, do not fallback to MyISAM.	4 years ago
Marko Mäkelä	59359fb44a	MDEV-24841 Build error with MSAN use-of-uninitialized-value in comp_err The MemorySanitizer implementation in clang includes some built-in instrumentation (interceptors) for GNU libc. In GNU libc 2.33, the interface to the stat() family of functions was changed. Until the MemorySanitizer interceptors are adjusted, any MSAN code builds will act as if that the stat() family of functions failed to initialize the struct stat. A fix was applied in https://reviews.llvm.org/rG4e1a6c07052b466a2a1cd0c3ff150e4e89a6d87a but it fails to cover the 64-bit variants of the calls. For now, let us work around the MemorySanitizer bug by defining and using the macro MSAN_STAT_WORKAROUND().	4 years ago
Elena Stepanova	ed6e271f78	MDEV-28036 gcol.gcol_supported_sql_funcs_xxx fail in FIPS mode	4 years ago
Sergei Golubchik	6789f2cfab	MDEV-18304 sql_safe_updates does not work with OR clauses not every index-using plan sets bits in table->quick_keys. QUICK_ROR_INTERSECT_SELECT, for example, doesn't. Use the fact that select->quick is set instead. Also allow EXPLAIN to work.	4 years ago
Daniel Black	d78173828e	MDEV-27900: aio handle partial reads/writes As btrfs showed, a partial read of data in AIO /O_DIRECT circumstances can really confuse MariaDB. Filipe Manana (SuSE)[1] showed how database programmers can assume O_DIRECT is all or nothing. While a fix was done in the kernel side, we can do better in our code by requesting that the rest of the block be read/written synchronously if we do only get a partial read/write. Per the APIs, a partial read/write can occur before an error, so reattempting the request will leave the caller with a concrete error to handle. [1] https://lore.kernel.org/linux-btrfs/CABVffENfbsC6HjGbskRZGR2NvxbnQi17gAuW65eOM+QRzsr8Bg@mail.gmail.com/T/#mb2738e675e48e0e0778a2e8d1537dec5ec0d3d3a Also spell synchronously correctly in other files.	4 years ago
Marko Mäkelä	dc680d2119	Avoid shutdown timeout in innodb.undo_truncate Let us explicitly wait for purge before invoking a slow shutdown, so that instrumented builds (such as ASAN or UBSAN) will not exceed the 60-second timeout during shutdown.	4 years ago
Marko Mäkelä	4cfb6eddcd	Merge 10.4 into 10.5	4 years ago
Marko Mäkelä	8afabca6fd	MDEV-19577 fixup: galera.galera_binlog_stmt_autoinc	4 years ago
Marko Mäkelä	97d82808b8	Fix clang -Wtypedef-redefinition This fixes commit `77c184df7c`.	4 years ago
Marko Mäkelä	9047a908fe	Merge 10.4 into 10.5	4 years ago
Marko Mäkelä	fc8da65919	After-merge fix: clang -Winconsistent-missing-override The virtual member function that was added in commit `1766a18e06` needs to be declared "override".	4 years ago
Marko Mäkelä	5503c40460	Stabilize innodb.redo_log_during_checkpoint Externally kill and restart the server, and remove the unreliable crash_after_checkpoint.	4 years ago
Marko Mäkelä	81523baac6	Merge 10.4 into 10.5	4 years ago
Marko Mäkelä	22d2df8c6b	Merge 10.3 into 10.4	4 years ago
Marko Mäkelä	77c184df7c	Explicitly specify that we use the C99 dialect	4 years ago
Vlad Lesin	1766a18e06	MDEV-19577 Replication does not work with innodb_autoinc_lock_mode=2 The first step for deprecating innodb_autoinc_lock_mode(see MDEV-27844) is: - to switch statement binlog format to ROW if binlog format is MIXED and the statement changes autoincremented fields - issue warnings if innodb_autoinc_lock_mode == 2 and binlog format is STATEMENT	4 years ago
Andrei	e7cf871dda	MDEV-24617 OPTIMIZE on a sequence causes unexpected ER_BINLOG_UNSAFE_STATEMENT The warning out of OPTIMIZE Statement is unsafe because it uses a system function was indeed counterfactual and was resulted by checking an insufficiently strict property of lex' sql_command_flags. Fixed with deploying an additional checking of weather the current sql command that modifes a share->non_determinstic_insert table is capable of generating ROW format events. The extra check rules out the unsafety to OPTIMIZE et al, while the existing check continues to do so to CREATE TABLE (which is perculiarly tagged as ROW-event generative sql command). As a side effect sql_sequence.binlog test gets corrected and binlog_stm_unsafe_warning.test is reinforced to add up an unsafe CREATE..SELECT test.	4 years ago
Daniel Black	6de482a6fe	MDEV-28011: debian autobake cleanup Travis is dead to us so we don't need all the conditions around it. Remove depends for no longer supported versions Debian Jessies, and Ubuntu Trusty, Xenial, Wily are all eol as far as we are concerned. The dependancy on an apt cache when running autobake broke the 10.2 aarch64 packages (MDEV-28014). Lets reduce the risk here.	4 years ago
Daniel Black	8ea08505a1	MDEV-28022: Debian stretch has zstd too old zstd-1.1.3 is needed however stretch has only 1.1.2. Move to distro version based checks as checks against the apt-cache are unreliable if there is no cache.	4 years ago
Haidong Ji	114476f2ec	MDEV-27978 fix wrong name in error when max_session_mem_used exceeded Fixed typo in my_malloc_size_cb_func. There is no max-thread-mem-used sys variable in MariaDB, only max-session-mem-used. The relevant entry in sys_vars.cc is also fixed. Added a fallback case in case we could allocate the 256 bytes for the error message containing the exact setting.	4 years ago
Vlad Lesin	0b92c7b0e0	Merge 10.4 into 10.5	4 years ago
Vlad Lesin	1ec3205703	Merge 10.3 into 10.4	4 years ago
Vlad Lesin	86c1bf118a	MDEV-27992 DELETE fails to delete record after blocking is released MDEV-27025 allows to insert records before the record on which DELETE is locked, as a result the DELETE misses those records, what causes serious ACID violation. Revert MDEV-27025, MDEV-27550. The test which shows the scenario of ACID violation is added.	4 years ago
Marko Mäkelä	2dce3bad9c	Merge 10.4 into 10.5	4 years ago
Marko Mäkelä	7b97020d40	Merge 10.3 into 10.4	4 years ago
Julius Goryavsky	5172f132bf	galera_3nodes.galera_2_cluster: the test is temporarily disabled	4 years ago
Marko Mäkelä	02da00a98c	Merge 10.2 into 10.3	4 years ago

1 2 3 4 5 ...

193688 Commits (b101f19d2936ca0e9081ece8ec5d3b40c3bc27ad) All Branches Search

193688 Commits (b101f19d2936ca0e9081ece8ec5d3b40c3bc27ad)

All Branches