mariadb

Tree: aed761ced5

Author	SHA1	Message	Date
Marko Mäkelä	aed761ced5	WIP: MDEV-17603 REPLACE and INSERT…ON DUPLICATE KEY UPDATE are deadlock-prone Implement an alternative fix for the bug whose original fix mysql/mysql-server@c93b0d9a972cb6f98fd445f2b69d924350f9128a in MySQL 5.7.4 caused problems. This is based on mysql/mysql-server@e0e4bacddf421550baca3578bc0db13693874fdb in MySQL 5.7.26. When performing a rollback to the start of the current row operation in REPLACE or INSERT...ON DUPLICATE KEY UPDATE we were not maintaining serializability, because we would release implicit locks that could already have been acquired for some of the indexes. lock_rec_convert_impl_to_expl_for_trx(): Declare globally. undo_node_t::convert_impl_to_expl(): Convert an implicit lock to an explicit one during a partial rollback. row_insert_for_mysql(): Set trx->duplicates=ULINT_UNDEFINED for rolling back the current row operation. This will allow undo_node_t::convert_impl_to_expl() to be effective only for this use case, not for other scenarios, such as rolling back to the start of the statement, or ROLLBACK TO SAVEPOINT. FIXME: Neither innodb.auto_increment_dup,log-bin nor the upstream fix (which we did not add) innodb.iodku pass. While the undo_node_t::convert_impl_to_expl() is working as intended, what happens in innodb.auto_increment_dup,log-bin is that the newly created explicit record lock for the record heap number 6 on the PRIMARY key root page (3) will be released when that record is deleted moments later, with the following stack trace: lock_rec_reset_nth_bit lock_rec_reset_and_release_wait_low lock_rec_reset_and_release_wait lock_update_delete btr_cur_optimistic_delete_func row_undo_ins_remove_clust_rec row_undo_ins row_undo row_undo_step que_thr_step que_run_threads_low que_run_threads trx_rollback_to_savepoint_low trx_rollback_to_savepoint row_mysql_handle_errors row_insert_for_mysql The idea might work with predicate locks, which we do not have. This entire scenario could also be fixed by MDEV-16232, which could allow the entire operation to be protected with page latches.	7 years ago
Marko Mäkelä	762663d89e	MDEV-17603 preparation: Revert MDEV-17073 and the upstream change The test innodb.auto_increment_dup,log-bin will cease to produce the expected locking conflict; hence we disable the test.	7 years ago
Marko Mäkelä	1a5ba2a4be	MDEV-19342 Merge new release of InnoDB 5.7.26 to 10.2	7 years ago
Marko Mäkelä	4e9f8c9cc4	Remove roll_node_t::partial The field roll_node_t::partial holds if and only if savept has been set. Make savept a pointer. trx_rollback_start(): Use the semantic type undo_no_t for roll_limit.	7 years ago
Aditya A	f3a9f12bc3	Bug #29021730 CRASHING INNOBASE_COL_CHECK_FK WITH FOREIGN KEYS PROBLEM ------- Function innodb_base_col_setup_for_stored() was skipping to store the base column information for a generated column if the base column was a "STORED" generated column. This later causes a crash in function innoabse_col_check_fk() where it says that a generated columns depends upon two base columns ,but there is information on only one of them. There was a explicit check barring the stored columns being stored, which is wrong because the documentation says that a generated stored column can be a part of a generated column. FIX ---- Store the information of base column if it is a stored generated column. #RB21247 Reviewed by: Debarun Banerjee <debarun.banerjee@oracle.com>	7 years ago
Marko Mäkelä	793bd3ee13	lock_rec_convert_impl_to_expl_for_trx(): Remove unused parameter	7 years ago
Marko Mäkelä	c795a9f3fe	MDEV-12004: Add the Bug#28825718 test case Adapt the test case from mysql/mysql-server@2bbbcddd903626c84c610dd2ed82cc22ee4d6cde (MySQL 5.7.26).	7 years ago
Sachin Agarwal	06ec56f579	Bug #27850600 INNODB ASYNC IO ERROR HANDLING IN IO_EVENT Problem: io_getevents() - read asynchronous I/O events from the completion queue. For each IO event, the res field in io_event tells whether IO event is succeeded or not. To see if the IO actually succeeded we always need to check event.res (negative=error, positive=bytesread/written). LinuxAIOHandler::collect() doesn't check event.res value for each event. which leads to incorrect value in n_bytes for IO context (or IO Slot). Fix: Added a check for event.res negative value. RB: 20871 Reviewed by : annamalai.gurusami@oracle.com	7 years ago
Marko Mäkelä	1c4d1f3d05	innobase_col_check_fk(): Remove copying	7 years ago
Alexander Barkov	5cfc7799a3	MDEV-16518 MYSQL57_GENERATED_FIELD: The code in TABLE_SHARE::init_from_binary_frm_image() is not safe	7 years ago
Sujatha Sivakumar	9a5a86f293	MDEV-17260: Memory leaks in mysqlbinlog Problem: ======== The mysqlbinlog tool is leaking memory, causing failures in various tests when compiling and testing with AddressSanitizer or LeakSanitizer like this: cmake -DCMAKE_BUILD_TYPE=Debug -DWITH_ASAN:BOOL=ON /path/to/source make -j$(nproc) cd mysql-test ASAN_OPTIONS=abort_on_error=1 ./mtr --parallel=auto Analysis: ========= Two types of leaks were observed during above execution. 1) Leak in Log_event::read_log_event(char const, unsigned int, char const, Format_description_log_event const, char) File: sql/log_event.cc:2150 For all row based replication events the memory which is allocated during read_log_event is not freed after the event is processed. The event specific memory has to be retained only when flashback option is enabled with mysqlbinlog tool. In this case all the events are retained till the end statement is received and they are processed in reverse order and they are destroyed. But in the existing code all events are retained irrespective of flashback mode. Hence the memory leaks are observed. 2) read_remote_annotate_event(unsigned char, unsigned long, char const) File: client/mysqlbinlog.cc:194 In general the Annotate event is not printed immediately because all subsequent rbr-events can be filtered away. Instead it will be printed together with the first not filtered away Table map or the last rbr will be processed. While reading remote annotate events memory is allocated for event buffer and event's temp_buf is made to point to the allocated buffer as shown below. The TRUE flag is used for doing proper cleanup using free_temp_buf(). i.e at the time of deletion of annotate event its destructor takes care of clearing the temp_buf. / Ensure the event->temp_buf is pointing to the allocated buffer. (TRUE = free temp_buf on the event deletion) / event->register_temp_buf((char)event_buf, TRUE); But existing code does the following when it receives a remote annotate_event. if (remote_opt) ev->temp_buf= 0; That is code immediately sets temp_buf=0, because of which free_temp_buf() call will return empty handed as it has lost the reference to the allocated temporary buffer. This results in memory leak Fix: ==== 1) If not in flashback mode, destroy the memory for events once they are processed. 2) Remove the ev->temp_buf=0 code for remote option. Let the proper cleanup to be done as part of free_temp_buf().	7 years ago
Oleksandr Byelkin	4e01bc8c96	MDEV-16240: Assertion `0' failed in row_sel_convert_mysql_key_to_innobase Set table in row ID position mode before using this function.	7 years ago
Oleksandr Byelkin	3dffdee667	MDEV-17036: BULK with replace doesn't take the first parameter in account INSERT and REPLACE served by the same function, so flags (and processing) should be the same.	7 years ago
Marko Mäkelä	b2dbc781c7	Implement --debug=d,ib_log_checkpoint_avoid Normally, the InnoDB master thread executes InnoDB log checkpoints so frequently that bugs in crash recovery or redo logging can be hard to reproduce. This is because crash recovery would start replaying the log only from the latest checkpoint. Because the InnoDB redo log format only allows saving information for at most 2 latest checkpoints, and because the log files are written in a circular fashion, it would be challenging to implement a debug option that would start the redo log apply from the very start of the redo log file.	7 years ago
Eugene Kosov	6c5c1f0b2f	MDEV-19231 make DB_SUCCESS equal to 0 It's a micro optimization. On most platforms CPUs has instructions to compare with 0 fast. DB_SUCCESS is the most popular outcome of functions and this patch optimized code like (err == DB_SUCCESS) BtrBulk::finish(): bogus assertion fixed fil_node_t::read_page0(): corrected usage of os_file_read() que_eval_sql(): bugus assertion removed. Apparently it checked that the field was assigned after having been zero-initialized at object creation. It turns out that the return type of os_file_read_func() was changed in mysql/mysql-server@98909cefbc37e54efc6452c7e95bccbf64ac9213 (MySQL 5.7) from ibool to dberr_t. The reviewer (if there was any) failed to point out that because of future merges, it could be a bad idea to change the return type of a function without changing the function name. This change was applied to MariaDB 10.2.2 in commit `2e814d4702` but the MariaDB-specific code was not fully adjusted accordingly, e.g. in fil_node_open_file(). Essentially, code like !os_file_read(...) became dead code in MariaDB and later in Mariabackup 10.2, and we could be dealing with an uninitialized buffer after a failed page read.	7 years ago
Marko Mäkelä	bc145193c1	Merge 10.1 into 10.2	7 years ago
Marko Mäkelä	bfb0726fc2	Merge 5.5 into 10.1	7 years ago
Thirunarayanan Balathandayuthapani	d5da8ae04d	MDEV-15772 Potential list overrun during XA recovery InnoDB could return the same list again and again if the buffer passed to trx_recover_for_mysql() is smaller than the number of transactions that InnoDB recovered in XA PREPARE state. We introduce the transaction state TRX_PREPARED_RECOVERED, which is like TRX_PREPARED, but will be set during trx_recover_for_mysql() so that each transaction will only be returned once. Because init_server_components() is invoking ha_recover() twice, we must reset the state of the transactions back to TRX_PREPARED after returning the complete list, so that repeated traversals will see the complete list again, instead of seeing an empty list. Without this tweak, the test main.tc_heuristic_recover would hang in MariaDB 10.1.	7 years ago
Varun Gupta	1f1a61cfc4	MDEV-15837: Assertion `item1->type() == Item::FIELD_ITEM && item2->type() == Item::FIELD_ITEM' failed in compare_order_elements function The issue here is the function compare_order_lists() is called for the order by list of the window functions so that those window function that can be computed together are adjacent. So in the function compare_order_list we iterate over all the elements in the order list of the two functions and compare the items in their order by clause. The function compare_order_elements() is called for each item in the order by clause. This function assumes that all the items that are in the order by list would be of the type Item::FIELD_ITEM. The case we have is that we have constants in the order by clause. We should ignore the constant and only compare items of the type Item::FIELD_ITEM in compare_order_elements()	7 years ago
Sujatha Sivakumar	cb8d888c42	MDEV-17260: Memory leaks in mysqlbinlog Problem: ======== The mysqlbinlog tool is leaking memory, causing failures in various tests when compiling and testing with AddressSanitizer or LeakSanitizer like this: cmake -DCMAKE_BUILD_TYPE=Debug -DWITH_ASAN:BOOL=ON /path/to/source make -j$(nproc) cd mysql-test ASAN_OPTIONS=abort_on_error=1 ./mtr --parallel=auto rpl.rpl_row_mysqlbinlog CURRENT_TEST: rpl.rpl_row_mysqlbinlog Direct leak of 112 byte(s) in 1 object(s) allocated from: #0 0x4eff87 in __interceptor_malloc (/dev/shm/5.5/client/mysqlbinlog+0x4eff87) #1 0x60eaab in my_malloc /mariadb/5.5/mysys/my_malloc.c:41:10 #2 0x5300dd in Log_event::read_log_event(char const, unsigned int, char const, Format_description_log_event const, char) /mariadb/5.5/sql/log_event.cc:1568: #3 0x564a9c in dump_remote_log_entries(st_print_event_info, char const) /mariadb/5.5/client/mysqlbinlog.cc:1978:17 Analysis: ======== 'mysqlbinlog' tool is being used to read binary log events from a remote server. While reading binary log, if a fake rotate event is found following actions are taken. If 'to-last-log' option is specified, then fake rotate event is processed. In the absence of 'to-last-log' skip the fake rotate event. In this skipped case the fake rotate event object is not getting cleaned up resulting in memory leak. Fix: === Cleanup the fake rotate event. This issues is already fixed in MariaDB 10.0.23 and higher versions as part of commit `c3018b0ff4`	7 years ago
Igor Babaev	5fc8dd8b82	MDEV-17796 WHERE filter is ignored by DISTINCT IFNULL(GROUP_CONCAT(X), Y) with GROUP BY + ORDER BY The method JOIN::create_postjoin_aggr_table() should not call call JOIN::add_sorting_to_table() unless the first non-constant join table is passed as the first parameter to the method.	7 years ago
Marko Mäkelä	e5aa8ea525	MDEV-18139 ALTER IGNORE ... ADD FOREIGN KEY causes bogus error dict_create_foreign_constraints_low(): Tolerate the keywords IGNORE and ONLINE between the keywords ALTER and TABLE. We should really remove the hacky FOREIGN KEY constraint parser from InnoDB.	7 years ago
Marko Mäkelä	38b6dc5a3d	Fix the linking of async_example	7 years ago
Vladislav Vaintroub	6b5d3c51b3	Do fast exit with error code and FATAL ERROR message, if innodb cannot start during prepare. Otherwise, it is possible for "prepare" to exit with error code 0, even if it did not work at all.	7 years ago
Alexander Barkov	9dcfd6be94	MDEV-9465 The constructor StringBuffer(const char str, size_t length, const CHARSET_INFO cs) looks suspicious Removing the suspicious constructor, it's not used in the code anyway.	7 years ago
Igor Babaev	279a907fd0	MDEV-17605 Statistics for InnoDB table is wrong if persistent statistics is used The command SHOW INDEXES ignored setting of the system variable use_stat_tables to the value of 'preferably' and and showed statistical data received from the engine. Similarly queries over the table STATISTICS from INFORMATION_SCHEMA ignored this setting. It happened because the function fill_schema_table_by_open() did not read any data from statistical tables.	7 years ago
Alexey Botchkov	a4f7d85932	MDEV-18920 Prepared statements with st_convexhull hang and eat 100% cpu. In the case of error when object shapes are half-collected we need to set the NULL at the vertice's list.	7 years ago
Alexander Barkov	6c5e4c9bc0	Fixing -Werror=format-overflow errors (found by gcc-8.3.1)	7 years ago
Alexander Barkov	279b50b4eb	MDEV-14041 Server crashes in String::length on queries with functions and ROLLUP	7 years ago
Alexander Barkov	f4b2740018	MDEV-17299 Assertion `maybe_null' failed in make_sortkey	7 years ago
Marko Mäkelä	d315b4ff39	Remove IBUF_COUNT_DEBUG The compile-time option IBUF_COUNT_DEBUG has not been used for years. It would only work with up to 3 created .ibd files, with no buffered changes existing while InnoDB is started up.	7 years ago
Sergei Petrunia	056b6fe1d5	MDEV-17297: stats.records=0 for a table of Archive engine when it has rows, when we run ANALYZE command Archive storage engine assumed that any query that attempts to read from the table will call ha_archive::info() beforehand. ha_archive would flush un-written data in that call (this would make it visible for the reads). Break this assumption. Flush the data when the table is opened for reading. This way, one can do multiple write statements without causing a flush, but as soon as we might need the data, we flush it.	7 years ago
Alexander Barkov	0bb924e18c	MDEV-17830 Server crashes in Item_null_result::field_type upon SELECT with CHARSET(date) and ROLLUP	7 years ago
Marko Mäkelä	169c00994b	MDEV-12699 Improve crash recovery of corrupted data pages InnoDB crash recovery used to read every data page for which redo log exists. This is unnecessary for those pages that are initialized by the redo log. If a newly created page is corrupted, recovery could unnecessarily fail. It would suffice to reinitialize the page based on the redo log records. To add insult to injury, InnoDB crash recovery could hang if it encountered a corrupted page. We will fix also that problem. InnoDB would normally refuse to start up if it encounters a corrupted page on recovery, but that can be overridden by setting innodb_force_recovery=1. Data pages are completely initialized by the records MLOG_INIT_FILE_PAGE2 and MLOG_ZIP_PAGE_COMPRESS. MariaDB 10.4 additionally recognizes MLOG_INIT_FREE_PAGE, which notifies that a page has been freed and its contents can be discarded (filled with zeroes). The record MLOG_INDEX_LOAD notifies that redo logging has been re-enabled after being disabled. We can avoid loading the page if all buffered redo log records predate the MLOG_INDEX_LOAD record. For the internal tables of FULLTEXT INDEX, no MLOG_INDEX_LOAD records were written before commit `aa3f7a107c`. Hence, we will skip these optimizations for tables whose name starts with FTS_. This is joint work with Thirunarayanan Balathandayuthapani. fil_space_t::enable_lsn, file_name_t::enable_lsn: The LSN of the latest recovered MLOG_INDEX_LOAD record for a tablespace. mlog_init: Page initialization operations discovered during redo log scanning. FIXME: This really belongs in recv_sys->addr_hash, and should be removed in MDEV-19176. recv_addr_state: Add the new state RECV_WILL_NOT_READ to indicate that according to mlog_init, the page will be initialized based on redo log record contents. recv_add_to_hash_table(): Set the RECV_WILL_NOT_READ state if appropriate. For now, we do not treat MLOG_ZIP_PAGE_COMPRESS as page initialization. This works around bugs in the crash recovery of ROW_FORMAT=COMPRESSED tables. recv_mark_log_index_load(): Process a MLOG_INDEX_LOAD record by resetting the state to RECV_NOT_PROCESSED and by updating the fil_name_t::enable_lsn. recv_init_crash_recovery_spaces(): Copy fil_name_t::enable_lsn to fil_space_t::enable_lsn. recv_recover_page(): Add the parameter init_lsn, to ignore any log records that precede the page initialization. Add DBUG output about skipped operations. buf_page_create(): Initialize FIL_PAGE_LSN, so that recv_recover_page() will not wrongly skip applying the page-initialization record due to the field containing some newer LSN as a leftover from a different page. Do not invoke ibuf_merge_or_delete_for_page() during crash recovery. recv_apply_hashed_log_recs(): Remove some unnecessary lookups. Note if a corrupted page was found during recovery. After invoking buf_page_create(), do invoke ibuf_merge_or_delete_for_page() via mlog_init.ibuf_merge() in the last recovery batch. ibuf_merge_or_delete_for_page(): Relax a debug assertion. innobase_start_or_create_for_mysql(): Abort startup if a corrupted page was found during recovery. Corrupted pages will not be flagged if innodb_force_recovery is set. However, the recv_sys->found_corrupt_fs flag can be set regardless of innodb_force_recovery if file names are found to be incorrect (for example, multiple files with the same tablespace ID).	7 years ago
Marko Mäkelä	376bf4ede5	MDEV-19241 InnoDB fails to write MLOG_INDEX_LOAD upon completing ALTER TABLE Similar to what was done in commit `aa3f7a107c` for FULLTEXT INDEX, we must ensure that MLOG_INDEX_LOAD records will always be written if redo logging was disabled. row_merge_build_indexes(): Invoke row_merge_write_redo() also when online operation is not being executed or an error occurs. In case of an error, invoke flush_observer->interrupted() so that the pages will not be flushed but merely evicted from the buffer pool. Before resuming redo logging, it is crucial for the correctness of mariabackup and InnoDB crash recovery to flush or evict all affected pages and to write MLOG_INDEX_LOAD records.	7 years ago
Marko Mäkelä	bc8d173b9f	MDEV-14239 Missing space: "innodb_open_files ... greaterthan" innobase_init(): Add a missing space to a warning message. Apparently, this message was corrupted in MariaDB 10.2.2 in commit `fec844aca8` related to a conflict resolution when applying a change from MySQL 5.7.12.	7 years ago
Varun Gupta	409dddf695	MDEV-18300: ASAN error in Field_blob::get_key_image upon UPDATE with subquery For single table updates and multi-table updates , engine independent statistics were not being read even if the statistics were collected. Fixed it, so when the optimizer_use_condition_selectivity > 2 then we would read the available statistics for update queries.	7 years ago
Marko Mäkelä	4ac8fa008d	FSP_FLAGS_MEM_MASK: Remove traces of ATOMIC_WRITES	7 years ago
Jan Lindström	03dcec9a9a	Fix wsrep_thd_is_applier macro to point correct function name.	7 years ago
Sergei Golubchik	725579c0f4	cmake: pass CMAKE_BUILD_TYPE into src.rpm and don't pass BUILD_CONFIG twice, once is enough.	7 years ago
Marko Mäkelä	7362f11554	Require --big-test for innodb.undo_truncate_recover	7 years ago
Marko Mäkelä	e7f426d2c9	MDEV-19212: Replace macros with type-safe inline functions The regression that was reported in MDEV-19212 occurred due to use of macros that did not ensure that the arguments have compatible types. ut_2pow_remainder(), ut_2pow_round(), ut_calc_align(): Define as inline function templates. UT_CALC_ALIGN(): Define as a macro, because this is used in compile_time_assert(). Only starting with C++11 (MariaDB 10.4) we could define the inline functions as constexpr.	7 years ago
Marko Mäkelä	f120a15b93	MDEV-19212 4GB Limit on large_pages - integer overflow os_mem_alloc_large(): Invoke the macro ut_2pow_round() with the correct argument type. innobase_large_page_size, innobase_use_large_pages, os_use_large_pages, os_large_page_size: Remove. Simply refer to opt_large_page_size, my_use_large_pages.	7 years ago
Vlad Lesin	caa8c20abe	MDEV-14192 Mariabackup assertion failure: byte_offset % OS_FILE_LOG_BLOCK_SIZE == 0 xtrabackup_backup_func(): If the log checkpoint header changed since we last read it, search for the most recent checkpoint again. Otherwise, we could corrupt the backup of the redo log, because the least significant bits of checkpoint_lsn_start would not match log_sys->log.lsn.	7 years ago
Marko Mäkelä	4b822111ef	MDEV-8139: Clean up the freeing of B-tree pages btr_page_free(): Renamed from btr_page_free_low(). If scrubbing is enabled, zero out the page with proper redo logging. Only pass ahi=true to fseg_free_page() if the page is actually indexed. fil_space_t::modify_check(): Renamed from fsp_space_modify_check(). fsp_init_file_page(): Define inline.	7 years ago
Sergei Golubchik	e124ff17e0	cmake: force Boost dependency as needed because FindBoost.cmake won't do it	7 years ago
Sergei Golubchik	5023e465a9	copy-paste error fixed thanks @FaramosCZ	7 years ago
Sergei Golubchik	7d720ca8de	cmake: don't use generated files to detect a submodule Even if Makefile for some reason was checked in in a submodule, it is still a generated file, will be cleaned, won't be in a source package. One cannot jump to conclusions if it doesn't exist.	7 years ago
Marko Mäkelä	7f5849a809	MDEV-18309: Remove unused code	7 years ago
Marko Mäkelä	867617a976	MDEV-18309: InnoDB reports bogus errors about missing #sql-*.ibd on startup This is a follow-up to MDEV-18733. As part of that fix, we made dict_check_sys_tables() skip tables that would be dropped by row_mysql_drop_garbage_tables(). DICT_ERR_IGNORE_DROP: A new mode where the file should not be attempted to be opened. dict_load_tablespace(): Do not try to load the tablespace if DICT_ERR_IGNORE_DROP has been specified. row_mysql_drop_garbage_tables(): Pass the DICT_ERR_IGNORE_DROP mode. fil_space_for_table_exists_in_mem(): Remove a parameter. The only caller that passed print_error_if_does_not_exist=true was row_drop_single_table_tablespace().	7 years ago

1 2 3 4 5 ...

181870 Commits (aed761ced539bf5481f8358dfd7ca599da39273b) All Branches Search

181870 Commits (aed761ced539bf5481f8358dfd7ca599da39273b)

All Branches