mariadb

Tree: ab2f3dd2a2

Author	SHA1	Message	Date
Staale Smedseng	ab2f3dd2a2	Bug #43397 mysql headers redefine pthread_mutex_init unnecessarily The problem is that libmysqlclient.so is built with THREAD undefined, while a client compiling against the same header files will see THREAD as defined and definitions in my_pthread.h will be included, possibly resulting in undefined symbols that cannot be resolved with libmysqlclient.so. The suggested solution is to require that clients wanting to link with libmysqlclient.so should be built with MYSQL_CLIENT_NO_THREADS defined. This requires a documentation change, and more details for this will be supplied if this patch is approved. The MYSQL_CLIENT_NO_THREADS define was renamed from UNDEF_THREADS_HACK, to get a more suitable (less suspicious) name for the define. (The UNDEF_THREADS_HACK is retained for backwards compatibility, though.) This patch is also in anticipation of WL#4958, which will remove this problem altogether by dropping the building of libmysqlclient.	17 years ago
Georgi Kodinov	ead1ce94e6	Addendum to the fix for bug 45807 : initialize a member needed in Item_field::fix_fields()	17 years ago
Georgi Kodinov	c2ec53f94a	Bug#38998, Bug#46029, Bug#45243, Bug#46030 making tests experimental	17 years ago
Georgi Kodinov	5069a3e9ef	automerge	17 years ago
Georgi Kodinov	c8c22c7a98	Bug #40796 : adding the tests to the experimental pb2 set.	17 years ago
Patrick Crews	1eb64fa651	merge	17 years ago
Patrick Crews	61425acb3d	Bug#37746: Arithmetic range ("int") is smaller than expected Added code to the .test file to skip this test on Win64 for PB2 stability. Please remove this code when the bug is fixed.	17 years ago
Georgi Kodinov	d03714da6b	revert of hiding of the error exposed by this suite.	17 years ago
Georgi Kodinov	6a2f91bff4	merge of making bug 45578, 46010 and 45576 experimental in pb2.	17 years ago
Georgi Kodinov	7c681e9001	atuomerge	17 years ago
Georgi Kodinov	abfe915ac9	fixed compilation warnings on macosx	17 years ago
Georgi Kodinov	2275faa00e	fixed a failing test ctype_gbk_binlog : Table 't2' already exists	17 years ago
V Narayanan	6155562ca9	merging with mysql-5.1-bugteam.	17 years ago
Patrick Crews	869e6bd19f	Bug#44920: MTR2 is not processing master.opt input properly on Windows. Had attempted to disable this test on Windows only, but the nature of this bug does not allow for this. The master.opt file is processed before anything in in the actual test. As a result, we must use disabled.def files to ensure these tests are skipped on the problematic platforms. Removed Windows-only code and updated the proper disabled.def files accordingly.	17 years ago
Georgi Kodinov	05e498ea3d	null merged the disablement : problem is not present in 5.1	17 years ago
Georgi Kodinov	e92c681532	disable ndb_autodiscover2 : dependent on the disabled ndb_autodiscover	17 years ago
Georgi Kodinov	ba83235f42	Bug #45974 : disable test case in 5.1-bugteam	17 years ago
Georgi Kodinov	4c4109b35b	null-merged the test case disablement in bug 45972 to 5.1	17 years ago
Georgi Kodinov	9d94015b34	Bug#45972: disable the test case in 5.0	17 years ago
Georgi Kodinov	13306216c7	null-merged the disabled test cases.	17 years ago
Georgi Kodinov	c0ad792136	null-merge the mark of bug #38499 to big_test : it's running faster on 5.1	17 years ago
Georgi Kodinov	2a17098a60	Bug #35148 : ndb_autodiscover3 disabled	17 years ago
Georgi Kodinov	07e69e29ea	Bug #35148 : disabled testcase loaddata_autocom_ndb	17 years ago
Georgi Kodinov	fd709c8408	Bug #45521 : disabled the test case	17 years ago
Georgi Kodinov	b74f6cda43	Bug #38499 : test marked as a big test : takes approx 275 secs on a P4 2.4 GHz.	17 years ago
Georgi Kodinov	6286f620c2	automerge	17 years ago
Georgi Kodinov	cba730d718	null-merged test cases disablement	17 years ago
Georgi Kodinov	6cc65b7e69	Bug#38315 and Bug#35148: disabled sporadically failing NDB tests	17 years ago
V Narayanan	0c66f4a64a	Bug#45803 Inaccurate estimates for partial key values with IBMDB2I Some collations were causing IBMDB2I to report inaccurate key range estimations to the optimizer for LIKE clauses that select substrings. This can be seen by running EXPLAIN. This problem primarily affects multi-byte and unicode character sets. This patch involves substantial changes to several modules. There are a number of problems with the character set and collation handling. These problems have been or are being fixed, and a comprehensive test has been included which should provide much better coverage than there was before. This test is enabled only for IBM i 6.1, because that version has support for the greatest number of collations. mysql-test/suite/ibmdb2i/r/ibmdb2i_collations.result: Bug#45803 Inaccurate estimates for partial key values with IBMDB2I result file for test case. mysql-test/suite/ibmdb2i/t/ibmdb2i_collations.test: Bug#45803 Inaccurate estimates for partial key values with IBMDB2I Tests for character sets and collations. This test is enabled only for IBM i 6.1, because that version has support for the greatest number of collations. storage/ibmdb2i/db2i_conversion.cc: Bug#45803 Inaccurate estimates for partial key values with IBMDB2I - Added support in convertFieldChars to enable records_in_range to determine how many substitute characters were inserted and to suppress conversion warnings. - Fixed bug which was causing all multi-byte and Unicode fields to be created as UTF16 (CCSID 1200) fields in DB2. The corrected code will now create UCS2 fields as UCS2 (CCSID 13488), UTF8 fields (except for utf8_general_ci) as UTF8 (CCSID 1208), and all other multi-byte or Unicode fields as UTF16. This will only affect tables that are newly created through the IBMDB2I storage engine. Existing IBMDB2I tables will retain the original CCSID until recreated. The existing behavior is believed to be functionally correct, but it may negatively impact performance by causing unnecessary character conversion. Additionally, users accessing IBMDB2I tables through DB2 should be aware that mixing tables created before and after this change may require extra type casts or other workarounds. For this reason, users who have existing IBMDB2I tables using a Unicode collation other than utf8_general_ci are encouraged to recreate their tables (e.g. ALTER TABLE t1 ENGINE=IBMDB2I) in order to get the updated CCSIDs associated with their DB2 tables. - Improved error reporting for unsupported character sets by forcing a check for the iconv conversion table at table creation time, rather than at data access time. storage/ibmdb2i/db2i_myconv.h: Bug#45803 Inaccurate estimates for partial key values with IBMDB2I Fix to set errno when iconv fails. storage/ibmdb2i/db2i_rir.cc: Bug#45803 Inaccurate estimates for partial key values with IBMDB2I Significant improvements were made to the records_in_range code that handles partial length string data in keys for optimizer plan estimation. Previously, to obtain an estimate for a partial key value, the implementation would perform any necessary character conversion and then attempt to determine the unpadded length of the partial key by searching for the minimum or maximum sort character. While this algorithm was sufficient for most single-byte character sets, it did not treat Unicode and multi-byte strings correctly. Furthermore, due to an operating system limitation, partial keys having UTF8 collations (ICU sort sequences in DB2) could not be estimated with this method. With this patch, the code no longer attempts to explicitly determine the unpadded length of the key. Instead, the entire key is converted (if necessary), including padding, and then passed to the operating system for estimation. Depending on the source and target character sets and collations, additional logic is required to correctly handle cases in which MySQL uses unconvertible or differently -weighted values to pad the key. The bulk of the patch exists to implement this additional logic. storage/ibmdb2i/ha_ibmdb2i.h: Bug#45803 Inaccurate estimates for partial key values with IBMDB2I The convertFieldChars declaration was updated to support additional optional behaviors.	17 years ago
Alfranio Correia	6a14a2352f	auto-merge mysql-5.1-bugteam (local) --> mysql-5.1-bugteam	17 years ago
Alfranio Correia	8ba57fa3c9	BUG#44581 Slave stops when transaction with non-transactional table gets lock wait timeout In STMT and MIXED modes, a statement that changes both non-transactional and transactional tables must be written to the binary log whenever there are changes to non-transactional tables. This means that the statement gets into the binary log even when the changes to the transactional tables fail. In particular , in the presence of a failure such statement is annotated with the error number and wrapped in a begin/rollback. On the slave, while applying the statement, it is expected the same failure and the rollback prevents the transactional changes to be persisted. Unfortunately, statements that fail due to concurrency issues (e.g. deadlocks, timeouts) are logged in the same way causing the slave to stop as the statements are applied sequentially by the SQL Thread. To fix this bug, we automatically ignore concurrency failures on the slave. Specifically, the following failures are ignored: ER_LOCK_WAIT_TIMEOUT, ER_LOCK_DEADLOCK and ER_XA_RBDEADLOCK.	17 years ago
Ramil Kalimullin	345e8347cb	Fix for bug#42364 reverted.	17 years ago
Kristofer Pettersson	1621a97fd4	5.0-bugteam -> 5.1-bugteam	17 years ago
Kristofer Pettersson	5899e13a8e	Bug#37274 client 'status' command doesn't print all info after losing connection to server If the server connection was lost during repeated status commands, the client would fail to detect this and the client output would be inconsistent. This patch fixes this issue by making sure that the server is online before the client attempts to execute the status command. client/mysql.cc: * Replace variable "connected" with a call to mysql_real_query_for_lazy() will attempt to reconnect to server on if there is a failure.	17 years ago
Alexey Kopytov	cfebaf442a	Automerge.	17 years ago
Alexey Kopytov	2d4df13ef2	Manual merge.	17 years ago
Sergey Glukhov	59d239e1f1	5.0-bugteam->5.1-bugteam merge	17 years ago
Sergey Glukhov	2dd7094681	Bug#45806 crash when replacing into a view with a join! The crash happend because for views which are joins we have table_list->table == 0 and table_list->table->'any method' call leads to crash. The fix is to perform table_list->table->file->extra() method for all tables belonging to view. mysql-test/r/view.result: test result mysql-test/t/view.test: test case sql/sql_insert.cc: added prepare_for_positional_update() function which updates extra info about primary key for tables belonging to view.	17 years ago
Bernt M. Johnsen	15b23550d4	Prepare for push	17 years ago
Sergey Glukhov	45d59063cb	Bug#42364 SHOW ERRORS returns empty resultset after dropping non existent table enabled message storing into error message list for 'drop table' command mysql-test/r/warnings.result: test result mysql-test/t/warnings.test: test case sql/sql_table.cc: We should skip error sending then we should return warnings to client as some functions may send its own errors, so we should set no_warnings_for_error= 0 only in case of warning. The fix is to enable message storing into error message list for 'drop table' command(only for error case). tests/mysql_client_test.c: test fix	17 years ago
Bernt M. Johnsen	61488d2abb	automerge	17 years ago
Bernt M. Johnsen	768f5b08fb	Prepare for push	17 years ago
Bernt M. Johnsen	7bb5986d93	Bug#15866 Prepared for push on 5.1	17 years ago
Bernt M. Johnsen	e0a3403b45	Bug#15866 Prepared for push on 5.0	17 years ago
Alexey Kopytov	096c12b2c4	Bug #45262 : Bad effects with CREATE TABLE and DECIMAL Using DECIMAL constants with more than 65 digits in CREATE TABLE ... SELECT led to bogus errors in release builds or assertion failures in debug builds. The problem was in inconsistency in how DECIMAL constants and fields are handled internally. We allow arbitrarily long DECIMAL constants, whereas DECIMAL(M,D) columns are limited to M<=65 and D<=30. my_decimal_precision_to_length() was used in both Item and Field code and truncated precision to DECIMAL_MAX_PRECISION when calculating value length without adjusting precision and decimals. As a result, a DECIMAL constant with more than 65 digits ended up having length less than precision or decimals which led to assertion failures. Fixed by modifying my_decimal_precision_to_length() so that precision is truncated to DECIMAL_MAX_PRECISION only for Field object which is indicated by the new 'truncate' parameter. Another inconsistency fixed by this patch is how DECIMAL constants and expressions are handled for CREATE ... SELECT. create_tmp_field_from_item() (which is used for constants) was changed as a part of the bugfix for bug #24907 to handle long DECIMAL constants gracefully. Item_func::tmp_table_field() (which is used for expressions) on the other hand was still using a simplistic approach when creating a Field_new_decimal from a DECIMAL expression. mysql-test/r/type_newdecimal.result: Added a test case for bug #45262. mysql-test/t/type_newdecimal.test: Added a test case for bug #45262. sql/item.cc: Use the new 'truncate' parameter in my_decimal_precision_to_length(). sql/item_cmpfunc.cc: Use the new 'truncate' parameter in my_decimal_precision_to_length(). sql/item_func.cc: 1. Use the new 'truncate' parameter in my_decimal_precision_to_length(). 2. Do not truncate decimal precision to DECIMAL_MAX_PRECISION for additive expressions involving long DECIMAL constants. 3. Fixed an incosistency in how DECIMAL constants and expressions are handled for CREATE ... SELECT. sql/item_func.h: Use the new 'truncate' parameter in my_decimal_precision_to_length(). sql/item_sum.cc: Use the new 'truncate' parameter in my_decimal_precision_to_length(). sql/my_decimal.h: Do not truncate precision to DECIMAL_MAX_PRECISION when calculating length in my_decimal_precision_to_length() if 'truncate' parameter is FALSE. sql/sql_select.cc: 1. Use the new 'truncate' parameter in my_decimal_precision_to_length(). 2. Use a more correct logic when adjusting value's length.	17 years ago
Georgi Kodinov	ae8950f1e8	Bug #45807 : crash accessing partitioned table and sql_mode contains ONLY_FULL_GROUP_BY The partitioning code needs to issue a Item::fix_fields() on the partitioning expression in order to prepare it for being evaluated. It does this by creating a special table and a table list for the scope of the partitioning expression. But when checking ONLY_FULL_GROUP_BY the Item_field::fix_fields() was relying that there always be cached_table set and was trying to use it to get the select_lex of the SELECT the field's table is in. But the cached_table was not set by the partitioning code that creates the artificial TABLE_LIST used to resolve the partitioning expression and this resulted in a crash. Fixed by rectifying the following errors : 1. Item_field::fix_fields() : the code that check for ONLY_FULL_GROUP_BY relies on having tables with cacheable_table set. This is mostly true, the only two exceptions being the partitioning context table and the trigger context table. Fixed by taking the current parsing context if no pointer to the TABLE_LIST instance is present in the cached_table. 2. fix_fields_part_func() : 2a. The code that adds the table being created to the scope for the partitioning expression is mostly a copy of the add_table_to_list and friends with one exception : it was not marking the table as cacheable (something that normal add_table_to_list is doing). This caused the problem in the check for ONLY_FULL_GROUP_BY in Item_field::fix_fields() to appear. Fixed by setting the correct members to make the table cacheable. The ideal structural fix for this is to use a unified interface for adding a table to a table list (add_table_to_list?) : noted in a TODO comment 2b. The Item::fix_fields() was called with a NULL destination pointer. This causes uninitalized memory reads in the overloaded ::fix_fields() function (namely Item_field::fix_fields()) as it expects a non-zero pointer there. Fixed by passing the source pointer similarly to how it's done in JOIN::prepare(). mysql-test/r/partition.result: Bug #45807: test case mysql-test/t/partition.test: Bug #45807: test case sql/item.cc: Bug #45807: fix the ONLY_FULL_GROUP_BY check code to handle correctly non-cacheable tables. sql/sql_partition.cc: Bug #45807: fix the Item::fix_fields() context initializatio for the partitioning expression in CREATE TABLE.	17 years ago
Matthias Leich	a01b9e2922	Merge 5.0 -> 5.1 of fix for bug 45902	17 years ago
Matthias Leich	3abee40e6b	Fix for Bug#45902 rpl_sp fails sporadically in check testcases Details: - Add "sync_slave_with_master" at test end - Restore the initial value of log_bin_trust_function_creators	17 years ago
V Narayanan	fdf1461a4f	Bug#45793 macce charset causes error with IBMDB2I Creating an IBMDB2I table with the macce character set is successful, but any attempt to insert data into the table was failing. This was happening because the character set name "macce" is not a valid iconv descriptor for IBM i PASE. This patch adds an override to convertTextDesc to use the equivalent valid iconv descriptor "IBM-1282" instead. mysql-test/suite/ibmdb2i/r/ibmdb2i_bug_45793.result: Bug#45793 macce charset causes error with IBMDB2I Result file for the test case. mysql-test/suite/ibmdb2i/t/ibmdb2i_bug_45793.test: Bug#45793 macce charset causes error with IBMDB2I Add a testcase for the macce charater set. storage/ibmdb2i/db2i_charsetSupport.cc: Bug#45793 macce charset causes error with IBMDB2I The character set name "macce" is not a valid iconv descriptor for IBM i PASE. Add an override to convertTextDesc to use the equivalent valid iconv descriptor "IBM-1282" instead.	17 years ago
Staale Smedseng	3c052dd097	Merge from 5.0	17 years ago

1 2 3 4 5 ...

57715 Commits (ab2f3dd2a2d23d2b96604515ddc0576b54ad8049) All Branches Search

57715 Commits (ab2f3dd2a2d23d2b96604515ddc0576b54ad8049)

All Branches