mariadb

Tree: a808c18b73

Author	SHA1	Message	Date
Marko Mäkelä	fc2ca2be4e	MDEV-21024: Clean up page allocation fsp_alloc_seg_inode_page(): Ever since commit `3926673ce7` all newly allocated pages are zero-initialized. Assert that this is the case for the FSEG_ID fields.	6 years ago
Marko Mäkelä	98e1d603bf	MDEV-21024: Optimize writing BTR_EXTERN_LEN btr_store_big_rec_extern_fields(): Remove the redundant initialization of the most significant 32 bits of BTR_EXTERN_LEN. InnoDB never supported BLOBs that are longer than 4GiB. In fact, dtuple_convert_big_rec() would write emit an error message if a clustered index record tuple would exceed 1,000,000,000 bytes in length. The BTR_EXTERN_LEN in the BLOB pointers in clustered index leaf page records is zero-initialized at least since commit `41bb3537ba`	6 years ago
Marko Mäkelä	3621df70ca	MDEV-21024: Clean up rtr_adjust_upper_level() Remove the unnecessary retrieval and null-modifications of the preceding page.	6 years ago
Marko Mäkelä	29d67d051a	Cleanup btr_page_get_prev(), btr_page_get_next() Remove the redundant parameter mtr_t*. Make use of page_has_prev(), page_has_next() whenever possible.	6 years ago
Marko Mäkelä	1d2458f813	MDEV-21024: Clean up rtr_adjust_upper_level() Remove the unnecessary retrieval and null-modifications of the preceding page.	6 years ago
Andrei Elkin	13db50fc03	MDEV-19376 Repl_semi_sync_master::commit_trx assertion failure: ... \|\| !m_active_tranxs->is_tranx_end_pos(trx_wait_binlog_name, trx_wait_binlog_pos) The assert indicates that the current transaction got caught uncleaned from the semisync master's cache when it is signaled to proceed upon its ack receive. The reason of missed cleanup turns out to be a flaw in the gtid connect mode. A submitted by connecting slave value of its last received event's binlog file name was adopted into {{Repl_semi_sync_master::m_reply_file_name}} as a part of semisync initialization. Notice that the initialization still refines the position part of the submitted last received event's binlog coordinates. The master side binlog filename:pos refinement is specific to the gtid connect mode for purpose of computing the latest binlog file to resume slave feeding from. Effectively in the gtid connect mode the computed resumption filename:pos may appear smaller in which case a new post-connect time committing transaction may be logged with its filename:pos also less than the submitted coordinates and that triggers the assert. Fixed with making the semisync initialization to use the refined filename:pos. It is guaranteed to be less than any new generated transaction's binlog:pos.	6 years ago
Daniel Bartholomew	74892bda3a	bump the VERSION	6 years ago
Daniel Bartholomew	c4ee8a306b	bump the VERSION	6 years ago
Daniel Bartholomew	cbf5f6d6b5	bump the VERSION	6 years ago
Daniel Bartholomew	dfd2d3d861	bump the VERSION	6 years ago
Marko Mäkelä	bce71a2909	Cleanup: Replace xdes_set_bit() The XDES_CLEAN_BIT is always set for every element of the page allocation bitmap in the extent descriptor pages. Do not bother touching it, to avoid redundant writes. xdes_set_free<bool free>(): Replaces xdes_set_bit().	6 years ago
Marko Mäkelä	5ed54e78ac	Cleanup: Remove redundant XDES_FREE_BIT parameters The page allocation bitmaps in the extent descriptor pages contain two bits per page: XDES_FREE_BIT and XDES_CLEAN_BIT, which is unused. Simplify read access. xdes_is_free(descr,mtr): Remove. Use !xdes_get_n_used(descr) instead. xdes_is_free(): Replaces xdes_get_bit(), xdes_mtr_get_bit(). xdes_find_free(): Replaces xdes_find_bit(). fsp_seg_inode_page_get_nth_inode(): Remove the redundant parameters physical_size, mtr. fsp_seg_inode_page_find_used(), fsp_seg_inode_page_find_free(): Remove the redundant parameter mtr.	6 years ago
Marko Mäkelä	74b7d0182d	Merge 10.4 into 10.5	6 years ago
Marko Mäkelä	b5ef7ffa59	Use uint16_t for FIL_PAGE_TYPE Since commit `5d596064d6` fil_page_type_is_index() expects uint16_t, not ulint.	6 years ago
Marko Mäkelä	15b713cadc	MDEV-17138 follow-up: Use MLOG_MEMSET in xdes_init()	6 years ago
Marko Mäkelä	a6d614fb4a	MDEV-12353 preparation: Remove redundant writes fsp_alloc_seg_inode_page(): Ever since commit `3926673ce7` all newly allocated pages are zero-initialized. Assert that this is the case for the FSEG_ID fields. (Side note: before that fix, other parts of the pages could contain nonzero garbage.) btr_store_big_rec_extern_fields(): Remove the redundant initialization of the most significant 32 bits of BTR_EXTERN_LEN. InnoDB never supported BLOBs that are longer than 4GiB. In fact, dtuple_convert_big_rec() would write emit an error message if a clustered index record tuple would exceed 1,000,000,000 bytes in length.	6 years ago
Marko Mäkelä	5b72e8136f	Cleanup: Do not pass mtr_t* as NULL PageConverter::update_index_page(): Invoke lower-level writes directly.	6 years ago
Marko Mäkelä	5d596064d6	Cleanup: Define FIL_PAGE_TYPE constants as constexpr	6 years ago
Marko Mäkelä	52246dff2c	Merge 10.4 into 10.5	6 years ago
Marko Mäkelä	78d0d2cdc5	Cleanup: Remove mach_read_ulint() The function mach_read_ulint() is a wrapper for the lower-level functions mach_read_from_1(), mach_read_from_2(), mach_read_from_8(). Invoke those functions directly, for better readability of the code. mtr_t::read_ulint(), mtr_read_ulint(): Remove. Yes, we will lose the ability to assert that the read is covered by the mini-transaction. We would still check that on writes, and any writes that wrongly bypass mini-transaction logging would likely be caught by stress testing with Mariabackup.	6 years ago
Hartmut Holzgraefe	c4a844ca51	MDEV-20981 wsrep_sst_mariabackup fails silently when mariabackup is not installed (#1406 ) Make sure failure to find mariabackup binary does not terminate the script silently, terminate with a clear error message instead	6 years ago
Marko Mäkelä	8a5eb4141b	MDEV-17138 follow-up: Use MLOG_MEMSET for writing FIL_NULL Always use the MLOG_MEMSET record for writing FIL_NULL, because it is more compact.	6 years ago
Aleksey Midenkov	db56543993	Compilation fix with partitioning off (MDEV-17553)	6 years ago
Aleksey Midenkov	1e73d7d6c6	MDEV-17553 Enable setting start datetime for interval partitioned history of system versioned tables * Explicit STARTS syntax * SHOW CREATE * Default STARTS rounding depending on INTERVAL type * Warn when STARTS timestamp is later than query time * Fix uninitialized Lex->create_last_non_select_table under mysql_unpack_partition() Default STARTS rounding depending on INTERVAL type If STARTS clause is omitted, default one is assigned with value derived from query timestamp. The rounding is done on STARTS value depending on INTERVAL type: SECOND: no rounding is done; MINUTE: timestamp seconds is set to 0; HOUR: timestamp seconds and minutes are set to 0; DAY, WEEK, MONTH and YEAR: timestamp seconds, minutes and hours are set to 0 (the date of rotation is kept as current date).	6 years ago
Varun Gupta	b1ab2ba583	MDEV-20519: Query plan regression with optimizer_use_condition_selectivity > 1 The issue here is the wrong estimate of the cardinality of a partial join, the cardinality is too high because the function table_cond_selectivity() returns an absurd number 100 while selectivity cannot be greater than 1. When accessing table t by outer reference t1.a via index we do not perform any range analysis for t. Yet we see TABLE::quick_key_parts[key] and TABLE->quick_rows[key] contain a non-zero value though these should have been remained untouched and equal to 0. Thus real cause of the problem is that TABLE::init does not clean the arrays TABLE::quick_key_parts[] and TABLE::>quick_rows[]. It should have done it because the TABLE structure created for any instance of a table can be reused for many queries.	6 years ago
Marko Mäkelä	77e8a311e1	Merge 10.4 into 10.5 A conflict between MDEV-19514 (`b42294bc64`) and MDEV-20934 (`d7a2401750`) was resolved. We will not invoke the function ibuf_delete_recs() from ibuf_merge_or_delete_for_page(). Instead, we will add that logic to the function ibuf_read_merge_pages().	6 years ago
Oleksandr Byelkin	3ad37ed0eb	Merge 10.4 into 10.5	6 years ago
Marko Mäkelä	c24ec3cece	Merge 10.3 into 10.4	6 years ago
Marko Mäkelä	352e766787	MDEV-20934: Make the test more robust Due to MDEV-12288, the slow shutdown in MariaDB 10.3 will include resetting the DB_TRX_ID for all inserted records. This might cause the 60-second shutdown_server timeout to be exceeded. Let us wait for the purge to complete before initiating slow shutdown.	6 years ago
Marko Mäkelä	928abd6967	Merge 10.3 into 10.4	6 years ago
Marko Mäkelä	908ca4668d	Merge 10.2 into 10.3	6 years ago
Marko Mäkelä	90451a5981	Follow-up to `792c9f9a49` dict_index_add_to_cache(): Make the 'index' a reference to a pointer, so that the caller will avoid the expensive call to dict_index_get_if_in_cache_low().	6 years ago
Marko Mäkelä	8688ef22c2	Merge 10.1 to 10.2	6 years ago
Marko Mäkelä	d7a2401750	MDEV-20934 Infinite loop on innodb_fast_shutdown=0 with inconsistent change buffer Due to a data corruption bug that may have occurred a long time earlier (possibly involving physical backup and MySQL Bug #69122, which was addressed in commit `f166ec71b7`) it seems possible that the InnoDB change buffer might end up containing entries, while no buffered changes exist according to the change buffer bitmap pages in the .ibd files. ibuf_delete_recs(): New function, to be invoked on slow shutdown only. Remove all buffered changes for a specific page. ibuf_merge_or_delete_for_page(): If the change buffer bitmap is clean and a slow shutdown is in progress, invoke ibuf_delete_recs(). We do not want to do that during normal operation, due to the additional overhead that is involved. The bitmap page should be consistent with the change buffer in the first place.	6 years ago
Marko Mäkelä	4e99e67c4e	Merge 5.5 into 10.1	6 years ago
Thirunarayanan Balathandayuthapani	5c3bbbd845	MDEV-20987 InnoDB fails to start when fts table has FK relation InnoDB: Assertion failure in file .../dict/dict0dict.cc line ... InnoDB: Failing assertion: table->can_be_evicted This fixes a regression that was caused by the fix of MDEV-20621 (commit `a41d429765`). MySQL 5.6 (and MariaDB 10.0) introduced eviction of tables from the InnoDB data dictionary cache. Tables that are connected to FOREIGN KEY constraints or FULLTEXT INDEX are exempt of the eviction. With the problematic change, a table that would already be exempt from eviction due to FOREIGN KEY would cause the problem if there also was a FULLTEXT INDEX defined on it. dict_load_table(): Only prevent eviction if table->can_be_evicted holds.	6 years ago
Alexander Barkov	46f2f24ec4	MDEV-20985 Add LEX methods stmt_drop_{function\|procedure}() and stmt_alter_{function\|procedure}_start() Adding a few helper LEX methods, to unify sql_yacc.yy and sql_yacc_ora.yy easier	6 years ago
Daniel Bartholomew	d9899ce671	bump the VERSION	6 years ago
Daniel Bartholomew	5d3bd2b75b	bump the VERSION	6 years ago
Daniel Bartholomew	7bc26de591	bump the VERSION	6 years ago
Daniel Bartholomew	6e48f3a062	bump the VERSION	6 years ago
Daniel Bartholomew	e23cb3835e	bump the VERSION	6 years ago
Alexander Barkov	79e295b601	Cleanup: moving '(' after the stmt_create_stored_function_start() call This is a logically better position. Also, this makes the code in sql_yacc.yy and sql_yacc_ora.yy look more similar.	6 years ago
Alexander Barkov	0858500f2f	Cleanup: reusing opt_sp_parenthesized_fdparam_list and removing duplicate rules.	6 years ago
Vladislav Vaintroub	dc771113a6	Fix ninja build Do not rely on existence of CMakeFiles/${target}.dir directory existence It is not there for custom targets in Ninja build.	6 years ago
Sergei Golubchik	cd156e2c3e	MDEV-20971 ASAN heap-use-after-free in list_delete / heap_close Don't save/restore HP_INFO as it could be changed by a concurrent thread. different parts of HP_INFO are protected by different mutexes and the mutex that protect most of the HP_INFO does not protect its open_list data. As a bonus, make heap_check_heap() to take const HP_INFO* and not make any changes there whatsoever.	6 years ago
Marko Mäkelä	51fb39bf17	MDEV-19586: Restore pointer indirection for recv_t::data Something was wrong with the removal of pointer indirection, because on 32-bit Windows we got crash recovery failures. Curiously, WITH_ASAN of a 32-bit debug build did not notice anything. This reverts a part of commit `b7fc2c899e`. We have a 2MiB recv_sys.buf for the initial buffering. The minimum size of log_sys.buf would be 16MiB, and that buffer should be practically unused during recovery. If the buffer pool size is measured in gigabytes, it would indeed make sense to use the buffer pool for the recovered log records, perhaps after we have run out of log_sys.buf. FIXME: allow the entire buf_block_t::frame to be used for buffered log records, and remove MEM_HEAP_FOR_RECV_SYS. For example, use buf_page_t::list or buf_page_t::LRU for keeping track of memory that was allocated for recovery? Most members of buf_block_t (except buf_block_t::frame) are unused when block->page.state == BUF_BLOCK_MEMORY.	6 years ago
Marko Mäkelä	5164f8c206	Fix GCC 9.2.1 -Wstringop-truncation dict_table_rename_in_cache(): Use strcpy() instead of strncpy(), because they are known to be equivalent in this case (the length of old_name was already validated). mariabackup: Invoke strncpy() with one less than the buffer size, and explicitly add NUL as the last byte of the buffer.	6 years ago
Marko Mäkelä	f89436b592	MDEV-18115: Remove a unused variable	6 years ago
Marko Mäkelä	8f40c029db	Fix -Wmaybe-uninitialized Follow-up to commit 8965ae27b9f011333dd1e2dc47db6e0514b5976a: always initialize found_group.	6 years ago

1 2 3 4 5 ...

187837 Commits (a808c18b736762384e835746d19c7dae97d38990) All Branches Search

187837 Commits (a808c18b736762384e835746d19c7dae97d38990)

All Branches