mariadb

Tree: a808c18b73

Author	SHA1	Message	Date
Daniele Sciascia	2b5f4b3ed6	MDEV-17099 Preliminary changes for Galera XA support (#1401 ) Update wsrep-lib, and adapt to wsrep-lib interface changes.	6 years ago
Alexander Barkov	8ba5af7eaf	MDEV-20890 Illegal mix of collations with UUID()	6 years ago
Marko Mäkelä	88cdfc5c7d	MDEV-20487 Set innodb_adaptive_hash_index=OFF by default Based on the performance testing that was conducted in MDEV-17492, the InnoDB adaptive hash index could only help performance in specific, almost-read-only workloads. It could slow down all kinds of workloads (especially DROP TABLE, TRUNCATE TABLE, ALTER TABLE, or DROP INDEX operations), and it can become corrupted, causing crashes (such as MDEV-18815, MDEV-20203) and possibly data corruption. Furthermore, the adaptive hash index consumes space from the InnoDB buffer pool, which could hurt performance when the working set would almost fit in the buffer pool. Given all this, it is best to disable the adaptive hash index by default.	6 years ago
Sergei Golubchik	790a74d22b	Merge branch 'github/5.5' into 10.1	6 years ago
Jan Lindström	82f22d2f25	MDEV-18590 galera.versioning_trx_id: Test failure: mysqltest: Result content mismatch Ignore warning.	6 years ago
Jan Lindström	1036886b70	Stabilize tests. Changes to be committed: modified: mysql-test/suite/galera_sr/disabled.def modified: mysql-test/suite/galera_sr/r/GCF-561.result modified: mysql-test/suite/galera_sr/r/galera_sr_ddl_master.result modified: mysql-test/suite/galera_sr/r/galera_sr_kill_query.result modified: mysql-test/suite/galera_sr/r/galera_sr_shutdown_slave.result new file: mysql-test/suite/galera_sr/suite.pm modified: mysql-test/suite/galera_sr/t/GCF-561.test modified: mysql-test/suite/galera_sr/t/galera_sr_ddl_master.test modified: mysql-test/suite/galera_sr/t/galera_sr_kill_query.test modified: mysql-test/suite/galera_sr/t/galera_sr_shutdown_slave.test	6 years ago
Sergei Golubchik	803d0521a2	compilation failure on ppc with -DCMAKE_BUILD_TYPE=Debug if ${CRC32_LIBRARY} target has no COMPILE_FLAGS yet, GET_TARGET_PROPERTY returns COMPILE_FLAGS-NOTFOUND, which doesn't work very well when it's later fed back into COMPILE_FLAGS. GET_PROPERTY() returns an empty string in this case. Cherry-picked from 10.4 - `13e8f728ec` Signed-off-by: Vicențiu Ciorbaru <vicentiu@mariadb.org>	7 years ago
Michael Widenius	716d396bb3	Remove \n from DBUG_PRINT statements	6 years ago
Michael Widenius	06d2e1d828	read-only slave using statement replication should replicate tmp tables Relates to MDEV-17863 DROP TEMPORARY TABLE creates a transaction in binary log on read only server Other things: - Fixed that insert into normal_table select from tmp_table is replicated as row events if tmp_table doesn't exists on slave.	6 years ago
Monty	9c735784ae	Ensure that full_crc32_import doesn't fail Test should die if innodb_compression_algorithm=3 doesn't exists	6 years ago
Monty	c2e0a0b175	Server crashes with BACKUP STAGE and FLUSH TABLE table_name Fixes MDEV-18067, MDEV-18068 and MDEV-18069 The problem was that FLUSH TABLES table_name combined with UNLOCK TABLES calls MDL_context::set_transaction_duration_for_all_locks(), which changed backup_locks from MDL_EXPLICT to MDL_TRANSACTION. Fixed by ensuring that set_transaction_duration_for_all_locks() doesn't touch BACKUP locks.	6 years ago
Monty	18a44b4b4b	Don't crash in S3 if Aria is not initialzed	6 years ago
Monty	017150b747	Fixed compilation issue	6 years ago
Monty	7def2877e3	Write error message if aria_log.??????? files are missing This can happen if one uses a backup where not all aria_log.* files are copied or if the last one is too short. In this case the data files will contain data that is not in the logs and recovery will fail. Other things: - Fixed tprint() to not print extra new line to debug trace	6 years ago
Monty	67687d06bf	Simplify TABLE::decide_logging_format() - Use local variables table and share to simplify code - Use sql_command_flags to detect what kind of command was used - Added CF_DELETES_DATA to simplify detecton of delete commands - Removed duplicate error in create_table_from_items().	6 years ago
Monty	b62101f84b	Fixes for binary logging --read-only mode - Any temporary tables created under read-only mode will never be logged to binary log. Any usage of these tables to update normal tables, even after read-only has been disabled, will use row base logging (as the temporary table will not be on the slave). - Analyze, check and repair table will not be logged in read-only mode. Other things: - Removed not used varaibles in MYSQL_BIN_LOG::flush_and_set_pending_rows_event. - Set table_share->table_creation_was_logged for all normal tables. - THD::binlog_query() now returns -1 if statement was not logged., This is used to update table_share->table_creation_was_logged. - Don't log admin statements in opt_readonly is set. - Table's that doesn't have table_creation_was_logged will set binlog format to row logging. - Removed not needed/wrong setting of table->s->table_creation_was_logged in create_table_from_items()	6 years ago
Marko Mäkelä	2809842031	MDEV-20864 Introduce debug option innodb_change_buffer_dump To diagnose a hang in slow shutdown (innodb_fast_shutdown=0), let us introduce a Boolean startup option in debug builds that will cause the contents of the InnoDB change buffer to be dumped to the server error log at startup.	6 years ago
Sergei Golubchik	719ac0ad4a	crash in string-to-int conversion using a specially crafted strings one could overflow `shift` variable and cause a crash by dereferencing d10[-2147483648] (on a sufficiently old gcc). This is a correct fix and a test case for Bug #29723340: MYSQL SERVER CRASH AFTER SQL QUERY WITH DATA ?AST	6 years ago
Sergei Golubchik	412e3e6917	MDEV-9546 mysqlaccess script shows an old version (which was vulnerable to CVE-2005-0004) update mysqlaccess version	6 years ago
Oleksandr Byelkin	c9b5280371	MDEV-20466: fix of embedded test suite	6 years ago
Alexander Barkov	ec171a94a3	MDEV-20844 RBR from binary(16) to inet6 fails with error 171: The event was corrupt, leading to illegal data being read This patch changes the way how INET6 is packed to the RBR binary log: - from fixed length 16 bytes - to BINARY(16) compatible variable length style with trailing 0x00 byte compression. This is to make INET6 fully compatible with BINARY(16) in RBR binary logs, so RBR replication works in this scenarios: - Old master BINARY(16) -> New slave INET6 - New master INET6 -> Old slave BINARY(16) A new class StringPack was added to share the code between Field_string and Field_inet6.	6 years ago
Alexander Barkov	e0b6294338	MDEV-20855 Crash with PARTITION BY LIST and extended characters The code in convert_charset_partition_constant() did not take into account that the call for item->safe_charset_converter() can return NULL when conversion is not safe. Note, 10.2 was not affected. The test for NULL presents in 10.2, but it disappeared in 10.3 in a mistake. Restoring the test.	6 years ago
Alexander Barkov	9a833dc688	MDEV-20856 Bad values in metadata views for partitions on VARBINARY The old code to print partition values was too complicated: - it created new Items for character set conversion purposes. - it mixed string conversion and partition error reporting in the same code blocks. Simplifying the code as follows: - Adding helper methods String::can_be_safely_convert_to() and String::append_introducer_and_hex(). - Adding DBUG_EXECUTE_IF("generate_partition_syntax_for_frm", push_warning...) into generate_partition_syntax_for_frm(), to test the PARTITON clause written to FRM. Adding test partition_utf8-debug.test for this. - Removing functions get_cs_converted_part_value_from_string() and get_cs_converted_string_value. Changing get_partition_column_description() to use Type_handler::partition_field_append_value() instead. This makes SHOW CREATE TABLE and SELECT FROM I_S.PARTITIONS use the same code path. - Changing Type_handler::partition_field_append_value() not to call convert_charset_partition_constant(), to avoid creating a new Item for string conversion pursposes. Rewritting the code to use only String methods. - Removing error reporting code (ER_PARTITION_FUNCTION_IS_NOT_ALLOWED) from Type_handler::partition_field_append_value(). The error is correctly detected and reported on the caller level. So error reporting was redundant here. Also: - Moving methods Type_handler::partition_field_*() from sql_partition.cc to sql_type.cc. This fixes compilation problem with -DPLUGIN_PARTITION=NO, earlier introduced by the patch for MDEV-20831.	6 years ago
Marko Mäkelä	0b9cee2cbf	Merge 10.2 into 10.3	6 years ago
Oleksandr Byelkin	5b6b16636d	MDEV-20730: Syntax error on SELECT INTO @variable with CTE added forgotem WITH option to spacial case with INTO	6 years ago
Oleksandr Byelkin	de2186dd2f	MDEV-20074: Lost connection on update trigger Instead of checking lex->sql_command which does not corect in case of triggers mark tables for insert.	6 years ago
Marko Mäkelä	fa929f7cdf	Simplify row_undo_ins_remove_sec_low() Reduce the scope of some variables, remove a goto and a redundant assertion. For B-tree secondary indexes, this function can remove a delete-marked purgeable record, in case a row rollback of the INSERT was initiated due to an error in an earlier secondary index.	6 years ago
Marko Mäkelä	b027830232	MDEV-20850 Merge new release of InnoDB 5.7.28 to 10.2	6 years ago
Marko Mäkelä	fa32d28f2f	MDEV-20852 BtrBulk is unnecessarily holding dict_index_t::lock The BtrBulk class, which was introduced in MySQL 5.7, is by design the exclusive writer to an index. It is therefore unnecessary to acquire the dict_index_t::lock in that code. Holding the dict_index_t::lock would unnecessarily block other threads (SQL connections and the InnoDB purge threads) from buffering concurrent modifications to being-created secondary indexes. This fix is motivated by a change in MySQL 5.7.28: Bug #29008298 MYSQLD CRASHES ITSELF WHEN CREATING INDEX mysql/mysql-server@f9fb96c20f9d190f654e7aa2387255bf80fd6e45 PageBulk::init(), PageBulk::latch(): Never acquire m_index->lock. PageBulk::storeExt(): Remove some pointer indirection, and improve a debug assertion that seems to prove that some code is redundant. BtrBulk::pageCommit(): Assert that m_index->lock is not being held. btr_blob_log_check_t: Do not acquire m_index->lock if m_op == BTR_STORE_INSERT_BULK. Add UNIV_UNLIKELY hints around that condition. btr_store_big_rec_extern_fields(): Allow index->lock not to be held while op == BTR_STORE_INSERT_BULK. Add UNIV_UNLIKELY hints around that condition.	6 years ago
Olivier Bertrand	a00b713130	Fix wrong second parameter in snprintf	6 years ago
Alexander Barkov	9c96061525	Part2: MDEV-20837 Add MariaDB_FUNCTION_PLUGIN Removing MariaDB_FUNCTION_COLLECTION_PLUGIN	6 years ago
Alexander Barkov	5a052ab6b1	Part1: MDEV-20837 Add MariaDB_FUNCTION_PLUGIN - Defining MariaDB_FUNCTION_PLUGIN - Changing the code in /plugins/type_inet/ and /plugins/type_test/ to use MariaDB_FUNCTION_PLUGIN instead of MariaDB_FUNCTION_COLLECTION_PLUGIN. - Changing maturity for the INET6 data type plugin from experimental to alpha.	6 years ago
Olivier Bertrand	b56589eaf2	Some small changes. =================== - Fix unhandled throws, add some trace + typo modified: storage/connect/jdbconn.cpp modified: storage/connect/tabodbc.cpp modified: storage/connect/valblk.cpp modified: storage/connect/value.cpp	6 years ago
Monty	3ce14a66ef	Fixed bug in lock tables + alter table with Aria tables. MDEV-18451 Server crashes in maria_create_trn_for_mysql upon ALTER TABLE Problem was that when table was locked many times, not all instances where removed from the transaction by _ma_remove_table_from_trnman()	6 years ago
Jan Lindström	6cdde9ebbf	MDEV-20836 : Galera test failure on wsrep.variables Add one more wait to make sure all threads have been started.	6 years ago
seppo	421d52e896	MDEV-6860 Parallel async replication hangs (#1400 ) Instrumenting parallel slave worker thread with wsrep replication hooks. Added mtr test for testing parallel slave support. The test is based on the test attached in MDEV-6860 jira tracker.	6 years ago
Oleksandr Byelkin	b7bc8c3fcb	MDEV-20466: fix of test suite	6 years ago
Monty	7952f7720f	MDEV-10748 Server crashes in ha_maria::implicit_commit Problem was in a combination of LOCK TABLES on several Aria tables followed by an ALTER TABLE. After the ALTER TABLE there was a force close + reopen of the alter table. The close failed because the table was still part of a transaction. Fixed by calling extra(HA_EXTRA_PREPARE_FOR_FORCED_CLOSE) as part of closing the table, which ensures that the table is not anymore part of the current transaction.	6 years ago
Alexander Barkov	22b645ef52	MDEV-20831 Table partitioned by LIST/RANGE COLUMNS(inet6) can be created, but not inserted into This clause in CREATE TABLE: PARTITION BY LIST COLUMNS (inet6column) (PARTITION p1 VALUES IN ('::')) was erroneously written to frm file as: PARTITION BY LIST COLUMNS(inet6column) (PARTITION p1 VALUES IN (_binary 0x3A3A)) I.e. the text value '::' was converted to HEX representation and prefixed with _binary. A simple fix could write `_latin1 0x3A3A` instead of `_binary 0x3A3A`, but in case of INET6 we don't need neither character set introducers, nor HEX encoding, because text representation of INET6 values consist of pure ASCII characters. So this patch changes the above clause to be printed as: PARTITION BY LIST COLUMNS(inet6column) (PARTITION p1 VALUES IN ('::')) Details: The old code in check_part_field() was not friendly to pluggable data types. Replacing this function to two new virtual methods in Type_handler: virtual bool partition_field_check(const LEX_CSTRING &field_name, Item item_expr) const; virtual bool partition_field_append_value(String str, Item item_expr, CHARSET_INFO field_cs, partition_value_print_mode_t mode) const; so data type plugins can decide whether they need to use character set introducer and/or hex encoding when printing partition values.	6 years ago
Oleksandr Byelkin	4ba763db77	MDEV-13172: Wrong result / SELECT ... WHERE EXISTS ... (with UNIQUE Key) IS NULL or <=> with unique field does not mean unique row, because several NULL possible, so we can not convert to normal join in this case.	6 years ago
Aleksey Midenkov	7ae0be25a6	MDEV-20812 Unexpected ER_ROW_IS_REFERENCED_2 upon DELETE from versioned table with FK MDEV-16210 original case was wrongly allowed versioned DELETE from referenced table where reference is by non-primary key. InnoDB UPDATE has optimization for new rows not changing its clustered index position. In this case InnoDB doesn't update all secondary indexes and misses the one holding the referenced key. The fix was to disable this optimization for versioned DELETE. In case of versioned DELETE we forcely update all secondary indexes and therefore check them for constraints. But the above fix raised another problem with versioned DELETE on foreign table side. In case when there was no corresponding record in referenced table (illegal foreign reference can be done with "set foreign_key_checks=off") there was spurious constraint check (because versioned DELETE is actually UPDATE) and hence the operation failed with constraint error. MDEV-16210 tried to fix the above problem by checking foreign table instead of referenced table and that at least was illegal. Constraint check is done by row_ins_check_foreign_constraint() no matter what kind of table is checked, referenced or foreign (controlled by check_ref argument). Referenced table is checked by row_upd_check_references_constraints(). Foreign table is checked by row_ins_check_foreign_constraints(). Current fix rolls back the wrong fix for the above problem and disables referenced table check for DELETE on foreign side by introducing `check_foreign` argument which when set to false skips row_ins_check_foreign_constraints() call.	6 years ago
Oleksandr Byelkin	c2854c7863	MDEV-20466: SHOW PROCESSLIST truncates query text on \0 bytes Data should be sent with length.	6 years ago
Eugene Kosov	4d14785546	MDEV-20778 UBSAN: call to function free_rpl_filter() through pointer to incorrect function type Proper C-style type erasure is done via void, not via char or something else. free_key_cache() free_rpl_filter(): types were fixed to avoid function pointer type cast which is still undefined behavior. Note, that casting from void* to any other pointer type is safe and correct.	6 years ago
Alexander Barkov	8ec978142b	MDEV-20822 INET6 crashes in combination with RBR extended metadata The code erroneously assumed that only Field_str descendants can store character set information. After adding Field_inet6, it's not true anymore. Also, after adding Field_inet6, storing field->charset() become not correct either: - Field_inet6::charset() return &my_charset_latin1, because clients see INET6 as VARCHAR(39). - Field_inet6::binlog_type_info().m_cs returns &my_charset_bin because storage engines see INET6 as BINARY(16). We need to store &my_charset_bin to the binlog metadata, so the slave sees INET6 as BINARY(16), like storage engines do, to make the slave treat the replicated data as binary IPv6 address representation (rather than text representation). The correct character set that needs to be stored to the metadata is already populated to binlog_type_info_array[i].m_cs. So the fixed code version uses this value rather than field->charset().	6 years ago
Alexander Barkov	a11694b80d	MDEV-20826 Wrong result of MIN(inet6) with GROUP BY Type_handler_inet6::is_val_native_ready() was not overriden and returned "false" by default, so Item_sum_min_max::update_field() erroneously went through the min_max_update_str_field() rather than min_max_update_native_field() execution path. As a result '8888::' was compared to 'fff::' in string format (rather than INET6 binary format) and gave "less" instead of "greater". Adding the forgotten overriding method returning "true".	6 years ago
Marko Mäkelä	f989c0ce66	MDEV-20813: Do not rotate keys for unallocated pages fil_crypt_rotate_page(): Skip the key rotation for pages that carry 0 in FIL_PAGE_TYPE. This avoids not only unnecessary writes, but also failures of the recently added debug assertion in buf_flush_init_for_writing() that the FIL_PAGE_TYPE should be nonzero. Note: the debug assertion can fail if the file was originally created before MySQL 5.5. In old InnoDB versions, FIL_PAGE_TYPE was only initialized for B-tree pages, to FIL_PAGE_INDEX. For any other pages, the field could be garbage, including FIL_PAGE_INDEX. In MariaDB 10.2 and later, buf_flush_init_for_writing() would initialize the FIL_PAGE_TYPE on such old pages, but only after passing the debug assertion that insists that pages have a nonzero FIL_PAGE_TYPE. Thus, the debug assertion at the start of buf_flush_init_for_writing() can fail when upgrading from very old debug files. This assertion is only present in debug builds, not release builds.	6 years ago
Marko Mäkelä	4f9f3f19cd	Merge 10.1 into 10.2 Do not merge the InnoDB changes for MDEV-20813.	6 years ago
Marko Mäkelä	ae702d7643	MDEV-20813: Remove the buf_flush_init_for_writing() assertion Old InnoDB/XtraDB versions only initialized FIL_PAGE_TYPE for B-tree pages (to FIL_PAGE_INDEX), and left it uninitialized (possibly containing FIL_PAGE_INDEX) for others. In MySQL or MariaDB 5.5, the field is initialized on almost all pages, but still not all of them. In MariaDB 10.2 and later, buf_flush_init_for_writing() would initialize the FIL_PAGE_TYPE on such old pages, but only after passing the debug assertion that we are now removing from 10.1. There, we will be able to modify fil_crypt_rotate_page() so that it will skip the key rotation for pages that contain 0 in FIL_PAGE_TYPE. In MariaDB 10.1, there is no logic that would initialize FIL_PAGE_TYPE on data pages in old data files after an update. So, encryption key rotation may routinely cause page flushes on pages that contain 0 in FIL_PAGE_TYPE.	6 years ago
Marko Mäkelä	2920377aa0	MDEV-19740: Fix C++11 violations caught by GCC 9.2.1 This is a backport of commit `ec28f9532e` to MariaDB Server 10.1.	6 years ago
Alexey Botchkov	ba8e5e689c	MDEV-16620 JSON_ARRAYAGG and JSON_OBJECTAGG. Ison_objectagg implemented.	6 years ago

... 3 4 5 6 7 ...

187837 Commits (a808c18b736762384e835746d19c7dae97d38990) All Branches Search

187837 Commits (a808c18b736762384e835746d19c7dae97d38990)

All Branches