mariadb

Tree: a01773dbee

Author	SHA1	Message	Date
Mattias Jonsson	a01773dbee	Bug#51851: Server with SBR locks mutex twice on LOAD DATA into partitioned MyISAM table Problem was that both partitioning and myisam used the same table_share->mutex for different protections (auto inc and repair). Solved by adding a specific mutex for the partitioning auto_increment. Also adding destroying the ha_data structure in free_table_share (which is to be propagated into 5.5). This is a 5.1 ONLY patch, already fixed in 5.5+.	15 years ago
Davi Arnaut	a73b734949	Bug#55846: Link tests fail on Windows - my_compiler.h missing Make the my_compiler.h header, like my_attribute.h, part of the distribution. This is required due to the dependency of the former on the latter (which can undefine __attribute__).	15 years ago
Gleb Shchepa	7a343e0c82	automerge local --> 5.1-bugteam (bug 53034)	15 years ago
Gleb Shchepa	9554b7ac6e	Bug #53034 : Multiple-table DELETE statements not accepting "Access compatibility" syntax The "wild" "DELETE FROM table_name.* ... USING ..." syntax for multi-table DELETE statements is documented but it was lost in the fix for the bug 30234. The table_ident_opt_wild parser rule has been added to restore the lost syntax.	15 years ago
Ramil Kalimullin	03d0aedd8e	Automerge.	15 years ago
Ramil Kalimullin	9c6143ef80	Fix for bug #51875 : crash when loading data into geometry function polyfromwkb Check for number of line strings in the incoming polygon data (wkb) and for number of points in the incoming linestring wkb.	15 years ago
Alexey Kopytov	d5b40686b0	Automerge.	15 years ago
Vasil Dimov	74c32d69b0	Merge mysql-5.1-innodb -> mysql-5.1-bugteam	15 years ago
Alexey Kopytov	b409a2218e	Bug #54465 : assert: field_types == 0 \|\| field_types[field_pos] == MYSQL_TYPE_LONGLONG A MIN/MAX() function with a subquery as its argument could lead to a debug assertion on debug builds or wrong data on release ones. The problem was a combination of the following factors: - Item_sum_hybrid::fix_fields() might use the argument (args[0]) to calculate 'hybrid_field_type' which was later used to decide how the data should be sent to the client. - Item_sum::make_field() might use the argument again to calculate the field's type when sending result set metadata to the client. - The argument could be changed in between these two calls via Item::set_arg() leading to inconsistent metadata being reported. Here is what was happening for the bug's test case: 1. Item_sum_hybrid::fix_fields() calculates hybrid_field_type as MYSQL_TYPE_LONGLONG based on args[0] which is an Item::SUBSELECT_ITEM at that time. 2. A temporary table is created to execute the query. create_tmp_field_from_item() creates a Field_long object according to the subselect's max_length. 3. The subselect item in Item_sum_hybrid is replaced by the Item_field object referencing the newly created Field_long. 4. Item_sum::make_field() rightfully returns the MYSQL_TYPE_LONG type when calculating the result set metadata. 5. When sending the actual data, Item::send() relies on the virtual field_type() function which in our case returns previously calculated hybrid_field_type == MYSQL_TYPE_LONGLONG. It looks like the only solution is to never refer to the argument's metadata after the result metadata has been calculated in fix_fields(), since the argument itself may be different by then. In this sense, Item_sum::make_field() should never be used, because it may rely on the argument's metadata and is only called after fix_fields(). The "default" implementation in Item::make_field() should be used instead as it relies only on field_type(), but not on the argument's type. Fixed by removing Item_sum::make_field() so that the superclass implementation Item::make_field() is always used.	15 years ago
Ramil Kalimullin	1087cfc4d5	Fix for bug #54253 : memory leak when using I_S plugins w/o deinit method Free memory allocated by the server for all plugins, with or without deinit() method.	15 years ago
Vasil Dimov	72ec16b1d1	Increment InnoDB Plugin version to 1.0.12. InnoDB Plugin 1.0.11 has been released with MySQL 5.1.50.	15 years ago
Bjorn Munch	fba50f8401	Reduced #ifndef for 52301, caused compile warning	15 years ago
Alexey Kopytov	2df3a61c3f	Automerge.	15 years ago
Sergey Vojtovich	0648087ca0	Fixed race condition in a test case for BUG#55580.	15 years ago
Evgeny Potemkin	151af144ff	Bug #55656 : mysqldump can be slower after bug 39653 fix. After fix for bug 39653 the shortest available secondary index was used for full table scan. Primary clustered key was used only if no secondary index can be used. However, when chosen secondary index includes all fields of the table being scanned it's better to use primary index since the amount of data to scan is the same but the primary index is clustered. Now the find_shortest_key function takes this into account.	15 years ago
Bjorn Munch	79aefacb04	merge followup fix for 52301	15 years ago
Bjorn Munch	16b7af9ae0	Cherry pick 55501	15 years ago
Dmitry Shulga	8520a9fd62	Fixed bug #29751 - do not rename the error log at FLUSH LOGS. Added open log file with FILE_SHARE_DELETE flag on Windows.	15 years ago
Bjorn Munch	a22b5651fd	Bug #52301 Add --protocol to mysqltest Added code resulted in strange linking problem for embedded on Windows Avoided by not doing this for embedded mode It's irrelevant for embedded server anyway, --protocol will be ignored	15 years ago
Alexey Kopytov	756076bd23	Bug #54802 : 'NOT BETWEEN' evaluation is incorrect Queries involving predicates of the form "const NOT BETWEEN not_indexed_column AND indexed_column" could return wrong data due to incorrect handling by the range optimizer. For "c NOT BETWEEN f1 AND f2" predicates, get_mm_tree() produces a disjunction of the SEL_ARG trees for "f1 > c" and "f2 < c". If one of the trees is empty (i.e. one of the arguments is not sargable) the resulting tree should be empty as well, since the whole expression in this case is not sargable. The above logic is implemented in get_mm_tree() as follows. The initial state of the resulting tree is NULL (aka empty). We then iterate through arguments and compute the corresponding SEL_ARG tree (either "f1 > c" or "f2 < c"). If the resulting tree is NULL, it is simply replaced by the generated tree. Otherwise it is replaced by a disjunction of itself and the generated tree. The obvious flaw in this implementation is that if the first argument is not sargable and thus produces a NULL tree, the resulting tree will simply be replaced by the tree for the second argument. As a result, "c NOT BETWEEN f1 AND f2" will end up as just "f2 < c". Fixed by adding a check so that when the first argument produces an empty tree for the NOT BETWEEN case, the loop is aborted with an empty tree as a result. The whole idea of using a loop for 2 arguments does not make much sense, but it was probably used to avoid code duplication for several BETWEEN variants.	15 years ago
Marko Mäkelä	ce7d6a288c	Bug#55832: selects crash too easily when innodb_force_recovery>3 dict_update_statistics_low(): Create bogus statistics for those indexes that cannot be accessed because of the innodb_force_recovery setting. ha_innobase::info(): Calculate statistics for each index, even if innodb_force_recovery is set. Fill in bogus data for those indexes that are not accessed because of the innodb_force_recovery setting.	15 years ago
Marko Mäkelä	109893dac0	Bug#55832: selects crash too easily when innodb_force_recovery>3 dict_update_statistics_low(): Create bogus statistics for those indexes that cannot be accessed because of the innodb_force_recovery setting. ha_innobase::info(): Calculate statistics for each index, even if innodb_force_recovery is set. Fill in bogus data for those indexes that are not accessed because of the innodb_force_recovery setting.	15 years ago
Mattias Jonsson	6973c354de	post push test fix	15 years ago
Georgi Kodinov	bbaad8880e	merge	15 years ago
Georgi Kodinov	f1517f4861	merge	15 years ago
Georgi Kodinov	f2adff5da1	merge	15 years ago
Sunny Bains	54fd56c5c3	Fix Bug #54538 - use of exclusive innodb dictionary lock limits performance. This patch doesn't get rid of the need to acquire the dict_sys->mutex but reduces the need to keep the mutex locked for the duration of the query to fsp_get_available_space_in_free_extents() from ha_innobase::info(). rb://390.	15 years ago
Sunny Bains	eff4a5d202	Fix Bug #55027 : assertion: mutex_own(&dict_sys->mutex) in dict_table_get_on_id() The callers should indicate that the dictionary is locked or not using the trx->dict_operation_lock_mode == RW_X_LATCH mode. Checking explicitly for system tables is unnecessary. Approved by Marko on IRC.	15 years ago
Sunny Bains	73c92b1408	Fix bug#55699 - Assertion failure in innodb plugin with large number of threads Fix a debug assertion that was missed in svnrev:2380 (fix for Bug# 35352). Approved by Marko on IRC	15 years ago
karen.langford@oracle.com	05d0568bee	Merge from mysql-5.1.50-release	15 years ago
MySQL Build Team	12e10ba2ba	Raise the version number, 5.1.50 is (was) being built in a parellel tree.	15 years ago
Mattias Jonsson	89d7ac6007	merge	15 years ago
Marko Mäkelä	d3a7ef9913	Bug#55626: MIN and MAX reading a delete-marked record from secondary index Remove a bogus debug assertion that triggered the bug. Add assertions precisely where records must not be delete-marked. And a comment to clarify when the record is allowed to be delete-marked.	15 years ago
	b766a51f41	WL#5370 Keep forward-compatibility when changing 'CREATE TABLE IF NOT EXISTS ... SELECT' behaviour BUG#55474, BUG#55499, BUG#55598, BUG#55616 and BUG#55777 are fixed in this patch too. This is the 5.1 part. It implements: - if the table exists, binlog two events: CREATE TABLE IF NOT EXISTS and INSERT ... SELECT - Insert nothing and binlog nothing on master if the existing object is a view. It only generates a warning that table already exists.	15 years ago
Vasil Dimov	ae55711efa	Merge mysql-5.1-innodb from bk-internal into my local tree	15 years ago
Vasil Dimov	fbfbe2a6eb	Disable all innodb_plugin tests on Solaris until the problem is resolved. Track this via: Bug#56063 InnoDB Plugin mysql-tests fail on Solaris	15 years ago
Georgi Kodinov	12f7d57d42	Bug #55580 : segfault in read_view_sees_trx_id The server was not checking for errors generated during the execution of Item::val_xxx() methods when copying data to the group, order, or distinct temp table's row. Fixed by extending the copy_funcs() to return an error code and by checking for that error code on the places copy_funcs() is called. Test case added.	15 years ago
Georgi Kodinov	b6e3adf10f	Bug #55565 : debug assertion when ordering by expressions with user variable assignments The assert() that is firing is checking if expressions that can't be null return a NULL when evaluated. MAKEDATE() function can return NULL if the second argument is less then or equal to 0. Thus its nullability depends not only on the nullability of its arguments but also on their values. Fixed by (overoptimistically) setting MAKEDATE() to be nullable despite the nullability of its arguments. Test added. Had to update one test result to reflect the metadata change.	15 years ago
Martin Hansson	a89224ba85	Bug#54444: Do not run main.range test for products without partitioning feature The test for bug no 50939 was put in range.test which isn't such a good idea since it requires partitioning. Fixed by moving the test case to partitioning_range.test.	15 years ago
Georgi Kodinov	11b1c9b76c	merge	15 years ago
Georgi Kodinov	5781bfa271	Bug #55809 : Server README not current Updated the README file.	15 years ago
Jon Olav Hauglid	cc3be1aee0	Bug #54106 assert in Protocol::end_statement, INSERT IGNORE ... SELECT ... UNION SELECT ... This assert was triggered by INSERT IGNORE ... SELECT. The assert checks that a statement either sends OK or an error to the client. If the bug was triggered on release builds, it caused OK to be sent to the client instead of the correct error message (in this case ER_FIELD_SPECIFIED_TWICE). The reason the assert was triggered, was that lex->no_error was set to TRUE during JOIN::optimize() because of IGNORE. This causes all errors to be ignored. However, not all errors can be ignored. Some, such as ER_FIELD_SPECIFIED_TWICE will cause the INSERT to fail no matter what. But since lex->no_error was set, the critical errors were ignored, the INSERT failed and neither OK nor the error message was sent to the client. This patch fixes the problem by temporarily turning off lex->no_error in places where errors cannot be ignored during processing of INSERT ... SELECT. Test case added to insert.test.	15 years ago
Georgi Kodinov	87acb536f1	Bug #54909 : Confusing description about read_buffer_size and read_rnd_buffer_size Applied the updated description from Paul's patch.	16 years ago
Jimmy Yang	ff8cf2e974	Address bug #55465 ERROR 1280 (42000): Incorrect index name '<index name>', adding a couple FK related messages. rb://409 approved by Sunny Bains	16 years ago
Bjorn Munch	ae2c3d62e9	Bug #55503 MTR fails to filter LEAK SUMMARY from valgrind report of restarted servers Undo workaround as fix is being merged in	16 years ago
Bjorn Munch	8e242e8140	merge from 5.1-mtr	16 years ago
Inaam Rana	372999ed01	Backport of revno 3148 mysql-innodb-trunk Currently we do a full validation of AHI whenever check tables is called on any table. This patch fixes this by only doing this full check in debug versions. bug#55716 rb://423 approved by: Marko	16 years ago
Georgi Kodinov	82e2ca0181	Addendum to bug #42144 : fixed a wrong type conversation causing plugin tests failures on sparc64.	16 years ago
Martin Hansson	f77996950a	Bug#54568: create view cause Assertion failed: 0, file .\item_subselect.cc, line 836 IN quantified predicates are never executed directly. They are rather wrapped inside nodes called IN Optimizers (Item_in_optimizer) which take care of the execution. However, this is not done during query preparation. Unfortunately the LIKE predicate pre-evaluates constant right-hand side arguments even during name resolution. Likely this is meant as an optimization. Fixed by not pre-evaluating LIKE arguments in view prepare mode.	16 years ago
Georgi Kodinov	84686593ad	Bug #42144 : plugin_load fails Reverted the ulong->uint diff Re-applied the first diff. The original commit message follows: enum plugin system variables are ulong internally, not int. On systems where long is not the same as an int it causes problems. Fixed by correct typecasting. Removed the test from the experimental list.	16 years ago

1 2 3 4 5 ...

63040 Commits (a01773dbee1318e0894057daed544188b14f90c8) All Branches Search

63040 Commits (a01773dbee1318e0894057daed544188b14f90c8)

All Branches