mariadb

Tree: 99cce18955

Author	SHA1	Message	Date
unknown	99cce18955	Fixed LP BUG#800696. The problem was that optimizer removes some outer references (it they are constant for example) and the list of outer items built during prepare phase is not actual during execution phase when we need it as the cache parameters. First solution was use pointer on pointer on outer reference Item and initialize temporary table on demand. This solved most problem except case when optimiser also reduce Item which contains outer references ('OR' in this bug test suite). The solution is to build the list of outer reference items on execution phase (after optimization) on demand (just before temporary table creation) by walking Item tree and finding outer references among Item_ident (Item_field/Item_ref) and Item_sum items. Removed depends_on list (because it is not neede any mnore for the cache, in the place where it was used it replaced with upper_refs). Added processor (collect_outer_ref_processor) and get_cache_parameters() methods to collect outer references (or other expression parameters in future). mysql-test/r/subselect_cache.result: A new test added. mysql-test/r/subselect_scache.result: Changes in creating the cache and its paremeters order or adding arguments of aggregate function (which is a parameter also, but this has no influence on the result). mysql-test/t/subselect_cache.test: Added a new test. sql/item.cc: depends_on removed. Added processor (collect_outer_ref_processor) and get_cache_parameters() methods to collect outer references. Item_cache_wrapper collect parameters befor initialization of its cache. sql/item.h: depends_on removed. Added processor (collect_outer_ref_processor) and get_cache_parameters() methods to collect outer references. sql/item_cmpfunc.cc: depends_on removed. Added processor (collect_outer_ref_processor) to collect outer references. sql/item_cmpfunc.h: Added processor (collect_outer_ref_processor) to collect outer references. sql/item_subselect.cc: depends_on removed. Added processor get_cache_parameters() method to collect outer references. sql/item_subselect.h: depends_on removed. Added processor get_cache_parameters() method to collect outer references. sql/item_sum.cc: Added processor (collect_outer_ref_processor) method to collect outer references. sql/item_sum.h: Added processor (collect_outer_ref_processor) and get_cache_parameters() methods to collect outer references. sql/opt_range.cc: depends_on removed. sql/sql_base.cc: depends_on removed. sql/sql_class.h: New iterator added. sql/sql_expression_cache.cc: Build of list of items resolved in outer query done just before creating expression cache on the first execution of the subquery which removes influence of optimizer removing items (all optimization already done). sql/sql_expression_cache.h: Build of list of items resolved in outer query done just before creating expression cache on the first execution of the subquery which removes influence of optimizer removing items (all optimization already done). sql/sql_lex.cc: depends_on removed. sql/sql_lex.h: depends_on removed. sql/sql_list.h: Added add_unique method to add only unique elements to the list. sql/sql_select.cc: Support of new Item list added. sql/sql_select.h: Support of new Item list added.	15 years ago
Sergey Petrunya	5df875b02b	BUG#803303: Wrong result with semijoin=on, outer join in maria-5.3-subqueries-mwl90 - Add testcase.	15 years ago
Sergey Petrunya	775ac38dcd	Buildbot fixes: add --sorted-result	15 years ago
Sergey Petrunya	265b51df73	Merge	15 years ago
Igor Babaev	cfc7896461	Merge.	15 years ago
Igor Babaev	fdad40630e	Merge.	15 years ago
Igor Babaev	f392edab02	Fixed valgrind problems of the patch for bug 794901.	15 years ago
unknown	c9e236828e	Fix bug lp:782305 Analysis: Both the wrong result and the valgrind warning were a result of incomplete cleanup of the MIN/MAX subquery rewrite. At the first execution of the query, the non-aggregate subquery is transformed into an aggregate MIN/MAX subquery. During the fix_fields phase of the MIN/MAX function, it sets the property st_select_lex::with_sum_func to true. The second execution of the query finds this flag to be ON. When optimization reaches the same MIN/MAX subquery transformation, it tests if the subquery is an aggregate or not. Since select_lex->with_sum_func == true from the previous execution, the transformation executes the second branch that handles aggregate subqueries. This substitutes the subquery Item into a Item_maxmin_subselect. At the same time elsewhere it is assumed that the subquery Item is of type Item_allany_subselect. Ultimately this results in casting the actual object to the wrong class, and calling the wrong any_value() method from empty_underlying_subquery(). Solution: Cleanup the st_select_lex::with_sum_func property in the case when the MIN/MAX transformation was performed for a non-aggregate subquery, so that the transformation can be repeated.	15 years ago
Igor Babaev	a7287d9ae1	Fixed LP bug #793448 . This bug could lead to wrong result sets for a query over a materialized derived table or view accessed by a multi-component key. It happened because the function get_next_field_for_derived_key was supposed to update its argument, and it did not do it.	15 years ago
Igor Babaev	cc0195d6a1	Merge with the latest 5.3 code.	15 years ago
Igor Babaev	d37465a9cc	Fixed LP bug #794901 . Also: 1. simplified the code of the function mysql_derived_merge_for_insert. 2. moved merge of views/dt for multi-update/delete to the prepare stage. 3. the list of the references to the candidates for semi-join now is allocated in the statement memory.	15 years ago
unknown	c1b6eb1490	Merge of subquery cache off by default.	15 years ago
unknown	af284b55f0	Make subquery cache off by default. mysql-test/r/subselect_scache.result: Test with subquery cache on. mysql-test/t/subselect_scache.test: Test with subquery cache on.	15 years ago
unknown	06fb641c0b	Automatic merge.	15 years ago
Igor Babaev	03081bc1fd	Changed the default setting of the optimizer switch 'optimize_join_buffer_size'. Made it 'off' by default.	15 years ago
Sergey Petrunya	0a12fa2922	Merge	15 years ago
Sergey Petrunya	0aaae1e31d	Test result update forgotten in pre-previous cset.	15 years ago
Sergey Petrunya	08fa757a73	Valgrind fix for the previous cset: - {ha_myisam,ha_maria}::index_read_idx_map should also initialize end_range, because index condition function will attempt to check it. We initialize it like index_init() does.	15 years ago
Sergey Petrunya	56a23357ae	BUG#803457: Wrong result with semijoin + view + outer join in maria-5.3-subqueries-mwl90 (This is not a real fix for this bug, even though it makes it to no longer repeat) - Semi-join subquery predicates, i.e. ... WHERE outer_expr IN (SELECT ...) may have null-rejecting properties, may allow to convert outer joins into inner. - When convert_subq_to_sj() injected IN-equality into parent's WHERE/ON clause, it didn't call $new_cond->top_level_item(), which would cause null-rejecting properties to be lost. - Fixed, now the mentioned outer-to-inner conversion will really take place.	15 years ago
unknown	445fcaa81a	MWL#68 efficient partial matching - Added an initial set of feature-specific test cases - Handled the special case where the materialized subquery of an IN predicates consists of only NULL values. - Fixed a bug where making Item_in_subselect a constant, didn't respect its null_value value.	15 years ago
Sergey Petrunya	932d516656	Merge	15 years ago
Sergey Petrunya	2a9c86be26	BUG#778434 Wrong result with in_to_exists=on in maria-5.3-mwl89 - Make {ha_myisam,ha_maria}::index_read_idx_map check pushed index condition. - Address review feedback (added comments)	15 years ago
unknown	53681ee5db	Fix bug lp:777691 Analysis: For some of the re-executions of the correlated subquery the where clause is false. In these cases the execution of the subquery detects that it must generate a NULL row because of implicit grouping. In this case the subquery execution reaches the following code in do_select(): while ((table= li++)) mark_as_null_row(table->table); This code marks all rows in the table as complete NULL rows. In the example, when evaluating the field t2.f10 for the second row, all bits of Field::null_ptr[0] are set by the previous call to mark_as_null_row(). Then the call to Field::is_null() returns true, resulting in a NULL for the MAX function. Thus the lines above are not suitable for subquery re-execution because mark_as_null_row() changes the NULL bits of each table field, and there is no logic to restore these fields. Solution: The call to mark_as_null_row() was added by the fix for bug lp:613029. Therefore removing the fix for lp:613029 corrects this wrong result. At the same time the test for lp:613029 behaves correctly because the changes of MWL#89 result in a different execution path where: - the constant subquery is evaluated via JOIN::exec_const_cond - detecting that it has an empty result triggers the branch if (zero_result_cause) return_zero_rows() - return_zero_rows() calls mark_as_null_row().	15 years ago
unknown	c4097382ef	Automatic merge.	15 years ago
Igor Babaev	b1a177e438	Merge.	15 years ago
Igor Babaev	ff9c406c1d	Fixed LP bug #809179 . The attribute not_null_tables could be calculated incorrectly in the function SELECT_LEX::update_used_tables for queries over views with row items in the WHERE clause. It happened because no implementation of the virtual callback function eval_not_null_tables was provided for the class Item_row. Also slightly optimized the code calculating the value of the maybe_null flag for tables in the function SELECT_LEX::update_used_tables.	15 years ago
Igor Babaev	70455c517b	Corrected the patch for bug 809206 to fix valgrind failures.	15 years ago
Sergey Petrunya	85571ea76c	Disable LooseScan and FirstMatch when outer joins are present.	15 years ago
unknown	1e6bd6b4df	Fix bug lp:809266 Analysis: This is a bug in MWL#68, where it was incorrectly assumed that if there is a match in the only non-null key, then if there is a covering NULL row on all remaining NULL-able columns there is a partial match. However, this is not the case, because even if there is such a null-only sub-row, it is not guaranteed to be part of the matched sub-row. The matched sub-row and the NULL-only sub-row may be parts of different rows. In fact there are two cases: - there is a complete row with only NULL values, and - all nullable columns contain only NULL values. These two cases were incorrectly mixed up in the class member subselect_partial_match_engine::covering_null_row_width. Solution: The solution is to: - split covering_null_row_width into two members: has_covering_null_row, and has_covering_null_columns, and - take into account each state during initialization and execution.	15 years ago
Igor Babaev	7c46dc525e	Merge.	15 years ago
Igor Babaev	102fb4e0b8	Corrected the code of the recent patch that had changed the base class for Item_func_xor. Added the implementation of the subst_argument_checker virtual method that the objects of this class used to use before the patch. Reverted the previous result changes in sunselect_sj and subselect_sj_jcl6.	15 years ago
unknown	61eb3423b4	Merged the fix for bug lp:608744	15 years ago
unknown	990584d73a	Fixed bug lp:809245 In addition to the bug fix explained below, the patch performs few renames, and adds some comments to avoid similar problems. Analysis: The failed assert was due to a bug in MWL#68, where it was incorrectly assumed that the size of the bitmap subselect_rowid_merge_engine::null_only_columns should be the same as the size of the array of Ordered_keys. The bitmap null_only_columns contains bits to mark columns that contain only NULLs. Therefore the indexes of the bits to be set in null_only_columns are different from the indexes of the Ordered_keys. If there is a NULL-only column that appears in a table after the last partial match column with Ordered_key, this NULL-only column would require setting a bit with index bigger than the size of the bitmap null_only_columns. Accessing such a bit caused the failed assert. Solution: Upon analysis, it turns out that null_only_columns is not needed at all, because we are looking for partial matches, and having such columns guarantees that there is a partial match for any corresponding outer value. Therefore the patch removes subselect_rowid_merge_engine::null_only_columns.	15 years ago
Sergey Petrunya	bf28449803	Update test results for previous cset	15 years ago
Igor Babaev	5819dfcdf6	Fixed LP bug #809206 . The bitmap of used tables must be evaluated for the select list of every materialized derived table / view and saved in a dedicated field. This is also applied to materialized subqueries.	15 years ago
Sergey Petrunya	419c20f10a	Merge	15 years ago
Igor Babaev	6e5413853e	Merge with the latest 5.3 code.	15 years ago
Sergey Petrunya	2c28412e2e	Port of code for: (part of testcase is in mysql-test/t/subquery*.test and will be ported separately) Bug#11766642: crash in Item_field::register_field_in_read_map with view (Former 59793) Prior to the refactoring in this patch, Item_cond_xor behaved partially as an Item_cond and partially as an Item_func. The reasoning behind this was that XOR is currently not optimized (thus should be Item_func instead of Item_cond), but it was planned optimize it in the future (thus, made Item_cond anyway to ease optimization later). Even though Item_cond inherits from Item_func, there are differences between these two. One difference is that the arguments are stored differently. Item_cond stores them in a list while Item_func store them in an args[]. BUG no 45221 was caused by Item_cond_xor storing arguments in the list while users of the objects would look for them in args[]. The fix back then was to store the arguments in both locations. In this bug, Item_cond_xor initially gets two Item_field arguments. These are stored in the list inherited from Item_cond and in args[] inherited from Item_func. During resolution, find_field_in_view() replaces the Item_fields stored in the list with Item_direct_view_refs, but args[] still points to the unresolved Item_fields. This shows that the fix for 45221 was incorrect. The refactoring performed in this patch removes the confusion by making the XOR item an Item_func period. A neg_transformer() is also implemented for Item_func_xor to improve performance when negating XOR expressions. An XOR is negated by negating one of the operands.	15 years ago
Igor Babaev	47aee19827	Fixed LP bug #793386 . Auto-generated names for view field items must be allocated in the statement memory, not in the execution memory of the statement.	15 years ago
Sergey Petrunya	62cc4df4d3	Alternate version of MySQL's fix for BUG#49453. The cause of the crash is sj_nest->sj_subq_pred->unit->first_select()->item_list contains "stale" items for the second execution. By "stale" I mean that they have item->fixed==FALSE, and they are Item_field object instead of Item_direct_view_ref. The solution is to use sj_nest->sj_subq_pred->unit->first_select()->ref_pointer_array. Surprisingly, that array contains items that are ok. Oracle team has introduced and is using NESTED_JOIN::sj_inner_exprs, but we go without that and always copy the ref_pointer_array.	15 years ago
Igor Babaev	f8db35bd15	Fixed LP bug #806504 . Missing initialization of the bitmap not_null_tables_cache to 0 in the function Item_func::eval_not_null_tables caused this bug. This function is called indirectly from the function SELECT_LEX::update_used_tables after merging mergeable views and derived tables into the main query. The leaf tables of resulting query may change their bitmap numbers after this merge. That's why the not_null_tables_cache bitmaps must be updated. Due to the bug mentioned above the result of the re-evaluation of the not_null_tables_cache turned out to be incorrect in some cases. This could trigger an invalid conversion of outer joins into inner joins leading to invalid query result sets. Also removed an implicit conversion from int to bool in the function SELECT_LEX::update_used_tables.	15 years ago
Vladislav Vaintroub	7ff45c1379	merge	15 years ago
Vladislav Vaintroub	46465327e7	merge	15 years ago
Vladislav Vaintroub	03b4c3bcde	merge	15 years ago
Vladislav Vaintroub	066fb9d289	merge	15 years ago
Vladislav Vaintroub	3b393c929b	Fix LPBUG#808233 - undefined uint in typelib.h	15 years ago
Igor Babaev	a515802c5b	Fixed LP bug #806097 . The value of THD::used tables should be re-evaluated after merges of views and derived tables into the main query. Now it's done in the function SELECT_LEX::update_used_tables. The re-evaluation of the 'used_table' bitmaps for the items in HAVING, GROUP BY and ORDER BY clauses has been added as well.	15 years ago
Sergey Petrunya	9e7495df83	Semi-join fixes: make COST_VECT objects survive add_io(add_io_cnt=0, add_avg_cost=...) calls without getting NaN in internal fields.	15 years ago
Sergey Petrunya	0ce603ab5e	[No BUG#] Fixes for problems discovered when running mysql-trunk's subquery testsuite	15 years ago
Sergey Petrunya	a4f5e01475	Merge @@optimizer_switch default settings changes into 5.3	15 years ago

1 2 3 4 5 ...

67368 Commits (99cce18955dfb43d7d69c7de704cb29f047f8da5) All Branches Search

67368 Commits (99cce18955dfb43d7d69c7de704cb29f047f8da5)

All Branches