mariadb

Tree: 985d2d393c

Author	SHA1	Message	Date
Alexander Barkov	c58df0cdd4	MDEV-14031 Password policy causes replication failure	8 years ago
Vicențiu Ciorbaru	be758322e2	MDEV-12366: FLUSH PRIVILEGES can break hierarchy of roles Whenever we call merge_role_privileges on a role, we make use of the role->counter variable to check if all it's children have had their privileges merged. Only if all children have had their privileges merged, do we update the privileges on parent. This is done to prevent extra work. The same idea is employed during flush privileges. You only begin merging from "leaf" roles. The recursive calls will merge their parents at some point. A problem arises when we try to "re-merge" a parent. Take the following graph: {noformat} A (0) ---- C (2) ---- D (2) ---- USER / / B (0) ----/ / / E (0) --------------/ {noformat} In parentheses we have the "counter" value right before we start to iterate through the roles hash and propagate values. It represents the number of roles granted to the current role. The order in which we iterate through the roles hash is alphabetical. * First merge A, which leads to decreasing the counter for C to 1. Since C is not 0, we don't proceed with merging into C. * Second we merge B, which leads to decreasing the counter for C to 0. Now we proceed with merging into C. This leads to reducing the counter for D to 1 as part of C merge process. * Third as we iterate through the hash, we see that C has counter 0, thus we start the merge process again. This leads to reducing the counter for D to 0! We then attempt to merge D. * Fourth we start merging E. When E sees D as it's parent (according to the code) it attempts to reduce D's counter, which leads to overflow. Now D's counter is a very large number, thus E's privileges are not forwarded to D yet. To correct this behavior we must make sure to only start merging from initial leaf nodes.	8 years ago
Vicențiu Ciorbaru	2fced9e7b6	MDEV-13655: Set role does not properly grant privileges. When granting a role to another role, DB privileges get propagated. If the grantee had no previous DB privileges, an extra ACL_DB entry is created to house those "indirectly received" privileges. If, afterwards, DB privileges are granted to the grantee directly, we must make sure to not create a duplicate ACL_DB entry.	8 years ago
Oleksandr Byelkin	88cc6db0a4	MDEV-13453: Executing a query via CTE requires more permissions than the query itself Fix of nondebuging version issue	8 years ago
Igor Babaev	3afc9629fd	Fixed bug mdev-13453 Executing a query via CTE requires more permissions than the query itself ACL checks were not properly supported for tables used in CTE specifications. This patch fixes the problem.	8 years ago
Sergei Golubchik	2aa51f528f	Various compier warnings gcc 5.4 and 7.1, Debug and Release builds	8 years ago
Vicențiu Ciorbaru	4090ef820e	Fix check_role_is_granted for embedded	8 years ago
Vicențiu Ciorbaru	b9418ed333	MDEV-13676: Field "create Procedure" is NULL, even if the the user has role which is the definer. (SHOW CREATE PROCEDURE) During show create procedure we ommited to check the current role, if it is the actual definer of the procedure. In addition, we should support indirectly granted roles to the current role. Implemented a recursive lookup to search the tree of grants if the rolename is present. SQL Standard 2016, Part 5 Section 53 View I_S.ROUTINES selects ROUTINE_BODY and its WHERE clause says that the GRANTEE must be either PUBLIC, or CURRENT_USER or in the ENABLED_ROLES.	8 years ago
Vladislav Vaintroub	dc93ce8dea	Windows : Fix truncation warnings in sql/	8 years ago
Vladislav Vaintroub	7354dc6773	MDEV-13384 - misc Windows warnings fixed	8 years ago
Oleksandr Byelkin	cb2a57c203	MDEV-13439: Database permissions are not enough to run a subquery with GROUP BY within a view The bug is result adding ability to have derived tables inside views. Fixed checks should be a switch between view/derived or select derived and information schema.	8 years ago
Sergei Golubchik	71b4503242	MDEV-9998 Fix issues caught by Clang's -Wpointer-bool-conversion warning remove useless checks and a couple of others	9 years ago
Vicențiu Ciorbaru	8f05c848c5	MDEV-10541: Faking the version string only works with MariaDB-Clients Our RPL_VERSION_HACK prefix caused MySQL clients to always report 5.5 major and minor versions, even if a specific fake version is passed via my.cnf or command line parameters. When a specific version is requested, don't employ the RPL_VERSION_HACK prefix within the server handshake packet.	9 years ago
Vladislav Vaintroub	f2fe5cb282	Fix several compile warnings on Windows	9 years ago
Sergei Golubchik	0877eff401	thd_rnd service	9 years ago
Sergei Golubchik	6305533de2	Auth Plugin API: add THD to MYSQL_SERVER_AUTH_INFO so that auth plugins could use various thd services	9 years ago
Sergei Golubchik	199f88cb9c	MDEV-5999 MySQL Bug#12766319 - 61865: RENAME USER DOES NOT WORK CORRECTLY - REQUIRES FLUSH PRIVILEGES use update_hostname() to update the hostname. test case comes from commit 0abdeed1d6d Author: gopal.shankar@oracle.com <> Date: Thu Mar 29 00:20:54 2012 +0530 Bug#12766319 - 61865: RENAME USER DOES NOT WORK CORRECTLY - REQUIRES FLUSH PRIVILEGES	9 years ago
Vicențiu Ciorbaru	d731ce21a7	MDEV-11170: MariaDB 10.2 cannot start on MySQL 5.7 datadir PART 2 of the fix adds the logic of not using password column, unless it exists. If password column is missing we attempt to use plugin && authentication_string columns.	9 years ago
Vicențiu Ciorbaru	5ab93737be	MDEV-11170: MariaDB 10.2 cannot start on MySQL 5.7 datadir PART 1 of the fix requires a bit of refactoring to not use hard-coded field indices any more. Create classes that express the grant tables structure, without exposing the underlying field indices. Most of the code is converted to use these classes, except parts which are not directly affected by the MDEV-11170. These however are TODO items for subsequent refactoring.	9 years ago
Vicențiu Ciorbaru	dc90e24978	Define a helper class to allow for saving sql_mode using RAII On construction the Sql_mode_save class stores the current THD's sql_mode. On destruction, the THD's mode is restored.	9 years ago
Alexey Botchkov	30a9ac4250	MDEV-10956 Strict Password Validation Breaks Replication. strict_password_validation variable now has no effect in the slave thread.	9 years ago
Monty	5f0c31f928	MDEV-11597 Assertion when doing select from virtual column with impossible value - Changed error handlers interface so that they can change error level in the handler - Give warnings and errors when calculating virtual columns - On insert/update error is fatal in strict mode. - SELECT and DELETE will only give a warning if a virtual field generates an error - Added VCOL_UPDATE_FOR_DELETE and VCOL_UPDATE_INDEX_FOR_REPLACE to be able to easily detect in update_virtual_fields() if we should use an error handler to mask errors or not.	9 years ago
Monty	ed0bc17bee	Removed usage of my_hash_search() with uninitialized HASH. - Not documented on intened usage - Extra checking takes time for all HASH usage	9 years ago
Oleksandr Byelkin	23cc1be270	MDEV-11584: GRANT inside an SP does not work well on 2nd execution Allocate password hash in statment memory	9 years ago
Oleksandr Byelkin	100f721c0a	MDEV-11584: GRANT inside an SP does not work well on 2nd execution Allocate password hash in statment memory	9 years ago
Vicențiu Ciorbaru	e99990c631	MDEV-10744: Roles are not fully case sensitive Due to the collation used on the roles_mapping_hash, key comparison would work in a case-insensitive manner. This is incorrect from the roles mapping perspective. Make use of a case-sensitive collation for that hash, the same one used for the acl_roles hash.	9 years ago
Arun Kuruvila	3a37745ca0		9 years ago
Alexander Barkov	5058ced5df	MDEV-7769 MY_CHARSET_INFO refactoring# On branch 10.2 Part 3 (final): removing MY_CHARSET_HANDLER::well_formed_len().	9 years ago
Monty	7b96416f3c	Use sql_mode_t for sql_mode. This fixed several cases where we where using just ulong for sql_mode	9 years ago
Sergei Golubchik	ece01ef3dc	After-review changes * remove redundant code * fix tests * move declarations and defines where they belong	9 years ago
Nirbhay Choubey	31697d0b80	MDEV-10545: Server crashed in my_copy_fix_mb on querying I_S and P_S tables Once THDs have been added to the global "threads" list, they must modify query_string only after acquiring per- thread LOCK_thd_data mutex.	9 years ago
Arun Kuruvila	aeab9d6b41	Bug#23303391: HANDLE_FATAL_SIGNAL (SIG=11) IN ALLOC_QUERY USING CHARACTER-SET-SERVER=UTF16 This is a backport of Bug#15985752 to mysql-5.5	9 years ago
Sergei Golubchik	2013a7fc29	fix: CURRENT_ROLE() inside SECURITY DEFINER views	9 years ago
Vladislav Vaintroub	56c4cfe0be	MDEV-9293 - Use MariaDB's Connector/C in server	9 years ago
Vladislav Vaintroub	31a8cf54c8	Revert "MDEV-9293 Connector/C integration" This reverts commit `7b89b9f510`.	9 years ago
Vladislav Vaintroub	7b89b9f510	MDEV-9293 Connector/C integration	9 years ago
Sergei Golubchik	0d5583b41b	cleanup	9 years ago
Alexander Barkov	3f32bf627f	More tests for "MDEV-7563 Support CHECK constraint". Testing non-ASCII string literals.	9 years ago
Sergei Golubchik	341e5f4411	MDEV-10054 Secure login fails when CIPHER is required SSL: do not require client certificate to exist, if GRANT didn't require that	9 years ago
Monty	838205f0bb	Fixed compiler warnings and test failures found by buildbot	9 years ago
Igor Pashev	5fd8087590	[MDEV-9614] Roles and Users longer than 6 characters The bug is apparent when the username is longer than the rolename. It is caused by a simple typo that caused a memcmp call to compare a different number of bytes than necessary. The fix was proposed by Igor Pashev. I have reviewed it and it is the correct approach. Test case introduced by me, using the details provided in the MDEV. Signed-off-by: Vicențiu Ciorbaru <vicentiu@mariadb.org>	10 years ago
Monty	89685d55d7	Reuse THD for new user connections - To ensure that mallocs are marked for the correct THD, even if it's allocated in another thread, I added the thread_id to the THD constructor - Added st_my_thread_var to thr_lock_info_init() to avoid a call to my_thread_var - Moved things from THD::THD() to THD::init() - Moved some things to THD::cleanup() - Added THD::free_connection() and THD::reset_for_reuse() - Added THD to CONNECT::create_thd() - Added THD::thread_dbug_id and st_my_thread_var->dbug_id. These are needed to ensure that we have a constant thread_id used for debugging with a THD, even if it changes thread_id (=connection_id) - Set variables.pseudo_thread_id in constructor. Removed not needed sets.	10 years ago
Nirbhay Choubey	1512078a7a	MDEV-9851: CREATE USER w/o IDENTIFIED BY clause causes crash when using cracklib plugin Do not allow NULL password to pass directly to password validation plugin.	10 years ago
Sergei Golubchik	4db2ebb1fe	MDEV-9940 CREATE ROLE blocked by password validation plugin	10 years ago
Alexey Botchkov	94cd0f6c9b	MDEV-9898 SET ROLE NONE can crash mysqld. The check_user_can_set_role() used find_user_exact() to get the permissions for the SET ROLE NONE command. Which returned NULL too often, for instance when user authenticated as 'user'@'%'. Now we use find_user_wild() instead.	10 years ago
Monty	ad4239cc3d	Fixed assert if user table was mailformed. Added mysql_to_mariadb.sql script, to change mysql.user tables from MySQL 5.7 to MariaDB. After this script is run, one can get the other tables fixed by running mysql_upgrade	10 years ago
Sergei Golubchik	d821dd106a	MDEV-9580 SHOW GRANTS FOR <current_user> fails use get_current_user() to distinguish user name without a hostname and a role name. move privilege checks inside mysql_show_grants() to remove duplicate get_current_user() calls	10 years ago
Igor Pashev	e5410da190	SEGFAULT in get_column_grant() Due to a typo, the wrong grant_table was used when fetching privileges for roles. Signed-off-by: Vicențiu Ciorbaru <vicentiu@mariadb.org>	10 years ago
Sergei Golubchik	cc04a9fc0f	MDEV-9835 Valid password is not working after server restart On SET PASSWORD if the plugin is mysql_native_password or mysql_old_password, do reset plugin and auth_str fields.	10 years ago
Monty	260dd476b0	Removed TABLE->sort to make it possible to have multiple active calls to filesort and init_read_record() for the same table. This will simplify code for WINDOW FUNCTIONS (MDEV-6115) - Filesort_info renamed to SORT_INFO and moved to filesort.h - filesort now returns SORT_INFO - init_read_record() now takes a SORT_INFO parameter. - unique declaration is moved to uniques.h - subselect caching of buffers is now more explicit than before - filesort_buffer is now reusable even if rec_length has changed. - filsort_free_buffers() and free_io_cache() calls are removed - Remove one malloc() when using get_addon_fields() Other things: - Added --debug-assert-on-not-freed-memory option to make it easier to debug some not-freed-memory issues.	10 years ago

1 2 3 4 5 ...

2438 Commits (985d2d393c285ecd4539cb579b680f7b91fdaa1a)