mariadb

Tree: 985d2d393c

Author	SHA1	Message	Date
Vicențiu Ciorbaru	985d2d393c	Merge remote-tracking branch 'origin/10.1' into 10.2	8 years ago
Alexander Barkov	a76a2522ec	MDEV-14426 Assertion in Diagnostics_area::set_error_status when using a bad datetime with PS and SP	8 years ago
Sergei Petrunia	9c28fd7a33	Merge branch '10.2' into bb-10.2-mariarocks	8 years ago
Marko Mäkelä	461cf3e5a3	Make a test more robust Sometimes, the test would fail with a result difference for the READ UNCOMMITTED read, because the incremental backup would finish before redo log was written for all the rows that were inserted in the second batch. To fix that, cause a redo log write by creating another transaction. The transaction rollback (which internally does commit) will be flushed to the redo log, and before that, all the preceding changes will be flushed to the redo log as well.	8 years ago
Marko Mäkelä	9d7c0882fa	Merge 10.0 into 10.1	8 years ago
Marko Mäkelä	0202e47274	MDEV-12827 Assertion failure when reporting duplicate key error in online table rebuild row_log_table_apply_insert_low(), row_log_table_apply_update(): When reporting the error_key_num, only count the clustered index if it corresponds to a key in the SQL layer. The assertion failure was probably introduced by the (incomplete) MySQL 5.6.28 bug fix Bug #21364096 THE BOGUS DUPLICATE KEY ERROR IN ONLINE DDL WITH INCORRECT KEY NAME which we are improving. Side note: the fix was incorrectly merged to MySQL 5.7.10; incorrect key names will continue to be reported in MySQL 5.7.	8 years ago
Marko Mäkelä	1cf28964f5	MDEV-6247 post-fix: Re-enable some debug assertions These assertions were disabled in MariaDB 10.1.1 in commit `df4dd593f2` with a bogus comment referring to the function wsrep_fake_trx_id() that was introduced in the very same commit.	8 years ago
Elena Stepanova	5f896b3604	Updated list of unstable tests for 10.1.30 release	8 years ago
Sergei Petrunia	207976d6b9	Better comments part #2	8 years ago
Sergei Petrunia	e27e7ec767	Better comments part #1	8 years ago
Sergei Petrunia	85fad60dc7	Disable back rocksdb.col_opt_zerofill due to MDEV-14729	8 years ago
Sachin Setiya	2a4faa8ab6	MDEV-13478 Full SST sync fails because of the error in the cleaning part Problem: The command was: find $paths -mindepth 1 -regex $cpat -prune -o -exec rm -rf {} \+ Which was supposed to work as * skipping $paths directories themselves (-mindepth 1) * see if the dir/file name matches $cpat (-regex) * if yes - don't dive into the directory, skip it (-prune) * otherwise (-o) * remove it and everything inside (-exec) Now -exec ... \+ works like this: every new found path is appended to the end of the command line. when accumulated command line length reaches `getconf ARG_MAX` (~2Gb) it's executed, and find continues, appending to a new command line. What happens here, find appends some directory to the command line, then dives into it, and starts appending files from that directory. At some point command line overflows, rm -rf gets executed and removes the whole directory. Now find tries to continue scanning the directory that was already removed. Fix: don't dive into directories that will be recursively removed anyway, use -prune for them. Basically, we should be pruning both paths that have matched $cpat and paths that have not matched it. This is achived by pruning unconditionally, before the regex is tested: find $paths -mindepth 1 -prune -regex $cpat -o -exec rm -rf {} \+ Patch Credit:- Serg	8 years ago
Sergei Petrunia	73fa7aeb20	MDEV-14165: not MyRocks -problem in ps-protocol, happens in upstream too Enable the test back, as the fix has been pushed.	8 years ago
Sergei Petrunia	21eed925a0	Cleanup out of date comments (no real changes).	8 years ago
Oleksandr Byelkin	eb14042383	MDEV-14613: Assertion `fixed == 0' failed in Item_func::fix_fields fix_fields calls fixed.	8 years ago
Vicențiu Ciorbaru	353fe8a321	Merge remote-tracking branch '10.0-galera' into 10.1	8 years ago
Vicențiu Ciorbaru	e3d89652e5	Merge branch '10.0' into 10.1	8 years ago
Christian Hesse	7bbc6c14d1	Generate and install sysusers and tmpfiles configuration Using systemd we can automate creating users and directories. So generate and install the configuration files. Signed-off-by: Vicențiu Ciorbaru <vicentiu@mariadb.org> Small change in cmake/install_layout.cmake compared to original contributor patch to also install SYSTEMD_SYSUSERS and SYSTEMD_TMPFILES directories. The variables were being set, but the loop which defines the final install files was not updated.	9 years ago
Vicențiu Ciorbaru	042f763268	Merge remote-tracking branch '5.5' into 10.0	8 years ago
Varun Gupta	924db8b4ed	MDEV-12350: Heap corruption, overrun buffer, ASAN errors, server crash in my_fill_8bit / filesort In the function make_sortkey a tmp buffer was defined and in the absence of param->tmp_buffer, tmp buffer used the sort_keys buffer. sort_keys buffer has a length defined in sort_field->length, while param->tmp_buffer is stored in param->rec_length. Make sure to use the appropriate length based on which buffer we are using otherwise we'll overflow. Also added a type cast to size_t during the calculation of the sort keys buffer size to avoid an oveflow if the buffer size exceeds 32 bits.	8 years ago
Alexander Barkov	cb121a047b	An after-fix for MDEV-14008 Assertion failing: `!is_set() \|\| (m_status == DA_OK_BULK && is_bulk_op()) Fixing an additional failure discovered after a merge to 10.2	8 years ago
Alexander Barkov	c58df0cdd4	MDEV-14031 Password policy causes replication failure	8 years ago
Marko Mäkelä	f7f5c710e4	Correct a function comment The comment became stale in commit `9f57e595b4` which removed the parameter "flags".	8 years ago
sjaakola	64e1dda0a0	MW-416 DDL replication moved after acl checking galera_events test shows a regression with the original fix for MW-416 Reason was that Events::drop_event() can be called also from inside event execution, and there we have a speacial treatment for event, which executes "DROP EVENT" statement, and runs TOI replication inside the event processing body. This resulted in executing WSREP_TO_ISOLATION two times for such DROP EVENT statement. Fix is to call WSREP_TO_ISOLATION_BEGIN only in Events::drop_event()	8 years ago
sjaakola	1a8da003f6	MW-416 Changed return code for replicatio error to TRUE. This is aligned with native mysql convention to return TRUE (defined to 1) or FALSE (defined to 0) from a bool function. This is wrong, but follows the mysql conventiosn, at least...	8 years ago
Simon J Mudd	cfa18e4ae1	MDEV-14639: Fix unexpected end of line at 'Normal shutdown'	8 years ago
Sergey Vojtovich	2cd3169113	MDEV-14265 - RPMLint warning: shared-lib-calls-exit find_type_or_exit() client helper did exit(1) on error, exit(1) moved to clients. mysql_read_default_options() did exit(1) on error, error is passed through and handled now. my_str_malloc_default() did exit(1) on error, replaced my_str_ allocator functions with normal my_malloc()/my_realloc()/my_free(). sql_connect.cc did many exit(1) on hash initialisation failure. Removed error check since my_hash_init() never fails. my_malloc() did exit(1) on error. Replaced with abort(). my_load_defaults() did exit(1) on error, replaced with return 2. my_load_defaults() still does exit(0) when invoked with --print-defaults.	8 years ago
Marko Mäkelä	8d70097c21	Merge 10.1 to 10.2 Follow-up fix to MDEV-14008: Let Field_double::val_uint() silently return 0 on error	8 years ago
Jan Lindström	ed7e4b68ed	DEV-14701: install_db shows corruption for rest encryption with innodb_data_file_path=ibdata1:3M Problem was that crypt_data->min_key_version is not a reliable way to detect is tablespace encrypted and could lead that in first page of the second (page 192 and similarly for other files if more configured) system tablespace file used key_version is replaced with zero leading a corruption as in next startup page is though to be corrupted. Note that crypt_data->min_key_version is updated only after all pages from tablespace have been processed (i.e. key rotation is done) and flushed. fil_write_flushed_lsn Use crypt_data->should_encrypt() instead.	8 years ago
Jan Lindström	252e690c85	Fix galera.view test case crash. WSREP_TO_ISOLATION_BEGIN() call must be after view name is back on tables list.	8 years ago
Vicențiu Ciorbaru	be758322e2	MDEV-12366: FLUSH PRIVILEGES can break hierarchy of roles Whenever we call merge_role_privileges on a role, we make use of the role->counter variable to check if all it's children have had their privileges merged. Only if all children have had their privileges merged, do we update the privileges on parent. This is done to prevent extra work. The same idea is employed during flush privileges. You only begin merging from "leaf" roles. The recursive calls will merge their parents at some point. A problem arises when we try to "re-merge" a parent. Take the following graph: {noformat} A (0) ---- C (2) ---- D (2) ---- USER / / B (0) ----/ / / E (0) --------------/ {noformat} In parentheses we have the "counter" value right before we start to iterate through the roles hash and propagate values. It represents the number of roles granted to the current role. The order in which we iterate through the roles hash is alphabetical. * First merge A, which leads to decreasing the counter for C to 1. Since C is not 0, we don't proceed with merging into C. * Second we merge B, which leads to decreasing the counter for C to 0. Now we proceed with merging into C. This leads to reducing the counter for D to 1 as part of C merge process. * Third as we iterate through the hash, we see that C has counter 0, thus we start the merge process again. This leads to reducing the counter for D to 0! We then attempt to merge D. * Fourth we start merging E. When E sees D as it's parent (according to the code) it attempts to reduce D's counter, which leads to overflow. Now D's counter is a very large number, thus E's privileges are not forwarded to D yet. To correct this behavior we must make sure to only start merging from initial leaf nodes.	8 years ago
Vicențiu Ciorbaru	2fced9e7b6	MDEV-13655: Set role does not properly grant privileges. When granting a role to another role, DB privileges get propagated. If the grantee had no previous DB privileges, an extra ACL_DB entry is created to house those "indirectly received" privileges. If, afterwards, DB privileges are granted to the grantee directly, we must make sure to not create a duplicate ACL_DB entry.	8 years ago
Galina Shalygina	079c359971	MDEV-14629: failing assertion when a user-defined variable is defined by the recursive CTE During the user-defined variable defined by the recursive CTE handling procedure check_dependencies_in_with_clauses that checks dependencies between the tables that are defined in the CTE and find recursive definitions wasn't called.	8 years ago
Daniel Black	ce4cdfa0f8	MDEV-13809: [service] should [Service] in systemd service files	8 years ago
Daniel Black	64f1fab068	MDEV-12128: systemd - add Documentation= directives	8 years ago
Marko Mäkelä	09c5bbf471	Merge 10.0 into 10.1	8 years ago
Marko Mäkelä	40088bfc7e	MDEV-13407 innodb.drop_table_background failed in buildbot with "Tablespace for table exists" The InnoDB background DROP TABLE queue is something that we should really remove, but are unable to until we remove dict_operation_lock so that DDL and DML operations can be combined in a single transaction. Because the queue is not persistent, it is not crash-safe. In stable versions of MariaDB, we can only try harder to drop all enqueued tables before server shutdown. row_mysql_drop_t::table_id: Replaces table_name. row_drop_tables_for_mysql_in_background(): Do not remove the entry from the list as long as the table exists. In this way, the table should eventually be dropped.	8 years ago
Nirbhay Choubey	682c3bfd25	MDEV-10442: "Address already in use" on restart SST processes should inherit mysqld's process group.	9 years ago
sjaakola	91daf8819c	MW-416 Moved TOI replication to happen after ACL checking for commands: SQLCOM_CREATE_EVENT SQLCOM_ALTER_EVENT SQLCOM_DROP_EVENT SQLCOM_CREATE_VIEW SQLCOM_CREATE_TRIGGER SQLCOM_DROP_TRIGGER SQLCOM_INSTALL_PLUGIN SQLCOM_UNINSTALL_PLUGIN	8 years ago
Sergei Golubchik	beabe6b216	MDEV-13969 sst mysqldump and xtrabackup-v2 handle WSREP_SST_OPT_CONF incorrectly $WSREP_SST_OPT_CONF already includes --defaults-extra-file= prefix.	8 years ago
Martynas Bendorius	1c2f59f7fb	MDEV-13969 sst mysqldump and xtrabackup-v2 handle WSREP_SST_OPT_CONF incorrectly wrep_sst_common: Setting "-c ''" for my_print_defaults just takes no values from config at all. $MY_PRINT_DEFAULTS is already set at the top of the script to have --defaults-file and --defaults-extra-file. If WSREP_SST_OPT_CONF if set to "--defaults-file=/etc/my.cnf --defaults-extra-file=/etc/my.extra.cnf", then "my_print_defaults -c "" --defaults-file=/etc/my.cnf" succeeds, but if WSREP_SST_OPT_CONF is empty - no default values are taken at all. wsrep_sst_xtrabackup-v2: innobackupex does not support --defaults-extra-file, so ${WSREP_SST_OPT_CONF} cannot be used as an argument, it has been changed to ${WSREP_SST_OPT_DEFAULT}. Removed --defaults-file= from INNOMOVE line, because WSREP_SST_OPT_CONF already includes it (INNOBACKUP was fine, INNOMOVE - not).	8 years ago
Vladislav Vaintroub	f32063c513	MDEV-13620 - improve help message for 'plugin-dir' and 'plugin-load' options.	8 years ago
Sergei Golubchik	03e91ce324	MDEV-14641 Incompatible key or row definition between the MariaDB .frm file and the information in the storage engine make sure that mysql_create_frm_image() and fast_alter_partition_table() use the same code to derive HA_OPTION_PACK_RECORD from create_info->row_type.	8 years ago
Alexey Botchkov	6ee9cba745	MDEV-10486 MariaDB 10.x does not update rows_examined in performance_schema tables. Save the rows_examined counter before it gets emptied.	8 years ago
Alexander Barkov	c1e5fef05d	MDEV-14008 Assertion failing: `!is_set() \|\| (m_status == DA_OK_BULK && is_bulk_op())	8 years ago
Monty	06f0b23a78	Fixed memory leak in my_rocks rocksdb_sys_vars.rocksdb_update_cf_options_basic.test failed with reports about not freed memory.	8 years ago
Oleksandr Byelkin	273591df0c	MDEV-14619: VIEW and GROUP_CONCAT Correctly print separator string in single quotes.	8 years ago
Sergei Petrunia	4bd63bd551	MDEV-14679: RocksdB plugin fails to load with "Loading of unknown plugin ROCKSDB_CFSTATS Set maturity level of all "Sub-plugins" to be the same as the main maturity level.	8 years ago
Sergei Petrunia	7380376370	MDEV-14293: MyRocks lacks basic functionality Adjust the fix according to the review input: don't introduce a special error caode, use ER_INTERNAL_ERROR catch-all.	8 years ago
Sergei Petrunia	64b11e61b5	MDEV-14293: MyRocks lacks basic functionality The error "Unsupported collation on string indexed column %s Use binary collation (latin1_bin, binary, utf8_bin)." is misleading. Change it: - It is now a warning - It is printed only for collations that do not support index-only access (reversible collations that use unpack_info are ok) - The new warning text is: Indexed column %s.%s uses a collation that does not allow index-only access in secondary key and has reduced disk space efficiency in primary key.	8 years ago

1 2 3 4 5 ...

179083 Commits (985d2d393c285ecd4539cb579b680f7b91fdaa1a) All Branches Search

179083 Commits (985d2d393c285ecd4539cb579b680f7b91fdaa1a)

All Branches