mariadb

Tree: 985d2d393c

Author	SHA1	Message	Date
Sergey Vojtovich	2cd3169113	MDEV-14265 - RPMLint warning: shared-lib-calls-exit find_type_or_exit() client helper did exit(1) on error, exit(1) moved to clients. mysql_read_default_options() did exit(1) on error, error is passed through and handled now. my_str_malloc_default() did exit(1) on error, replaced my_str_ allocator functions with normal my_malloc()/my_realloc()/my_free(). sql_connect.cc did many exit(1) on hash initialisation failure. Removed error check since my_hash_init() never fails. my_malloc() did exit(1) on error. Replaced with abort(). my_load_defaults() did exit(1) on error, replaced with return 2. my_load_defaults() still does exit(0) when invoked with --print-defaults.	8 years ago
Vesa Pentti	9f3c014ca3	MDEV-10728 -- mysqlbinlog can't be input to mysql client String comparison with utf8_bin collation is case sensitive. Hence "DELIMITER" did not match with "delimiter". The delimiter command matching now uses my_charset_latin1.	8 years ago
Sergei Golubchik	d76f5774fe	MDEV-13459 Warnings, when compiling with gcc-7.x mostly caused by -Wimplicit-fallthrough	8 years ago
Marko Mäkelä	dc112d2f48	Fix -Wimplicit-fallthrough warnings (no functional change)	8 years ago
Anushree Prakash B	5ac61b2af0	Bug#26372491 - RCE THROUGH THE MISHANDLE OF BACKSLASH DESCRIPTION: =========== The bug is related to incorrect parsing of SQL queries when typed in on the CLI. The incorrect parsing can result in unexpected results. ANALYSIS: ======== The scenarios mainly happens for identifier names with a typical combination of backslashes and backticks. The incorrect parsing can either result in executing additional queries or can result in query truncation. This can impact mysqldump as well. FIX: === The fix makes sure that such identifier names are correctly parsed and a proper query is sent to the server for execution. (cherry picked from commit `31a372aa1c`)	8 years ago
Daniel Black	7338d3f221	client: mysql - fix type field_names[x][y] is a pointer client/mysql.cc: In function 'void build_completion_hash(bool, bool)': client/mysql.cc:2855:37: error: invalid conversion from 'char' to 'char' [-fpermissive] field_names[i][num_fields2]= '\0'; Signed-off-by: Daniel Black <daniel.black@au.ibm.com>	8 years ago
Sergei Golubchik	4d21313549	coverity medium warnings	9 years ago
Sergei Golubchik	d2d52305b4	MDEV-12755 Replication tests fail in buildbot with ASAN remove double-initialization of MYSQL structure	8 years ago
Sergei Golubchik	d5cd334504	MDEV-13187 incorrect backslash parsing in clients cover ANSI_QUOTES and NO_BACKSLASH_ESCAPES in mysqltest	8 years ago
Sergei Golubchik	39385ff7b2	MDEV-13187 incorrect backslash parsing in clients don't do backslash escapes inside backticks	8 years ago
Ivo Roylev	20addb05e5	Bug# 25998635: Client does not escape the USE statement When there are quotes in the USE statement, the mysql client does not correctly escape them. The USE statement is processed line by line from the client's parser, and cannot handle multi-line commands as the server. The fix is to escape the USE parameters whenever quotes are used.	9 years ago
Sergei Golubchik	7c03edf2fe	MDEV-6262 analyze the coverity report on mariadb uploaded 10.0, analyzed everything with the Impact=High (and a couple of Medium)	9 years ago
Anushree Prakash B	756b00d80a	Bug#25340722 - PRINT BINARY DATA AS HEX IN THE MYSQL CLIENT (CONTRIBUTION) DESCRIPTION: ============ Binary data should be printed as hex in the mysql client when the option binary-as-hex is enabled. ANALYSIS: ========= The fix deals only with mysql command line client. It does not change, at all, the data sent to the applications. Printing binary data as hex also allows to use the output in the where clause of the query. FIX: ==== A new option 'binary-as-hex' is introduced to print the binary contents as hex in the mysql client. The option is disabled by default. When the option is enabled, we convert the binary data to hex before printing the contents irrespective of whether it is in tabular, xml or html format.	9 years ago
iangilfillan	f0ec34002a	Correct FSF address	9 years ago
Ramil Kalimullin	060b1eadf4	BUG#25575605: SETTING --SSL-MODE=REQUIRED SENDS CREDENTIALS BEFORE VERIFYING SSL CONNECTION MYSQL_OPT_SSL_MODE option introduced. It is set in case of --ssl-mode=REQUIRED and permits only SSL connection. (cherry picked from commit `3b2d28578c`)	9 years ago
Ramil Kalimullin	2531c8dcd1	BUG#25575605: SETTING --SSL-MODE=REQUIRED SENDS CREDENTIALS BEFORE VERIFYING SSL CONNECTION MYSQL_OPT_SSL_MODE option introduced. It is set in case of --ssl-mode=REQUIRED and permits only SSL connection.	9 years ago
Sergey Vojtovich	ce1011669b	MDEV-11175 - \H option does not replace localhost with a host name Let \H issue host name when connected to localhost via TCP/IP.	9 years ago
Sergei Golubchik	383007c75d	mysql cli: fix USE command quoting * use proper sql quoting rules for USE, while preserving as much of historical behavior as possible * short commands (\u) behave as before	9 years ago
Sergei Golubchik	ece01ef3dc	After-review changes * remove redundant code * fix tests * move declarations and defines where they belong	9 years ago
Vladislav Vaintroub	56c4cfe0be	MDEV-9293 - Use MariaDB's Connector/C in server	9 years ago
Vladislav Vaintroub	31a8cf54c8	Revert "MDEV-9293 Connector/C integration" This reverts commit `7b89b9f510`.	9 years ago
Vladislav Vaintroub	7b89b9f510	MDEV-9293 Connector/C integration	9 years ago
Sergey Vojtovich	1c68b9e9a4	MDEV-505 - feature request: add \H option for mysql client prompt An addition to original patch: - use FN_REFLEN instead of HOST_NAME_MAX (the latter can be undefined) - avoid calling gethostname() on every prompt construction by caching it	10 years ago
Dan Ungureanu	eca060775e	MDEV-505: feature request: add \H option for mysql client prompt Introduce `\H` option which behaves mostly like `\h`. The only exception is when the client connects to the server hosted on localhost. In this case, the hostname will be used instead.	10 years ago
Sergey Vojtovich	43e19b3fc8	Fixed compilation failure due to unused var.	10 years ago
Sergey Vojtovich	0ea4c73dae	Fixed compilation failure due to unused var.	10 years ago
Sergei Golubchik	ce355304e6	MDEV-9885 Client doesn't start if 'TERM' unknown 1. don't exit if setupterm() failed 2. don't use vidattr() if setupterm() failed	10 years ago
Otto Kekäläinen	1777fd5f55	Fix spelling: occurred, execute, which etc	10 years ago
Ramil Kalimullin	b3e9211e48	WL#9072: Backport WL#8785 to 5.5	10 years ago
Sergei Golubchik	5a0f2f5ea8	MDEV-9149 Ctrl-C in MySQL client does not interrupt query, but interrupts the session instead mysql.cc: Unlike the main MYSQL structure, kill_mysql did not have MYSQL_OPT_PROTOCOL set. Move all connection-related settings to a separate function and use it both for the main MYSQL and for kill_mysql.	10 years ago
Sergei Golubchik	c4cb240061	MDEV-9024 Build fails with VS2015 cherry-pick `f1daf9ce` from 10.0 branch ------------------------------------- Fix build failures caused by new C runtime library - isnan, snprintf, struct timespec are now defined, attempt to redefine them leads - P_tmpdir, tzname are no more defined - lfind() and lsearch() in lf_hash.c had to be renamed, declaration conflicts with some C runtime functions with the same name declared in a header included by stdlib.h Also fix couple of annoying warnings : - remove #define NOMINMAX from config.h to avoid "redefined" compiler warnings(NOMINMAX is already in compile flags) - disable incremental linker in Debug as well (feature not used much and compiler crashes often) Also simplify package building with Wix, require Wix 3.9 or later (VS2015 is not compatible with old Wix 3.5/3.6)	10 years ago
Oleksandr Byelkin	d4b3a199ac	MDEV-9117: Client Server capability negotiation for MariaDB specific functionality New capability flags space. Removed old progress flag, added new one.	10 years ago
Sergei Golubchik	13989b36c1	cleanup: remove useless internal fied flag	10 years ago
Vladislav Vaintroub	f1daf9ced4	MDEV-9024 Build fails with VS2015 Fix build failures caused by new C runtime library - isnan, snprintf, struct timespec are now defined, attempt to redefine them leads - P_tmpdir, tzname are no more defined - lfind() and lsearch() in lf_hash.c had to be renamed, declaration conflicts with some C runtime functions with the same name declared in a header included by stdlib.h Also fix couple of annoying warnings : - remove #define NOMINMAX from config.h to avoid "redefined" compiler warnings(NOMINMAX is already in compile flags) - disable incremental linker in Debug as well (feature not used much and compiler crashes often) Also simplify package building with Wix, require Wix 3.9 or later (VS2015 is not compatible with old Wix 3.5/3.6)	10 years ago
Sergey Vojtovich	18e9c314e4	MDEV-6650 - LINT_INIT emits code in non-debug builds Replaced all references to LINT_INIT with UNINIT_VAR and LINT_INIT_STRUCT. Removed LINT_INIT macro.	11 years ago
Sergei Golubchik	7f5e51b940	MDEV-34 delete storage/ndb and sql/ndb (and collateral changes) remove: * NDB from everywhere * IM from mtr-v1 * packaging/rpm-oel and packaging/rpm-uln * few unused spec files * plug.in file * .bzrignore	11 years ago
Sergei Golubchik	ae3cc4f1b7	MDEV-6561 libedit detection is broken fix readline/libedit detection: * search in readline/, editline/ and edit/readline/ * fix typos CMAKE_REQUIRES_LIBRARIES -> CMAKE_REQUIRED_LIBRARIES * use correct libedit API * use different cmake variables for libedit and readline	11 years ago
Venkata Sidagam	a0537faa8b	Bug #17297324 GLIBC DOUBLE FREE OR CORRUPTION WHEN KILLING CLIENT; CTRL+C Description: Sometimes when killing the mysql command line client with KILL -2(SIGINT), mysql client core dumps as a result of a double free or corruption. Analysis: When we run the mysql client in command line mode it will goes to mysql_end() and frees many data structures. At the same time (i.e after some data structures are freed), if we give "KILL -2" signal then the signal will be handled with function handle_kill_signal() and as part of it will again calls mysql_end() and goes with free() to the already freed data structure for batch_readline_end() function, which causes core dump. Fix: Ignoring SIGQUIT and SIGINT signals when cleanup process starts. This will help in resolving the double free issues, which occurs in case the signal handler function is started in between of the clean up function. For 5.6 we need to ignore SIGHUP also.	11 years ago
Venkata Sidagam	c20c135a23	Bug #17297324 GLIBC DOUBLE FREE OR CORRUPTION WHEN KILLING CLIENT; CTRL+C Description: Sometimes when killing the mysql command line client with KILL -2(SIGINT), mysql client core dumps as a result of a double free or corruption. Analysis: When we run the mysql client in command line mode it will goes to mysql_end() and frees many data structures. At the same time (i.e after some data structures are freed), if we give "KILL -2" signal then the signal will be handled with function handle_kill_signal() and as part of it will again calls mysql_end() and goes with free() to the already freed data structure for batch_readline_end() function, which causes core dump. Fix: Ignoring SIGQUIT and SIGINT signals when cleanup process starts. This will help in resolving the double free issues, which occurs in case the signal handler function is started in between of the clean up function. For 5.6 we need to ignore SIGHUP also.	11 years ago
Sergei Golubchik	26618a54fa	MDEV-5736 remove what remains from ONE_SHOT hack	12 years ago
Michael Widenius	49ca12a107	Fixed some failing tests Remove memory warnings if mysql client aborts early Changed copyright for clients client/mysql.cc: Free memory if get_options fails, so that we don't get warnings from safemalloc include/welcome_copyright_notice.h: Added SkySQL to client copyrights mysql-test/valgrind.supp: Added suppressions for memory leaks from dlopen() for OpenSUSE 12.3 storage/oqgraph/mysql-test/oqgraph/regression_mdev5744.result: Suppress warning storage/oqgraph/mysql-test/oqgraph/regression_mdev5744.test: Suppress warning	12 years ago
Vamsikrishna Bhagi	6923c1d9a5	Bug #18186103 BUFFER OVERFLOW IN CLIENT Problem: While printing the Server version, mysql client doesn't check for the buffer overflow in a String variable. Solution: Used a different print function which checks the allocated length before writing into the string.	12 years ago
Vamsikrishna Bhagi	c187840b6b	Bug #18186103 BUFFER OVERFLOW IN CLIENT Problem: While printing the Server version, mysql client doesn't check for the buffer overflow in a String variable. Solution: Used a different print function which checks the allocated length before writing into the string.	12 years ago
unknown	4e6606acad	MDEV-4984: Implement MASTER_GTID_WAIT() and @@LAST_GTID. MASTER_GTID_WAIT() is similar to MASTER_POS_WAIT(), but works with a GTID position rather than an old-style filename/offset. @@LAST_GTID gives the GTID assigned to the last transaction written into the binlog. Together, the two can be used by applications to obtain the GTID of an update on the master, and then do a MASTER_GTID_WAIT() for that position on any read slave where it is important to get results that are caught up with the master at least to the point of the update. The implementation of MASTER_GTID_WAIT() is implemented in a way that tries to minimise the performance impact on the SQL threads, even in the presense of many waiters on single GTID positions (as from @@LAST_GTID).	12 years ago
Sergei Golubchik	16e0cae0cc	fixed a client-side overflow in mysql cli	12 years ago
Sergei Golubchik	8ece9de833	workaround test failures in buildbot: in some VMs readline thinks that the window size is zero. ignore it.	12 years ago
Michael Widenius	04bee0af2e	Fix for MDEV-5547: Bad error message when moving very old .frm files to MariaDB 5.5. mysql_upgrade --help now also prints out --default options and variable values. mysql_upgrade now prints permission errors. mysql_upgrade doesn't print some non essential info if --silent is used. Added handler error message about incompatible versions Fixed that mysqlbug and mysql_install_db have the executable flag set. Removed executable flag for some non executable files. Changed in mysql_install_db askmonty.org to mariadb.com. Ensured that all client executables prints --default options the same way. Allow REPAIR ... USE_FRM for old .frm files if the are still compatible. Extended shown error for storage engine messages. client/mysql.cc: print_defaults() should be first (as in all other programs) client/mysql_upgrade.c: --help now also prints out --default options and variable values Print out error if wrong permissions Don't print info if --silent client/mysqladmin.cc: print_defaults() should be first (as in all other programs) client/mysqlbinlog.cc: Added print_defaults() to --help client/mysqlcheck.c: Added empty line in --help client/mysqlimport.c: Added empty line in --help client/mysqlshow.c: Made --help compatible client/mysqlslap.c: Made --help compatible client/mysqltest.cc: Added print_defaults() to --help include/handler_ername.h: Added handler error message include/my_base.h: Added handler error message mysql-test/r/mysql_upgrade.result: Updated results mysql-test/r/repair.result: Added test case for better error messages mysql-test/std_data/host_old.MYD: Added test case for better error messages mysql-test/std_data/host_old.MYI: Added test case for better error messages mysql-test/std_data/host_old.frm: Added test case for better error messages mysql-test/t/repair.test: Added test case for better error messages mysys/my_handler_errors.h: Added handler error message scripts/CMakeLists.txt: Fixed that mysqlbug and mysql_install_db have the executable flag set scripts/mysql_install_db.sh: askmonty.org -> mariadb.com sql/ha_partition.cc: Sometimes table_type() can be called for errors even if partition didn't manage to open any files sql/handler.cc: Write clear text for not handled, but defined error messages. sql/share/errmsg-utf8.txt: Extended shown error for storage engine messages sql/sql_admin.cc: Allow REPAIR ... USE_FRM for old .frm files if the are still compatible storage/myisam/ha_myisam.cc: Use new error message	12 years ago
Sergei Golubchik	70f6ac10b3	MDEV-5323 Ctrl-C not working under Ubuntu don't reset interrupted_query after sending the KILL signal, otherwise the client won't know it has to stop fetching and printing the data.	12 years ago
Sergei Golubchik	ab3604989c	MDEV-4243 [PATCH] Warnings/errors while compiling with clang fix the code to compile with clang. fix warnings too. include/probes_mysql_nodtrace.h: clang++ doesn't like numeric _constants_ being used in \|\| (it suspects that the intention was \| ). Boolean constants are ok. sql/hostname.cc: only used in DBUG_ASSERT sql/item.cc: str_to_time and str_to_datetime return bool, not MYSQL_TIMESTAMP_xxx sql/item_func.cc: str_to_datetime_with_warn() returns bool, not MYSQL_TIMESTAMP_xxx storage/cassandra/CMakeLists.txt: CMAKE_CXX_FLAGS can be empty storage/connect/odbconn.cpp: HWND is void* storage/connect/user_connect.h: deprecated on FreeBSD and unused anyway storage/connect/value.cpp: bad characters inside. unused. storage/spider/spd_trx.cc: clang++ warns that memset will also overwrite vtbl. it might be as well a good idea, as it asserts that the object will only be used as a storage. silence the warning.	12 years ago
unknown	c776f5ac26	Client attributes	12 years ago

1 2 3 4 5 ...

1666 Commits (985d2d393c285ecd4539cb579b680f7b91fdaa1a)