mariadb

Tree: 96b8909062

Author	SHA1	Message	Date
Sergei Golubchik	96b8909062	MDEV-16662 CMake warnings: CMP0022	7 years ago
Sergei Golubchik	aa19eda7da	MDEV-16662 CMake warnings: CMP0007	7 years ago
Sergei Golubchik	a39337415d	MDEV-14900 Upstream 10.3 debian patches applied (at least partially): * armhf_mroonga_storage_fail.patch (unaligned write) * mysqld_multi.server_lsb-header.patch (add LSB header) * fix-spelling-errors.patch (tabxml.cpp) * hurd_socket.patch (in Platform.pm) * remove-systemd-obsolete-target.patch	7 years ago
Sergei Golubchik	08b91548db	MDEV-16495 mariadb segfaults at start on FreeBSD don't use MY_MUTEX_INIT_FAST in constructors of statically allocated objects.	7 years ago
Otto Kekäläinen	10d347dc6a	Deb: Make libmariadb3 Breaks+Replaces libmariadbclient18 so upgrade pass The package libmariadbclient18 contains the dialog.so plugin, which also the new libmariadb3 ships. As they both use the exact same path the latter must be marked as a with Breaks and Replaces relations ship. Note: This fix is conservative hack for stable releases 10.2 and 10.3. In 10.4, the development release at the time, we will clean up how the libmariadb3 packaging and it's -compat packages are done to match that what is done in downstream Debian official.	7 years ago
Marko Mäkelä	340c8a2a32	Remove set-but-not-used log_sys.log.state	7 years ago
Sachin	482d4da0a7	MDEV-15127 AddressSanitizer: stack-buffer-overflow in base_list::push_back .. Problem:- If we try to run this query with -WITH_ASAN=ON compiled server CREATE TABLE t1 (i INT); SET debug_dbug="+d,test_completely_invisible,test_invisible_index"; CREATE TABLE t2 LIKE t1; This will generate a stack buffer overflow error. ==8922==ERROR: AddressSanitizer: stack-buffer-overflow on address #ADDR Analyze:- Error is generated on this line if (((last)=new list_node(info, &end_of_list))) So info is our Key, &end_of_list is global variable and last == #ADDR So last is suspicious variable. And last is the variable present in alter_info ->key_list. Now the question is how this key_list->last gets wrong/ different stack variable. In the backtrace, we can see that key_list is generated in mysql_create_table_like_table by calling mysql_preapre_alter_table_function and dummy key_list is created by mysql_create_like_table. In the end on mysql_prepare_alter_table we call alter_info->key_list.swap(new_key_list); So there is two options either key_list is empty or not empty , IF it is not empty then there is no issues last ptr is replaced by thd->mem_root (allocated ptr) So problem arises when key_list is empty. It swaps the dummy last ptr by mysql_prepare_alter_table declared ptr. which is wrong. Solution:- We wont swap variable if list does not have any element.	7 years ago
Alexander Barkov	4cbadaeaea	MDEV-16891 EVENTs created with SQL_MODE=ORACLE fail to execute	7 years ago
Otto Kekäläinen	cb1945dd0d	MDEV-16666: Partially revert "Deb: Update documentation and fix spelling errors" This partially reverts commit `548ec3a088` by removing the misfixed misspellings.	7 years ago
Vladislav Vaintroub	3570ea9189	remove warning on Windows Replace do-it-yourself version of strdup() with real strdup().	7 years ago
Vladislav Vaintroub	f4e2db5b43	MDEV-16544 - crash in ha_sphinx::create() Use table_arg that was passed to the function, instead of dereferencing this->table, which is a NULL pointer.	7 years ago
Igor Babaev	d453374fc4	MDEV-16801 seg_fault on a query The bug was in the in the code of JOIN::check_for_splittable_materialized() where the structures describing the fields of a materialized derived table that potentially could be used in split optimization were build. As a result of this bug some fields that were not usable for splitting were detected as usable. This could trigger crashes further in st_join_table::choose_best_splitting().	7 years ago
Oleksandr Byelkin	7749745b7d	Fix of type, to make windows compiler happy.	7 years ago
Marko Mäkelä	aab5c557cf	MDEV-16830 Crash in ALTER TABLE DROP FOREIGN KEY ha_innobase::inplace_alter_table(): Do nothing if INNOBASE_ALTER_INSTANT flags (such as DROP FOREIGN KEY) was present. Also, use ALTER_OPTIONS instead of the alias ALTER_CHANGE_CREATE_OPTION. This bug was caused by MDEV-11369, MDEV-13134 or related work.	7 years ago
Marko Mäkelä	05459706f2	Merge 10.2 into 10.3	7 years ago
Marko Mäkelä	e6a808bec7	Fix heap-use-after-free in debug code rw_lock_get_debug_info(): Remove. This function is inherently unsafe to use, because the copied pointers can become stale between rw_lock_debug_mutex_exit() and the dereferencing of the pointer in the caller.	7 years ago
Marko Mäkelä	be370efac4	Do not declare an unused variable	7 years ago
Marko Mäkelä	7b145fae13	mariabackup: Use snprintf() instead of sprintf()	7 years ago
Marko Mäkelä	391e60b2db	Fix -Wclass-memaccess warnings in InnoDB	7 years ago
Marko Mäkelä	814ae57daf	Merge 10.1 into 10.2	7 years ago
Oleksandr Byelkin	9d42eb5e28	Disable an unstable test	7 years ago
Marko Mäkelä	769f6d2db7	Fix -Wclass-memaccess in WSREP,InnoDB,XtraDB	7 years ago
Marko Mäkelä	0d3972c6be	Merge 10.0 into 10.1	7 years ago
Marko Mäkelä	9dfef6e29b	Fix -Wclass-memaccess warnings in InnoDB,XtraDB	7 years ago
Marko Mäkelä	b963cbaf4b	Follow-up fix to MDEV-16865: InnoDB fts_query() ignores KILL fts_query(): Remove a redundant condition (result will never be NULL), and instead check if *result is NULL, to prevent SIGSEGV in fts_query_free_result().	7 years ago
Marko Mäkelä	976f920514	MDEV-16850 Merge new release of InnoDB 5.7.23 to 10.2 This concludes the merge of all applicable InnoDB changes from MySQL 5.7.23, with the exception of a performance fix, which we plan to rewrite in MariaDB later in such a way that it does not involve changing the storage engine API: MDEV-16849 Extending indexed VARCHAR column should be instantaneous	7 years ago
Marko Mäkelä	62ee2cd461	Fix a race between TRUNCATE and FOREIGN KEY check This is a port of an Oracle fix. No test case was provided by Oracle. It seems that to exploit this bug, one would have to SET foreign_key_checks=0 before TRUNCATE, and to concurrently run some DML statement that causes a foreign key constraint to be checked. commit `1f24c5aa28` Author: Aditya A <aditya.a@oracle.com> Date: Fri May 18 12:32:37 2018 +0530 Bug #27208858 CONCURRENT DDL/DML ON FOREIGN KEYS CRASH IN PAGE_CUR_SEARCH_WITH_MATCH_BYTES	7 years ago
Marko Mäkelä	de469a2f29	MDEV-14637: Fix hang due to persistent statistics Similar to the tables SYS_FOREIGN and SYS_FOREIGN_COLS, the tables mysql.innodb_table_stats and mysql.innodb_index_stats are updated by the InnoDB internal SQL parser, which fails to enforce the size limits of the data. Due to this, it is possible for InnoDB to hang when there are persistent statistics defined on partitioned tables where the total length of table name, partition name and subpartition name exceeds the incorrectly defined limit VARCHAR(64). That column should have been defined as VARCHAR(199). btr_node_ptr_max_size(): Interpret the VARCHAR(64) as VARCHAR(199), to prevent a hang in the case that the upgrade script has not been run. dict_table_schema_check(): Ignore difference in the length of the table_name column. ha_innobase::max_supported_key_length(): For innodb_page_size=4k, return a larger value so that the table mysql.innodb_index_stats can be created. This could allow "impossible" tables to be created, such that it is not possible to insert anything into a secondary index when both the secondary key and the primary key are long, but this is the easiest and most consistent way. The Oracle fix would only ignore the maximum length violation for the two statistics tables. os_file_get_status_posix(), os_file_get_status_win32(): Handle ENAMETOOLONG as well. This patch is based on the following change in MySQL 5.7.23. Not all changes were applied, and our variant allows persistent statistics to work without hangs even if the table definitions were not upgraded. From `fdbdce701a` Mon Sep 17 00:00:00 2001 From: Aditya A <aditya.a@oracle.com> Date: Thu, 17 May 2018 16:11:43 +0530 Subject: [PATCH] Bug #26390736 THE FIELD TABLE_NAME (VARCHAR(64)) FROM MYSQL.INNODB_TABLE_STATS CAN OVERFLOW. In mysql.innodb_index_stats and mysql.innodb_table_stats tables the table name column didn't take into consideration partition names which can be more than varchar(64).	7 years ago
Marko Mäkelä	2046089745	MDEV-14637: Fix hang due to DDL with FOREIGN KEY When MySQL 5.7.1 introduced WL#6326 to reduce contention on the non-leaf levels of B-trees, it introduced a new rw-lock mode SX (not conflicting with S, but conflicting with SX and X) and new rules to go with it. A thread that is holding an dict_index_t::lock aka index->lock in SX mode is permitted to acquire non-leaf buf_block_t::lock aka block->lock X or SX mode, in monotonically descending order. That is, once the thread has acquired a block->lock, it is not allowed to acquire a lock on its parent or grandparent pages. Such arbitrary-order access is only allowed when the thread acquired the index->lock in X mode upfront. A customer encountered a repeatable hang when loading a dump into InnoDB while using multiple innodb_purge_threads (default: 4). The dump makes very heavy use of FOREIGN KEY constraints. By luck, it happened so that two purge worker threads (srv_worker_thread) deadlocked with each other. Both were operating on the index FOR_REF of the InnoDB internal table SYS_FOREIGN. One of them was legitimately holding index->lock S-latch and the root block->lock S-latch. The other had acquired index->lock SX-latch, root block->lock SX-latch, and a bunch of other latches, including the fil_space_t::latch for freeing some blocks and some leaf page latches. This other thread was inside 2 nested calls to btr_compress() and it was trying to reacquire the root block->lock in X mode, violating the WL#6326 protocol. This violation led to a deadlock, because while S is compatible with SX and a thread can upgrade an SX lock to X when there are no conflicting requests, in this case there was a conflicting S lock held by the other purge worker thread. During this deadlock, both threads are holding dict_operation_lock S-latch, which would block any subsequent DDL statements, such as CREATE TABLE. The tables SYS_FOREIGN and SYS_FOREIGN_COLS are special in that they define key columns of the type VARCHAR(0), created using the InnoDB internal SQL parser. Because InnoDB does not internally enforce the maximum length of columns, it would happily write more than 0 bytes to these columns. This caused a miscalculation of node_ptr_max_size. btr_cur_will_modify_tree(): Clean up some code. (No functional change.) btr_node_ptr_max_size(): Renamed from dict_index_node_ptr_max_size(). Use a more realistic maximum size for SYS_FOREIGN and SYS_FOREIGN_COLS. btr_cur_pessimistic_delete(): Refrain from merging pages if it is not safe. This work is based on the following MySQL 5.7.23 fix: commit `58dcf0b4a4` Author: Aakanksha Verma <aakanksha.verma@oracle.com> Date: Wed May 9 18:54:03 2018 +0530 BUG#26225783 MYSQL CRASH ON CREATE TABLE (REPRODUCEABLE) -> INNODB: A LONG SEMAPHORE WAIT	7 years ago
Allen Lai	f70a318576	Bug#27805553 HARD ERROR SHOULD BE REPORTED WHEN FSYNC() RETURN EIO. fsync() will just return EIO only once when the IO error happens, so, it's wrong to keep trying to call it till it return success. When fsync() returns EIO it should be treated as a hard error and InnoDB must abort immediately.	8 years ago
Sergey Vojtovich	a1b2336199	Optimized away excessive condition trx_set_rw_mode() is never called for read-only transactions, this is guarded by callers. Removing this condition from critical section immediately gives 5% scalability improvement in OLTP index updates benchmark.	8 years ago
Marko Mäkelä	f867a695f8	After-merge fix: Remove an unnecessary parameter	7 years ago
Alexander Barkov	8ae2a2dbe6	MDEV-15363 Wrong result for CAST(LAST_DAY(TIME'00:00:00') AS TIME) This problem was earlier fixed by the patch for MDEV-15340. Adding tests only.	7 years ago
Oleksandr Byelkin	5ce21bc67f	Merge branch '10.1' into 10.2	7 years ago
Oleksandr Byelkin	b4f7f12e2b	fix galera test.	7 years ago
Michael Widenius	89b6ce026a	Disabled rocksdb.autoinc_debug as it fails very often	7 years ago
Rasmus Johansson	a89a6e4f77	Added -j option to dpkg-buildpackage to speed up build	7 years ago
Alexander Barkov	1b87cd80a2	MDEV-16878 Functions ADDTIME and SUBTIME get wrongly removed from WHERE by the equal expression optimizer	7 years ago
Marko Mäkelä	ef3070e997	Merge 10.1 into 10.2	7 years ago
Daniel Bartholomew	90b66c1699	bump the VERSION	7 years ago
Vladislav Vaintroub	a90b3862d9	MDEV-16860 MyRocks: support CRC32 instructions on Winx64 Compile on Windows MSVC with -DHAVE_SSE2 and -DHAVE_PCLMUL It is safe, since code will do also runtime checks via cpuid(), before using the instructions, and will fallback to slower versions, if instructions are not available.	7 years ago
Marko Mäkelä	2fb68244b4	Merge 10.0 into 10.1	7 years ago
Marko Mäkelä	a7f84f09bf	MDEV-16865 InnoDB fts_query() ignores KILL The functions fts_ast_visit() and fts_query() inside InnoDB FULLTEXT INDEX query processing are not checking for THD::killed (trx_is_interrupted()), like anything that potentially takes a long time should do. This is a port of the following change from MySQL 5.7.23, with a completely rewritten test case. commit `c58c6f8f66` Author: Aakanksha Verma <aakanksha.verma@oracle.com> Date: Fri May 4 15:53:13 2018 +0530 Bug #27155294 MAX_EXECUTION_TIME NOT INTERUPTED WITH FULLTEXT SEARCH USING MECAB	7 years ago
Marko Mäkelä	b3e95086e1	Fix function pointer type mismatch	7 years ago
Alexey Botchkov	f4eac2deeb	MDEV-16054 simple json functions flatline cpu on garbage input. Incorrect char sentence should be handled properly.	7 years ago
Marko Mäkelä	87ec6a0448	Merge 10.0 into 10.1	7 years ago
Elena Stepanova	e023f9a4d5	Unstable tests for 10.0.36 release, latest additions	7 years ago
Oleksandr Byelkin	865e807125	Merge branch '10.0' into 10.1	7 years ago
Marko Mäkelä	e52315a4a2	MDEV-16855 Fix fts_sync_synchronization in InnoDB This is a backport of the following fix from MySQL 5.7.23. Some code refactoring has been omitted, and the test case has been adapted to MariaDB. commit `7a689acaa6` Author: Krzysztof Kapuścik <krzysztof.kapuscik@oracle.com> Date: Tue Mar 13 12:34:03 2018 +0100 Bug#27082268 Invalid FTS sync synchronization The fix closes two issues: Bug #27082268 - INNODB: FAILING ASSERTION: SYM_NODE->TABLE != NULL DURING FTS SYNC Bug #27095935 - DEADLOCK BETWEEN FTS_DROP_INDEX AND FTS_OPTIMIZE_SYNC_TABLE Both issues were related to a FTS cache sync being done during operations that perfomed DDL actions on internal FTS tables (ALTER TABLE, TRUNCATE). In some cases the FTS tables and/or internal cache structures could get removed while still being used to perform FTS synchronization leading to crashes. In other the sync operations could not get finishes as it was waiting for dict lock which was taken by thread waiting for the background sync to be finished. The changes done includes: - Stopping background operations during ALTER TABLE and TRUNCATE. - Removal of unused code in FTS. - Cleanup of FTS sync related code to make it more readable and easier to maintain. RB#18262	7 years ago
Marko Mäkelä	5ed2da9587	Apply the 5.6.40 security fixes to XtraDB We did not merge Percona XtraDB 5.6.40-84.0 yet. The changes in it are mostly cosmetic, except for 2 bug fixes from Oracle MySQL 5.6.40, which could be security bugs. This was achieved by taking the applicable parts of an earlier InnoDB commit to XtraDB: git diff 15ec8c2f28f08517ecbffb959d756b4bdd53ab45{~,} storage/innobase\| sed -e s+/innobase/+/xtradb/+\|patch -p1	7 years ago

1 2 3 4 5 ...

183119 Commits (96b8909062c0b4df654f11057905b1e31398f88f) All Branches Search

183119 Commits (96b8909062c0b4df654f11057905b1e31398f88f)

All Branches