mariadb

Tree: 89633995e4

Author	SHA1	Message	Date
Marko Mäkelä	89633995e4	MDEV-16678: Actually ignore #sql-ib tables Apparently, regular expression operations that remove entire lines of output do not work with list_files, and hence the adjustments in commit `1c282d4bc4` were ineffective. For cat_file (preceded by list_files_write_file) the replace_regex does work. For some reason, for suite/parts/inc/partition_crash_exchange.inc some file names will be lost when using list_files_write_file instead of list_files. We use a precise pattern match. dict_mem_create_temporary_tablename() is generating #sql-ib names followed by decimal digits only.	6 years ago
Marko Mäkelä	28c89b7151	Merge 10.4 into 10.5	6 years ago
Marko Mäkelä	745fd4b39f	MDEV-21174: Remove some mlog_write_initial_log_record_fast() Pass buf_block_t* to more functions that write redo log. page_zip_write_node_ptr(), page_zip_write_blob_ptr(), page_zip_compress_write_log_no_data(): Take buf_block_t* as parameter, and do not tolerate mtr=NULL. page_zip_compress(): Do not tolerate mtr=NULL. page_zip_dir_insert(): Take page_cur_t* as parameter. mlog_write_initial_log_record(): Remove. This function was unused. RecIterator::remove(): Remove the redundant page_zip parameter. PageConverter::m_page_zip_ptr: Remove.	6 years ago
Marko Mäkelä	2b5a269cb4	MDEV-21174: Clean up record insertion page_cur_insert_rec_low(): Take page_cur_t* as a parameter, and do not tolerate mtr=NULL. page_cur_insert_rec_zip(): Do not tolerate mtr=NULL.	6 years ago
Marko Mäkelä	befde6e97e	MDEV-12353 preparation: Clean up page_cur_delete_rec() page_cur_delete_rec(): Do not tolerate mtr=NULL. page_delete_rec(): Merge with the only caller, RecIterator::remove(). RecIterator::m_mtr: New data member: a dummy mini-transaction.	6 years ago
Marko Mäkelä	1c282d4bc4	MDEV-16678: Ignore stray #sql-ib tables The adjustments in `adb117cf69` turned out to be insufficient.	6 years ago
Marko Mäkelä	8fa759a576	Merge 10.3 into 10.4 We disable the MDEV-21189 test galera.galera_partition because it times out.	6 years ago
Eugene Kosov	a9ea0056c7	MDEV-21133: use aligned memcpy in redo log and buffer pool	6 years ago
Alexander Barkov	bbd2fa5c65	MDEV-21278 Assertion `is_unsigned() == attr.unsigned_flag' or Assertion `field.is_sane()' failed The type handler and unsigned_flag erroneously went out of sync in Item_func_minus::fix_length_and_dec.	6 years ago
Marko Mäkelä	3466b47b0d	Merge 10.2 into 10.3	6 years ago
Eugene Kosov	f0aa073f2b	MDEV-20950 Reduce size of record offsets offset_t: this is a type which represents one record offset. It's unsigned short int. a lot of functions: replace ulint with offset_t btr_pcur_restore_position_func(), page_validate(), row_ins_scan_sec_index_for_duplicate(), row_upd_clust_rec_by_insert_inherit_func(), row_vers_impl_x_locked_low(), trx_undo_prev_version_build(): allocate record offsets on the stack instead of waiting for rec_get_offsets() to allocate it from mem_heap_t. So, reducing memory allocations. RECORD_OFFSET, INDEX_OFFSET: now it's less convenient to store pointers in offset_t* array. One pointer occupies now several offset_t. And those constant are start indexes into array to places where to store pointer values REC_OFFS_HEADER_SIZE: adjusted for the new reality REC_OFFS_NORMAL_SIZE: increase size from 100 to 300 which means less heap allocations. And sizeof(offset_t[REC_OFFS_NORMAL_SIZE]) now is 600 bytes which is smaller than previous 800 bytes. REC_OFFS_SEC_INDEX_SIZE: adjusted for the new reality rem0rec.h, rem0rec.ic, rem0rec.cc: various arguments, return values and local variables types were changed to fix numerous integer conversions issues. enum field_type_t: offset types concept was introduces which replaces old offset flags stuff. Like in earlier version, 2 upper bits are used to store offset type. And this enum represents those types. REC_OFFS_SQL_NULL, REC_OFFS_MASK: removed get_type(), set_type(), get_value(), combine(): these are convenience functions to work with offsets and it's types rec_offs_base()[0]: still uses an old scheme with flags REC_OFFS_COMPACT and REC_OFFS_EXTERNAL rec_offs_base()[i]: these have type offset_t now. Two upper bits contains type.	6 years ago
Eugene Kosov	014e125830	optimize crash recovery recv_dblwr_t::list is used for appending to the beginning and iterating through its elements. std::deque fits better for that purpose because it does less allocations than std::forward_list and provides better memory locality.	6 years ago
Eugene Kosov	ce41a9075a	fix a memory leak introduced by `f4b4284650`	6 years ago
Marko Mäkelä	0a20e5ab77	Merge 10.2 into 10.3	6 years ago
Alexander Barkov	e0f9540bcc	MDEV-20667 Server crash on pop_cursor When backpatching a forward GOTO label, the old code erroneously used CURSOR/HANDLER difference between context frames "c" and "a" to tune a cpop/hpop command. So the cpop/hpop command later tried to pop all cursors/handlers declared between "a" and "c", but those between "b" and "c" were not cpushed/hpoped yet during the execution of "GOTO x". Fixing the code to use the difference between frames "b" and "a" only. BEGIN -- a ... GOTO x; -- b ... <<x>> -- c ... END -- d	6 years ago
Vladislav Vaintroub	3304004a57	MDEV-21260 Innodb/Wjndows do not report error when trying open volumes on UNC paths fil_node_t::find_metadata() tries to find out whether file is on an SSD, and the disk sector size. On Windows, it opens the corresponding volume for finding this data. This does not go well, if datadir is on network path/UNC. The volume name is invalid, CreateFile() function fails, and a cryptic (from the end user perspective) error is reported. Like this [ERROR] InnoDB: File \\.\\\workpc\work: 'CreateFile()' returned OS error 203. The fix is not to report error if open volume failed, and the path was not on fixed disk, i.e not on HDD or SSD. This is not a fatal error, there is a fallback anyway.	6 years ago
Vladislav Vaintroub	71e47f34f8	git ignore generated stuff	6 years ago
Vlad Lesin	beec9c0e19	MDEV-21255: Deadlock of parallel slave and mariabackup (with failed log copy thread) mariabackup hangs waiting until innodb redo log thread read log till certain LSN, and it waits under FTWRL. If there is redo log read error in the thread, it is finished, and main thread knows nothing about it, what leads to hanging. As it hangs under FTWRL, slave threads on server side can be blocked due to MDL lock conflict. The fix is to finish mariabackup with error message on innodb redo log read failure.	6 years ago
Varun Gupta	808036a61d	MDEV-19380: ASAN heap-use-after-free in Protocol::net_store_data The issue here is window function makes the passed string object to point to an area in a temporary table's record buffer. Then, the temporary table is freed, together with its record buffer. Then, Item_cache_str attempts to read this value. The fix is to call value_buff.copy(). This will make the value_buff to store its string in a buffer that it owns, which will not disappear unexpectedly.	6 years ago
Daniel Bartholomew	3b401a69f7	bump the VERSION	6 years ago
Daniel Bartholomew	ce47e66516	bump the VERSION	6 years ago
Daniel Bartholomew	546644f1cc	bump the VERSION	6 years ago
Eugene Kosov	f4b4284650	MDEV-16678 Prefer MDL to dict_sys.latch for innodb background tasks Use std::queue backed by std::deque instead of list because it does less allocations which still having O(1) push and pop operations. Also store trx_purge_rec_t directly, because its only 16 bytes and allocating it is to wasteful. This should be faster. purge_node_t::purge_node_t: container is already empty after creation purge_node_t::end(): replace clearing container with assertion that it's clear	6 years ago
Vladislav Vaintroub	202a62deb0	MDEV-11345 Compile english error messages into mysqld executable. Simplify loading messages into mariabackup. Do the same as server does We're forcing english, so there is no attempt to load errmsg.sys	6 years ago
Daniele Sciascia	72a5a4f1d5	MDEV-20780 Fixes for failures on galera_sr_ddl_master (#1425 ) Test galera_sr_ddl_master would sometimes fail due to leftover streaming replication fragments. Rollbacker thread would attempt to open streaming_log table to remove the fragments, but would fail in check_stack_overrun(). Ultimately the check_stack_overrun() failure was caused by rollbacker missing to switch the victim's THD thread stack to rollbacker's thread stack. Also in this patch: - Remove duplicate functionality in rollbacker helper functions, and extract rollbacker fragment removal into function wsrep_remove_streaming_fragments() - Reuse open_for_write() in wsrep_schema::remove_fragments - Partially revert changes to galera_sr_ddl_master test from commit `44a11a7c08`. Removed unnecessary wait condition and isolation level setting	6 years ago
Vladislav Vaintroub	280f1c2605	MDEV-11345 Compile english error messages into mysqld executable.	6 years ago
Marko Mäkelä	f2d3b2eede	Cleanup test sys_vars.innodb_buffer_pool_size_basic When using huge pages, the innodb_buffer_pool_size cannot necessarily be restored. Simplify things by restarting the server.	6 years ago
Marko Mäkelä	41e6a154ec	MDEV-14482 - Cache line contention on ut_rnd_interval() InnoDB RNG maintains global state, causing otherwise unnecessary bus traffic. Even worse, this is cross-mutex traffic. That is, different mutexes suffer from contention. Fixed delay of 4 was verified to give best throughput by OLTP update index and read-write benchmarks on Intel Broadwell (2/20/40) and ARM (1/46/46). This is a backport of `ce04790065` from MariaDB Server 10.3.	6 years ago
Marko Mäkelä	b1f2d3a8c8	MDEV-21256: Replace the 64-bit LCG with a 32-bit Galois LFSR We should not need anywhere near 32 bits of entropy, so we might just limit ourselves to a 32-bit random number generator. Also, it might be cheaper to use exclusive-or, bit shifting and conditional jumps, instead of multiplication and addition. We use relaxed atomic operations on the global random number generator state in order in an attempt to silence any warnings about race conditions. There is an obvious race condition between the load and store in ut_rnd_gen(), but we do not think that it matters much that the state of the random number generator could 'stutter'. This change seems makes the 'uncompress_ops' nondeterministic in innodb_zip.cmp_per_index after the restart. It looks like there is an inherent race condition in the test, because the table could be opened for InnoDB statistics recalculation already before innodb_cmp_per_index_enabled was set. We might end up having uncompress_ops anywhere between 0 and 9, or perhaps even more. Let us remove that part of the test.	6 years ago
Marko Mäkelä	d146e3dcfe	MDEV-21256: Simplify ut_rnd_interval() ut_rnd_interval(): Remove the first parameter, which was mostly passed as 0. Implement as a simple wrapper around ut_rnd_gen(). Trivially return 0 if the size of the interval is smaller than 2. ut_rnd_ulint_counter, ut_rnd_gen_next_ulint(), ut_rnd_gen_ulint(): Remove.	6 years ago
Marko Mäkelä	51fc8ab73e	MDEV-21256: Reduce the use of ut_rnd_gen_next_ulint() ut_rnd_set_seed(): Unused function; remove. ut_rnd_gen(): Renamed from page_cur_lcg_prng(). ut_rnd_current: The internal state of ut_rnd_gen(). page_cur_open_on_rnd_user_rec(): Replace linear search with page_rec_get_nth().	6 years ago
Marko Mäkelä	adb117cf69	MDEV-16678: Fix a problem with duplicate #sql2 table names row_drop_table_for_mysql(): If a #sql2 table is open in another thread (purge) while we attempting to drop it, rename it to #sql-ib name to hide it from the SQL layer. Adjust tests accordingly to hide #sql-ib tables, which can continue to exist until the background DROP TABLE completes.	6 years ago
Eugene Kosov	4c0854f221	MDEV-21223 innodb_fts.sync_ddl fails in buildbot, server crashed in que_thr_step FreeState(): replace pointer to freed memory with NULL. This actually fixes a crash which is use-after-free as reported by ASAN DbugParse(): unconditionally lock mutex because we're touching shared init_settings.keywords	6 years ago
Elena Stepanova	7c2c420b70	List of unstable tests for 10.4.11 release	6 years ago
Marko Mäkelä	ea37b14409	MDEV-16678 Prefer MDL to dict_sys.latch for innodb background tasks This is joint work with Thirunarayanan Balathandayuthapani. The MDL interface between InnoDB and the rest of the server (in storage/innobase/dict/dict0dict.cc and in include/) is my work, while most everything else is Thiru's. The collection of InnoDB persistent statistics and the defragmentation were not refactored to use MDL. They will keep relying on lower-level interlocking with fil_check_pending_operations(). The purge of transaction history and the background operations on fulltext indexes will use MDL. We will revert commit `2c4844c9e7` (MDEV-17813) because thanks to MDL, purge cannot conflict with DDL operations anymore. For a similar reason, we will remove the MDEV-16222 test case from gcol.innodb_virtual_debug_purge. Purge is essentially replacing all use of the global dict_sys.latch with MDL. Purge will skip the undo log records for tables whose names start with #sql-ib or #sql2. Theoretically, such tables might be renamed back to visible table names if TRUNCATE fails to create a new table, or the final rename in ALTER TABLE...ALGORITHM=COPY fails. In that case, purge could permanently leave some garbage in the table. Such garbage will be tolerated; the table would not be considered corrupted. To avoid repeated MDL releases and acquisitions, trx_purge_attach_undo_recs() will sort undo log records by table_id, and purge_node_t will keep the MDL and table handle open for multiple successive undo log records. get_purge_table(): A new accessor, used during the purge of history for indexed virtual columns. This interface should ideally not exist at all. thd_mdl_context(): Accessor of THD::mdl_context. Wrapped in a new thd_mdl_service. dict_get_db_name_len(): Define inline. dict_acquire_mdl_shared(): Acquire explicit shared MDL on a table name if needed. dict_table_open_on_id(): Return MDL_ticket, if requested. dict_table_close(): Release MDL ticket, if requested. dict_fts_index_syncing(), dict_index_t::index_fts_syncing: Remove. row_drop_table_for_mysql() no longer needs to check these, because MDL guarantees that a fulltext index sync will not be in progress while MDL_EXCLUSIVE is protecting a DDL operation. dict_table_t::parse_name(): Parse the table name for acquiring MDL. purge_node_t::undo_recs: Change the type to std::list<trx_purge_rec_t*> (different container, and storing also roll_ptr). purge_node_t: Add mdl_ticket, last_table_id, purge_thd, mdl_hold_recs for acquiring MDL and for keeping the table open across multiple undo log records. purge_vcol_info_t, row_purge_store_vsec_cur(), row_purge_restore_vsec_cur(): Remove. We will acquire the MDL earlier. purge_sys_t::heap: Added, for reading undo log records. fts_sync_during_ddl(): Invoked during ALGORITHM=INPLACE operations to ensure that fts_sync_table() will not conflict with MDL_EXCLUSIVE. Uses fts_t::sync_message for bookkeeping.	6 years ago
Oleksandr Byelkin	af650c76a6	MDEV-18460: Server crashed in strmake / tdc_create_key / THD::create_tmp_table_def_key When there is a WITH clause we postpone check for tables without database for later stages when tables in WITH will be defined. But we should not try to open such tables as temporary tables because temporary tables always belong to a some database.	6 years ago
Varun Gupta	246e2ae12b	MDEV-20900: IN predicate to IN subquery conversion causes performance regression Disable the IN predicate to IN subquery conversion when the types on the left and right hand side of the IN predicate are not of comparable type.	6 years ago
Vladislav Vaintroub	e47bd0073c	MDEV-21262 MTR does not work with Windows ASAN builds Do not use suppressions on Windows, the ASAN_OPTIONS can't be parsed whenever full file names are used, because file names contain ':' which is ASAN_OPTIONS delimeter.	6 years ago
Vladislav Vaintroub	66de4fef76	MDEV-16264 - some improvements - wait notification, tpool_wait_begin/tpool_wait_end - to notify the threadpool that current thread is going to wait Use it to wait for IOs to complete and also when purge waits for workers.	6 years ago
Marko Mäkelä	d3b2625ba0	MDEV-21259 Assertion failed in mtr_t::write() btr_free_externally_stored_field(): Pass w=mtr_t::OPT to note that the BTR_EXTERN_LEN is not necessarily changing when a multi-page ROW_FORMAT=COMPRESSED off-page column is being freed, and to allow redundant writes to the redo log to be optimized away. Ever since commit `56f6dab1d0` the refactored function mtr_t::write() asserts by default that the page contents is being changed.	6 years ago
Oleksandr Byelkin	a15234bf4b	Merge branch '10.3' into 10.4	6 years ago
Marko Mäkelä	425748f1b5	Cleanup: Replace a redundant statement with an assertion	6 years ago
Marko Mäkelä	292015d486	MDEV-21254 Remove unused keywords from the InnoDB SQL parser The InnoDB internal SQL parser, which is used for updating the InnoDB data dictionary tables (to be removed in MDEV-11655), persistent statistics (to be refactored in MDEV-15020) and fulltext indexes, implements some unused keywords and built-in functions: OUT BINARY BLOB INTEGER FLOAT SUM DISTINCT READ COMPACT BLOCK_SIZE TO_CHAR TO_NUMBER BINARY_TO_NUMBER REPLSTR SYSDATE PRINTF ASSERT RND RND_STR ROW_PRINTF UNSIGNED Also, procedures are never declared with parameters. Only one top-level procedure is declared and invoked at a time, and parameters are being passed via pars_info_t.	6 years ago
Jan Lindström	59e14b9684	MDEV-21189: Dropping partition with 'wsrep_OSU_method=RSU' and 'SESSION sql_log_bin = 0' cases the galera node to hang Found two bugs (1) have_committing_connections was missing mutex unlock on one exit case. As this function is called on a loop it caused mutex lock when we already owned the mutex. This could cause hang. (2) wsrep_RSU_begin did set up error code when partition to be dropped could not be MDL-locked because of concurrent operations but wrong error code was propagated to upper layer causing error to be ignored. This could have also caused the hang.	6 years ago
Teemu Ollakka	9a62120089	MDEV-21229 Update wsrep-lib to deal with libstdc++ vector assertion (#1423 ) The assertion was caused by use of operator[] for an empty vector. The wsrep-lib update changes vector operations which access the underlying data array to use data() method which is valid for empty vectors.	6 years ago
Alexey Botchkov	fd1979bc9a	MDEV-18463 Don't allow multiple table CONSTRAINTs with the same name. Add necessary checks.	6 years ago
Vladislav Vaintroub	6aa0fa3897	CONC-417 Windows clients using Schannel often encounter error SEC_E_INVALID_TOKEN reenable ssl_8k_key on Windows, which was affected by this bug	6 years ago
Vladislav Vaintroub	6484288cd2	CONC-447 ERROR 2026 (HY000): SSL connection error: Certificate signature check failed Enable CRL checking on Windows. Enable certificate verification testing in client testing.	6 years ago
Alexander Barkov	d30dbaa20d	A cleanup for MDEV-8844: Fixing compilation failure on Windows Fixing lossy type conversions: - from int64 to int - from size_t to uint	6 years ago
Alexander Barkov	3c6065a270	MDEV-8844 Unreadable control characters printed as is in warnings	6 years ago

1 2 3 4 5 ...

188082 Commits (89633995e4962a7ad4a241cdf62ee637990d6787) All Branches Search

188082 Commits (89633995e4962a7ad4a241cdf62ee637990d6787)

All Branches