mariadb

Tree: 884d22f288

Author	SHA1	Message	Date
Eugene Kosov	884d22f288	remove fishy reinterpret_cast from buf_page_is_zeroes() In my micro-benchmarks memcmp(4196) 3 times faster than old implementation. Also, it's generally better to use as less reinterpret_casts<> as possible. buf_is_zeroes(): renamed from buf_page_is_zeroes() and argument changed to span<> for convenience. st_::span<T>::const_iterator: fixed page_zip-verify_checksum(): make argument byte* instead of void*	6 years ago
Igor Babaev	2bde065525	MDEV-17177 Crash in Item_func_in::cleanup() for SELECT executed via prepared statement The method Item_func_in::build_clone() that builds a clone item for an Item_func_in item first calls a generic method Item_func::build_item() that builds the the clones for the arguments of the Item_func_in item to be cloned, creates a copy of the Item_func_in object and attaches the clones for the arguments to this copy. Then the method Item_func_in::build_clone() makes the copy fully independent on the copied object in order to guarantee a proper destruction of the clone. The fact is the copy of the Item_func_in object is registered as any other item object and should be destructed as any other item object. If the method Item_func::build_item fails to build a clone of an argument then it returns 0. In this case no copy of the Item_func_in object should be created. Otherwise the finalizing actions for this copy would not be performed and the copy would remain in a state that would prevent its proper destruction. The code of Item_func_in::build_clone() before this patch created the copy of the Item_func_in object before cloning the argument items. If this cloning failed the server crashed when trying to destruct the copy item. The code of Item_row::build_clone() was changed similarly to the code of Item_func::build_clone though this code could not cause any problems.	6 years ago
Marko Mäkelä	9f7b8625e6	MDEV-14431: Fix ulong/ulonglong type mismatch	6 years ago
Marko Mäkelä	b034d708c8	MDEV-21549: Clean up the import/export tests Remove CREATE/DROP database. Remove some unnecessary suppressions, replacements, and SQL statements. Populate tables via have_sequence.inc to avoid the creation of explicit InnoDB record locks in INSERT...SELECT. This will remove some gaps in AUTO_INCREMENT values.	6 years ago
Marko Mäkelä	b8b3edff13	MDEV-21549 IMPORT TABLESPACE fails to adjust all tablespace ID in root pages After MDEV-12353, the consistency check that I originally added for commit `1b9fe0bbac` (InnoDB Plugin for MySQL 5.1) started randomly failing. It turns out that the IMPORT TABLESPACE code was always incorrect: it did not update the (redundantly stored) tablespace ID in index tree root pages. It only does that for page headers and BLOB pointers. PageConverter::update_index_page(): Update the tablespace ID in the BTR_SEG_TOP and BTR_SEG_LEAF of index root pages.	6 years ago
Marko Mäkelä	c9ec1cc751	Merge 10.1 into 10.2	6 years ago
Alexander Barkov	328edf8560	MDEV-21977 main.func_math fails due to undefined behaviour The problem happened in these line: uval0= (ulonglong) (val0_negative ? -val0 : val0); uval1= (ulonglong) (val1_negative ? -val1 : val1); return check_integer_overflow(val0_negative ? -(longlong) res : res, !val0_negative); when unary minus was performed on -9223372036854775808. This behavior is undefined in C/C++.	6 years ago
Marko Mäkelä	a66eebf57c	MDEV-21981 Replace arithmetic + with bitwise OR when possible Several macros such as sint2korr() and uint4korr() are using the arithmetic + operator while a bitwise or operator would suffice. GCC 5 and clang 5 and later can detect patterns consisting of bitwise or and shifts by multiples of 8 bits, such as those used in the InnoDB function mach_read_from_4(). They actually translate that verbose low-level code into high-level machine language (i486 bswap instruction or fused into the Haswell movbe instruction). We should do the same for MariaDB Server code that is outside InnoDB. Note: The Microsoft C compiler is lacking this optimization. There, we might consider using _byteswap_ushort(), _byteswap_ulong(), _byteswap_uint64(). But, those would lead to unaligned reads, which are bad for reasons stated in MDEV-20277. Besides, outside InnoDB, most data is already being stored in the native little-endian format of that compiler.	6 years ago
Marko Mäkelä	6960e9ed24	MDEV-21983: Crash on DROP/RENAME TABLE after DISCARD TABLESPACE fil_delete_tablespace(): Remove the unused parameter drop_ahi, and add the parameter if_exists=false. We want to suppress error messages if we know that the tablespace has been discarded. dict_table_rename_in_cache(): Pass the new parameter to fil_delete_tablespace(), that is, do not complain about missing tablespace if the tablespace has been discarded. row_make_new_pathname(): Declare as static. row_drop_table_for_mysql(): Tolerate !table->data_dir_path when the tablespace has been discarded. row_rename_table_for_mysql(): Skip part of the RENAME TABLE when fil_space_get_first_path() returns NULL.	6 years ago
Marko Mäkelä	9fd692aeca	MDEV-13626: Clean up the buffer pool resizing tests from MySQL 5.7 buf_pool_resize(): Simplify the fault injection for innodb.buf_pool_resize_oom. innodb.buf_pool_resize_oom: Use a small buffer pool. innodb.innodb_buffer_pool_load_now: Make use of the sequence engine, to avoid creating explicit InnoDB record locks. Clean up the accesses to information_schema.innodb_buffer_page_lru.	6 years ago
Marko Mäkelä	bfb5e1c3f0	MDEV-13626: Import and adjust buffer pool resizing tests from MySQL 5.7	6 years ago
Marko Mäkelä	e28b4b68d3	MDEV-14057: Fix some tests	6 years ago
Alexey Botchkov	a0ce62f804	MDEV-14057 InnoDB GIS tests fail. Tests fixed. MBR::Within() function fixed.	6 years ago
Thirunarayanan Balathandayuthapani	09e8707d90	MDEV-21826 Recovery failure : loop of Read redo log up to LSN - This issue is caused by MDEV-19176 (`bba59abb03`). - Problem is that there is miscalculation of available memory during recovery if innodb_buffer_pool_instances > 1. - Ignore the buffer pool instance while calculating available_memory - Removed recv_n_pool_free_frames variable and use buf_pool_get_n_pages() instead.	6 years ago
Oleksandr Byelkin	6ecbb211c0	new (fixed) version of CC.	6 years ago
Marko Mäkelä	ab0034a789	MDEV-20370 Crash after OPTIMIZE TABLE on TEMPORARY TABLE Temporary tables are typically short-lived, and temporary tables are assumed to be accessed only by the thread that is handling the owning connection. Hence, they must not be subject to defragmenting. ha_innobase::optimize(): Do not add temporary tables to the defragment_table() queue.	6 years ago
Thirunarayanan Balathandayuthapani	e61b99073f	MDEV-14808 innodb_fts.sync fails in buildbot with wrong result AUTO_INCREMENT values are nondeterministic after crash recovery. While MDEV-6076 guarantees that the AUTO_INCREMENT values of committed transactions will not roll back, it is possible that the AUTO_INCREMENT values will be durably incremented for incomplete transactions. So changing the test case to avoid showing the result of AUTO_INCREMENT value.	6 years ago
Alexey Botchkov	e64a3df4dc	MDEV-21959 GIS error message doesn't show the wrong value, just the type. Error message now shows the whole value.	6 years ago
Marko Mäkelä	89698cef72	MDEV-10570: Fix -Wmaybe-uninitialized Rows_log_event::change_to_flashback_event(): Reduce the scope of the variable swap_buff2, and do not duplicate conditions. GCC 9.3.0 flagged the -Wmaybe-uninitialized when compiling the 10.5 branch using cmake -DWITH_ASAN=ON -DCMAKE_CXX_FLAGS=-O2	6 years ago
Petr Vaněk	b1d7ba472e	innodb: fix typo in function description Function os_file_get_last_error_low returns error number + OS_FILE_ERROR_MAX (which is currently set to 200) for unknown numbers to this program.	6 years ago
Sergei Golubchik	5c1ed707a3	mtr: update heuristics for --parallel=auto to work better for CPUs with more than 2000 bogomips. old behavior is preserved if less than 2500 bogomips.	6 years ago
Sergei Golubchik	0fe3d6d563	all status variables above `questions` MUST be ulong see e.g. `add_to_status()`	6 years ago
Marko Mäkelä	ed21202a14	Fix GCC 10.0 -Wstringop-overflow myrg_open(): Reduce the scope of the variable 'end' and simplify the code. For some reason, I got no warning for this code in the 10.2 branch, only 10.3 or later. The ENGINE=MERGE is covered by the tests main.merge, main.merge_debug, and main.merge-big.	6 years ago
Sujatha	d9d3c222ca	MDEV-10047: table-based master info repository Problem: ======= When we upgrade from "mysql" to "mariadb" if slave is using repositories as tables their data is completely ignored and no warning is issued in error log. Fix: === "mysql_upgrade" test should check for the presence of data in "mysql.slave_master_info" and "mysql.slave_relay_log_info" tables. When tables have some data the upgrade script should report a warning which hints users that the data in repository tables will be ignored.	6 years ago
Marko Mäkelä	9f858f38c0	Fix clang 10 warnings _ma_fetch_keypage(): Correct an assertion that used to always hold. Thanks to clang -Wint-in-bool-context for flagging this. double_to_datetime_with_warn(): Suppress -Wimplicit-int-float-conversion by adding a cast. LONGLONG_MAX converted to double will actually be LONGLONG_MAX+1.	6 years ago
Marko Mäkelä	2e8b0c56a0	MDEV-21933 INFORMATION_SCHEMA.INNODB_SYS_TABLESPACES accesses SYS_DATAFILES All tablespace metadata is buffered in fil_system. There is a LRU mechanism, but that only controls the opening and closing of fil_node_t::handle. It is much more efficient and less error-prone to access data file names by looking up the fil_space_t object rather than by essentially joining each row with an access to SYS_DATAFILES via the InnoDB internal SQL parser. dict_get_first_path(): Declare static. The function may only be needed when loading or updating the data dictionary. Also, change a condition in order to avoid a bogus GCC 10 -Wstringop-overflow warning for mem_strdupl() about len==ULINT_UNDEFINED. i_s_sys_tablespaces_fill_table(): Do not access other InnoDB internal dictionary tables than SYS_TABLESPACES.	6 years ago
Marko Mäkelä	47382a2f8c	Fix GCC 10 -Wclass-memaccess	6 years ago
Marko Mäkelä	a8566f727f	Fix GCC 10 -Wstringop-truncation	6 years ago
Marko Mäkelä	2c8fa28f40	Update libmariadb This fixes GCC 10.0.1 -Wstringop-truncation and some typos.	6 years ago
Marko Mäkelä	32904dc5fa	Merge 10.1 into 10.2	6 years ago
Marko Mäkelä	7b082fb099	Merge 5.5 into 10.1	6 years ago
Eugene Kosov	5257bcfc7a	InnoDB: improve error message for checksum mismatch	6 years ago
Eugene Kosov	7f36300df5	MDEV-21918 improve page_zip_verify_checksum() actually, page_zip_verify_checksum() generally allows all-zeroes checksums because our CRC32 checksum is something like crc_1 ^ crc_2 ^ crc_3 Also, all zeroes page is considered correct. As a side effect fix nasty reinterpret_cast<> UB Also, since `c0f47a4a58` innodb_checksum_algorithm=full_crc32 exists which computes CRC32 in one go (without bitwise arithmetic)	6 years ago
Eugene Kosov	df88e7cefa	fix typedef-related warning and cleanup using namespace std	6 years ago
Marko Mäkelä	3ab33c6c92	Cleanup: clang-10 -Wmisleading-indentation Also, remove some trailing white space and add missing static qualifier to free_annotate_event().	6 years ago
Sergei Petrunia	b30446c85d	Fix compile warning: It was: implicit conversion from 'ha_rows' (aka 'unsigned long long') to 'double' changes value from 18446744073709551615 to 18446744073709551616 Follow what JOIN::get_examined_rows() does for similar code.	6 years ago
Jan Lindström	069bad5e6b	Add galera debug sync to galera_slave_replay test.	6 years ago
Marko Mäkelä	02343c4a54	MDEV-19740: Correct a type mismatch WITH_INNODB_EXTRA_DEBUG	6 years ago
Eugene Kosov	2b8b85bd0a	fix use-after-free	6 years ago
Marko Mäkelä	69e4c74e07	Make main.mysql_client_test non-great again Re-enable main.mysql_client_test on all builders, because at the moment we do not run any --big-test on buildbot due to resource constraints. A number of tests were declared big in commit `eeee1832d7` in an attempt to save resources on buildbot.	6 years ago
Marko Mäkelä	8cd6cee876	Merge 10.1 into 10.2	6 years ago
Marko Mäkelä	1c40cb6877	Do not bother to disable non-existing tests	6 years ago
Marko Mäkelä	7a52b6fd25	Minor cleanup of main.partition_innodb Stop masking the Data_free values, because innodb_file_per_table=1 is the default. Also, do mask Update_time after updating tables, even though for some reason it does appear to matter.	6 years ago
Jan Lindström	2bf4e574ad	MDEV-21758 : Events switched randomly to SLAVESIDE_DISABLED Change events only on Galera environment where idea is that event is enabled only on one node of the cluster and nodes are identified by server_id.	6 years ago
Vicențiu Ciorbaru	d7f74150e5	Check for CPU_COUNT macro within my_getncpus * Small refactor of my_getncpus function to compile for very old glibc < 2.6. * Cleanup code to eliminate duplication.	6 years ago
Daniel Black	6610532170	Update install layout to account for multi-arch setup Cleanup install_layout to account for multi-arch setup and remove redundant defines in debian rules. Signed-off-by: Vicențiu Ciorbaru <vicentiu@mariadb.org>	6 years ago
Oleksandr Byelkin	75d286c2cc	Merge branch '10.1' into 10.2	6 years ago
Stepan Patryshev	91aae18cc4	Enable galera.galera_ist_mariabackup and galera.mysql-wsrep#33.	6 years ago
Oleksandr Byelkin	345aaca14c	Merge branch '5.5' into 10.1	6 years ago
Vicențiu Ciorbaru	c5c1027c6e	MDEV-19208 mariadb.pc: install into libdir The .pc file installed by mariadb mentions archful directories and therefore must be archful itself. This fixes MDEV-14340.	6 years ago

1 2 3 4 5 ...

183205 Commits (884d22f28884e1decced1dee9c69ddcb25002ed1) All Branches Search

183205 Commits (884d22f28884e1decced1dee9c69ddcb25002ed1)

All Branches