mariadb

Tree: 837ad9ab97

Author	SHA1	Message	Date
Rucha Deodhar	837ad9ab97	MDEV-10014 Add RETURNING to INSERT Closes #1384	6 years ago
Sergei Golubchik	57a09a72a3	cleanup st_select_lex_unit::explainable	6 years ago
Sergei Golubchik	721a9df751	cleanup: formatting comments, whitespaces	6 years ago
Sergei Golubchik	828d9ae597	cleanup: reduce code duplication	6 years ago
Sergei Golubchik	a4a025f5d1	cleanup: don't pass wild_num to setup_wild() because internally setup_wild() adjusts select_lex->with_wild directly anyway, so there is no reason to pretend that the number of '*' may be anything else but select_lex->with_wild And don't update select_lex->item_list, because fields can come from anywhere and don't necessarily have to be copied into select_lex.	6 years ago
Sergei Golubchik	c7320830a6	outer references in subqueries in INSERT remove inconsistent limitation	6 years ago
Sergei Golubchik	173ae63114	MDEV-12684 Show what config file a sysvar got a value from Show the config file in I_S.SYSTEM_VARIABLES But only if the user has FILE privilege	6 years ago
Sergei Golubchik	f217612fad	MDEV-12684 Show what config file a sysvar got a value from change get_one_option() prototype to pass the filename and not to pass the redundant optid.	6 years ago
Sergei Golubchik	927521a2c1	MDEV-12684 Show what config file a sysvar got a value from make load_defaults() store the file name in the generated option list using a special marker ---file-marker--- option. Pick up this filename in handle_options(). Remove ---args-separator---, use ---file-marker--- with an empty file name instead - this simplifies checks on the caller, only one special option to recognize.	6 years ago
Sergei Golubchik	f7b8d14490	cleanup: don't use my_getopt_is_args_separator() only my_getopt should use it, because it changes my_getopt's behavior. If one simply wants to skip the separator - don't ask it to be added in the first place	6 years ago
Sergei Golubchik	3e56972712	cleanup: unify --defaults* option handling process all --defaults* options uniformly, get rid of special case for --no-defaults and --print-defaults use realpath instead of blindly concatenating pwd and relative path.	6 years ago
Sergei Golubchik	3ea51b518b	cleanup: my_getopt, get_one_option isn't optional it turns out that practically every single user of handle_options() used the get_one_option callback. Simplify the code, make it mandatory, adjust unit tests.	6 years ago
Sergei Golubchik	eb3431d529	cleanup: my_getopt, consistency almost all my_getopt settings and callbacks are global variables, directly assignable to configure my_getopt. Only getopt_get_addr was using a setter function. Get rid of it, make it a global directly assignable variable like all other settings. Also make getopt_compare_strings() static.	6 years ago
Sergei Golubchik	8965ae27b9	cleanup: my_defaults, remove Process_option_func This is a remnant of "MySQL Instance Manager", which was removed in MySQL-5.5.0 and never existed in MariaDB Remove callback, simplify and optimize the code accordingly.	6 years ago
Alexander Barkov	5392726e3c	MDEV-20818 ER_CRASHED_ON_USAGE or Assertion `length <= column->length' failed in write_block_record on temporary table The patch for `MDEV-20795 CAST(inet6 AS BINARY) returns wrong result` unintentionally changed what Item_char_typecast::type_handler() returns. This broke UNIONs with the BINARY() function, as the Aria engine started to get columns of unexpected data types. Restoring previous behaviour, to return Type_handler::string_type_handler(max_length). The prototype for Item_handed_func::return_type_handler() has changed from: const Type_handler return_type_handler() const to: const Type_handler return_type_handler(const Item_handled_func *) const	6 years ago
Alexander Barkov	fa8437908b	clang failed to compile the embedded library with unused constant errors Putting "#ifndef NO_EMBEDDED_ACCESS_CHECKS" around these constant declarations: const uint max_hostname_length= 60; const uint max_dbname_length= 64;	6 years ago
Alexander Barkov	9853026cec	MDEV-20800 Server crashes in Field_inet6::store_warning upon updating table statistics Suppress warnings when Field_inet6::store() is called from read_statistics_for_table() and other optimizer related routines. This patch does for Field_inet6 the same thing with what Monty's patch previously did for other Field_xxx: > commit `1bbe8c5e0f` > Author: Michael Widenius <monty@mariadb.org> > Date: Sun Sep 22 04:08:48 2019 +0300 > > Proper fix for disabling warnings in read_statistics_for_table(). > MDEV-20589: Server still crashes in Field::set_warning_truncated_wrong_value Alas, some meaningful warnings disappeared.	6 years ago
Alexander Barkov	2cb7047f69	Removing redundant `--source include/have_innodb.inc` from type_inet6_{memory\|myisam}.test These tests use only HEAP and MyISAM tables.	6 years ago
Alexander Barkov	93cf67fda8	Adding the "override" keyword to Item_char_typecast_func_handler_inet6_to_binary::type_handler_for_create_select() Clang fails to compile without it.	6 years ago
Oleksandr Byelkin	ebeb4f93e8	MDEV-16327: Server doesn't account for engines that supports OFFSET on their own. Engine get LIMIT/OFFSET info an can it use/reset.	6 years ago
Oleksandr Byelkin	a6de640804	MDEV-18553: MDEV-16327 pre-requisits part 3: move kill check in one place Kill check moved from send_data() methids in its wrapper: send_data_with_check().	6 years ago
Oleksandr Byelkin	1ae02f0e0d	MDEV-18553: MDEV-16327 pre-requisits part 2: uniform of LIMIT/OFFSET handling Now both offset and limit are stored and do not chenged during execution (offset is decreased during processing in versions before 10.5). (Big part of this changes made by Monty)	6 years ago
Oleksandr Byelkin	eb0804ef5e	MDEV-18553: MDEV-16327 pre-requisits part 1: isolation of LIMIT/OFFSET handling	6 years ago
Marko Mäkelä	8336371441	Merge 10.4 into 10.5	6 years ago
Marko Mäkelä	899c843f11	Merge 10.3 into 10.4	6 years ago
Marko Mäkelä	fa6c606257	MDEV-20814 Assertion index->is_instant() failed on trivial upgrade from 10.1 rec_init_offsets(): Relax the assertion that was added in commit `01f45becd1` to catch ROW_FORMAT=REDUNDANT records that have fewer fields than expected. This assertion would fail when accessing the records of the built-in InnoDB table SYS_INDEXES. The column MERGE_THRESHOLD had been effectively instantly added in MariaDB Server 10.2 (and MySQL 5.7), but is_instant() does not hold for that index. Relax the assertion, so that it will not fail in this case.	6 years ago
Marko Mäkelä	0a473de08d	Null-merge 10.3 into 10.4	6 years ago
Marko Mäkelä	bb450b1fed	Merge 10.2 into 10.3	6 years ago
Marko Mäkelä	361e8284f3	MDEV-20813 Assertion failure in buf_flush_init_for_writing() for innodb_immediate_scrub_data_uncompressed=ON The assertion that was added in commit `c0c003beb4` to augment the fix of MDEV-20805 turns out to be invalid when innodb_immediate_scrub_data_uncompressed is enabled. In this mode, fsp_init_file_page() will be invoked on data pages that have been freed, causing writes of almost-all-zero pages. btr_page_free(): Adjust the comment. buf_flush_init_for_writing(): Disable the assertion with a note that it should be re-enabled in MDEV-15528.	6 years ago
Alexander Barkov	6860d6f8be	Fixing a mysqld crash on Ubuntu-10.2 (Quantal)	6 years ago
Marko Mäkelä	dba743b653	Fix -Wunused-variable	6 years ago
Marko Mäkelä	55c75b6bb3	Merge 10.3 into 10.4	6 years ago
Marko Mäkelä	8e3d85e112	Merge 10.2 into 10.3	6 years ago
Alexander Barkov	530f3f7cfc	MDEV-20806 Federated does not work with INET6, returns NULL with warning ER_TRUNCATED_WRONG_VALUE	6 years ago
Marko Mäkelä	2227dec45e	Merge 10.1 into 10.2	6 years ago
Julius Goryavsky	2ae02c295a	MDEV-20728: /usr/sbin/mysqld: unknown variable 'defaults-group-suffix=mysqld1 When the mysqld_multi script passes the --defaults-group-suffix option to mysqld, it must remove the initial substring with the group name ("mysqld") from option value, because otherwise substring "mysqld" will be added to the group name and then the group name will contain the word "mysqld" twice, which is wrong, because mysqld itself adds the suffix received to the group name.	6 years ago
Julius Goryavsky	4ca0abe964	MDEV-20728: /usr/sbin/mysqld: unknown variable 'defaults-group-suffix=mysqld1 When the mysqld_multi script passes the --defaults-group-suffix option to mysqld, it must remove the initial substring with the group name ("mysqld") from option value, because otherwise substring "mysqld" will be added to the group name and then the group name will contain the word "mysqld" twice, which is wrong, because mysqld itself adds the suffix received to the group name.	6 years ago
Julius Goryavsky	0ecc85c5d9	MDEV-20728: /usr/sbin/mysqld: unknown variable 'defaults-group-suffix=mysqld1 When the mysqld_multi script passes the --defaults-group-suffix option to mysqld, it must remove the initial substring with the group name ("mysqld") from option value, because otherwise substring "mysqld" will be added to the group name and then the group name will contain the word "mysqld" twice, which is wrong, because mysqld itself adds the suffix received to the group name.	6 years ago
Julius Goryavsky	36824d2bef	MDEV-20728: /usr/sbin/mysqld: unknown variable 'defaults-group-suffix=mysqld1 When the mysqld_multi script passes the --defaults-group-suffix option to mysqld, it must remove the initial substring with the group name ("mysqld") from option value, because otherwise substring "mysqld" will be added to the group name and then the group name will contain the word "mysqld" twice, which is wrong, because mysqld itself adds the suffix received to the group name.	6 years ago
Alexander Barkov	a0d3a351b8	MDEV-20790 CSV table with INET6 can be created and inserted into, but cannot be read from	6 years ago
Marko Mäkelä	38736928e7	Fix -std=c++98 -Wzero-length-array This is another follow-up fix to commit `b393e2cb0c` which turned out to be still broken. Replace the C++11 keyword 'constexpr' with #define. debug_sync_t::str: Remove the zero-length array. Replace sync->str with reinterpret_cast<char*>(&sync[1]).	6 years ago
Marko Mäkelä	1e1b53ccfd	After-merge fix: Correct an assertion During IMPORT TABLESPACE, we do invoke buf_flush_init_for_writing() with block==NULL and newest_lsn!=0.	6 years ago
Alexander Barkov	5d6d28f274	MDEV-20798 Conversion from INET6 to other types performed without errors or warnings	6 years ago
Alexander Barkov	d8e599bb80	MDEV-20808 CAST from INET6 to FLOAT does not produce an error	6 years ago
Marko Mäkelä	966d97b5f9	Merge 10.1 into 10.2	6 years ago
Marko Mäkelä	1fd1ef25c2	Fix CMAKE_BUILD_TYPE=Debug Remove unused variables and type mismatch that was introduced in commit `b393e2cb0c` Also, fix a typo in the documentation of the parameter, and update the test.	6 years ago
Marko Mäkelä	b42294bc64	MDEV-19514 Defer change buffer merge until pages are requested We will remove the InnoDB background operation of merging buffered changes to secondary index leaf pages. Changes will only be merged as a result of an operation that accesses a secondary index leaf page, such as a SQL statement that performs a lookup via that index, or is modifying the index. Also ROLLBACK and some background operations, such as purging the history of committed transactions, or computing index cardinality statistics, can cause change buffer merge. Encryption key rotation will not perform change buffer merge. The motivation of this change is to simplify the I/O logic and to allow crash recovery to happen in the background (MDEV-14481). We also hope that this will reduce the number of "mystery" crashes due to corrupted data. Because change buffer merge will typically take place as a result of executing SQL statements, there should be a clearer connection between the crash and the SQL statements that were executed when the server crashed. In many cases, a slight performance improvement was observed. This is joint work with Thirunarayanan Balathandayuthapani and was tested by Axel Schwenke and Matthias Leich. The InnoDB monitor counter innodb_ibuf_merge_usec will be removed. On slow shutdown (innodb_fast_shutdown=0), we will continue to merge all buffered changes (and purge all undo log history). Two InnoDB configuration parameters will be changed as follows: innodb_disable_background_merge: Removed. This parameter existed only in debug builds. All change buffer merges will use synchronous reads. innodb_force_recovery will be changed as follows: * innodb_force_recovery=4 will be the same as innodb_force_recovery=3 (the change buffer merge cannot be disabled; it can only happen as a result of an operation that accesses a secondary index leaf page). The option used to be capable of corrupting secondary index leaf pages. Now that capability is removed, and innodb_force_recovery=4 becomes 'safe'. * innodb_force_recovery=5 (which essentially hard-wires SET GLOBAL TRANSACTION ISOLATION LEVEL READ UNCOMMITTED) becomes safe to use. Bogus data can be returned to SQL, but persistent InnoDB data files will not be corrupted further. * innodb_force_recovery=6 (ignore the redo log files) will be the only option that can potentially cause persistent corruption of InnoDB data files. Code changes: buf_page_t::ibuf_exist: New flag, to indicate whether buffered changes exist for a buffer pool page. Pages with pending changes can be returned by buf_page_get_gen(). Previously, the changes were always merged inside buf_page_get_gen() if needed. ibuf_page_exists(const buf_page_t&): Check if a buffered changes exist for an X-latched or read-fixed page. buf_page_get_gen(): Add the parameter allow_ibuf_merge=false. All callers that know that they may be accessing a secondary index leaf page must pass this parameter as allow_ibuf_merge=true, unless it does not matter for that caller whether all buffered changes have been applied. Assert that whenever allow_ibuf_merge holds, the page actually is a leaf page. Attempt change buffer merge only to secondary B-tree index leaf pages. btr_block_get(): Add parameter 'bool merge'. All callers of btr_block_get() should know whether the page could be a secondary index leaf page. If it is not, we should avoid consulting the change buffer bitmap to even consider a merge. This is the main interface to requesting index pages from the buffer pool. ibuf_merge_or_delete_for_page(), recv_recover_page(): Replace buf_page_get_known_nowait() with much simpler logic, because it is now guaranteed that that the block is x-latched or read-fixed. mlog_init_t::mark_ibuf_exist(): Renamed from mlog_init_t::ibuf_merge(). On crash recovery, we will no longer merge any buffered changes for the pages that we read into the buffer pool during the last batch of applying log records. buf_page_get_gen_known_nowait(), BUF_MAKE_YOUNG, BUF_KEEP_OLD: Remove. btr_search_guess_on_hash(): Merge buf_page_get_gen_known_nowait() to its only remaining caller. buf_page_make_young_if_needed(): Define as an inline function. Add the parameter buf_pool. buf_page_peek_if_young(), buf_page_peek_if_too_old(): Add the parameter buf_pool. fil_space_validate_for_mtr_commit(): Remove a bogus comment about background merge of the change buffer. btr_cur_open_at_rnd_pos_func(), btr_cur_search_to_nth_level_func(), btr_cur_open_at_index_side_func(): Use narrower data types and scopes. ibuf_read_merge_pages(): Replaces buf_read_ibuf_merge_pages(). Merge the change buffer by invoking buf_page_get_gen().	6 years ago
Marko Mäkelä	c0c003beb4	MDEV-20805 follow-up: Catch writes of bogus pages buf_flush_init_for_writing(): Assert that FIL_PAGE_TYPE is set except when creating a new data file with a dummy first page. buf_dblwr_create(): Ensure that FIL_PAGE_TYPE on all pages will be initialized. Reset buf_dblwr_being_created at the end.	6 years ago
Marko Mäkelä	cbfd6882f4	Merge 5.5 into 10.1	6 years ago
Marko Mäkelä	ea61b79694	MDEV-20805 ibuf_add_free_page() is not initializing FIL_PAGE_TYPE first In the function recv_parse_or_apply_log_rec_body() there are debug checks for validating the state of the page when redo log records are being applied. Most notably, FIL_PAGE_TYPE should be set before anything else is being written to the page. ibuf_add_free_page(): Set FIL_PAGE_TYPE before performing any other changes.	6 years ago

1 2 3 4 5 ...

187581 Commits (837ad9ab9760db83b2d117a6183519f18448b782) All Branches Search

187581 Commits (837ad9ab9760db83b2d117a6183519f18448b782)

All Branches