mariadb

Tree: 773479f5b3

Author	SHA1	Message	Date
Vladislav Vaintroub	773479f5b3	Add test for partial backup for partitioned table.	7 years ago
Sergei Golubchik	2cf30866d7	MDEV-14576 Include full name of object in message about incorrect value for column update engines/ suites followup for `c4ab352b67`	7 years ago
Sergei Golubchik	37b1b065f4	TokuDB: generate tokudb.cnf unconditionally it's listed in MYSQL_ADD_PLUGIN() declaration, so it must always exist, jemalloc or not.	7 years ago
Marko Mäkelä	c5bb6024a7	MDEV-18039 Assertion failed in btr_node_ptr_max_size for VARCHAR(0) btr_node_ptr_max_size(): Do not reserve extra space for indexed VARCHAR(0) columns.	7 years ago
Eugene Kosov	0dafcf529c	cleanup os_event	7 years ago
Eugene Kosov	ed166f53fa	MDEV-18043 data race in os_event os_event::is_set(): protect os_event::m_set with os_event::mutex	7 years ago
Marko Mäkelä	b7a9563b21	Merge 10.1 into 10.2	7 years ago
Marko Mäkelä	40a094e4a8	Relax a too tight suppression When using a wrong key, all encrypted pages will look corrupted, and occasionally the test may access other pages than the clustered index root page.	7 years ago
Alexander Barkov	e631ea4a7c	MDEV-17738 Server crashes in Item::delete_self on closing connection after unsuccessful PS Also fixes: MDEV-17741 Assertion `thd->Item_change_list::is_empty()' failed in mysql_parse after unsuccessful PS The problem was introduced by: commit `f033fbd9f2` Changed the test case for MDEV-15571 It was later fixed, but in 10.3 only: commit `ce2cf855bf` MDEV-16043 Assertion thd->Item_change_list::is_empty() failed in mysql_parse upon SELECT from a view reading from a versioned table This patch is a backport of `ce2cf855bf` to 10.2	7 years ago
Vladislav Vaintroub	9f4a4cb401	Cleanup recent mariabackup validation patches. - Refactor code to isolate page validation in page_is_corrupted() function. - Introduce --extended-validation parameter(default OFF) for mariabackup --backup to enable decryption of encrypted uncompressed pages during backup. - mariabackup would still always check checksum on encrypted data, it is needed to detect partially written pages.	7 years ago
Marko Mäkelä	ed36fc353f	MDEV-18025: Detect corrupted innodb_page_compression=zlib pages In MDEV-13103, I made a mistake in the error handling of page_compressed=1 decryption when the default innodb_compression_algorithm=zlib is used. Due to this mistake, with certain versions of zlib, MariaDB would fail to detect a corrupted page. The problem was uncovered by the following tests: mariabackup.unencrypted_page_compressed mariabackup.encrypted_page_compressed	7 years ago
Sergei Golubchik	dc2856ad60	Merge branch 'connect/10.2' into 10.2	7 years ago
Sergei Golubchik	8ede9b3ae5	MDEV-17975 Assertion `! is_set()' or `!is_set() \|\| (m_status == DA_OK_BULK && is_bulk_op())' failed upon REVOKE under LOCK TABLE open_grant_tables() returns -1/0/1, where -1 is an error, while 1 is not. Don't store it's return value in bool	7 years ago
Sergei Golubchik	cb4c2a98b5	always link C/C with external (to C/C) zlib it'll be either system zlib.so or bundled with the server (but still external to C/C) zlib.a	7 years ago
Sergei Golubchik	24763451fe	update C/C to v3.0.8	7 years ago
Sergei Golubchik	2027841d5b	MDEV-16110 ALTER with ALGORITHM=INPLACE breaks temporary table with virtual columns Part two, temporary tables. Make temporary tables respect TABLE::m_needs_reopen. See also `77cd754229`	7 years ago
Sergei Golubchik	d13302ff60	cleanup: small simplification	7 years ago
Sergei Golubchik	2ec018b281	MDEV-17953 MariaDB 10.2.19 with TokuDB incompatible with Jemalloc 5+ Simplify the check, remove redundant code. Add a safety check to avoid linking with static jemalloc_pic.a if jemalloc version is 5+. This doesn't fix the issue on Gentoo, it should be fixed in the ebuild.	7 years ago
Sergei Golubchik	f04bbed220	MDEV-17755 Assertion `!table \|\| (!table->read_set \|\| bitmap_is_set(table->read_set, field_index) \|\| (!(ptr >= table->record[0] && ptr < table->record[0] + table->s->reclength)))' failed in Field_bit::val_int upon SELECT with JOIN, partitions, indexed virtual column add a test case	7 years ago
Nikita Malyavin	6a73569f12	MDEV-16429: Assertion `!table \|\| (!table->read_set \|\| bitmap_is_set(table->read_set, field_index))' fails upon attempt to update virtual column on partitioned versioned table When using buffered sort in `UPDATE`, keyread is used. In this case, `TABLE::update_virtual_field` should be aborted, but it actually isn't, because it is called not with a top-level handler, but with the one that is actually going to access the disk. Here the problemm is issued with partitioning, so the solution is to recursively mark for keyread all the underlying partition handlers. * ha_partition: update keyread state for child partitions Closes #800	7 years ago
Sergei Golubchik	7b2e2288e9	MDEV-16903 Assertion `!auto_increment_field_not_null' failed in TABLE::init after unsuccessful attempt to add CHECK constraint on temporary table if the CHECK constraint failed in copy_data_between_tables(), the loop was aborted prematurely and to->auto_increment_field_not_null wasn't reset.	7 years ago
Sergei Golubchik	a79183b01e	correct table name in CHECK failures during ALTER TABLE	7 years ago
Sergei Golubchik	fca44b7c1f	MDEV-17909 Problem by MariaDB Update 10.1.32 -> 10.2.19 (Incorrect information in file: .frm) use frm_version, not mysql_version when parsing frm In particular, virtual columns are stored according to frm_version. And CHECK TABLE will overwrite mysql_version to the current server version, so it cannot correctly describe frm format.	7 years ago
Marko Mäkelä	e765b47e41	MDEV-17199 Assertion `pos < table->n_v_def' failed after upgrade to 10.2 Before MDEV-5800 in MariaDB 10.2.2, InnoDB knew nothing about virtual columns. But, they would be present in the TABLE_SHARE. It appears that the MDEV-12936 fix only worked in the special case when the virtual columns are the last columns in a table definition. mysql_fields(): Remove. build_template_needs_field(): Omit virtual columns if the InnoDB table definition is known to not contain them, based on the .frm file version. build_template_field(): Clean up some code. ha_innobase::build_template(): Remove redundant computations. Loop over all MariaDB columns. Skip virtual columns if InnoDB does not know about them. calc_row_difference(): Skip not-known-to-InnoDB virtual columns. wsrep_calc_row_hash(): Skip all virtual columns. This would fix an out-of-bounds access to dict_table_t::cols[]. Also, remove some redundant computations and variables. create_table_check_doc_id_col(): Assert that the .frm file for a newly created table will be in a format where InnoDB knows about virtual columns.	7 years ago
Marko Mäkelä	610e4034d7	Merge 10.1 into 10.2	7 years ago
Marko Mäkelä	dd72d7d561	MDEV-18025: Improve test case and consistency checks Write a test case that computes valid crc32 checksums for an encrypted page, but zeroes out the payload area, so that the checksum after decryption fails. xb_fil_cur_read(): Validate the page number before trying any checksum calculation or decrypting or decompression. Also, skip zero-filled pages. For page_compressed pages, ensure that the FIL_PAGE_TYPE was changed. Also, reject FIL_PAGE_PAGE_COMPRESSED_ENCRYPTED if no decryption was attempted.	7 years ago
Varun Gupta	82a4d55d5c	MDEV-15424: Unreasonable SQL Error (1356) on select from view While printing a view containing a window function we were printing it as an Item_field object instead of an Item_window_func object. This is incorrect and this leads to us throwing an error ER_VIEW_INVALID. Fixed by adjusting the Item_ref:print function. Also made UDF function aware if there arguments have window function.	7 years ago
Ian Gilfillan	0c2fc9b3da	Update InnoDB urls	7 years ago
Vladislav Vaintroub	74659e55b7	MDEV-16268 : sporadic checksum mismatch when opening system tablespace in backup Attempt to fix by retrying srv_sys_space.open_or_create() if it reports corruption.	7 years ago
Marko Mäkelä	560df47926	Merge 10.1 into 10.2	7 years ago
Marko Mäkelä	1b471face8	MDEV-18025: Apply the fix to XtraDB and adjust tests The fix was accidentally only applied to InnoDB, and encryption tests were not adjusted.	7 years ago
Thirunarayanan Balathandayuthapani	171271edf8	MDEV-18025 Mariabackup fails to detect corrupted page_compressed=1 tables Problem: ======= Mariabackup seems to fail to verify the pages of compressed tables. The reason is that both fil_space_verify_crypt_checksum() and buf_page_is_corrupted() will skip the validation for compressed pages. Fix: ==== Mariabackup should call fil_page_decompress() for compressed and encrypted compressed page. After that, call buf_page_is_corrupted() to check the page corruption.	7 years ago
Marko Mäkelä	977073e3dc	After-merge fix	7 years ago
Marko Mäkelä	0032170940	Merge 10.1 into 10.2	7 years ago
Marko Mäkelä	84f119f25c	MDEV-12112/MDEV-12114: Relax strict_innodb, strict_none Starting with commit `6b6987154a` the encrypted page checksum is only computed with crc32. Encrypted data pages that were written earlier can contain other checksums, but new ones will only contain crc32. Because of this, it does not make sense to implement strict checks of innodb_checksum_algorithm for other than strict_crc32. fil_space_verify_crypt_checksum(): Treat strict_innodb as innodb and strict_none as none. That is, allow a match from any of the algorithms none, innodb, crc32. (This is how it worked before the second MDEV-12112 fix.) Thanks to Thirunarayanan Balathandayuthapani for pointing this out.	7 years ago
Marko Mäkelä	ed13a0d221	MDEV-12112: Support WITH_INNODB_BUG_ENDIAN_CRC32 fil_space_verify_crypt_checksum(): Compute the bug-compatible variant of the CRC-32C checksum if the correct one does not match.	7 years ago
Marko Mäkelä	fae7e350a8	Merge 10.1 into 10.2	7 years ago
Marko Mäkelä	51a1fc737c	Fix a compiler warning fil_space_verify_crypt_checksum(): Add a dummy return statement in case memory is corrupted and innodb_checksum_algorithm has an invalid value.	7 years ago
Marko Mäkelä	7d245083a4	Merge 10.1 into 10.2	7 years ago
Marko Mäkelä	8c43f96388	Follow-up to MDEV-12112: corruption in encrypted table may be overlooked The initial fix only covered a part of Mariabackup. This fix hardens InnoDB and XtraDB in a similar way, in order to reduce the probability of mistaking a corrupted encrypted page for a valid unencrypted one. This is based on work by Thirunarayanan Balathandayuthapani. fil_space_verify_crypt_checksum(): Assert that key_version!=0. Let the callers guarantee that. Now that we have this assertion, we also know that buf_page_is_zeroes() cannot hold. Also, remove all diagnostic output and related parameters, and let the relevant callers emit such messages. Last but not least, validate the post-encryption checksum according to the innodb_checksum_algorithm (only accepting one checksum for the strict variants), and no longer try to validate the page as if it was unencrypted. buf_page_is_zeroes(): Move to the compilation unit of the only callers, and declare static. xb_fil_cur_read(), buf_page_check_corrupt(): Add a condition before calling fil_space_verify_crypt_checksum(). This is a non-functional change. buf_dblwr_process(): Validate the page only as encrypted or unencrypted, but not both.	7 years ago
Marko Mäkelä	10e01b56f7	Fix USE_AFTER_FREE (CWE-416) A static analysis tool suggested that in the function row_merge_read_clustered_index(), ut_free(nonnull) could be invoked twice for nonnull!=NULL. While a manual review of the code disproved this, it should not hurt to clean up the code so that the static analysis tool will not complain. index_tuple_info_t::insert(), row_mtuple_cmp(): Remove the parameter mtr_committed, which duplicated !mtr->is_active(). row_merge_read_clustered_index(): Initialize row_heap = NULL. Remove a duplicated call mem_heap_empty(row_heap) that was inadvertently added in commit `cb1e76e4de`. Replace a "goto func_exit" with "break", to get consistent error handling for both failures to create or write a temporary file. end_of_index: Assign row_heap=NULL and nonnull=NULL to prevent double freeing. func_exit: Check for row_heap!=NULL before invoking mem_heap_free(). Closes #959	7 years ago
Jan Lindström	517c59c540	Merge pull request #1026 from codership/10.1-galera-defaults Remove provider defaults check from 'galera_defaults' MTR test	7 years ago
Jan Lindström	ee543beabf	MDEV-18021: Galera test galera_sst_mariabackup_table_options fails if AES_CTR is not available Problem is that if you use bundled yassl AES_CTR is not supported. There is a way to detect that but as we really want to keep this test enabled did not add skip for missing support. Changed method to AES_CBC as there is no need to use AES_CTR.	7 years ago
Jan Lindström	8a46b9fe3b	MDEV-17771: Add Galera ist and sst tests using mariabackup Add check that file key management plugin is found.	7 years ago
Varun Gupta	32eeed2129	MDEV-17676: Assertion `inited==NONE \|\| (inited==RND && scan)' failed in handler::ha_rnd_init While calculating distinct with the function remove_dup_with_compare, we don't have rnd_end calls when we have completed the scan over the temporary table. Added ha_rnd_end calls when we are done with the scan of the table.	7 years ago
Alexey Botchkov	20011c8b14	MDEV-14576 Include full name of object in message about incorrect value for column. galera_prepared_statement test fixed.	7 years ago
Alexey Botchkov	d1fb52afff	MDEV-14576 Include full name of object in message about incorrect value for column. connect.xml2 test result fixed.	7 years ago
Alexey Botchkov	c4ab352b67	MDEV-14576 Include full name of object in message about incorrect value for column. The error message modified. Then the TABLE_SHARE::error_table_name() implementation taken from 10.3, to be used as a name of the table in this message.	7 years ago
Vladislav Vaintroub	0a2edddbf4	MDEV-14975 : fix last commit's typo.	7 years ago
Vladislav Vaintroub	5716c71c54	MDEV-14975 mariabackup starts with unprivileged user. ported privilege checking from xtrabackup. Now, mariabackup would terminate early if either RELOAD or PROCESS privilege is not held, not at the very end of backup The behavior can be disabled with nre setting --check-privileges=0. Also , --no-lock does not need all of these privileges, since it skips FTWRL and SHOW ENGINE STATUS INNODB.	7 years ago

1 2 3 4 5 ...

181290 Commits (773479f5b305cea938b3b5835923ca3e46454a44) All Branches Search

181290 Commits (773479f5b305cea938b3b5835923ca3e46454a44)

All Branches