mariadb

Commit Graph

Author	SHA1	Message	Date
Monty	74f70c3944	Fixed costs in JOIN_TAB::estimate_scan_time() and HEAP MDEV-35958 Cost estimates for materialized derived tables are poor Estimate_scan_time() calculates the cost of scanning a derivied table. The old code did not take into account that the temporary table heap table may be converted to Aria. Things fixed: - Added checking if the temporary tables data will fit in the heap. If not, then calculate the cost based on the designated internal temporary table engine (Aria). - Removed MY_MAX(records, 1000) and instead trust the optimizer's estimate of records. This reduces the cost of temporary tables a bit for small tables, which caused a few changes in mtr results. - Fixed cost calculation for HEAP. - HEAP costs->row_next_find_cost was not set. This does not affect old costs calculation as this cost slot was not used anywhere. Now HEAP cost->row_next_find_cost is set, which allowed me to remove some duplicated computation in ha_heap::scan_time() Reviewed by: Sergei Petrunia <sergey@mariadb.com>	8 months ago
Dave Gosselin	edd52b7fc7	MDEV-30469 Feature rebase Upon rebase, some error codes changed order so record tests to update accordingly. Merge with trigger changes from MDEV-34724.	8 months ago
Dave Gosselin	5e07d1abd4	MDEV-35848, MDEV-35568 Reintroduce delete_while_scanning for multi_delete Reintroduces delete_while_scanning optimization for multi_delete. Reverse some test changes from the initial feature devlopment now that we delete-on-the-fly once again.	8 months ago
Sergei Petrunia	8ec275da16	MDEV-35955 Wrong result for UPDATE ... ORDER BY LIMIT which uses tmp.table (Variant 2) Multi-table UPDATE ... ORDER BY ... LIMIT could update the wrong rows when ORDER BY was resolved by Using temporary + Using filesort. == Background: ref_pointer_array == join->order[->next]->item point into join->ref_pointer_array, which has pointers to the used Item objects. This indirection is employed so that we can switch the ORDER BY expressions from using the original Items to using the values of their "image" fields in the temporary table. The variant of ref_pointer_array that has pointers to temp table fields is created when JOIN::make_aggr_tables_info() calls change_refs_to_tmp_fields(). == The problem == The created array didn't match element-by-element the original ref_pointer_array. When arrays were switched, ORDER BY elements started to point to the wrong temp.table fields, causing the wrong sorting. == The cause == The cause is JOIN::add_fields_for_current_rowid(). This function is called for UPDATE statements to make the rowids of rows in the original tables to be saved in the temporary tables. It adds extra columns to the select list in table_fields argument. However, select lists are organized in a way that extra elements must be added to the front* of the list, and then change_refs_to_tmp_fields() will add extra fields to the end of ref_pointer_array. So, add_fields_for_current_rowid() adds new fields to the back of table_fields list. This caused change_refs_to_tmp_fields() to produce ref_pointer_array slice with extra elements in the front, causing any references through ref_pointer_array to come to the wrong values. == The fix == Make JOIN::add_fields_for_current_rowid() add fields to the front of the select list.	8 months ago
Dave Gosselin	5001300bd4	MDEV-30469 Support ORDER BY and LIMIT for multi-table DELETE, index hints for single-table DELETE We now allow multitable queries with order by and limit, such as: delete t1., t2. from t1, t2 order by t1.id desc limit 3; To predict what rows will be deleted, run the equivalent select: select t1., t2. from t1, t2 order by t1.id desc limit 3; Additionally, index hints are now supported with single table delete statements: delete from t2 use index(xid) order by (id) limit 2; This approach changes the multi_delete SELECT result interceptor to use a temporary table to collect row ids pertaining to the rows that will be deleted, rather than directly deleting rows from the target table(s). Row ids are collected during send_data, then read during send_eof to delete target rows. In the event that the temporary table created in memory is not big enough for all matching rows, it is converted to an aria table. Other changes: - Deleting from a sequence now affects zero rows instead of emitting an error Limitations: - The federated connector does not create implicit row ids, so we to use a key when conditionally deleting. See the change in federated_maybe_16324629.test	10 months ago
Dave Gosselin	02dc8615f2	MDEV-30469 (refactoring) Support ORDER BY and LIMIT for multi-table DELETE... This patch includes a few changes to make the code easier to maintain: - Renamed SQL_I_List::link_in_list to SQL_I_List::insert. link_in_list was ambiguous as it could refer to a link or it could refer to a node - Remove field_name local variable in multi_update::initialize_tables because it is not used when creating the temporary tables - multi_update changes: - Move temp table callocs to init, a more natural location for them, and moved tables_to_update to const member variable so we don't recompute it. - Filter out jtbm tables and tables not in the update map, pushing those that will be updated into an update_targets container. This simplifies checks and loops in initialize_tables.	10 months ago
Iqbal Hassan	dfdbec1636	MDEV-10862: Stored procedures: default values for parameters (optional parameters) Implement default values for parameters of stored routines in both default and oracle mode. - Default values for cursor parameters are NOT supported yet. - An IN parameter with DEFAULT followed by an OUT param is not supported yet. This combination will be enabled together with the arrow syntax: sp1(v=>p2) The default values can be either literals or expressions. When it is an expression, it is only evaluated if the parameter has not been supplied by the caller (important if the expression has side effects).	11 months ago
Alexander Barkov	5a8e6230d7	MDEV-34189 Unexpected error on `WHERE inet6col` normalize_cond() translated `WHERE col` into `WHERE col<>0` But the opetator "not equal to 0" does not necessarily exists for all data types. For example, the query: SELECT * FROM t1 WHERE inet6col; was translated to: SELECT * FROM t1 WHERE inet6col<>0; which further failed with this error: ERROR : Illegal parameter data types inet6 and bigint for operation '<>' This patch changes the translation from `col<>0` to `col IS TRUE`. So now SELECT * FROM t1 WHERE inet6col; gets translated to: SELECT * FROM t1 WHERE inet6col IS TRUE; Details: 1. Implementing methods: - Field_longstr::val_bool() - Field_string::val_bool() - Item::val_int_from_val_str() If the input contains bad data, these methods raise a better error message: Truncated incorrect BOOLEAN value Before the change, the error was: Truncated incorrect DOUBLE value 2. Fixing normalize_cond() to generate Item_func_istrue/Item_func_isfalse instances instead of Item_func_ne/Item_func_eq 3. Making Item_func_truth sargable, so it uses the range optimizer. Implementing the following methods: - get_mm_tree(), get_mm_leaf(), add_key_fields() in Item_func_truth. - get_func_mm_tree(), for all Item_func_truth descendants. 4. Implementing the method negated_item() for all Item_func_truth descendants, so the negated item has a chance to be sargable: For example, WHERE NOT col IS NOT FALSE -- this notation is not sargable is now translated to: WHERE col IS FALSE -- this notation is sargable	9 months ago
Otto Kekalainen	d1ba623677	All-green GitLab CI in main branch in January 2025 Ensure that the GitLab CI is green again. Ideally all failures would be fixed, but at the moment it is not feasible. As the purpose of a CI is to protect the code base from having new testable regressions slip in, update the CI pipeline to be all green by disabling multiple failing test or reduce their scope. - Avoid timeouts and make buid faster with '-DCPACK_RPM_DEBUGINFO_PACKAGE=OFF' - Remove 'GIT_CLONE_PATH' which isn't universally supported on all GitLab instances - Bump 'MARIADB_MAJOR_VERSION' to current 'main' contents (11.8). Also update the upgrade test matrix to modern MariaDB versions. - Remove UBsan builds as they are failing and can't quickly be fixed, along with the MTR test that depended on it. - Switch the CentOS 7 build to use Amazon Linux 2 instead, which has equivalent Fedora package versions, but is still maintained and package archive mirrors active. - Extend skiplist to include currently failing MTR tests. These are not quick to fix, so adding them to the skiplist will at least make the CI green and allow us to catch any new regressions. - Drop the default QPS limit in the mini-benchmark.sh to match what is currently passing. The drop is large because it wasn't adjusted after `4016c905` got merged. - Remove the currently failing faketime tests for 2028 compatibility. - Remove unnecessary `dependencies:` definitions that have no effect in the presence of `needs:` - Reduce the scope of `cppcheck` to avoid timeouts from job. - Update the ignorelists for both `cppcheck` and `flawfinder` as the jobs were failing. This way the jobs will be green again, and reveal is any new commits introduce issues. - Drop the duplicate `cppcheck` and `flawfinder` job definitions that got erroneously merged when both `9c287c0` and `f4ce1e4` got merged on the `main` branch, when the original intent was to have the latter commit only on old MariaDB versions. All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.	10 months ago
Iqbal Hassan	9f5adf0ce4	MDEV-34317: Implement RECORD type Implement `DECLARE TYPE type_name IS RECORD (..)` with scalar members in stored routines and anonymous blocks	1 year ago
Dmitry Shulga	4c956fa15b	MDEV-34724: Skipping a row operation from a trigger Implementation of this task adds ability to raise the signal with SQLSTATE '02TRG' from a BEFORE INSERT/UPDATE/DELETE trigger and handles this signal as an indicator meaning 'to throw away the current row' on processing the INSERT/UPDATE/DELETE statement. The signal with SQLSTATE '02TRG' has special meaning only in case it is raised inside BEFORE triggers, for AFTER trigger's this value of SQLSTATE isn't treated in any special way. In according with SQL standard, the SQLSTATE class '02' means NO DATA and sql_errno for this class is set to value ER_SIGNAL_NOT_FOUND by current implementation of MariaDB server. Implementation of this task assigns the value ER_SIGNAL_SKIP_ROW_FROM_TRIGGER to sql_errno in Diagnostics_area in case the signal is raised from a trigger and SQLSTATE has value '02TRG'. To catch signal with SQLTSATE '02TRG' and handle it in special way, the methods Table_triggers_list::process_triggers select_insert::store_values select_create::store_values Rows_log_event::process_triggers and the overloaded function fill_record_n_invoke_before_triggers were extended with extra out parameter for returning the flag whether to skip the current values being processed by INSERT/UPDATE/DELETE statement. This extra parameter is passed as nullptr in case of AFTER trigger and BEFORE trigger this parameter points to a variable to store a marker whether to skip the current record or store it by calling write_record().	8 months ago
Sergei Petrunia	fcf7211136	MDEV-35616: Add basic optimizer support for virtual column: more tests Add tests with JSON_VALUE() function	8 months ago
Sergei Petrunia	18e4b944bf	MDEV-35833: Assertion `marked_for_read()' failed for query with vcols When replacing VCOL_EXPR with VCOL_FIELD, add VCOL_FIELD to table's read_set.	9 months ago
Sergei Petrunia	1c2a83179d	MDEV-35616: Add basic optimizer support for virtual column (Review input addressed) After this patch, the optimizer can handle virtual column expressions in WHERE/ON clauses. If the table has an indexed virtual column: ALTER TABLE t1 ADD COLUMN vcol INT AS (col1+1), ADD INDEX idx1(vcol); and the query uses the exact virtual column expression: SELECT * FROM t1 WHERE col1+1 <= 100 then the optimizer will be able use index idx1 for it. This is achieved by walking the WHERE/ON clauses and replacing instances of virtual column expression (like "col1+1" above) with virtual column's Item_field (like "vcol"). The latter can be processed by the optimizer. Replacement is considered (and done) only in items that are potentially usable to the range optimizer.	10 months ago
Dmitry Shulga	759df4cc5f	MDEV-34551: Column list in the trigger definition Added support of the clause `UPDATE OF <columns>` for BEFORE/AFTER UPDATE triggers. Triggers defined with this clause are fired and run actions only in case an UPDATE statement affects any of the listed columns. For columns not specified in the clause `UPDATE OF <columns>`, an UPDATE statement with such columns as targets don't result in running a trigger. Output of SHOW TRIGGERS isn't affected by this task. Output of the statement SHOW CREATE TRIGGER shows the clause `UPDATE OF <columns>` if it was specified on trigger creation. Tests accompany this task don't include tests that checking for cooperation of the statement LOAD DATA and the clause `UPDATE OF <columns>` for BEFORE/AFTER UPDATE triggers since the statement LOAD DATA is treated like the statement INSERT INTO and therefore doesn't fire BEFORE/AFTER UPDATE triggers.	9 months ago
Vladislav Vaintroub	3bd23b76c5	MDEV-34740 mariadb-import: optimize index and constraint creation For InnoDB tables, parse the CREATE TABLE statement to defer index and constraint creation until after data loading. For other storage engines, the DISABLE/ENABLE KEYS commands achieve similar optimization. This behavior is controlled by a new option, innodb-optimize-keys (default: ON), compatible with mydumper. Additionally, this commit separates the table creation phase from data loading. Running DDL statements (such as DROP IF EXISTS) in a single thread avoids the "table not locked" issue from MDEV-34741. As a bonus, view creation no longer requires a separate step.	9 months ago
Vladislav Vaintroub	9255206b86	appveyor - run builds in "main" branch	9 months ago
Vicențiu Ciorbaru	b8fa8b9b3d	MDEV-35921: s3.mysqldump fails in buildbot This is a fixup for MDEV-32250, introduced via `b24ecd7ca6`, the test case was not recorded given the new mariadb-dump format.	9 months ago
Alexander Barkov	89f5d28191	MDEV-22217 Make OS character sets "utf8" and "utf-8" map to MariaDB character set "utf8mb4" Map Unix utf8 locales to utf8mb4 instead of utf8mb3.	12 months ago
Sergei Golubchik	e11592aed3	MDEV-35450 VEC_DISTANCE() function to autouse the available index type	10 months ago
Sergei Golubchik	528249a20a	cleanup: one Item_func_vec_distance class, not three prepare for MDEV-35450 VEC_DISTANCE auto-detection	10 months ago
Sergei Golubchik	d2ec5ec9c2	cleanup: move test w/ character_set_results=utf16 into separate file	10 months ago
Sergei Golubchik	e36ca5b1a6	cleanup: extraneous quotes in errmsg.txt	10 months ago
Vladislav Vaintroub	5482155df6	MDEV-34703 followup - reenable Innodb bulk load in mariadb-import Since bulk load is fixed, in some newer versions of the server, reenable it, after checking whether MDEV-34703 was really fixed in server.	9 months ago
Sergey Vojtovich	11a6c1b30a	MDEV-34699 - mhnsw: support aarch64 SIMD instructions SIMD implementations of bloom filters and dot product calculation. A microbenchmark shows 1.7x dot product performance improvement compared to regular -O2/-O3 builds and 2.4x compared to builds with auto-vectorization disabled. Performance improvement (microbenchmark) for bloom filters is less exciting, within 10-30% ballpark depending on compiler options and load. Misc implementation notes: CalcHash: no _mm256_shuffle_epi8(), use explicit XOR/shift. CalcHash: no 64bit multiplication, do scalar multiplication. ConstructMask/Query: no _mm256_i64gather_epi64, access array elements explicitly. Query: no _mm256_movemask_epi8, accumulate bits manually. Closes #3671	10 months ago
Dave Gosselin	cacaaebf01	MDEV-35837 Move to c++17 Move from c++11 to c++17.	9 months ago
Vladislav Vaintroub	2563839853	MDEV-34979 generate SBOM from server builds This commit adds the capability to generate a Software Bill of Materials (SBOM) from server builds. It introduces a new WITH_SBOM variable, which defaults to ON for package builds (i.e if BUILD_CONFIG is used) and to OFF otherwise. When enabled, the build process will produce an sbom.json document in CycloneDX format, capturing information about various dependencies, which is gathered from various sources. We use git submodule information and CMake external projects properties to gather version information for 3rd party code, but also handle dependencies if external code is part of our repository (zlib, or Connect storage engine's minizip) The SBOM document is stored in the root build directory in sbom.json file, but is not currently installed.	9 months ago
Marko Mäkelä	18dbeae1b8	MDEV-35849: index records in a wrong order page_cur_dtuple_cmp(): Take DESC index fields into account also when comparing a NULL value in a ROW_FORMAT≠REDUNDANT record. Thanks to Elena Stepanova for finding this bug.	9 months ago
Marko Mäkelä	3761a7fec8	MDEV-35312 page_cur_search_with_match() could avoid rec_get_offsets() page_cur_search_with_match(): Remove rec_get_offsets(), and instead determine the start and end of each field while comparing. page_dir_slot_get_rec(), page_dir_slot_get_rec_validate(): Add a parameter to avoid invoking page_align(). page_cur_dtuple_cmp(): Replaces cmp_dtuple_rec_leaf() for both leaf and non-leaf pages. In SPATIAL INDEX, non-leaf records are special, because the child page number may be part of the comparison. Reviewed by: Vladislav Lesin	9 months ago
Marko Mäkelä	793a2fc8ba	MDEV-35049: Always enable page_cur_search_with_match_bytes() For some reason, page_cur_search_with_match_bytes(), which can speed up append operations (PAGE_CUR_LE used by INSERT), was only enabled if innodb_adaptive_hash_index=ON even though it has nothing to do with the adaptive hash index. Furthermore, mysql/mysql-server@c9bbc83d11b56831658b03475b23306e3d48acca a.k.a. commit `c9bbc83d11` reduced a limit from 3 to 2 but forgot to adjust the PAGE_N_DIRECTION limit accordingly. We are adjusting that as well. Reviewed by: Vladislav Lesin	9 months ago
Marko Mäkelä	4221ed1d7d	MDEV-35049: Avoid building AHI beyond unique field prefix During a workload, an adaptive hash index had been built on UNIQUE INDEX(ID) on SYS_TABLES, and during a DROP TABLE operation the adaptive hash index would be widened to cover also the PRIMARY KEY(NAME) field that the index includes: (ID,NAME). Such an adaptive hash index is unlikely to satisfy (m)any queries. Let us limit the AHI prefix to the unique fields. Reviewed by: Vladislav Lesin	9 months ago
Marko Mäkelä	5f7b2a3ced	MDEV-35049: Improve btr_search_drop_page_hash_index() btr_search_drop_page_hash_index(): Replace the Boolean parameter with const dict_index_t *not_garbage. If buf_block_t::index points to that, there is no need to acquire btr_sea::partition::latch. The old parameter bool garbage_collect=false is equivalent to the parameter not_garbage=nullptr. The parameter garbage_collect=true will be replaced either with the actual index that is associated with the buffer page, or with a bogus pointer not_garbage=-1 to indicate that any lazily entries for a freed index need to be removed. buf_page_get_low(), buf_page_get_gen(), mtr_t::page_lock(), mtr_t::upgrade_buffer_fix(): Do not invoke btr_search_drop_page_hash_index(). Our caller will have to do it when appropriate. buf_page_create_low(): Keep invoking btr_search_drop_page_hash_index(). This is the normal way of lazily dropping the adaptive hash index after a DDL operation such as DROP INDEX operation. btr_block_get(), btr_root_block_get(), btr_root_adjust_on_import(), btr_read_autoinc_with_fallback(), btr_cur_instant_init_low(), btr_cur_t::search_leaf(), btr_cur_t::pessimistic_search_leaf(), btr_pcur_optimistic_latch_leaves(), dict_stats_analyze_index_below_cur(): Invoke btr_search_drop_page_hash_index(block, index) for pages that may be leaf pages. No adaptive hash index may have been created on anything else than a B-tree leaf page. btr_cur_search_to_nth_level(): Do not invoke btr_search_drop_page_hash_index(), because we are only accessing non-leaf pages and the adaptive hash index may only have been created on leaf pages. btr_page_alloc_for_ibuf() and many other callers of buf_page_get_gen() or similar functions do not invoke btr_search_drop_page_hash_index(), because the adaptive hash index is never created on such pages. If a page in the tablespace was freed as part of a DDL operation and reused for something else, then buf_page_create_low() will take care of dropping the adaptive hash index before the freed page will be modified. It is notable that while the flst_ functions may access pages that are related to allocating B-tree index pages (the BTR_SEG_TOP and BTR_SEG_LEAF linked from the index root page), those pages themselves can never be stored in the adaptive hash index. Therefore, it is not necessary to invoke btr_search_drop_page_hash_index() on them. Reviewed by: Vladislav Lesin	9 months ago
Marko Mäkelä	c942b31340	MDEV-35049: Fix bogus rebuild on BTR_CUR_HASH_FAIL btr_search_info_update_hash(): Do nothing if the record is positioned on the page supremum or infimum pseudo-record. The adaptive hash index can only include user records. This deficiency would cause the adaptive hash index parameters to change between hashing a prefix of 1 field or a prefix of 1 byte. Reviewed by: Vladislav Lesin	9 months ago
Marko Mäkelä	6b58ee769f	MDEV-35049: Fix bogus BTR_CUR_HASH_FAIL on contention btr_search_guess_on_hash(): Only set BTR_CUR_HASH_FAIL on actual mismatch. If the page latch cannot be acquired, the hash search might very well have succeeded. Do not count that as a failure, that is, do not unnecessarily invoke btr_search_update_hash_ref() after a normal search. Set cursor->flag=BTR_CUR_HASH_ABORT if the current parameters of the adaptive hash index are not suitable for the search and a call to btr_cur_t::search_info_update() might help. btr_cur_t::search_leaf(): Do not invoke search_info_update() if btr_search_guess_on_hash() failed due to contention. btr_cur_t::pessimistic_search_leaf(): Do not invoke search_info_update() on the change buffer tree. Preivously, this condition was being checked inside search_info_update().	9 months ago
Marko Mäkelä	68cac26108	MDEV-35049: Fix bogus BTR_CUR_HASH_FAIL on PAGE_CUR_LE btr_cur_t::search_leaf(): Do not attempt to use the adaptive hash index for PAGE_CUR_G or PAGE_CUR_L, because those modes expect an inequal result, and the adaptive hash index can only deliver equal results. btr_cur_t::check_mismatch(): Only handle PAGE_CUR_LE and PAGE_CUR_GE. For PAGE_CUR_LE (bool ge=false), qualify a full match for the last record of a page that is not at the end of the index. Previously, an adaptive hash index lookup would fail when the record is at the end of an index page but not at the end of the index. This would lead to unnecessary rebuild of the adaptive hash index in read-only workloads. Reviewed by: Vladislav Lesin	9 months ago
Marko Mäkelä	4dd6131711	MDEV-35049: Privatize ut_fold_ulint_pair() Now that ut_fold_ulint_pair() and ut_fold_binary() are no longer needed for anything else than compatibility with old InnoDB data files that may use innodb_checksum_algorithm=innodb, let us move the code to a single compilation unit. Reviewed by: Vladislav Lesin	9 months ago
Marko Mäkelä	4dcb1b575b	MDEV-35049: Use CRC-32C and avoid allocating heap For the adaptive hash index, dtuple_fold() and rec_fold() were employing a slow rolling hash algorithm, computing hash values ("fold") for one field and one byte at a time, while depending on calls to rec_get_offsets(). We already have optimized implementations of CRC-32C and have been successfully using that function in some other InnoDB tables, but not yet in the adaptive hash index. Any linear function such as any CRC will fail the avalanche test that any cryptographically secure hash function is expected to pass: any single-bit change in the input key should affect on average half the bits in the output. But we always were happy with less than cryptographically secure: in fact, ut_fold_ulint_pair() or ut_fold_binary() are just about as linear as any CRC, using a combination of multiplication and addition, partly carry-less. It is worth noting that exclusive-or corresponds to carry-less subtraction or addition in a binary Galois field, or GF(2). We only need some way of reducing key prefixes into hash values. The CRC-32C should be better than a Rabin–Karp rolling hash algorithm. Compared to the old hash algorithm, it has the drawback that there will be only 32 bits of entropy before we choose the hash table cell by a modulus operation. The size of each adaptive hash index array is (innodb_buffer_pool_size / 512) / innodb_adaptive_hash_index_parts. With the maximum number of partitions (512), we would not exceed 1<<32 elements per array until the buffer pool size exceeds 1<<50 bytes (1 PiB). We would hit other limits before that: the virtual address space on many contemporary 64-bit processor implementations is only 48 bits (256 TiB). So, we can simply go for the SIMD accelerated CRC-32C. rec_fold(): Take a combined parameter n_bytes_fields. Determine the length of each field on the fly, and compute CRC-32C over a single contiguous range of bytes, from the start of the record payload area to the end of the last full or partial field. For secondary index records in ROW_FORMAT=REDUNDANT, also the data area that is reserved for NULL values (to facilitate in-place updates between NULL and NOT NULL values) will be included in the count. Luckily, InnoDB always zero-initialized such unused area; refer to data_write_sql_null() in rec_convert_dtuple_to_rec_old(). For other than ROW_FORMAT=REDUNDANT, no space is allocated for NULL values, and therefore the CRC-32C will only cover the actual payload of the key prefix. dtuple_fold(): For ROW_FORMAT=REDUNDANT, include the dummy NULL values in the CRC-32C, so that the values will be comparable with rec_fold(). innodb_ahi-t: A unit test for rec_fold() and dtuple_fold(). btr_search_build_page_hash_index(), btr_search_drop_page_hash_index(): Use a fixed-size stack buffer for computing the fold values, to avoid dynamic memory allocation. btr_search_drop_page_hash_index(): Do not release part.latch if we need to invoke multiple batches of rec_fold(). dtuple_t: Allocate fewer bits for the fields. The maximum number of data fields is about 1023, so uint16_t will be fine for them. The info_bits is stored in less than 1 byte. ut_pair_min(), ut_pair_cmp(): Remove. We can actually combine and compare int(n_fields << 16 \| n_bytes). PAGE_CUR_LE_OR_EXTENDS, PAGE_CUR_DBG: Remove. These were never defined, because they would only work with latin1_swedish_ci if at all. btr_cur_t::check_mismatch(): Replaces !btr_search_check_guess(). cmp_dtuple_rec_bytes(): Replaces cmp_dtuple_rec_with_match_bytes(). Determine the offsets of fields on the fly. page_cur_try_search_shortcut_bytes(): This caller of cmp_dtuple_rec_bytes() will not be invoked on the change buffer tree. cmp_dtuple_rec_leaf(): Replaces cmp_dtuple_rec_with_match() for comparing leaf-page records. buf_block_t::ahi_left_bytes_fields: Consolidated Atomic_relaxed<uint32_t> of curr_left_side << 31 \| curr_n_bytes << 16 \| curr_n_fields. The other set of parameters (n_fields, n_bytes, left_side) was removed as redundant. btr_search_update_hash_node_on_insert(): Merged to btr_search_update_hash_on_insert(). btr_search_build_page_hash_index(): Take combined left_bytes_fields instead of n_fields, n_bytes, left_side. btr_search_update_block_hash_info(), btr_search_update_hash_ref(): Merged to btr_search_info_update_hash(). btr_cur_t::n_bytes_fields: Replaces n_bytes << 16 \| n_fields. We also remove many redundant checks of btr_search.enabled. If we are holding any btr_sea::partition::latch, then a nonnull pointer in buf_block_t::index must imply that the adaptive hash index is enabled. Reviewed by: Vladislav Lesin	9 months ago
Marko Mäkelä	9c8bdc6c15	MDEV-35049: btr_search_check_free_space_in_heap() is a bottleneck Let us use implement a simple fixed-size allocator for the adaptive hash index, insted of complicating mem_heap_t or mem_block_info_t. MEM_HEAP_BTR_SEARCH: Remove. mem_block_info_t::free_block(), mem_heap_free_block_free(): Remove. mem_heap_free_top(), mem_heap_get_top(): Remove. btr_sea::partition::spare: Replaces mem_block_info_t::free_block. This keeps one spare block per adaptive hash index partition, to process an insert. We must not wait for buf_pool.mutex while holding any btr_sea::partition::latch. That is why we cache one block for future allocations. This is protected by a new btr_sea::partition::blocks_mutex in order to relieve pressure on btr_sea::partition::latch. btr_sea::partition::prepare_insert(): Replaces btr_search_check_free_space_in_heap(). btr_sea::partition::erase(): Replaces ha_search_and_delete_if_found(). btr_sea::partition::cleanup_after_erase(): Replaces the most part of ha_delete_hash_node(). Unlike the previous implementation, we will retain a spare block for prepare_insert(). This should reduce some contention on buf_pool.mutex. btr_search.n_parts: Replaces btr_ahi_parts. btr_search.enabled: Replaces btr_search_enabled. This must hold whenever buf_block_t::index is set while a thread is holding a btr_sea::partition::latch. dict_index_t::search_info: Remove pointer indirection, and use Atomic_relaxed or Atomic_counter for most fields. btr_search_guess_on_hash(): Let the caller ensure that latch_mode is BTR_MODIFY_LEAF or BTR_SEARCH_LEAF. Release btr_sea::partition::latch before buffer-fixing the block. The page latch that we already acquired is preventing buffer pool eviction. We must validate both block->index and block->page.state while holding part.latch in order to avoid race conditions with buffer page relocation or buf_pool_t::resize(). btr_search_check_guess(): Remove the constant parameter can_only_compare_to_cursor_rec=false. ahi_node: Replaces ha_node_t. This has been tested by running the regression test suite with the adaptive hash index enabled: ./mtr --mysqld=--loose-innodb-adaptive-hash-index=ON Reviewed by: Vladislav Lesin	9 months ago
Marko Mäkelä	5e8714b7b2	Merge 11.7 into main	9 months ago
Marko Mäkelä	3e9da8c923	Disable atomic.alter_table on MSAN because of slowness	9 months ago
Marko Mäkelä	15700f54c2	Merge 11.4 into 11.7	9 months ago
Marko Mäkelä	17f01186f5	Merge 10.11 into 11.4	9 months ago
Tony Chen	28b2958082	Add MTR to verify behavior on incompatible TLS configuration Add a simple test to verify the server behaves in a safe manner if configured with ciphers that aren't compatible with the server certificate. All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.	1 year ago
Tony Chen	2294ecdf0e	Add MTR to ensure startup fails with invalid ssl-cipher Add a simple test to verify that the server will fail to start up when no valid cipher suites are passed to `ssl-cipher`. As different TLS libraries and versions have differing cipher suite support, it would be a good idea to ensure the server behaves in a safe manner if it is configured with invalid cipher suites. All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.	1 year ago
Marko Mäkelä	420d9eb27f	Merge 10.6 into 10.11	9 months ago
Marko Mäkelä	b251cb6a4f	Merge 10.5 into 10.6	9 months ago
Sergei Golubchik	3bbbeae792	fix a memory leak	9 months ago
Sergei Golubchik	1d6f857534	MDEV-35607 Compile error with gcc-15 (signal returns) set policy CMP0067 to NEW, this will make try_compile to use project-wide CMAKE_C_STANDARD and CMAKE_CXX_STANDARD settings	9 months ago
Sergei Golubchik	3bf8b60caf	clarify the message when filesort is aborted by LIMIT ROWS EXAMINED	9 months ago
Sergei Golubchik	9508a44c37	enforce no trailing \n in Diagnostic_area messages that is in my_error(), push_warning(), etc	9 months ago

1 2 3 4 5 ...

202488 Commits (74f70c394456767c1c1b0bee6bf34faff5b72dce) All Branches Search

202488 Commits (74f70c394456767c1c1b0bee6bf34faff5b72dce)

All Branches