mariadb

Tree: 73cc529b51

Author	SHA1	Message	Date
Sergey Petrunya	73cc529b51	BUG#920255: Wrong result (extra rows) with loosescan and IN subquery The problem was that LooseScan execution code assumed that tab->key holds the index used for looseScan. This is only true when range or full index scan are used. In case of ref access, the index is in tab->ref.key (and tab->index==0 which explains how LooseScan passed tests with ref access: they used one index) Fixed by setting/using loosescan_key, which always the correct index#.	14 years ago
Sergey Petrunya	e10816118a	Update handler status variables after the last commit.	14 years ago
Sergey Petrunya	2ae3fca465	Add MRR counters: Handler_mrr_init, Handler_mrr_extra_rowid_sorts, Handler_mrr_extra_key_sorts.	14 years ago
Sergey Petrunya	9f60aa27f7	BUG#912513: Wrong result (missing rows) with join_cache_hashed+materialization+semijoin=on - equality substitution code was geared towards processing WHERE/ON clauses. that is, it assumed that it was doing substitions on the code that = wasn't attached to any particular join_tab yet = was going to be fed to make_join_select() which would take the condition apart and attach various parts of it to tables inside/outside semi-joins. - However, somebody added equality substition for ref access. That is, if we have a ref access on TBL.key=expr, they would do equality substition in 'expr'. This possibility wasn't accounted for. - Fixed equality substition code by adding a mode that does equality substition under assumption that the processed expression will be attached to a certain particular table TBL.	14 years ago
Sergey Petrunya	8bedf1ea1c	BUG#912538: Wrong result (missing rows) with semijoin=on, firstmatch=on, ... - setup_semijoin_dups_elimination() would incorrectly set join_tab->do_firstmatch when the join order had outer tables interleaved with inner.	14 years ago
Vladislav Vaintroub	0e975ded65	Fix compiler warning on Windows.	14 years ago
Igor Babaev	d92e84e083	Merge	14 years ago
Igor Babaev	40e4d09c53	Merge	14 years ago
Sergei Golubchik	88f451aa6e	multi-delete should ignore semi-join internal temp tables, when looking for tables to delete from	14 years ago
Sergei Golubchik	b297463407	lp:893522 more problems found by PVS Studio	14 years ago
Igor Babaev	746dbbe583	Fixed LP bug #917990 . If the expression for a derived table of a query contained a LIMIT clause the estimate of the number of rows in this derived table returned by the EXPLAIN command could be badly off since the optimizer ignored the limit number from the LIMIT clause when getting the estimate. The call of the method SELECT_LEX_UNIT->set_limit added in the code of mysql_derived_optimize() will be needed also in maria-5.5 where parameters in the LIMIT clause are supported.	14 years ago
unknown	69327e2987	Adjust test results after Monty's push of the new handler counter Handler_read_rnd_deleted.	14 years ago
unknown	6b4c132bc7	Removed unused code merged from 5.2. In 5.3 we fix this problem by checking if we put max/min group function without GROUP BY artificially in case of MODE_ONLY_FULL_GROUP_BY sql mode.	14 years ago
Michael Widenius	5438d57315	Added Handler_read_rnd_deleted, number of deleted rows found with ha_read_rnd_first.	14 years ago
unknown	296b450d3b	Fix the comment.	14 years ago
unknown	cf31ccc33c	Fix for LP BUG#908269 Wrong result with subquery in select list, EXISTS, constant MyISAM/Aria table. Problem: When building the condition for JOIN::outer_ref_cond the optimizer forgot to take into account that this condition could depend on constant tables as well.	14 years ago
Sergey Petrunya	d21189d775	Merge fix for BUG#912510	14 years ago
Michael Widenius	a148cf7fb0	Fixed that --sorted-result in mysql-test-run also works for exec mysql-test/r/information_schema_all_engines.result: Update result mysql-test/t/information_schema_all_engines.test: Added --sorted-results as tables in information_schema are not sorted.	14 years ago
Vladislav Vaintroub	cf86abffbf	MDEV-77 - possible deadlock in XtraDB async io subsystem on Windows. Split IO threads into ones that handle only read completion and ones that handle only write completion, as it was originally done, but got lost with "completion port" patch. The reason we need to have dedicated read and dedicated write threads is that read completion routine can block waiting for write io to complete, and in rare cases where all io threads are handling async reads, it can deadlock.	14 years ago
Sergey Petrunya	0b590282fc	BUG#912510: Crash in do_copy_not_null with semijoin=ON, firstmatch=ON, aggregate ... - Create/use do_copy_nullable_row_to_notnull() function for ref access, which is used when copying from not-NULL field in table that can be NULL-complemented to not-NULL field.	14 years ago
Igor Babaev	cd55894a52	Fixed LP bug #910083 . The patch for bug 685411 erroneously removed a call of engine->set_thd() from Item_subselect::fix_fields().	14 years ago
Sergey Petrunya	7714496dc1	Make test results stable.	14 years ago
unknown	0868847b55	Update version in configure.in (was forgotten in 5.3.3 release).	14 years ago
Sergey Petrunya	0346e25f07	Continuation of the efforts in previous cset.	14 years ago
Sergey Petrunya	d9fcec5acd	Make test results stable (they weren't, because filesort() used to read from a heap temptable, which uses pointers to records (that is, byte* pointers) as rowids. This meant that for rows with the same sort key value, the order was determined by memory layout.	14 years ago
Sergey Petrunya	3759df08eb	Update test results.	14 years ago
Sergey Petrunya	679b7704c6	Merge	14 years ago
Igor Babaev	c583aaf56b	Changed a test case from join_cache.test to make it platform independent.	14 years ago
Igor Babaev	2b1f0b8757	Back-ported the patch of the mysql-5.6 code line that fixed several defects in the greedy optimization: 1) The greedy optimizer calculated the 'compare-cost' (CPU-cost) for iterating over the partial plan result at each level in the query plan as 'record_count / (double) TIME_FOR_COMPARE' This cost was only used locally for 'best' calculation at each level, and not accumulated into the total cost for the query plan. This fix added the 'CPU-cost' of processing 'current_record_count' records at each level to 'current_read_time' before it is used as 'accumulated cost' argument to recursive best_extension_by_limited_search() calls. This ensured that the cost of a huge join-fanout early in the QEP was correctly reflected in the cost of the final QEP. To get identical cost for a 'best' optimized query and a straight_join with the same join order, the same change was also applied to optimize_straight_join() and get_partial_join_cost() 2) Furthermore to get equal cost for 'best' optimized query and a straight_join the new code substrcated the same '0.001' in optimize_straight_join() as it had been already done in best_extension_by_limited_search() 3) When best_extension_by_limited_search() aggregated the 'best' plan a plan was 'best' by the check : 'if ((search_depth == 1) \|\| (current_read_time < join->best_read))' The term '(search_depth == 1' incorrectly caused a new best plan to be collected whenever the specified 'search_depth' was reached - even if this partial query plan was more expensive than what we had already found.	14 years ago
Sergey Petrunya	5d9fbc6177	Fix version number: it's 5.3.3	14 years ago
Sergey Petrunya	fa061af373	Update mysql-test/suite/pbxt/r/subselect.result for the previous push	14 years ago
unknown	072073c09e	Backport of WL#5953 from MySQL 5.6 The patch differs from the original MySQL patch as follows: - All test case differences have been reviewed one by one, and care has been taken to restore the original plan so that each test case executes the code path it was designed for. - A bug was found and fixed in MariaDB 5.3 in Item_allany_subselect::cleanup(). - ORDER BY is not removed because we are unsure of all effects, and it would prevent enabling ORDER BY ... LIMIT subqueries. - ref_pointer_array.m_size is not adjusted because we don't do array bounds checking, and because it looks risky. Original comment by Jorgen Loland: ------------------------------------------------------------- WL#5953 - Optimize away useless subquery clauses For IN/ALL/ANY/SOME/EXISTS subqueries, the following clauses are meaningless: * ORDER BY (since we don't support LIMIT in these subqueries) * DISTINCT * GROUP BY if there is no HAVING clause and no aggregate functions This WL detects and optimizes away these useless parts of the query during JOIN::prepare()	14 years ago
Sergey Petrunya	a05a566cf0	BUG#906357: Incorrect result with outer join and full text match - The problem was that const-table-reading code would try to evaluate MATCH() before init_ftfuncs() was called. - Fixed by making MATCH function "expensive" so that nobody tries to evaluate it at optimization phase.	14 years ago
Sergey Petrunya	15ea7238e4	BUG#906385: EXPLAIN EXTENDED crashes in TABLE_LIST::print with limited max_join_size - Take into account that subquery's optimization can fail because of @@max_join_size error.	14 years ago
Sergey Petrunya	be3e52984f	BUG#904432: Wrong result with LEFT JOIN, constant table, semijoin=ON,materialization=ON - Correct handling for SJ-Materialization + outer joins (details in the comments in the code)	14 years ago
Sergey Petrunya	263ee55318	Remove garbage comments	14 years ago
unknown	11e2462152	Supression condition made wider to cover some other system cases.	14 years ago
Igor Babaev	7a1406f229	Fixed LP bug #904832 . Do not perform index condition pushdown for conditions containing subqueries and stored functions.	14 years ago
Sergey Petrunya	2bfd02cea9	Bump version number: now it's 5.3.3 (5.3.2 has been released some time ago)	14 years ago
Igor Babaev	68dad67762	Adjusted test cases of the suite funcs_1.	14 years ago
Sergey Petrunya	a4073c1990	Update test results for previous push	14 years ago
Alexey Botchkov	56125a3bce	GIS issues fixed. Failures on SUN Solaris. Buggy compiler there required some extra initialization for variables. Then the 02 optimization leads to bugs when values set through the pointer are not always taken into account. Finally, the (long long) / (long) crashes there, the explicit typeconverstion added. Failing innodb_plunin.innodb_gis.test fixed. per-file comments: mysql-test/suite/innodb_plugin/t/innodb_gis.test GIS issues fixed. sql/gcalc_slicescan.cc GIS issues fixed. sql/gcalc_tools.cc GIS issues fixed.	14 years ago
Igor Babaev	919f19110f	Merge	14 years ago
Sergey Petrunya	4dd456c220	Merge	14 years ago
Sergey Petrunya	04e9004fa3	BUG#901399: Wrong result (extra row) with semijoin=ON, materialization=OFF, optimizer_prune_level=0 - Correctly handle plan refinement stage for LooseScan plans: run create_ref_for_key() if LooseScan plan includes a ref access, and if we don't have any fixed key components, switch to a full index scan.	14 years ago
Igor Babaev	43d9fc3204	Merge.	14 years ago
Igor Babaev	a910e8ef5b	Made join_cache_level == 2 by default.	14 years ago
Sergey Petrunya	876f16afbb	Fix unused variable 'thd' error.	14 years ago
Sergey Petrunya	b1e037da6a	Merge	14 years ago
Sergey Petrunya	7a99121b2c	Fix trivial merge error	14 years ago

1 2 3 4 5 ...

68266 Commits (73cc529b51dd4262e81df86491e3f2803946339c) All Branches Search

68266 Commits (73cc529b51dd4262e81df86491e3f2803946339c)

All Branches