mariadb

Tree: 700e010309

Author	SHA1	Message	Date
Eugene Kosov	700e010309	fix aligned memcpy()-like functions usage I found that memcpy_aligned was used incorrectly at redo log and decided to put assertions in aligned functions. And found even more incorrect cases. Given the amount discovered of bugs, I left assertions to prevent future bugs. my_assume_aligned(): instead of MY_ASSUME_ALIGNED macro	6 years ago
Marko Mäkelä	cdd54c852a	Cleanup: Make Bounds_checked_array default-constructible	6 years ago
Varun Gupta	eab0dc6854	MDEV-21542: main.order_by_pack_big fails sporadically with wrong result Made the test order_by_pack_big stable	6 years ago
Marko Mäkelä	588eac58fd	MDEV-21551: Fix -Wsign-compare An assertion added in commit `c20bf8fd49` includes a sign mismatch. Make the affected data members unsigned.	6 years ago
Marko Mäkelä	6f2ca4eac1	MDEV-21263: Fix -Wclass-memaccess Since commit `f52bf92014` the type Sql_sort is non-trivial, because it includes a data member Bounds_checked_array<SORT_FIELD> local_sortorder. There still is no vtable, so memset() is safe to invoke, but we must add a cast to silence a warning in GCC 8 or later.	6 years ago
Varun Gupta	39e4fe8fa1	MDEV-21541: main.sum_distinct-big fails with Assertion `m_buffer_end == __null \|\| end <= m_buffer_end' For Merge_chuck structures first set the start and end positions of the buffer and then adjust the end positions of the buffer if the records are dynamic in nature.	6 years ago
Alexander Barkov	daf28db027	MDEV-21537 InnoDB INFORMATION_SCHEMA tables fail to define DEFAULT for ENUM NOT NULL - Adding a way to define I_S columns without DEFAULT. - Fixing all ENUM columns in I_S.INNODB* table definitions to have no DEFAULT.	6 years ago
Vladislav Vaintroub	c20bf8fd49	MDEV-21551 Fix calculation of current concurrency level in maybe_wake_or_create_thread() A task that is executed,could be counted as waiting (after wait_begin() before wait_end()) or as long-running (callback runs for a long time). If task is both marked waiting and long running, then calculation of current concurrency (# of executing tasks - # of long tasks - #of waiting tasks) is wrong, as task is counted twice. Thus current concurrency could go negative, but with unsigned arithmetic it will become a huge number. As a result, maybe_wake_or_create_thread() would neither wake or create a thread, when it should. Which may result in a deadlock.	6 years ago
Vladislav Vaintroub	92d6c13206	MDEV-21548 Explicitly declare sql_bultins library STATIC. Someone tried -DBUILD_SHARED_LIBS:BOOL=ON. This did not work well	6 years ago
Marko Mäkelä	e1b62f3026	MDEV-21263: Use C++11 default constructor	6 years ago
Vladislav Vaintroub	6f54a5abea	MDEV-21544 instrument sync_array waits with tpool::wait_begin/end threadpool has to know about long waits, to be able to create or wakeup new threads, or it can become slow, if it just relies on maintainence timer.	6 years ago
Varun Gupta	28129cd4e1	Fix a compilation issue	6 years ago
Marko Mäkelä	acc4da9c18	After-merge fix The merge commit `ded128aa9b` failed to adjust commit `9d18b62467` in debian/rules. We must adjust the build path, which is derived from the package name, which contains the major version number.	6 years ago
Varun Gupta	f52bf92014	MDEV-21263: Allow packed values of non-sorted fields in the sort buffer This task deals with packing the non-sorted fields (or addon fields). This would lead to efficient usage of the memory allocated for the sort buffer. The changes brought by this feature are 1) Sort buffers would have records of variable length 2) Each record in the sort buffer would be stored like <sort_key1><sort_key2>....<addon_length><null_bytes><field1><field2>.... addon_length is the extra bytes that are required to store the variable length of addon field across different records. 3) Changes in rr_unpack_from_buffer and rr_from_tempfile to take into account the variable length of records. Ported WL#1509 Pack values of non-sorted fields in the sort buffer from MySQL by Tor Didriksen	6 years ago
Marko Mäkelä	ded128aa9b	Merge 10.4 into 10.5	6 years ago
Marko Mäkelä	64952203af	MDEV-18115: Fix up sys_vars.sysvars_innodb This was forgotten in `e9de6386ad`	6 years ago
Marko Mäkelä	259185764b	MDEV-17062: Fix a typo in an error message	6 years ago
Jan Lindström	57ec527841	MDEV-17062 : Test failure on galera.MW-336 Add mutex protection while we calculate required slave thread change and create them. Add error handling.	6 years ago
Marko Mäkelä	87a61355e8	Merge 10.3 into 10.4 The MDEV-17062 fix in commit `c4195305b2` was omitted.	6 years ago
Marko Mäkelä	bc43bf3e43	Merge 10.2 into 10.3	6 years ago
Marko Mäkelä	ceffabc421	Enable tests for --embedded	6 years ago
Marko Mäkelä	e47b780286	MDEV-13626: Work around DEBUG_SYNC timeouts	6 years ago
Igor Babaev	7ea413ac2d	MDEV-21446 Assertion `!prebuilt->index->is_primary()' failed in row_search_idx_cond_check with rowid_filter upon concurrent access to table This bug has nothing to do with the concurrent access to table. Rather it concerns queries for which the optimizer decides to employ a rowid filter when accessing an InnoDB table by a secondary index, but later when calling test_if_skip_sort_order() changes its mind to access the table by the primary key. Currently usage of rowid filters is not supported in InnoDB if the table is accessed by the primary key. So in this case usage of a rowid filter to access the table must be prohibited.	6 years ago
Sergei Petrunia	9be5c19c34	Fix another trivial merge error	6 years ago
Sergei Golubchik	74a0cde1c6	mysql_install_db always has to pass --user=$user to the mysqld followup for `9d18b62467` strangely enough it only failed upgrade test on eoan	6 years ago
Igor Babaev	4de32015be	MDEV-21356 ERROR 1032 Can't find record when running simple, single-table query This bug could happen when both optimizer switches 'mrr' and 'mrr_sort_keys' are enabled and the optimizer decided to use a rowid filter when accessing an InnoDB table by a secondary key. With the above setting any access by a secondary is converted to the rndpos access. In InnoDB the rndpos access uses the primary key. Currently usage of a rowid filter within InnoDB engine is not supported if the table is accessed by the primary key. Do not use pushed rowid filter if the table is accessed actually by the primary key. Use the rowid filter outside the egine code instead.	6 years ago
Eugene Kosov	e9de6386ad	MDEV-18115 remove now unneeded constraint log_group_max_size: is not needed because redo log do not use fil_io() now	6 years ago
Marko Mäkelä	6373ec3ec7	Merge 10.2 into 10.3	6 years ago
Jan Lindström	057fbfa356	Disable Galera tests failing on bb and Azure until they are fixed.	6 years ago
Sergei Golubchik	51a9571256	MDEV-20205 mysql_install_db shouldn't execute chown Make chown error non-fatal. Just print a warning.	6 years ago
Sergei Golubchik	9d18b62467	rpm/deb and auth_pam_tool_dir/auth_pam_tool don't let mysql_install_db set SUID bit for auth_pam_tool in rpm/deb packages - instead package files with correct permissions and only fix the ownership of auth_pam_tool_dir (which can only be done after mysql user is created, so in post-install). keep old mysql_install_db behavior for bintars	6 years ago
Sergei Golubchik	744d545fd7	restore support for --defaults-file=<(...) if my_realpath() fails, don't return the error code, get_defaults_options() returns a number of options consumed, not 0=ok/1=error. instead, ignore the error from my_realpath. If it fails it internally falls back to my_load_path, which restores 10.4- behavior	6 years ago
Sergei Golubchik	8bcbdaf730	cleanup: remove unused arguments	6 years ago
Sergei Petrunia	d595a91bc6	Fix a merge typo	6 years ago
Marko Mäkelä	7b70cbd838	MDEV-21499 Merge new release of InnoDB 5.7.29 to 10.2	6 years ago
Nikša Skeledžija	c25a0662b3	Bug #30499288 - GCC 9.2.1 REPORTS A NEW WARNING FOR OS_FILE_GET_PARENT_DIR - Fixed a warning visible in optimized build related to calling memcpy with length parameters larger than ptrdiff_t max. rb#23333 approved by Annamalai Gurusami <annamalai.gurusami@oracle.com>	6 years ago
Marko Mäkelä	08b0b2b6fb	MDEV-21513: Avoid some crashes in ALTER TABLE...IMPORT TABLESPACE IndexPurge::next(): Replace btr_pcur_move_to_next_user_rec() with some equivalent code that performs sanity checks without killing the server. Perform some additional sanity checks as well. This change is motivated by mysql/mysql-server@48de4d74f4d2f10cd01b129753c7dfa908cf36b5 which unnecessarily introduces storage overhead to btr_pcur_t and uses a test case that injects a fault somewhere else, not in the code path that was modified.	6 years ago
Marko Mäkelä	457ce97ef2	MDEV-21512 InnoDB may hang due to SPATIAL INDEX MySQL 5.7.29 includes the following fix: Bug #30287668 INNODB: A LONG SEMAPHORE WAIT mysql/mysql-server@5cdbb22b51cf2b35dbdf5666a251ffbec2f84dec There is no test case. It seems that the problem could occur when a spatial index is large and peculiar enough so that multiple R-tree leaf pages will have the exactly same maximum bounding rectangle (MBR). The commit message suggests that the hang can occur when R-tree non-leaf pages are being merged, which should only be possible during transaction rollback or the purge of transaction history, when the R-tree index is at least 2 levels high and very many records are being deleted. The message says that a comparison result that two spatial index node pointer records are equal will cause an infinite loop in rtr_page_copy_rec_list_end_no_locks(). Hence, we must include the child page number in the comparison to be consistent with mysql/mysql-server@2e11fe0e152e34d73579e1a9ec19aedc3f6010f6. We fix this bug in a simpler way, involving fewer code changes. cmp_rec_rec(): Renamed from cmp_rec_rec_with_match(). Assert that rec2 always resides in an index page. Treat non-leaf spatial index pages specially.	6 years ago
Marko Mäkelä	c3695b4058	MDEV-21511: Remove unnecessary code Now that we will be invoking dtuple_get_n_ext() instead of letting btr_push_update_extern_fields() update an already calculated value, it is unnecessary to calculate the n_ext upfront. row_rec_to_index_entry(), row_rec_to_index_entry_low(): Remove the output parameter n_ext.	6 years ago
Marko Mäkelä	5838b52743	MDEV-21511 Wrong estimate of affected BLOB columns in update During update, rollback, or MVCC read, we may miscalculate the number of off-page columns, and thus the size of the clustered index record. The function btr_push_update_extern_fields() is mostly redundant, because the off-page columns would also be moved by row_upd_index_replace_new_col_val(), which is invoked via row_upd_index_replace_new_col_vals(). btr_push_update_extern_fields(): Remove. This is based on mysql/mysql-server@1fa475b85d24de4b9ce2958c0eed738c221fc82c which refines a fix for a recovery bug fix mysql/mysql-server@ce0a1e85e24e48b8171f767b44330da635a6ea0a in MySQL 5.7.5. No test case was provided by Oracle. Some of the changed code is being covered by the existing test innodb.blob-crash.	6 years ago
Marko Mäkelä	3e38d15585	MDEV-21509 Possible hang during purge of history, or rollback WL#6326 in MariaDB 10.2.2 introduced a potential hang on purge or rollback when an index tree is being shrunk by multiple levels. This fix is based on mysql/mysql-server@f2c58526300c0d84837effa26d37cbd5d2694967 with the main difference that our version of the test case uses DEBUG_SYNC instrumentation on ROLLBACK, not on purge. btr_cur_will_modify_tree(): Simplify the check further. This is the actual bug fix. row_undo_mod_remove_clust_low(), row_undo_mod_clust(): Add DEBUG_SYNC instrumentation for the test case.	6 years ago
Marko Mäkelä	9cae7bdcc0	MDEV-13626: Add the WL#6326 tests	6 years ago
Jan Lindström	c4195305b2	MDEV-17062 : Test failure on galera.MW-336 Add mutex protection while we calculate required slave thread change and create them. Add error handling.	6 years ago
Jan Lindström	7e378a8d31	Test requires debug build from galera library.	6 years ago
Alexander Barkov	6f65931f88	MDEV-19906 Port show_old_temporals from MySQL 5.6 Old temporal data types (created with a pre-10.0 version of MariaDB) are now displayed with a /* mariadb-5.3 / comment in: - SHOW CREATE TABLE - DESCRIBE - INFORMATION_SCHEMA.COLUMNS.COLUMN_TYPE For example: CREATE TABLE `t1` ( `t0` datetime / mariadb-5.3 / DEFAULT NULL, `t6` datetime(6) / mariadb-5.3 */ DEFAULT NULL ) ENGINE=MyISAM DEFAULT CHARSET=latin1 Note, new temporal data types are displayed without a format comment.	6 years ago
Sergei Petrunia	e709eb9bf7	Merge branch '10.2' into 10.3 # Conflicts: # mysql-test/suite/galera/r/MW-388.result # mysql-test/suite/galera/t/MW-388.test # mysql-test/suite/innodb/r/truncate_inject.result # mysql-test/suite/innodb/t/truncate_inject.test # mysql-test/suite/rpl/r/rpl_stop_slave.result # mysql-test/suite/rpl/t/rpl_stop_slave.test # sql/sp_head.cc # sql/sp_head.h # sql/sql_lex.cc # sql/sql_yacc.yy # storage/xtradb/buf/buf0dblwr.cc	6 years ago
Sergei Petrunia	b04429434a	Merge branch '10.1' into 10.2 # Conflicts: # sql/sp_head.cc # sql/sql_select.cc # sql/sql_trigger.cc	6 years ago
Sergei Golubchik	e7558d4760	fix compilation w/o perfschema followup for `3a3605f4b1`	6 years ago
Sergei Golubchik	fc5a6a28f7	compatibility with pcre2 < 10.30 * It uses stack a lot, limit the recursion depth like we used to do for pcre. * But don't do that for newer pcre2 that uses stack very little (and doesn't support limiting recursion depth anyway). * Fix tests to verify only that deep recursion doesn't crash, but ignore results and warnings (which depend on pcre2 version) * Also different pcre2 versions report different offset in error messages, take that into account.	6 years ago
Sergei Golubchik	ff5a528f26	mysqltest crashes on Debian Debian is apparently offended that pcre2-posix implements POSIX API, thus it renames all posix-compatible symbols in libpcre2-posix to have the PCRE2 prefix. But Debian doesn't do anything to pcre2posix.h header, so any unaware application will get POSIX compatible type names and function prototypes from pcre2, but actual symbols will come from libc. To remedy this enormous incongruity we have to redefine POSIX-compatible function names in pcre2posix to match Debian's hack.	6 years ago

1 2 3 4 5 ...

188302 Commits (700e010309ea9d0f7c32d0973ec88c3140c67956) All Branches Search

188302 Commits (700e010309ea9d0f7c32d0973ec88c3140c67956)

All Branches