mariadb

Tree: 68e0defc5b

Author	SHA1	Message	Date
Oleksandr Byelkin	68e0defc5b	MDEV-25182 Complex query in Store procedure corrupts results At the second execution of the PS 1. mark_as_dependent() is called with the same parameters as at the first execution (select#4 and select#3) 2. as outer_select (select#3) has been already merged at the first execution of PS it cannot be reached using the outer_select() function anymore (and so can not stop iteration). 3. as a result all selects towards the top level select including the select for 'ca' are marked as uncacheable. 4. Marked uncacheable it executed incorrectly triggering filling its temporary table several times and using freed memory at the end. To avoid the problem we use name resolution context to go "up". NOTE: problem also exists in 10.2 but has no visible effect on execution. That is why the problem is fixed in 10.2. The patch also add debug logging of important procedures and better specify parameters types of st_select_lex::mark_as_dependent.	5 years ago
Dmitry Shulga	f8bf2a0170	MDEV-25108: Running of the EXPLAIN EXTENDED statement produces extra warning in case it is executed in PS (prepared statement) mode The EXPLAIN EXTENDED statement run as a prepared statement can produce extra warning comparing with a case when EXPLAIN EXTENDED statement is run as a regular statement. For example, the following test case CREATE TABLE t1 (c int); CREATE TABLE t2 (d int); EXPLAIN EXTENDED SELECT (SELECT 1 FROM t2 WHERE d = c) FROM t1; produces the extra warning "Field or reference 'c' of SELECT #2 was resolved in SELECT #1" in case the above mentioned "EXPLAIN EXTENDED" statement is executed in PS mode, that is by submitting the following statements: PREPARE stmt FROM "EXPLAIN EXTENDED SELECT (SELECT 1 FROM t2 WHERE d = c) FROM t1"; EXECUTE stmt; The reason of the extra warning emittion is in a way items are handled (being fixed) during execution of the JOIN::prepare() method. The method Item_field::fix_fields() calls the find_field_in_tables() function in case a field hasn't been associated yet with the item. Implementation of the find_field_in_tables() function first checks whether a table containing the required field was already opened and cached. It is done by checking the data member item->cached_table. This data member is set on handling the PRERARE FROM statement and checked on executing the EXECUTE statement. If the data member item->cached_table is set the find_field_in_tables() function invoked and the mark_select_range_as_dependent() function called if the field is an outer referencee. The mark_select_range_as_dependent() function calls the mark_as_dependent() function that finally invokes the push_warning_printf() function that produces extra warning. To fix the issue, calling of push_warning_printf() is elimited in case it was run indirectly in result of hanlding already opened table from the Item_field::fix_fields() method.	5 years ago
Julius Goryavsky	e95cdc451a	MDEV-21484: galera_sst_mariabackup_encrypt_with_key test failed This commit removes the mtr test galera_sst_mariabackup_encrypt_with_key from the list of disabled tests because the problem with it has already been fixed.	5 years ago
Thirunarayanan Balathandayuthapani	cf2c6b7f8d	MDEV-24971 InnoDB access freed virtual column after rollback of secondary index Problem: ======== InnoDB fails to clean the index stub if it fails to add the virtual index which contains new virtual column. But it clears the newly virtual column from index in clear_added_indexes() during inplace_alter_table. On commit, InnoDB evicts and reload the table. In case of rollback, it doesn't happen. InnoDB clears the ABORTED index while opening the table or doing the DDL. In the mean time, InnoDB can access the dropped virtual index columns while creating prebuilt or rollback of concurrent DML. Solution: ========== (1) InnoDB should maintain newly added virtual column while rollbacking the newly added virtual index. (2) InnoDB must not defer the index removal if the alter table is executed with LOCK=EXCLUSIVE. (3) For LOCK=SHARED, InnoDB should check whether the table has any other transaction lock other than alter transaction before deferring the index stub. Replaced has_new_v_col with dict_add_vcol_info in dict_index_t to indicate whether the index has any new virtual column. dict_index_t::has_new_v_col(): Returns whether the index has newly added virtual column, it doesn't say which columns are newly added virtual column ha_innobase_inplace_ctx::is_new_vcol(): Return whether the given column is added as a part of the current alter. ha_innobase_inplace_ctx::clean_new_vcol_index(): Copy the newly added virtual column to new_vcol_info in dict_index_t. Replace the column in the index fields with virtual column stored in new_vcol_info. dict_index_t::assign_new_v_col(): Store the number of virtual column added in index as a part of alter table. dict_index_t::get_n_new_vcol(): Get the number of newly added virtual column dict_index_t::assign_drop_v_col(): Allocate the memory for adding new virtual column in new_vcol_info. dict_index_t::add_drop_v_col(): Add the newly added virtual column in new_vcol_info. dict_table_t::has_lock_for_other_trx(): Whether the table has any other transaction lock than given transaction. row_merge_drop_indexes(): Add parameter alter_trx and check whether the table has any other lock than alter transaction.	5 years ago
Marko Mäkelä	ea2d44d01b	MDEV-18802 Assertion table->stat_initialized failed in dict_stats_update_if_needed() When a table has been evicted from dict_sys and reloaded internally by InnoDB for FOREIGN KEY processing, statistics may not be initialized, but nevertheless row_update_cascade_for_mysql() could invoke dict_stats_update_if_needed(). In that case, we cannot really update the statistics. For tables that have STATS_PERSISTENT=1 and STATS_AUTO_RECALC=1, ANALYZE TABLE might have to be executed later. dict_stats_update_if_needed(): Replace the assertion with a conditional early return.	5 years ago
Marko Mäkelä	75dd7a0483	MDEV-24434 Assertion trx->in_rw_trx_list... in trx_sys_any_active_transactions() trx_sys_any_active_transactions(): Remove a bogus debug assertion. In trx_commit_in_memory() and trx_erase_lists(), we will remove the transaction from trx_sys->rw_trx_list and set the state to TRX_STATE_COMMITTED_IN_MEMORY.	5 years ago
Otto Kekäläinen	058d93d47a	Deb: Stop depending on empty transitional package dh-systemd MariaDB Server still supports Ubuntu 16.04 "Xenial" until it goes EOL in April 30, 2021. Thus we need to include a customization for backwards compatibility. This change is intended to be applied for all MariaDB versions still supported, i.e. 10.2 to 10.6.	5 years ago
Julius Goryavsky	966c5a35af	MDEV-25307: The value of the auto-increment variables changes during the test The auto-increment variables may change intermittently during the execution of some tests from the Galera mtr suite, causing these tests to fail. This patch creates conditions in which unpredictable changes to these variables are not possible during the execution of those tests in which this problem is noticed or their values are restored before the end of testing.	5 years ago
Julius Goryavsky	3eecb8db22	MDEV-25356: SST scripts should use the new mariabackup interface SST scripts for Galera should use the new mariabackup interface instead of the innobackupex interface, which is currently only supported for compatibility reasons. This commit converts the SST script for mariabackup to use the new interface. It does not need separate tests, as any problems will be seen as failures when running multiple tests for the mariabackup-based SST.	5 years ago
Julius Goryavsky	bf1e09e0c4	Removed extra spaces in generated command lines (minor "cosmetic" change after MDEV-24197)	5 years ago
Julius Goryavsky	d5dacca4c5	Clarified abbreviated option names in some tests, to avoid problems with ambiguous options in the future.	5 years ago
Julius Goryavsky	8ff0ac45dc	MDEV-25328: --innodb command line option causes mariabackup to fail This patch fixes an issue with launching mariabackup during SST (when used with Galera), when during bootstrap mariabackup receives the "--innodb" option, which is incorrectly interpreted as shortcut for "--innodb-force-recovery". This patch does not require separate test for mtr, as the problem is visible in general testing on buildbot.	5 years ago
Thirunarayanan Balathandayuthapani	1ac4d0c168	BtrBulk::table_name(): Return the table name while displaying table name for fts diagnostics	5 years ago
Thirunarayanan Balathandayuthapani	5a3151bcda	Improve diagnostics in order to catch MDEV-18868 and similar bugs	5 years ago
Marko Mäkelä	c6d0531cad	MDEV-13467 fixup: Improve error handling	5 years ago
Thirunarayanan Balathandayuthapani	72da83ff99	MDEV-25019 memory allocation failures during startup because server failure in different, confusing ways InnoDB fails to free the buffer pool instance mutex and zip mutex If the allocation of buffer pool instance chunk fails. So it leads to freeing of buffer pool before freeing the mutexes and leads to double freeing of memory while freeing the mutex during shutdown.	5 years ago
Arnaud Rebillout	82a2ea64b4	Fix postinst trigger when systemd is not running (Closes: #983563 ) Checking for the existence of the systemctl command only tells us that systemd is installed, however it does not tell us if systemd is running. What we really want to do here is reload systemd if it's installed AND if it's running. The usual way to check if systemd is running is to check for the existence of '/run/systemd/system'. Why would systemd be installed but not running? This is something that happens when one sets up or upgrade a system in a chroot or container. For more details refer to the bug report: <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=983563> Closes PR #1787	5 years ago
Thirunarayanan Balathandayuthapani	c32edd7515	MDEV-25295 Aborted FTS_DOC_ID_INDEX considered as existing FTS_DOC_ID_INDEX during DDL InnoDB should skip the dropped aborted FTS_DOC_ID_INDEX while checking the existing FTS_DOC_ID_INDEX in the table. InnoDB should able to create new FTS_DOC_ID_INDEX if the fulltext index is being added for the first time.	5 years ago
Sergei Golubchik	6fe624b5ac	MDEV-25242 Server crashes in check_grant upon invoking function with userstat enabled also fix index_stats table. followup for `5a79807119`	5 years ago
Julius Goryavsky	fb9d151934	MDEV-25321: mariabackup failed if password is passed via environment variable The mariabackup interface currently supports passing a password through an explicit command line variable, but does not support passing a password through the MYSQL_PWD environment variable. At the same time, the Galera SST script for mariabackup uses the environment variable to pass the password, which leads (in some cases) to an unsuccessful launch of mariabackup and to the inability to start the cluster. This patch fixes this issue. It does not need a separate test, as the problem is visible in general testing on buildbot.	5 years ago
Srinidhi Kaushik	5bc5ecce08	MDEV-24197: Add "innodb_force_recovery" for "mariabackup --prepare" During the prepare phase of restoring backups, "mariabackup" does not seem to allow (or recognize) the option "innodb_force_recovery" for the embedded InnoDB server instance that it starts. If page corruption observed during page recovery, the prepare step fails. While this is indeed the correct behavior ideally, allowing this option to be set in case of emergencies might be useful when the current backup is the only copy available. Some error messages during "--prepare" suggest to set "innodb_force_recovery" to 1: [ERROR] InnoDB: Set innodb_force_recovery=1 to ignore corruption. For backwards compatibility, "mariabackup --innobackupex --apply-log" should also have this option. Signed-off-by: Srinidhi Kaushik <shrinidhi.kaushik@gmail.com>	5 years ago
mkaruza	f93e087d74	MDEV-25047: SIGSEGV in mach_read_from_n_little_endian Virtual column fields are not found in prebuilt data type, so we should match InnoDB fields with `get_innobase_type_from_mysql_type` method. Reviewed-by: Jan Lindström <jan.lindstrom@mariadb.com>	5 years ago
Vladislav Vaintroub	453bac08c2	CMake - when searching bison, look also for win_bison win_bison belongs winflexbison project, which is Windows most up-to-date bison distro.	5 years ago
Vladislav Vaintroub	08cb5d8483	MDEV-25221 Do not remove source file, if copy_file() fails in mariabackup --move-back Remove an incompletely copied destination file.	5 years ago
Marko Mäkelä	35ee4aa4e3	MDEV-13103 fixup: Actually fix a crash during IMPORT TABLESPACE	5 years ago
David CARLIER	99945d77d7	MDEV-25294 signal handler display coredump on mac	5 years ago
Thirunarayanan Balathandayuthapani	b771ab242b	MDEV-25200 Index count mismatch due to aborted FULLTEXT INDEX - Aborting of fulltext index creation fails to remove the index from sys indexes table. When we try to reload the table definition, InnoDB fails with index count mismatch error. InnoDB should remove the index from sys indexes while rollbacking the secondary index creation.	5 years ago
Thirunarayanan Balathandayuthapani	108ba4c380	MDEV-15527 page_compressed compressed page partially during import tablespace - Post push to address 32-bit build failure.	5 years ago
Marko Mäkelä	7c423c26d9	Add missing have_perfschema.inc	5 years ago
Thirunarayanan Balathandayuthapani	c468d5cb50	MDEV-15527 page_compressed compressed page partially during import tablespace - Importing table operation fails to punch the hole in the filesystem when page compressed table is involved. To achieve that, InnoDB firstly punches the hole for the IOBuffer size(1MB). After that, InnoDB should write page by page when page compression is involved.	5 years ago
Jan Lindström	dfda1c9283	Add supression for warning.	5 years ago
Jan Lindström	d217a925b2	MDEV-24923 : Port selected Galera conflict resolution changes from 10.6 Add condition on trx->state == TRX_STATE_COMMITTED_IN_MEMORY in order to avoid unnecessary work. If a transaction has already been committed or rolled back, it will release its locks in lock_release() and let the waiting thread(s) continue execution. Let BF wait on lock_rec_has_to_wait and if necessary other BF is replayed. wsrep_trx_order_before If BF is not even replicated yet then they are ordered correctly. bg_wsrep_kill_trx Make sure victim_trx is found and check also its state. If state is TRX_STATE_COMMITTED_IN_MEMORY transaction is already committed or rolled back and will release it locks soon. wsrep_assert_no_bf_bf_wait Transaction requesting new record lock should be TRX_STATE_ACTIVE Conflicting transaction can be in states TRX_STATE_ACTIVE, TRX_STATE_COMMITTED_IN_MEMORY or in TRX_STATE_PREPARED. If conflicting transaction is already committed in memory or prepared we should wait. When transaction is committed in memory we held trx mutex, but not lock_sys->mutex. Therefore, we could end here before transaction has time to do lock_release() that is protected with lock_sys->mutex. lock_rec_has_to_wait We very well can let bf to wait normally as other BF will be replayed in case of conflict. For debug builds we will do additional sanity checks to catch unsupported bf wait if any. wsrep_kill_victim Check is victim already in TRX_STATE_COMMITTED_IN_MEMORY state and if it is we can return. lock_rec_dequeue_from_page lock_rec_unlock Remove unnecessary wsrep_assert_no_bf_bf_wait function calls. We can very well let BF wait here.	5 years ago
Daniel Black	c44273329e	remove broken tests/grant.pl	5 years ago
Daniel Black	fb3b2eb517	mallinfo2: whitespace fix	5 years ago
Vladislav Vaintroub	add24e7889	Windows - suppress nonsensical(for this OS) system check. Amends `48141f3c17`	5 years ago
Daniel Black	85b6a81805	MDEV-24586: remove mysql_to_mariadb.sql This script is unused and unmaintained. The logic is implemented in scripts/mysql_system_tables_fix.sql that forms part of mysql_upgrade Its components: alter table mysql.user drop column `password_last_changed`, drop column `password_lifetime`, drop column `account_locked`; has a friendlier migration path coming MDEV-24122 alter table mysql.user change column `authentication_string` `auth_string` text COLLATE utf8_bin NOT NULL; Already part of scripts/mysql_system_tables_fix.sql alter table mysql.user add column `Password` char(41) CHARACTER SET latin1 COLLATE latin1_bin NOT NULL DEFAULT '' after `user`, add column `is_role` enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N' after `auth_string`; alter table mysql.user add column `default_role` char(80) COLLATE utf8_bin NOT NULL DEFAULT '', add column `max_statement_time` decimal(12,6) NOT NULL DEFAULT '0.000000'; corrected in MDEV-23201 to be in the right order. update mysql.user set `password`=`auth_string`, plugin='' where plugin="mysql_native_password"; Is handled in server in the function acl_load.	5 years ago
Alexey Yurchenko	4d870b591d	Don't pass password to innobackup via command line, use environment instead Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	5 years ago
Alexey Botchkov	94dea8ef5b	MDEV-25457 CREATE / DROP PROCEDURE not logged with audit plugin. CREATE/DROP PROCEDIRE/FUNCTION is now treated as DDL.	5 years ago
Alexey Bychko	c0ca3c4ffa	MDEV-25240 minor upgrade does not perform server restart we need to stop server instance on upgrade, but it may be started either by SysV init script or by SystemD. this commit adds `mysql` target to `systemctl stop` call. `mysql` may be the name of initscript or an alias while `mariadb` is a systemd unit file.	5 years ago
Anel Husakovic	2fc76a5022	MDEV-13467: Feature request: Support for ST_Distance_Sphere() - jump to label ‘handle_errors’ can enter to the scope of non-POD ‘Geometry_buffer buffer2’	5 years ago
Anel Husakovic	5eda18f0ca	MDEV-25272: Wrong function name in error messages upon ST_GeomFromGeoJSON call - Invalid function name during ER_WRONG_VALUE_FOR_TYPE and ER_GIS_INVALID_DATA	5 years ago
Anel Husakovic	6769d1a078	MDEV-13467: Feature request: Support for ST_Distance_Sphere() - Cherry-pick `51e48b9f89` - vscode gitignore - Thanks Robin Dupret for the review. Reviewed by:daniel@mariadb.org holyfoot@mariadb.com	5 years ago
Michael Okoko	48141f3c17	Replace mallinfo with mallinfo2 on supported systems `mallinfo` is deprecated since glibc 2.33 and has been replaced by mallinfo2. The deprecation causes building the server to fail if glibc version is > 2.33. Check if mallinfo2 exist on the system and use it instead.	5 years ago
Eugene Kosov	36a05268e7	cmake cleanup: drop support for ancient clang in WITH_ASAN option	5 years ago
Eugene Kosov	dfae51de36	MDEV-25238 add support for -fsanitize-address-use-after-scope Use like this: cmake -DWITH_ASAN=ON -DWITH_ASAN_SCOPE=ON	5 years ago
Marko Mäkelä	a6d66fe75e	MDEV-24786: row_upd_clust_step() skips mtr_t::commit() on virtual column error The function row_upd_clust_step() is invoking several static functions, some of which used to commit the mini-transaction in some cases. If innobase_get_computed_value() would fail due to some reason, we would fail to invoke mtr_t::commit() and release buffer pool page latches. This would likely lead to a hanging server later. This regression was introduced in commit `97db6c15ea` (MDEV-20618). row_upd_index_is_referenced(), row_upd_sec_index_entry(), row_upd_sec_index_entry(): Cleanup: Replace some ibool with bool. row_upd_clust_rec_by_insert(), row_upd_clust_rec(): Guarantee that the mini-transaction will always remain in active state. row_upd_del_mark_clust_rec(): Guarantee that the mini-transaction will always remain in active state. This fixes one "leak" of mini-transaction on DB_COMPUTE_VALUE_FAILED. row_upd_clust_step(): Use only one return path, which will always invoke mtr.commit(). After a failed row_upd_store_row() call, we will no longer "leak" the mini-transaction. This fix was verified by RQG on 10.6 (depending on MDEV-371 that was introduced in 10.4). Unfortunately, it is challenging to create a regression test for this, and a test case could soon become invalid as more bugs in virtual column evaluation are fixed.	5 years ago
Vladislav Vaintroub	da26e2e673	Cleanup - reduce duplicate code, in SSL IO error handling.	5 years ago
Sergei Golubchik	5a79807119	MDEV-25242 Server crashes in check_grant upon invoking function with userstat enabled use check_grant(..., number_of_tables=1, ...) if you only need to check privileges for one table	5 years ago
Vladislav Vaintroub	cdb86faf82	MDEV-23740 postfix - potentially uninitialized variable passed to vio_socket_io_wait. Thanks to Daniel Black for reporting.	5 years ago
Sergei Golubchik	c4807c107a	MDEV-24879 Client crash on undefined charsetsdir	5 years ago

1 2 3 4 5 ...

184369 Commits (68e0defc5be41e42f5f9d050a436a5f88277a586) All Branches Search

184369 Commits (68e0defc5be41e42f5f9d050a436a5f88277a586)

All Branches