mariadb

Tree: 62513bb1bc

Author	SHA1	Message	Date
Sergey Petrunia	62513bb1bc	BUG#35478: sort_union() returns bad data when sort_buffer_size is hit - In QUICK_INDEX_MERGE_SELECT::read_keys_and_merge: when we got table->sort from Unique, tell init_read_record() not to use rr_from_cache() because a) rowids are already sorted and b) it might be that the the data is used by filesort(), which will need record rowids (which rr_from_cache() cannot provide). - Fully de-initialize the table->sort read in QUICK_INDEX_MERGE_SELECT::get_next(). This fixes BUG#35477. (bk trigger: file as fix for BUG#35478). sql/filesort.cc: BUG#35478: sort_union() returns bad data when sort_buffer_size is hit - make find_all_keys() use quick->get_next() instead of init_read_record(r)/r.read_record() calls - added dbug printout sql/mysql_priv.h: BUG#35478: sort_union() returns bad data when sort_buffer_size is hit - Added parameter to init_read_record sql/opt_range.cc: BUG#35478: sort_union() returns bad data when sort_buffer_size is hit - In QUICK_INDEX_MERGE_SELECT::read_keys_and_merge: when we got table->sort from Unique, tell init_read_record() not to use rr_from_cache() because a) rowids are already sorted and b) it might be that the the data is used by filesort(), which will need record rowids (which rr_from_cache() cannot provide). - Fully de-initialize the table->sort read in QUICK_INDEX_MERGE_SELECT::get_next(). sql/records.cc: BUG#35478: sort_union() returns bad data when sort_buffer_size is hit - Added disable_rr_cache parameter to init_read_record - Added comment sql/sql_acl.cc: BUG#35478: sort_union() returns bad data when sort_buffer_size is hit - Added parameter to init_read_record sql/sql_delete.cc: BUG#35478: sort_union() returns bad data when sort_buffer_size is hit - Added parameter to init_read_record sql/sql_help.cc: BUG#35478: sort_union() returns bad data when sort_buffer_size is hit - Added parameter to init_read_record sql/sql_select.cc: BUG#35478: sort_union() returns bad data when sort_buffer_size is hit - Added parameter to init_read_record sql/sql_table.cc: BUG#35478: sort_union() returns bad data when sort_buffer_size is hit - Added parameter to init_read_record sql/sql_udf.cc: BUG#35478: sort_union() returns bad data when sort_buffer_size is hit - Added parameter to init_read_record sql/sql_update.cc: BUG#35478: sort_union() returns bad data when sort_buffer_size is hit - Added parameter to init_read_record	18 years ago
Gleb Shchepa	d5077086f7	warning elimination	18 years ago
Gleb Shchepa	547ca13975	warning elimination	18 years ago
Tatiana A. Nurnberg	0617cf0f78	auto-merge	18 years ago
Tatiana A. Nurnberg	0833d66847	Bug#35848: UUID() returns UUIDs with the wrong time offset for time part in UUIDs was 1/1000 of what it should be. In other words, offset was off. Also handle the case where we count into the future when several UUIDs are generated in one "tick", and then the next call is late enough for us to unwind some but not all of those borrowed ticks. Lastly, handle the case where we keep borrowing and borrowing until the tick-counter overflows by also changing into a new "numberspace" by creating a new random suffix. mysql-test/r/func_misc.result: Show that time-part of UUIDs is correct now. mysql-test/t/func_misc.test: Show that time-part of UUIDs is correct now by replicating the C-code's resultin SQL. Results also decode to expect date-data on command-line (external validation). No test for unwinding of borrowed ticks as this a) is a race and b) depends on what timer we get. sql/item_strfunc.cc: correct offset for date/time-part of UUID. also make sure that when we counted into the future earlier (several UUIDs generated in same tick), we only give back as many "borrowed" ticks as we can without duplicating past timestamps. If our tick-counter overflows before we can give back, or if the system-clock is set back (by user or Daylight Saving Time), we create a new random suffix to avoid collisions and clear the tick-counter.	18 years ago
Gleb Shchepa	fa00dfe6b9	merge 5.0-main --> 5.0-bugteam	18 years ago
Matthias Leich	a81572bc42	1. Fix for Bug#37160 "funcs_2: The tests do not check if optional character sets exist." 2. Minor cleanup	18 years ago
unknown	55ab1ef695	Raise version number after cloning 5.0.66	18 years ago
Jonathan Perkin	0d62f60b81	Merge from trunk.	18 years ago
Mats Kindahl	b93fcb9b0e	Manual merge with mysql-5.0-bugteam	18 years ago
Marc Alff	a8a986bd66	Merge	18 years ago
Marc Alff	c7724872d8	Bug#26030 (Parsing fails for stored routine w/multi-statement execution enabled) Before this fix, the lexer and parser would treat the ';' character as a different token (either ';' or END_OF_INPUT), based on convoluted logic, which failed in simple cases where a stored procedure is implemented as a single statement, and used in a multi query. With this fix: - the character ';' is always parsed as a ';' token in the lexer, - parsing multi queries is implemented in the parser, in the 'query:' rules, - the value of thd->client_capabilities, which is the capabilities negotiated between the client and the server during bootstrap, is immutable and not arbitrarily modified during parsing (which was the root cause of the bug)	18 years ago
Mats Kindahl	914cae3a2d	Bug #37150 Risk for crash in User_var_log_event::exec_event() On certain kinds of errors (e.g., out of stack), a call to Item_func_ set_user_var::fix_fields() might fail. Since the return value of this call was not checked inside User_var_log_event::exec_event(), continuing execution after this will cause a crash inside Item_func_set_user_var:: update_hash(). The bug is fixed by aborting execution of the event with an error if fix_fields() fails, since it is not possible to continue execution anyway. sql/log_event.cc: Aborting execution of event if fix_fields() fails since execution of update_hash() might cause a crash.	18 years ago
Chad MILLER	c6f9477bda	Merge bug.	18 years ago
Chad MILLER	ac2a037ff9	Bug#30563: Is not possible to create rpl_ or innodb test if needed \ to use ANSI_QUOTES Make all have_* tests universally safe by using ANSI quotes.	18 years ago
Timothy Smith	5647bce366	Fix "C++ code in C file" syntax error in mysys/default.c	18 years ago
Patrick Crews	9393ae3dff	Bug#37380 - Test funcs_1.is_columns_myisam_embedded fails on OS X Test was failing due to the addition of a '\x05' character in result sets Latest builds of the server have shown this problem to have disappeared. Removing code within the test that disables the test on Mac OS X. Recommit due to tree error on earlier, approved patch.	18 years ago
Matthias Leich	52fee16e88	Fix for Bug#36787 Test funcs_1.charset_collation_1 failing Details: 1. Skip charset_collation_1 if charset "ucs2_bin" is missing (property which distincts "vanilla" builds from the others) 2. Let builds with version_comment LIKE "%Advanced%" (found them for 5.1) execute charset_collation_3. 3. Update comments charset_collation.inc so that they reflect the current experiences.	18 years ago
Timothy Smith	fe87c0db0c	Merge from upstream (my:5.0-bugteam)	18 years ago
Gleb Shchepa	b83b4697d2	backport from 6.0 Bug#35658 (An empty binary value leads to mysqld crash) Before this fix, the following token b'' caused the parser to crash when reading the binary value from the empty string. The crash was caused by: ptr+= max_length - 1; because max_length is unsigned and was 0, causing an overflow. With this fix, an empty binary literal b'' is parsed as a binary value 0, in Item_bin_string. mysql-test/r/varbinary.result: Bug#35658 (An empty binary value leads to mysqld crash) mysql-test/t/varbinary.test: Bug#35658 (An empty binary value leads to mysqld crash) sql/item.cc: Bug#35658 (An empty binary value leads to mysqld crash)	18 years ago
Matthias Leich	49417ad7c8	Fix for Bug#37492 timing bug in subselect.test + similar weaknesses found during testing + replace error numbers by error names	18 years ago
Timothy Smith	d5977e4c44	Bug #20748 : Configuration files should not be read more than once Normalize directory names before adding them to default_directories. mysys/default.c: Normalize directory names with unpack_dirname() before adding them to default_directories. This way, /etc/ and /etc will not count as duplicates. Because this entails allocating memory to store the normalized names, add error handling and ensure that it doesn't leak memory in case both my_print_defaults() and load_defaults() are called. Clean up the Windows code that finds the exe's parent directory, and pull it out into a separate function. Reorganize the code into a single init_default_directories() function, with internal #ifdefs, instead of init_default_directories_<system>() functions which were accessed via a function pointer. This is more in line with normal MySQL coding style, and easier to read for some.	18 years ago
Gleb Shchepa	c6f67c6fd9	back-port from 5.1. Bug#35480: BOM detection code crashes mysql CLI with zero-sized input MySQL client crashed if no input was passed to it.	18 years ago
Gleb Shchepa	2c77798c74	back-port from 5.1. Bug#33812: mysql client incorrectly parsing DELIMITER Remove unnecessary and incorrect code that tried to pull delimiter commands out of the middle of statements.	18 years ago
Gleb Shchepa	6eb2e76abd	Bug #36244 : MySQL CLI doesn't recognize standalone -- as a commentary mysql client has been modified to interpret EOL after standalone -- commentary strings like whitespace character (according to http://dev.mysql.com/doc/refman/5.0/en/ansi-diff-comments.html) mysql-test/t/mysql_delimiter.sql: Added test case for bug #36244.	18 years ago
Matthias Leich mleich@mysql.com	2356d4f54a	Fix for Bug#37167 funcs_1: Many tests fail if the embedded server is used. Bug#37164 funcs_1: Some tests fail if an optional character set is missing. + some cleanup within the testsuite related to the fixes above + some adjustments to open bugs on Mac OS X	18 years ago
Georgi Kodinov	07350a6c93	auto merge	18 years ago
Tatiana A. Nurnberg	8342336f3d	merge configure.in: Raise version number after cloning 5.0.64 mysql-test/r/federated_disabled.result: Bug#37069 (5.0): implement --skip-federated mysql-test/t/federated_disabled-master.opt: Bug#37069 (5.0): implement --skip-federated mysql-test/t/federated_disabled.test: Bug#37069 (5.0): implement --skip-federated mysys/errors.c: Fix for Bug#16902. sql/mysqld.cc: Bug#37069 (5.0): implement --skip-federated	18 years ago
Tatiana A. Nurnberg	b1132821af	Bug#36492: make dist and make install fails Ignore BitKeeper SCCS folders in make-dist mysql-test/Makefile.am: Ignore BitKeeper SCCS folders in make-dist (copy only .txt files).	18 years ago
Matthias Leich mleich@mysql.com	28f9704737	Fix for Bug#37167 funcs_1: Many tests fail if the embedded server is used. Bug#37164 funcs_1: Some tests fail if an optional character set is missing. + some cleanup within the testsuite related to the fixes above + some adjustments to open bugs on Mac OS X Details: - Remove the initial loading of data from tests if these data are not somewhere retrieved - Remove any use of columns with attribute unicode (-> UCS2 is no more needed) from tests where unicode properties are not checked or somehow required - Create a separate branch of the Character maximum length test (CML). If UCS2 is available than this test gets applied to every available type of string column with attribute unicode This prevents any loss of coverage by the points above. - Disable the execution of is_tables_ndb which gives wrong results because of a bug. Correct the exepected results of this test. - In case of tests failing when applied to the embedded server 1) Create a variant of this test for the embedded server or 2) Skip the test in case of embedded server depending on purpose and complexity of test. - Skip the tests which could suffer from Bug 28309 First insert violates unique constraint - was "memory" table empty ? Bug 37380 Test funcs_1.is_columns_myisam_embedded fails on OS X (both bugs Mac OS X, embedded server, MySQL 5.0 only) - Minor improvements like remove typos	18 years ago
Hakan Kuecuekyilmaz	f3a81ef408	Fix for Bug#16902. mysys/errors.c: Fixed typo, Bug#16902.	18 years ago
Joerg Bruehe	3b5c3df201	Merging bug fixes for 34995 and 35543 into the main tree, and the build tag for 5.0.62.	18 years ago
unknown	3c2cb27162	No change - hack to force BZR conversion	18 years ago
Georgi Kodinov	1e17f242f3	atuomatically merged 5.0 main to 5.0-bugteam	18 years ago
Jonathan Perkin	b32fce091f	Use skip-federated by default in all example configs.	18 years ago
mysqldev	dd64a86af4	Raise version number after cloning 5.0.64	18 years ago
Georgi Kodinov	da4cfa6d1e	Bug#37069 (5.0): implement --skip-federated mysql-test/r/federated_disabled.result: Bug#37069 (5.0): test case mysql-test/t/federated_disabled-master.opt: Bug#37069 (5.0): test case mysql-test/t/federated_disabled.test: Bug#37069 (5.0): test case	18 years ago
Matthias Leich mleich@mysql.com	1544026443	Bug#36788 Multiple funcs_1 'trig' tests are failing on vanilla builds Fix for this bug and additional improvements/fixes In detail: - Remove unicode attribute from several columns (unicode properties were nowhere needed/tested) of the table tb3 -> The runnability of these tests depends no more on the availibility of some optional collations. - Use a table tb3 with the same layout for all engines to be tested and unify the engine name within the protocols. -> <engine>_trig_<abc>.result have the same content - Do not load data into tb3 if these rows have no impact on result sets - Add tests for NDB (they exist already in 5.1) - "--replace_result" at various places because NDB variants of tests failed with "random" row order in results This fixes a till now unknown weakness within the funcs_1 NDB tests existing in 5.1 and 6.0 - Fix the expected result of ndb_trig_1011ext which suffered from Bug 32656 + disable this test - funcs_1 could be executed with the mysql-test-run.pl option "--reorder", which saves some runtime by optimizing server restarts. Runtimes on tmpfs (one attempt only): with reorder 132 seconds without reorder 183 seconds - Adjust two "check" statements within func_misc.test which were incorrect (We had one run with result set difference though the server worked good.) - minor fixes in comments	18 years ago
Matthias Leich mleich@mysql.com	200a93632e	Bug#36345 Test 'func_misc' fails on RHAS3 x86_64 Fix for this bug and a second similar problem found during experimenting. This replaces the first fix (already pushed to 5.1 and merged to 6.0) which - failed in runs with the embedded server - cannot be ported back to 5.0	18 years ago
Georgi Kodinov	54190bc098	automatically merged	18 years ago
Alexander Barkov	c9232b936d	Updating charset doc files. Thanks to Paul for preparing the up-to-date files reflecting 4.1 changes.	18 years ago
Georgi Kodinov	ed78639805	Bug #36887 : Typo in mysql_client_test.c uses bind instead of my_bind There was a typo in a error check causing wrong thing to be ckecked and a possible error not being caught. Fixed by using the correct variable to test for malloc() errors. tests/mysql_client_test.c: Bug #36887: fixed a typo	18 years ago
unknown	02ef24f778	Merge trift-lap.fambruehe:/MySQL/M50/mysql-5.0 into trift-lap.fambruehe:/MySQL/M50/work-5.0 mysql-test/mysql-test-run.pl: Auto merged	18 years ago
Chad MILLER	9198215ec1	Merge from 5.0 trunk. Adding mailer metainfo.	18 years ago
Chad Miller	e981dd6215	Merge metainfo for mailer plugin.	18 years ago
Chad MILLER	636e751f36	Add branch metainfo for mailer plugin.	18 years ago
unknown	8bc987ab5b	Merge host.loc:/work/bugs/5.0-bugteam-36676 into host.loc:/work/bk/5.0-bugteam	18 years ago
unknown	29e7fa258d	Fixed bug#36676: multiupdate using LEFT JOIN updates only first row or fails with an error: ERROR 1022 (23000): Can't write; duplicate key in table '' The server uses intermediate temporary table to store updated row data. The first column of this table contains rowid. Current server implementation doesn't reset NULL flag of that column even if the server fills a column with rowid. To keep each rowid unique, there is an unique index. An insertion into an unique index takes into account NULL flag of key value and ignores real data if NULL flag is set. So, insertion of actually different rowids may lead to two kind of problems. Visible effect of each of these problems depends on an initial engine type of temporary table: 1. If multiupdate initially creates temporary table as a MyISAM table (a table contains blob columns, and the create_tmp_table function assumes, that this table is large), it inserts only one single row and updates only rows with one corresponding rowid. Other rows are silently ignored. 2. If multiupdate initially creates MEMORY temporary table, fills it with data and reaches size limit for MEMORY tables (max_heap_table_size), multiupdate converts MEMORY table into MyISAM table and fails with an error: ERROR 1022 (23000): Can't write; duplicate key in table '' Multiupdate has been fixed to update the NULL flag of temporary table rowid columns. mysql-test/r/multi_update_tiny_hash.result: Added test case for bug#36676. mysql-test/t/multi_update_tiny_hash-master.opt: Added test case for bug#36676. mysql-test/t/multi_update_tiny_hash.test: Added test case for bug#36676. sql/sql_update.cc: Fixed bug#36676: multiupdate using LEFT JOIN updates only first row or fails with an error: ERROR 1022 (23000): Can't write; duplicate key in table '' The multi_update::send_data method has been modified to reset null bits of fields containing rowids.	18 years ago
unknown	f197f3abb4	Bug #36705 key_buffer_size of >= 2G allocates all availabel virtual memory on 64-bit wondo. temporary variables of 'long' types were used to store ulong values, that causes init_key_cache to receive distorted parameters sql/handler.cc: Bug #36705 key_buffer_size of >= 2G allocates all availabel virtual memory on 64-bit wondo. types of temporary variables changed to match init_key_cache() parameters	18 years ago
unknown	eee5b97258	Merge bk-internal.mysql.com:/home/bk/mysql-5.0-bugteam into zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-5.0-bugteam	18 years ago

1 2 3 4 5 ...

39162 Commits (62513bb1bca33902fa909ca13b25c550046ee3ae) All Branches Search

39162 Commits (62513bb1bca33902fa909ca13b25c550046ee3ae)

All Branches