mariadb

Tree: 600c85e85a

Author	SHA1	Message	Date
Marko Mäkelä	600c85e85a	Allocate the singleton fil_system statically fil_system_t::create(): Replaces fil_init(), fsp_init(). fil_system_t::close(): Replaces fil_close(). fil_system_t::max_n_open: Remove. Use srv_max_n_open_files directly.	8 years ago
Marko Mäkelä	1f0f7d5907	Remove dict_build_tablespace_for_table() create_table_info_t::create_table_def(): Assign the innodb_temporary tablespace directly. dict_build_tablespace_for_table(): Merge to the only remaining caller, dict_build_table_def_step().	8 years ago
Marko Mäkelä	60ef478c2e	Remove an unnecessary global declaration	8 years ago
Marko Mäkelä	d177a0ed14	Remove unused function fil_space_get_id_by_name()	8 years ago
Marko Mäkelä	980dd09be6	Merge 10.2 into 10.3	8 years ago
Marko Mäkelä	014dfe473a	MDEV-15719: Adjust a test case	8 years ago
Marko Mäkelä	3eb73bf630	Remove unnecessary SysTablespace references	8 years ago
Marko Mäkelä	622d21e2b8	row_drop_table_for_mysql(): Use a constant string It does not hurt to delete non-existing records from SYS_TABLESPACES and SYS_DATAFILES. Because MariaDB does not support CREATE TABLESPACE, only the system tablespace (space_id=0) can contain multiple tables. But, there are no entries for the system tablespace in these tables (which actually are stored inside the system tablespace).	8 years ago
Sergei Petrunia	b922741074	MDEV-15472: Assertion `!is_set() \|\| (m_status == DA_OK_BULK && is_bulk_op())' failure MariaDB differs from the upstream for "DDL-like" command. For these, it sets binlog_format=STATEMENT for the duration of the statement. This doesn't play well with MyRocks, which tries to prevent DML commands with binlog_format!=ROW. Also, if Locked_tables_list::reopen_tables() returned an error, then close_cached_tables should propagate the error condition and not silently consume it (it's difficult to have test coverage for this because this error condition is rare)	8 years ago
Monty	4277c173a9	MDEV-15149 Assert upon concurrent creating / querying sequences MDEV-15117 Server crashes in in open_and_process_table or ASAN heap-use-after-free in is_temporary_table upon creating/flushing sequences. Problem was that sequence_insert closed and reopened the like table without proper locking. Fixed by ensuring that the like table is not reopened in sequence_insert	8 years ago
Monty	cd93eeeb1d	MDEV-15149 Assert upon concurrent creating / querying sequences Problem was that sequence_insert closed and reopened the like table without proper locking. Fixed by ensuring that the like table is not reopened in sequence_insert	8 years ago
Monty	e2664ee836	MDEV-14275 Improving memory utilization for information schema SELECT queries on information_schema table will now not store data in the temporary table for columns that are not used in the query. This can drastically reduce memory when there are many rows involved in a query, like using SELECT table_name FROM information_schema.table on a system with many tables. The difference for the above query is about 14K per existing table. The code works this way: - Create a bitmap for all information_schema fields used in the query - For BLOB and VARCHAR fields that are not use, create a Field_null field.	8 years ago
Monty	33fa6abd02	Ensure that map->mutex is reset in my_bitmap_init	8 years ago
Monty	75dd94c7ce	Fixed compiler warnings Remove compiler warnings in sphinx, item_sum.cc and opt_split.cc	8 years ago
Michael Widenius	d572c19f22	Added flush tables to acl_load_mutex-5170.test This is needed as otherwise a lot of MyISAM tables may be marked as crashed, depending on in which order tests are run	8 years ago
Monty	410d093089	Move extra/rpl_tests/table_index_statistics to suite/innodb	8 years ago
Michael Widenius	39018f2a5a	Move mysql-test-run/extra/rpl_tests to suite/rpl/include Renamed suite/rpl/include/rpl_sync.inc to rpl_sync_test.inc to remove clash with include/rpl_sync.inc	8 years ago
Michael Widenius	108ed22854	Move mysql-test-run/extra/binlog to suite/binlog/include	8 years ago
Michael Widenius	a7abddeffa	Create 'main' test directory and move 't' and 'r' there	8 years ago
Monty	ab1941266c	Move alter partition flags to alter_info->partition_flags This is done to get more free flag bits for alter_info->flags Renamed all ALTER PARTITION defines to start with ALTER_PARTITION_ Renamed ALTER_PARTITION to ALTER_PARTITION_INFO Renamed ALTER_TABLE_REORG to ALTER_PARTITION_TABLE_REORG Other things: - Shifted some ALTER_xxx defines to get empty bits at end	8 years ago
Monty	2dbeebdb16	Changed static const in Alter_info and Alter_online_info to defines Main reason was to make it easier to print the above structures in a debugger. Additional benefits is that I was able to use same defines for both structures, which simplifes some code. Most of the code is just removing Alter_info:: and Alter_inplace_info:: from alter table flags. Following renames was done: HA_ALTER_FLAGS -> alter_table_operations CHANGE_CREATE_OPTION -> ALTER_CHANGE_CREATE_OPTION Alter_info::ADD_INDEX -> ALTER_ADD_INDEX DROP_INDEX -> ALTER_DROP_INDEX ADD_UNIQUE_INDEX -> ALTER_ADD_UNIQUE_INDEX DROP_UNIQUE_INDEx -> ALTER_DROP_UNIQUE_INDEX ADD_PK_INDEX -> ALTER_ADD_PK_INDEX DROP_PK_INDEX -> ALTER_DROP_PK_INDEX Alter_info:ALTER_ADD_COLUMN -> ALTER_PARSE_ADD_COLUMN Alter_info:ALTER_DROP_COLUMN -> ALTER_PARSE_DROP_COLUMN Alter_inplace_info::ADD_INDEX -> ALTER_ADD_NON_UNIQUE_NON_PRIM_INDEX Alter_inplace_info::DROP_INDEX -> ALTER_DROP_NON_UNIQUE_NON_PRIM_INDEX Other things: - Added typedef alter_table_operatons for alter table flags - DROP CHECK CONSTRAINT can now be done online - Added checks for Aria tables in alter_table_online.test - alter_table_flags now takes an ulonglong as argument. - Don't support online operations if checksum option is used. - sql_lex.cc doesn't add ALTER_ADD_INDEX if index is not created	8 years ago
Monty	0631f20ff7	Fixed some DBUG_PRINT to use %p properly	8 years ago
Monty	c3f37c070c	Fixed alter online table for Aria tables fill_alter_table() always thought that index was changed because of of a wrong check of block_size. Some engines had code to correct this that should not be needed, Aria didn't and because of this some online operations didn't work. This code fixes the comparision of block_size to only compare if it's set.	8 years ago
halfspawn	209375fdd0	MDEV-15664 : sql_mode=ORACLE: Make TRIM return NULL instead of empty string	8 years ago
Marko Mäkelä	adaee46a90	MDEV-15682 mariabackup.unsupported_redo fails in buildbot with wrong result code Skip the test mariabackup.unsupported_redo if a checkpoint occurred before mariabackup --backup completed. Remove the slow shutdowns and restarts which were attempting to prevent the checkpoints from occurring.	8 years ago
Marko Mäkelä	6cccef21a6	MDEV-15720 ib_buffer_pool unnecessarily includes the temporary tablespace The purpose of the InnoDB buffer pool dump is to allow InnoDB to be restarted with the same persistent data pages in the buffer pool. The InnoDB temporary tablespace that was introduced in MariaDB 10.2.2 is always reinitialized on restart. Therefore, it does not make sense to attempt to dump or restore any pages of the temporary tablespace.	8 years ago
Marko Mäkelä	4d9969c216	MDEV-15719 ALTER TABLE…ALGORITHM=INPLACE is unnecessarily refused due to innodb_force_recovery ha_innobase::check_if_supported_inplace_alter(): Only check for high_level_read_only. Do not unnecessarily refuse ALTER TABLE...ALGORITHM=INPLACE if innodb_force_recovery was specified as 1, 2, or 3. innobase_start_or_create_for_mysql(): Block all writes from SQL if the system tablespace was initialized with 'newraw'.	8 years ago
Sergey Vojtovich	4faf34ad63	Clean-up trx_sys.mutex misuse Currently trx_sys.mutex protects only trx_sys.mysql_trx_list and trx_sys.m_views, which are not accessed by lock0lock debug routines. Thus there's no need to bother trx_sys.mutex here. Removed trx_assert_started(): this assertion is fully covered by check_trx_state().	8 years ago
Sergey Vojtovich	b36da48ad3	MDEV-15612 - Latching violation in trx_roll_must_shutdown recv_sys_t::mutex and rw_trx_hash_elementi_t::mutex were acquired in reverse (to recorded) order. Fixed by releasing recv_sys_t::mutex, before iterating rw_trx_hash. Statistics gathering doesn't really need recv_sys_t::mutex protection, since it is always done in one thread (trx_roll_crash_recv_trx) and thus it can't go wrong.	8 years ago
Sergei Petrunia	0d2fffb612	MDEV-15686: Loading MyRocks plugin back after it has been unloaded causes a crash Adjust the testcase to handle all possible outcomes.	8 years ago
Alexander Barkov	2a13b3db50	MDEV-15714 Remove the use of STRING_ITEM from the parser	8 years ago
Marko Mäkelä	d18a66147c	recv_validate_tablespace(): Fix -Wmissing-fallthrough	8 years ago
Marko Mäkelä	5beddfa08c	fil_node_open_file(): Add a missing space to message	8 years ago
Marko Mäkelä	b81a403e69	lock_rec_enqueue_waiting(): Fix diagnostics This is fixup after commit `8026cd6202`. We must not silently allow a lock wait to occur during InnoDB data dictionary transactions. The dict_operation_lock is supposed to prevent lock waits, and we want to be aware of any errors.	8 years ago
Marko Mäkelä	1924594b80	Minor (mainly non-functional) cleanup	8 years ago
Sergei Golubchik	b1818dccf7	Merge branch '10.2' into 10.3	8 years ago
Sergei Petrunia	011586c04d	MDEV-15686: Loading MyRocks plugin back after it has been unloaded causes a crash - Disallow loading of MyRocks (or any auxilary) plugins after it has been unloaded. - Do it carefully - Plugin's system variables may be accesssed (e.g. default value is set) after the first rocksdb_done_func() call but before the secon rocksdb_init_func() call.	8 years ago
Sergei Petrunia	907aae2502	MDEV-15708: rocksdb.mariadb_plugin fails on winx64, Cannot enable tc-log at run-time Ignore the warning. On Windows, Galera is not available so the server starts in non-XA mode when both MyRocks and InnoDB are disabled.	8 years ago
Jan Lindström	3b119d9d30	MDEV-11531: encryption.innodb_lotoftables failed in buildbot Test changes only.	8 years ago
Alexander Barkov	c346029958	MDEV-15702 Remove the use of STRING_ITEM from Item_func_date_format::fix_length_and_dec() Implementing the task according to the description. Additionally, implementing Item_func_date_format::check_arguments().	8 years ago
Daniel Bartholomew	aafb9d44d6	bump the VERSION	8 years ago
Alexander Barkov	068450a382	MDEV-15689 Fix Item_func_set_collation to pass the collation using CHARSET_INFO instead of Item Main changes: - Changing the constructor to accept a CHARSET_INFO pointer, instead of an Item pointer - Updating the bison grammar accordingly Additional cleanups: - Simplifying Item_func_set_collation::eq() by reusing Item_func::eq() - Removing unused binary_keyword	8 years ago
Alexander Barkov	0f26f71b49	MDEV-15316 Assertion `(thd->lex)->var_list.is_empty()' failed in MYSQLparse	8 years ago
Thirunarayanan Balathandayuthapani	73af8af094	MDEV-15325 Incomplete validation of missing tablespace during recovery Problem: ======= During validation of missing tablespace, missing tablespace id is being compared with hash table of redo logs (recv_sys->addr_hash). But if the hash table ran out of memory then there is a possibility that it will not contain the redo logs of all tablespace. In that case, Server will load the InnoDB even though there is a missing tablespace. Solution: ======== If the recv_sys->addr_hash hash table ran out of memory then InnoDB needs to scan the remaining redo log again to validate the missing tablespace.	8 years ago
Alexander Barkov	902ace0968	MDEV-15620 Crash when using "SET @@NEW.a=expr" inside a trigger The problem resided in this branch of the "option_value_no_option_type" rule: \| '@' '@' opt_var_ident_type internal_variable_name equal set_expr_or_default Summary: 1. internal_variable_name initialized tmp.var to trg_new_row_fake_var (0x01). 2. The condition "if (tmp.var == NULL)" did not check the special case with trg_new_row_fake_var, so Lex->set_system_variable(&tmp, $3, $6) was called with tmp.var pointing to trg_new_row_fake_var, which created a sys_var instance pointing to 0x01 instead of a real system variable. 3. Later, at the trigger invocation time, this method was called: sys_var::do_deprecated_warning (this=0x1, thd=0x7ffe6c000a98) Notice, "this" is equal to trg_new_row_fake_var (0x01) Solution: The old implementation with separate rules internal_variable_name (in sql_yacc.yy and sql_yacc_ora.yy) and internal_variable_name_directly_assignable (in sql_yacc_ora.yy only) was too complex and hard to follow. Rewriting the code in a more straightforward way. 1. Changing LEX::set_system_variable() from: bool set_system_variable(struct sys_var_with_base , enum_var_type, Item ); to: bool set_system_variable(enum_var_type, sys_var , const LEX_CSTRING , Item ); 2. Adding new methods in LEX, which operate with variable names: bool set_trigger_field(const LEX_CSTRING , const LEX_CSTRING , Item ); bool set_system_variable(enum_var_type var_type, const LEX_CSTRING name, Item val); bool set_system_variable(THD thd, enum_var_type var_type, const LEX_CSTRING name1, const LEX_CSTRING name2, Item val); bool set_default_system_variable(enum_var_type var_type, const LEX_CSTRING name, Item val); bool set_variable(const LEX_CSTRING name, Item item); 3. Changing the grammar to call the new methods directly in option_value_no_option_type, Removing rules internal_variable_name and internal_variable_name_directly_assignable. 4. Removing "struct sys_var_with_base" and trg_new_row_fake_var. Good side effect: - The code in /sql reduced from 314 to 183 lines. - MDEV-15615 Unexpected syntax error instead of "Unknown system variable" ... was also fixed automatically	8 years ago
Sergei Petrunia	60438451c3	MDEV-14843: Assertion `s_tx_list.size() == 0' failed in myrocks::Rdb_transaction::term_mutex When the plugin is unloaded, walk the s_trx_list and delete the left over Rdb_transaction objects. It is responsibility of the SQL layer to make sure that the storage engine has no open tables when the plugin is being unloaded.	8 years ago
Elena Stepanova	b3cdafcb93	Updated list of unstable tests for 10.2.14	8 years ago
Thirunarayanan Balathandayuthapani	dcb59373d5	- Fixing innodb.purge_secondary test case failure	8 years ago
Marko Mäkelä	c813d9485a	Fix result after commit `e27535093d`	8 years ago
Thirunarayanan Balathandayuthapani	e27535093d	- Follow-up fix to MDEV-15229	8 years ago

1 2 3 4 5 ...

181729 Commits (600c85e85a26f5c401223983f842fdaecdc4671e) All Branches Search

181729 Commits (600c85e85a26f5c401223983f842fdaecdc4671e)

All Branches