mariadb

Tree: 5eae8c2742

Author	SHA1	Message	Date
Marko Mäkelä	5eae8c2742	Merge 10.4 into 10.5	5 years ago
Marko Mäkelä	8341f582b2	MDEV-15527 fixup for innodb_checksum_algorithm=full_crc32	5 years ago
Sergei Petrunia	bf310b4cfb	MDEV-25305: MyRocks: Killing server during RESET MASTER can lose last transactions rocksdb_checkpoint_request() should call FlushWAL(sync=true) (which does write-out and sync), not just SyncWAL() (which just syncs without writing out) Followup: the test requires debug sync facility (This is a backport to 10.5)	5 years ago
Sergei Petrunia	5b678d9ea4	MDEV-25251: main.derived_split_innodb fails on ICC release binary The code compares two query plans with identical costs, the plan with lateral is the same as one without. Introduce a small difference to cost numbers to prefer non-lateral plan in this case.	5 years ago
Marko Mäkelä	50de71b026	Merge 10.3 into 10.4	5 years ago
Marko Mäkelä	d6d3d9ae2f	Merge 10.2 into 10.3	5 years ago
David CARLIER	99945d77d7	MDEV-25294 signal handler display coredump on mac	5 years ago
Thirunarayanan Balathandayuthapani	b771ab242b	MDEV-25200 Index count mismatch due to aborted FULLTEXT INDEX - Aborting of fulltext index creation fails to remove the index from sys indexes table. When we try to reload the table definition, InnoDB fails with index count mismatch error. InnoDB should remove the index from sys indexes while rollbacking the secondary index creation.	5 years ago
Thirunarayanan Balathandayuthapani	108ba4c380	MDEV-15527 page_compressed compressed page partially during import tablespace - Post push to address 32-bit build failure.	5 years ago
Marko Mäkelä	7c423c26d9	Add missing have_perfschema.inc	5 years ago
Krunal Bauskar	76d2846a71	MDEV-24630: MY_RELAX_CPU assembly instruction upgrade/research for memory barrier on ARM As suggested in the said JIRA ticket based on the contribution done by the community (in an attempt to optimize the spin-loop) the said approach was evaluated against MariaDB Server 10.5 and found to help improve throughput in the range of 2-5%. Note: 10.6 timing graph and model are different as home-brew mutexes are replaced with pthread mutexes. Said patch has mixed impact on 10.6 so not recommended for 10.6.	5 years ago
Thirunarayanan Balathandayuthapani	c468d5cb50	MDEV-15527 page_compressed compressed page partially during import tablespace - Importing table operation fails to punch the hole in the filesystem when page compressed table is involved. To achieve that, InnoDB firstly punches the hole for the IOBuffer size(1MB). After that, InnoDB should write page by page when page compression is involved.	5 years ago
Marko Mäkelä	8c2e3259c1	MDEV-24302 follow-up: RESET MASTER hangs As pointed out by Andrei Elkin, the previous fix did not fix one race condition that may have caused the observed hang. innodb_log_flush_request(): If we are enqueueing the very first request at the same time the log write is being completed, we must ensure that a near-concurrent call to log_flush_notify() will not result in a missed notification. We guarantee this by release-acquire operations on log_requests.start and log_sys.flushed_to_disk_lsn. log_flush_notify_and_unlock(): Cleanup: Always release the mutex. log_sys_t::get_flushed_lsn(): Use acquire memory order. log_sys_t::set_flushed_lsn(): Use release memory order. log_sys_t::set_lsn(): Use release memory order. log_sys_t::get_lsn(): Use relaxed memory order by default, and allow the caller to specify acquire memory order explicitly. Whenever the log_sys.mutex is being held or when log writes are prohibited during startup, we can use a relaxed load. Likewise, in some assertions where reading a stale value of log_sys.lsn should not matter, we can use a relaxed load. This will cause some additional instructions to be emitted on architectures that do not implement Total Store Ordering (TSO), such as POWER, ARM, and RISC-V Weak Memory Ordering (RVWMO).	5 years ago
Jan Lindström	dfda1c9283	Add supression for warning.	5 years ago
Jan Lindström	d217a925b2	MDEV-24923 : Port selected Galera conflict resolution changes from 10.6 Add condition on trx->state == TRX_STATE_COMMITTED_IN_MEMORY in order to avoid unnecessary work. If a transaction has already been committed or rolled back, it will release its locks in lock_release() and let the waiting thread(s) continue execution. Let BF wait on lock_rec_has_to_wait and if necessary other BF is replayed. wsrep_trx_order_before If BF is not even replicated yet then they are ordered correctly. bg_wsrep_kill_trx Make sure victim_trx is found and check also its state. If state is TRX_STATE_COMMITTED_IN_MEMORY transaction is already committed or rolled back and will release it locks soon. wsrep_assert_no_bf_bf_wait Transaction requesting new record lock should be TRX_STATE_ACTIVE Conflicting transaction can be in states TRX_STATE_ACTIVE, TRX_STATE_COMMITTED_IN_MEMORY or in TRX_STATE_PREPARED. If conflicting transaction is already committed in memory or prepared we should wait. When transaction is committed in memory we held trx mutex, but not lock_sys->mutex. Therefore, we could end here before transaction has time to do lock_release() that is protected with lock_sys->mutex. lock_rec_has_to_wait We very well can let bf to wait normally as other BF will be replayed in case of conflict. For debug builds we will do additional sanity checks to catch unsupported bf wait if any. wsrep_kill_victim Check is victim already in TRX_STATE_COMMITTED_IN_MEMORY state and if it is we can return. lock_rec_dequeue_from_page lock_rec_unlock Remove unnecessary wsrep_assert_no_bf_bf_wait function calls. We can very well let BF wait here.	5 years ago
Daniel Black	c44273329e	remove broken tests/grant.pl	5 years ago
Daniel Black	fb3b2eb517	mallinfo2: whitespace fix	5 years ago
Vladislav Vaintroub	add24e7889	Windows - suppress nonsensical(for this OS) system check. Amends `48141f3c17`	5 years ago
Daniel Black	85b6a81805	MDEV-24586: remove mysql_to_mariadb.sql This script is unused and unmaintained. The logic is implemented in scripts/mysql_system_tables_fix.sql that forms part of mysql_upgrade Its components: alter table mysql.user drop column `password_last_changed`, drop column `password_lifetime`, drop column `account_locked`; has a friendlier migration path coming MDEV-24122 alter table mysql.user change column `authentication_string` `auth_string` text COLLATE utf8_bin NOT NULL; Already part of scripts/mysql_system_tables_fix.sql alter table mysql.user add column `Password` char(41) CHARACTER SET latin1 COLLATE latin1_bin NOT NULL DEFAULT '' after `user`, add column `is_role` enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N' after `auth_string`; alter table mysql.user add column `default_role` char(80) COLLATE utf8_bin NOT NULL DEFAULT '', add column `max_statement_time` decimal(12,6) NOT NULL DEFAULT '0.000000'; corrected in MDEV-23201 to be in the right order. update mysql.user set `password`=`auth_string`, plugin='' where plugin="mysql_native_password"; Is handled in server in the function acl_load.	5 years ago
Alexey Yurchenko	4d870b591d	Don't pass password to innobackup via command line, use environment instead Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	5 years ago
Otto Kekäläinen	0df74a0197	Deb: Fix failing Salsa-CI by syncing fixes from downstream to upstream Fixes jobs: - mysql-8.0 Sid to mariadb-10.5 upgrade - mariadb.org-10.5 to mariadb-10.5 upgrade Downstream source: `8db0e53087`	5 years ago
Otto Kekäläinen	5a4daa9099	Deb: Add Breaks/Replaces Fix the following Breaks/Replaces errors detected by Salsa-CI: [ERROR] mariadb-server-10.5 conflicts with mysql-client-core-8.0 files: {'/usr/bin/myisam_ftdump', '/usr/share/man/man1/myisam_ftdump.1.gz'} [ERROR] mariadb-server-10.5 conflicts with mysql-server-core-8.0 files: {'/usr/share/man/man1/mysqlbinlog.1.gz', '/usr/share/man/man1/myisamlog.1.gz', '/usr/share/man/man1/mysql_tzinfo_to_sql.1.gz', '/usr/share/man/man1/perror.1.gz', '/usr/share/man/man1/myisampack.1.gz', '/usr/bin/mysqld_safe', '/usr/share/man/man1/myisamchk.1.gz', '/usr/bin/myisamchk', '/usr/bin/mysql_secure_installation', '/usr/bin/mysqld_multi', '/usr/bin/mysql_tzinfo_to_sql', '/usr/bin/perror', '/usr/share/man/man1/mysqld_multi.1.gz', '/usr/bin/myisampack', '/usr/share/man/man1/mysqld_safe.1.gz', '/usr/bin/myisamlog', '/usr/share/man/man1/mysql_secure_installation.1.gz', '/usr/bin/mysqlbinlog'} [ERROR] mariadb-test conflicts with mysql-server-core-8.0 files: {'/usr/lib/mysql/plugin/adt_null.so', '/usr/lib/mysql/plugin/mypluglib.so'} Upstreamed from Debian packaging commits: `9b6a67b53c` `f6d5545a02` Also: - remove excess '<< ${source:Version}' on mysql-client-* and mysql-server-* - move more packages to Conflicts as it is semantically more correct than having those packages in Replaces	5 years ago
Otto Kekäläinen	ab3777a3bf	Revert "MDEV-23342 MariaDB cannot be installed over MySQL 5.7.30 on Bionic anymore" This reverts commit `44885273f2`. Reverting this commit is necessary to fix missing-breaks errors in the Debian packaging. The original fix was also not entirely necessary as a fix to the original problem. Partially also reverts commit `e7c7f5c1bb` where this unsorted debian/control file was sorted.	5 years ago
Alexey Botchkov	94dea8ef5b	MDEV-25457 CREATE / DROP PROCEDURE not logged with audit plugin. CREATE/DROP PROCEDIRE/FUNCTION is now treated as DDL.	5 years ago
Marko Mäkelä	e8b7fceb82	MDEV-24302: RESET MASTER hangs Starting with MariaDB 10.5, roughly after MDEV-23855 was fixed, we are observing sporadic hangs during the execution of the RESET MASTER statement. We are hoping to fix the hangs with these changes, but due to the rather infrequent occurrence of the hangs and our inability to reliably reproduce the hangs, we cannot be sure of this. What we do know is that innodb_force_recovery=2 (or a larger setting) will prevent srv_master_callback (the former srv_master_thread) from running. In that mode, periodic log flushes would never occur and RESET MASTER could hang indefinitely. That is demonstrated by the new test case that was developed by Andrei Elkin. We fix this case by implementing a special case for it. This also includes some code cleanup and renames of misleadingly named code. The interface has nothing to do with log checkpoints in the storage engine; it is only about requesting log writes to be persistent. handlerton::commit_checkpoint_request, commit_checkpoint_notify_ha(): Remove the unused parameter hton. log_requests.start: Replaces pending_checkpoint_list. log_requests.end: Replaces pending_checkpoint_list_end. log_requests.mutex: Replaces pending_checkpoint_mutex. log_flush_notify_and_unlock(), log_flush_notify(): Replaces innobase_mysql_log_notify(). The new implementation should be functionally equivalent to the old one. innodb_log_flush_request(): Replaces innobase_checkpoint_request(). Implement a fast path for common cases, and reduce the mutex hold time. POSSIBLE FIX OF THE HANG: We will invoke commit_checkpoint_notify_ha() for the current request if it is already satisfied, as well as invoke log_flush_notify_and_unlock() for any satisfied requests. log_write(): Invoke log_flush_notify() when the write is already durable. This was missing WITH_PMEM when the log is in persistent memory. Reviewed by: Vladislav Vaintroub	5 years ago
Alexey Bychko	c0ca3c4ffa	MDEV-25240 minor upgrade does not perform server restart we need to stop server instance on upgrade, but it may be started either by SysV init script or by SystemD. this commit adds `mysql` target to `systemctl stop` call. `mysql` may be the name of initscript or an alias while `mariadb` is a systemd unit file.	5 years ago
Monty	8e2d69f7b8	Fixed access to undefined memory alloc_query() is examined the content of it's argument, which was uninitalized. Fixed by storing stmt_id in llbuf, according to code comments.	5 years ago
Anel Husakovic	2fc76a5022	MDEV-13467: Feature request: Support for ST_Distance_Sphere() - jump to label ‘handle_errors’ can enter to the scope of non-POD ‘Geometry_buffer buffer2’	5 years ago
Alexey Botchkov	96475b78c5	MDEV-25457 CREATE / DROP PROCEDURE not logged with audit plugin. CREATE/DROP PROCEDIRE/FUNCTION is now treated as DDL.	5 years ago
Marko Mäkelä	80459bcbd4	Merge 10.4 into 10.5	5 years ago
Marko Mäkelä	7ae37ff74f	Merge 10.3 into 10.4	5 years ago
Marko Mäkelä	3157fa182a	Merge 10.2 into 10.3	5 years ago
Anel Husakovic	5eda18f0ca	MDEV-25272: Wrong function name in error messages upon ST_GeomFromGeoJSON call - Invalid function name during ER_WRONG_VALUE_FOR_TYPE and ER_GIS_INVALID_DATA	5 years ago
Anel Husakovic	6769d1a078	MDEV-13467: Feature request: Support for ST_Distance_Sphere() - Cherry-pick `51e48b9f89` - vscode gitignore - Thanks Robin Dupret for the review. Reviewed by:daniel@mariadb.org holyfoot@mariadb.com	5 years ago
Michael Okoko	48141f3c17	Replace mallinfo with mallinfo2 on supported systems `mallinfo` is deprecated since glibc 2.33 and has been replaced by mallinfo2. The deprecation causes building the server to fail if glibc version is > 2.33. Check if mallinfo2 exist on the system and use it instead.	5 years ago
Eugene Kosov	36a05268e7	cmake cleanup: drop support for ancient clang in WITH_ASAN option	5 years ago
Eugene Kosov	dfae51de36	MDEV-25238 add support for -fsanitize-address-use-after-scope Use like this: cmake -DWITH_ASAN=ON -DWITH_ASAN_SCOPE=ON	5 years ago
Marko Mäkelä	a6d66fe75e	MDEV-24786: row_upd_clust_step() skips mtr_t::commit() on virtual column error The function row_upd_clust_step() is invoking several static functions, some of which used to commit the mini-transaction in some cases. If innobase_get_computed_value() would fail due to some reason, we would fail to invoke mtr_t::commit() and release buffer pool page latches. This would likely lead to a hanging server later. This regression was introduced in commit `97db6c15ea` (MDEV-20618). row_upd_index_is_referenced(), row_upd_sec_index_entry(), row_upd_sec_index_entry(): Cleanup: Replace some ibool with bool. row_upd_clust_rec_by_insert(), row_upd_clust_rec(): Guarantee that the mini-transaction will always remain in active state. row_upd_del_mark_clust_rec(): Guarantee that the mini-transaction will always remain in active state. This fixes one "leak" of mini-transaction on DB_COMPUTE_VALUE_FAILED. row_upd_clust_step(): Use only one return path, which will always invoke mtr.commit(). After a failed row_upd_store_row() call, we will no longer "leak" the mini-transaction. This fix was verified by RQG on 10.6 (depending on MDEV-371 that was introduced in 10.4). Unfortunately, it is challenging to create a regression test for this, and a test case could soon become invalid as more bugs in virtual column evaluation are fixed.	5 years ago
Marko Mäkelä	2e67b9f665	MDEV-25265: ALTER TABLE...IMPORT TABLESPACE fails after DROP INDEX A side effect of the MDEV-24589 bug fix is that if FLUSH TABLE...FOR EXPORT is initiated before the history of an earlier DROP INDEX operation has been purged, then the data file will contain allocated pages that belonged to the dropped indexes. These pages would never be freed after a subsequent IMPORT TABLESPACE. We will work around this regression by making IMPORT TABLESPACE tolerate pages that refer to an unknown index.	5 years ago
Daniel Black	bcb9ca4105	MEM_CHECK_DEFINED: replace HAVE_valgrind HAVE_valgrind_or_MSAN to HAVE_valgrind was incorrect in `af784385b4`. In my_valgrind.h when clang exists (hence no __has_feature(memory_sanitizer), and -DWITH_VALGRIND=1, but without memcheck.h, we end up with a MEM_CHECK_DEFINED being empty. If we are also doing a CMAKE_BUILD_TYPE=Debug this results a number of [-Werror,-Wunused-variable] errors because MEM_CHECK_DEFINED is empty. With MEM_CHECK_DEFINED empty, there becomes no uses of this of the fixed field and innodb variables in this patch. So we stop using HAVE_valgrind as catchall and use the name HAVE_CHECK_MEM to indicate that a CHECK_MEM_DEFINED function exists. Reviewer: Monty Corrects: `af784385b4`	5 years ago
Vladislav Vaintroub	da26e2e673	Cleanup - reduce duplicate code, in SSL IO error handling.	5 years ago
mkaruza	d1ff2c583f	MDEV-21697: Galera assertion !wsrep_has_changes(thd) \|\| (thd->lex->sql_command == SQLCOM_CREATE_TABLE && !thd->is_current_stmt_binlog_format_row()) Prevent adding WSREP keys with CTAS when table is is not InnoDB. Reviewed-by: Jan Lindström <jan.lindstrom@mariadb.com>	5 years ago
Jan Lindström	161f4036c4	MDEV-24954 : 10.5.9 crashes on int wsrep::client_state::ordered_commit(): Assertion `owning_thread_id_ == wsrep::this_thread::get_id()' failed. Binlog group commit could lead to a situation where group commit leader accesses participant thd's wsrep client state concurrently with the thread executing the participant thd. This is because of race condition in MYSQL_BIN_LOG::write_transaction_to_binlog_events(), and was fixed by moving wsrep_ordered_commit() to happen in MYSQL_BIN_LOG::queue_for_group_commit() under protection of LOCK_prepare_ordered mutex.	5 years ago
Sergei Golubchik	5a79807119	MDEV-25242 Server crashes in check_grant upon invoking function with userstat enabled use check_grant(..., number_of_tables=1, ...) if you only need to check privileges for one table	5 years ago
Vladislav Vaintroub	cdb86faf82	MDEV-23740 postfix - potentially uninitialized variable passed to vio_socket_io_wait. Thanks to Daniel Black for reporting.	5 years ago
Igor Babaev	480a06718d	MDEV-25128 Wrong result from join with materialized semi-join and splittable derived If one of joined tables of the processed query is a materialized derived table (or view or CTE) with GROUP BY clause then under some conditions it can be subject to split optimization. With this optimization new equalities are injected into the WHERE condition of the SELECT that specifies this derived table. The injected equalities are generated for all join orders with which the split optimization can employed. After the best join order has been chosen only certain of this equalities are really needed. The others can be safely removed. If it's not done and some of injected equalities involve expressions over semi-joins with look-up access then the query may return a wrong result set. This patch effectively removes equalities injected for split optimization that are needed only at the optimization stage and not needed for execution. Approved by serg@mariadb.com	5 years ago
Sergei Golubchik	c4807c107a	MDEV-24879 Client crash on undefined charsetsdir	5 years ago
Marko Mäkelä	e731a28394	MDEV-24589 DROP TABLE is not crash-safe row_upd_clust_step(): Remove the "trigger" on DELETE SYS_INDEXES that would invoke dict_drop_index_tree(). Let us do it on purge. row_purge_remove_clust_if_poss_low(): Invoke dict_drop_index_tree() when purging a delete-marked SYS_INDEXES record.	5 years ago
Marko Mäkelä	8b11550356	fixup `cebf9ee204`	5 years ago
Marko Mäkelä	8f23aab068	MDEV-15528 fixup: Remove dict_table_open_on_index_id() dict_table_open_on_index_id(): Remove. This function was used by the background scrubbing, which was removed in commit `a5584b13d1`.	5 years ago

1 2 3 4 5 ...

192043 Commits (5eae8c274244aaa98320dda3e686f264e8a447d6) All Branches Search

192043 Commits (5eae8c274244aaa98320dda3e686f264e8a447d6)

All Branches