mariadb

Tree: 5d0496c749

Author	SHA1	Message	Date
Marko Mäkelä	5d0496c749	Merge 10.6 into 10.7	3 years ago
Marko Mäkelä	f2f18e20eb	MDEV-28923 atomic.rename_table occasionally fails fil_name_process(): If the recovery of a tablespace was deferred, do invoke fil_ibd_load() even though the name in recv_spaces is not changing. This allows us to recover from a situation where there are many FILE_RENAME records, renaming a tablespace back and forth, and a FILE_MODIFY record that had been written by fil_names_clear(). Co-developed with: Thirunarayanan Balathandayuthapani	3 years ago
Vladislav Vaintroub	eb7f46ca1e	Merge remote-tracking branch 'origin/10.5' into 10.6	3 years ago
Vladislav Vaintroub	35f2cdcb99	MDEV-28920 Rescheduling of innodb_stats_func() missing Fixed tpool timer implementation on POSIX. Prior to this patch, under some specific rare circumstances (concurrency related), timer callback execution might be skipped.	3 years ago
Marko Mäkelä	0f0a45b2dc	MDEV-18976 fixup: encryption.innodb-redo-badkey When attempting to recover a database with an incorrect encryption key, the unencrypted page contents should be expected to differ from what was written before recovery. Let us suppress some more messages. This caused intermittent failures, depending on when the latest log checkpoint was triggered.	3 years ago
Marko Mäkelä	6f4d0659dd	MDEV-22388 Corrupted undo log record leads to server crash trx_undo_rec_copy(): Return nullptr if the undo record is corrupted. trx_undo_rec_get_undo_no(): Define inline with the declaration. trx_purge_dummy_rec: Replaced with a -1 pointer. row_undo_rec_get(), UndorecApplier::apply_undo_rec(): Check if trx_undo_rec_copy() returned nullptr. trx_purge_get_next_rec(): Return nullptr upon encountering any corruption, to signal the end of purge.	3 years ago
Marko Mäkelä	8ebff3bcb0	Merge 10.6 into 10.7	3 years ago
Marko Mäkelä	0fa19fdebf	MDEV-28836 fixup On GNU/Linux, even though the C11 aligned_alloc() appeared in GNU libc early on, some custom memory allocators did not implement it until recently. For example, before gperftools/gperftools@d406f2285390c402e824dd28e6992f7f890dcdf9 the free() in tcmalloc would fail to free memory that was returned by aligned_alloc(), because the latter would map to the built-in allocator of libc. The Linux specific memalign() has a similar interface and is safer to use, because it has been available for a longer time. For AddressSanitizer, we will use aligned_alloc() so that the constraint on size can be enforced. buf_tmp_reserve_compression_buf(): When HAVE_ALIGNED_ALLOC holds, round up the size to be an integer multiple of the alignment. pfs_malloc(): In the unit test stub, round up the size to be an integer multiple of the alignment.	3 years ago
Marko Mäkelä	6680fd8d4b	Merge 10.6 into 10.7	3 years ago
Marko Mäkelä	3794673111	MDEV-28836: Memory alignment cleanup Table_cache_instance: Define the structure aligned at the CPU cache line, and remove a pad[] data member. Krunal Bauskar reported this to improve performance on ARMv8. aligned_malloc(): Wrapper for the Microsoft _aligned_malloc() and the ISO/IEC 9899:2011 <stdlib.h> aligned_alloc(). Note: The parameters are in the Microsoft order (size, alignment), opposite of aligned_alloc(alignment, size). Note: The standard defines that size must be an integer multiple of alignment. It is enforced by AddressSanitizer but not by GNU libc on Linux. aligned_free(): Wrapper for the Microsoft _aligned_free() and the standard free(). HAVE_ALIGNED_ALLOC: A new test. Unfortunately, support for aligned_alloc() may still be missing on some platforms. We will fall back to posix_memalign() for those cases. HAVE_MEMALIGN: Remove, along with any use of the nonstandard memalign(). PFS_ALIGNEMENT (sic): Removed; we will use CPU_LEVEL1_DCACHE_LINESIZE. PFS_ALIGNED: Defined using the C++11 keyword alignas. buf_pool_t::page_hash_table::create(), lock_sys_t::hash_table::create(): lock_sys_t::hash_table::resize(): Pad the allocation size to an integer multiple of the alignment. Reviewed by: Vladislav Vaintroub	3 years ago
Marko Mäkelä	2e43af69e3	MDEV-28870 InnoDB: Missing FILE_CREATE, FILE_DELETE or FILE_MODIFY before FILE_CHECKPOINT There was a race condition between log_checkpoint_low() and deleting or renaming data files. The scenario is as follows: 1. The buffer pool does not contain dirty pages. 2. A FILE_DELETE or FILE_RENAME record is written. 3. The checkpoint LSN will be moved ahead of the write of the record. 4. The server is killed before the file is actually renamed or deleted. We will prevent this race condition by ensuring that a log checkpoint cannot occur between the durable write and the file system operation: 1. Durably write the FILE_DELETE or FILE_RENAME record. 2. Perform the file system operation. 3. Allow any log checkpoint to proceed. mtr_t::commit_file(): Implement the DELETE or RENAME logic. fil_delete_tablespace(): Delegate some of the logic to mtr_t::commit_file(). fil_space_t::rename(): Delegate some logic to mtr_t::commit_file(). Remove the debug injection point fil_rename_tablespace_failure_2 because we do test RENAME failures without any debug injection. fil_name_write_rename_low(), fil_name_write_rename(): Remove. Tested by Matthias Leich	3 years ago
Marko Mäkelä	55f02c24a6	MDEV-28845 fixup: Prevent an infinite loop buf_page_create_low(): Before retrying, release the exclusive page latch in order to prevent an infinite loop in buf_pool_t::corrupted_evict().	3 years ago
Marko Mäkelä	3b662c6ebd	MDEV-28782 fixup: ./mtr --embedded	3 years ago
Daniel Black	0e4cf497ca	MDEV-28782 mariadb-tzinfo-to-sql to work in bootstrap mode Work around MDEV-28718 for now, but also optimize the interation of information_schema.SYSTEM_VARIABLES. Add test case to show that tzinfo data into bootstrap is desired functionality. Bug report thanks to Dan Lenski of AWS.	4 years ago
Sergei Golubchik	2643aa43ae	fix spider.variable_deprecation test	3 years ago
Sergei Golubchik	5ad9a41301	re-enable innodb.innodb_page_compressed tests	4 years ago
Marko Mäkelä	a8c22dae8b	Merge 10.6 into 10.7	4 years ago
Marko Mäkelä	5bb90cb2ac	Merge 10.5 into 10.6	4 years ago
Marko Mäkelä	e99ba4ac8d	MDEV-28864 Assertion `trx_id <= create_id' failed in innodb_check_version() ha_innobase::prepare_inplace_alter_table(): If the ALTER TABLE operation is no-op for InnoDB, do reset m_prebuilt->trx_id so that ha_innobase::table_version() will always report either 0 or the identifier of the transaction that would commit changes to the InnoDB data dictionary. The failure scenario involved a completed DROP INDEX followed by a no-op ALTER TABLE during which the server was killed. An effort to create a reproducible test failed.	4 years ago
Monty	674842bee0	MDEV-28858 Wrong result with table elimination combined with not_null_range_scan The bug was that build_notnull_conds_for_range_scans() did not take into account the join_tab is not yet sorted with constant tables first. Fixed the bug by testing explicitely if a table is a const table.	4 years ago
Marko Mäkelä	253806dffc	MDEV-28845 InnoDB: Failing assertion: bpage->can_relocate() in buf0lru.cc Since commit `0b47c126e3` (MDEV-13542) we treat all-zero pages as corrupted ones. During a stress test, a read-ahead of an all-zero page was triggered and the page read was completed concurrently with buf_page_create_low(). This caused the assertion to fail, because buf_page_create_low() was waiting for the page latch. buf_page_get_low(): Only invoke buf_pool_t::corrupted_evict() if the block was not already marked as corrupted. buf_page_create_low(): On page identifier mismatch, retry the buf_pool.page_hash lookup. buf_pool_t::corrupted_evict(): Set the state of the block to FREED so that a concurrent buf_page_get_low() will refuse to load the page. Wait for the page latch to be vacant before proceeding to remove the block from buf_pool.page_hash and buf_pool.LRU. page_id_t::set_corrupted(), page_id_t::is_corrupted(): Accessors for indicating a corrupted page identifier. Tested by Matthias Leich	4 years ago
Marko Mäkelä	0850267d00	MDEV-13542 fixup: Relax an assertion	4 years ago
Vlad Lesin	27309fc6b0	MDEV-28832 infinite loop in mariabackup if log LOG_HEADER_FORMAT field is 0 Avoid the loop with getting rid of back and forth jumping.	4 years ago
Marko Mäkelä	42d3a7b63d	Merge 10.6 into 10.7	4 years ago
Marko Mäkelä	6c82ab4f72	MDEV-28840 innodb_undo_log_truncate is not crash-safe trx_purge_free_segment(): Do mark that the block will be modified. It seems possible that this regression was introduced by the changes to the page-freeing logic in commit `4179f93d28` (MDEV-18976). Tested by: Matthias Leich	4 years ago
Thirunarayanan Balathandayuthapani	6c669b9586	MDEV-25581 Allow user thread to do InnoDB fts cache sync - innodb_fts.sync_block doesn't make sense after MDEV-25581's patch because fts cache syncing is done as a part of insert operation and it leads to completion of select over insert sometimes. This test case is not relevant any more	4 years ago
Marko Mäkelä	ddf511c44d	Merge 10.6 into 10.7	4 years ago
Marko Mäkelä	1f1fa7e09c	Merge 10.5 into 10.6	4 years ago
Marko Mäkelä	4849d94fe6	MDEV-28828 SIGSEGV in buf_flush_LRU_list_batch In commit `73fee39ea6` (MDEV-27985) a regression was introduced that would cause bpage=nullptr to be referenced. buf_flush_LRU_list_batch(): Always terminate the loop upon encountering a null pointer.	4 years ago
Nayuta Yanagisawa	06e9ce798c	MDEV-26127 Assertion `err != DB_DUPLICATE_KEY' failed or InnoDB: Failing assertion: id != 0 on ALTER ... REBUILD PARTITION During rebuild of partition, the partitioning engine calls alter_close_table(), which does not unlock and close some table instances of the target table. Then, the engine fails to rename partitions because there are table instances that are still locked. Closing all the table instance of the target table fixes the bug.	4 years ago
Marko Mäkelä	1f3f457193	MDEV-28802 DROP DATABASE in InnoDB still is case-insensitive innodb_drop_database(): Use explicit TO_BINARY casts on SYS_TABLES.NAME, which for historical reasons uses the wrong collation latin1_swedish_ci instead of BINARY.	4 years ago
Monty	65dd31088a	Update magic file with Aria table files and ddl log	4 years ago
Monty	1bcd87cdcc	Fixed maria.maria-recover and maria.encrypt-no-key test files These had been damaged during some merge which caused --embedded test to fail	4 years ago
Tuukka Pasanen	d4760d8c01	MDEV-28642: Suspend obvious false-positive Lintian warnings MariaDB codebase is huge and Lintian has lots of test than can fire false-positive warnings which leads to situation where real problems can't be spotted. Suspend obvious false-positive Lintian warnings and let Lintian problems that needs some love shine out. Suspends in package mariadb-test-data Supporting BSD family needs to use '/usr/bin/env perl' and not '/usr/bin/perl' Perl script are for testing and not for production in mariadb-test-data package: * incorrect-path-for-interpreter There is several files with national-encoding which are test file so they can't be in unicode charset * national-encoding Serveral test paths are intentionally repeated: * repeated-path-segment Suspends in package mariadb-test Supporting BSD family needs to use '/usr/bin/env perl' and not '/usr/bin/perl' Perl script are for testing and not for production in mariadb-test-data package: * incorrect-path-for-interpreter Suspends in package source package Remade some 'version-substvar-for-external-package' to use regex. MGroonga is missing source file 'jquery-ui-1.8.18.custom.js' correct lintian suspend with regex: * source-is-missing There is several files with very long line lenghts. Add suspends for those that can't be corrected in several places. Most of them are test result files, SQL test files or intentional long lines that can't be splitted. * very-long-line-length-in-source-file There is several autogenerated C++ files which probably should not be there but they should not do any harm: * source-contains-autogenerated-visual-c++-file	4 years ago
Thirunarayanan Balathandayuthapani	1fd7d3a9ad	MDEV-25581 Allow user thread to do InnoDB fts cache sync Problem: ======== InnoDB FTS requesting the fts sync of the table once the fts cache size reaches 1/10 of innodb_ft_cache_size. But fts_sync() releases cache lock when writing the word. By doing this, InnoDB insert thread increases the innodb fts cache memory and SYNC operation will take more time to complete. Solution: ========= Remove the fts sync operation(FTS_MSG_SYNC_TABLE) from the fts optimize background thread. Instead of that, allow user thread to sync the InnoDB fts cache when the cache size exceeds 512 kb. User thread holds cache lock while doing cache syncing, it make sure that other threads doesn't add the docs into the cache. Removed FTS_MSG_SYNC_TABLE and its related function because we do remove the FTS_MSG_SYNC_TABLE message itself. Removed fts_sync_index_check() and all related function because other threads doesn't add while cache operation going on.	4 years ago
Marko Mäkelä	51ca5d517e	Fix ./mtr --embedded This fixes up commit `3d241eb948`	4 years ago
Marko Mäkelä	fe75e5e5b1	Merge 10.6 into 10.7	4 years ago
Marko Mäkelä	e11b82f8f5	Merge 10.5 into 10.6	4 years ago
Marko Mäkelä	a9d0bb12e6	Merge 10.4 into 10.5	4 years ago
Marko Mäkelä	c89e3b70a7	Merge 10.3 into 10.4	4 years ago
Marko Mäkelä	98293130c3	MDEV-28779: ALTER TABLE IMPORT TABLESPACE corrupts an encrypted table PageConverter::update_header(): Remove an unnecessary write. The field that was originally called FIL_PAGE_FILE_FLUSH_LSN only made sense for the first page of the system tablespace (initially, for the first page of each file of the system tablespace). It never had any meaning for .ibd files, and it lost its original meaning in MariaDB Server 10.8.1 when commit `b07920b634` (MDEV-27199) removed the ability to start without ib_logfile0. If the most significant 32 bits of the LSN are nonzero, this unnecessary write would write the wrong encryption key identifier to the page. The first page of any file is never encrypted, so normally those bytes should be 0 for any .ibd file.	4 years ago
Daniel Lewart	2cd1edfc21	MDEV-25577 mariadb-tzinfo-to-sql generates superfluous warnings The zoneinfo directory is littered with non-timezone information files. These frequently contain extensions, not present in real timezone files. Alo leapseconds is frequently there and is not a timezone file.	4 years ago
GuiXiaoDi	9c207c88c1	mysql.server.sh fix for non-Red Hat platforms The else condition is meant to be here to define the functions if the Red Hat include file isn't there. Fixes: commit `467011bcac` / MDEV-26614 RedHat -> Red Hat by Daniel Black	4 years ago
Tingyao Nian	4145618103	MDEV-22023 Update man page NAME section to say MariaDB instead of MySQL Continue the effort of a previous commit (PR#2114) which changed the man pages titles from MariaDB to MySQL, to further update the man pages. Update the man page NAME sections to use mariadb-* instead of mysql* for MariaDB binaries that are drop-in replacements for MySQL equivalents, indicating that the commands are actually of the MariaDB version. Before: NAME mysql_upgrade - check tables for MariaDB upgrade ... After: NAME mariadb-upgrade - check tables for MariaDB upgrade (mysql_upgrade is now a symlink to mariadb-upgrade) ... All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.	4 years ago
Oleg Smirnov	5efadf8d8c	MDEV-28747 Index condition pushdown may be configured incorrectly ha_innobase::build_template may initialize m_prebuilt->idx_cond even if there is no valid pushed_idx_cond_keyno. This potentially problematic piece of code was found while working on MDEV-27366	4 years ago
Marko Mäkelä	77b3959b5c	MDEV-28457 Crash in page_dir_find_owner_slot() A prominent remaining source of crashes on corrupted index pages is page directory corruption. A frequent caller of page_dir_find_owner_slot() is page_rec_get_prev(). Some of those calls can be replaced with simpler logic that is less prone to fail. page_dir_find_owner_slot(), page_rec_get_prev(), page_rec_get_prev_const(), btr_pcur_move_to_prev(), btr_pcur_move_to_prev_on_page(), btr_cur_upd_rec_sys(), page_delete_rec_list_end(), rtr_page_copy_rec_list_end_no_locks(), rtr_page_copy_rec_list_start_no_locks(): Return an error code on failure. fil_space_t::io(), buf_page_get_low(): Use DB_CORRUPTION for out-of-bounds page reads. PageBulk::getSplitRec(), PageBulk::copyOut(): Simplify the code. btr_validate_level(): Prevent some more CHECK TABLE crashes on corrupted pages. btr_block_get(), btr_pcur_move_to_next_page(): Implement some checks that were previously only part of IndexPurge::next(). IndexPurge::next(): Use btr_pcur_move_to_next_page().	4 years ago
Marko Mäkelä	44ab6cba76	Cleanup: Remove unused error code DB_FORCED_ABORT MariaDB never supported this form of preemption via high-priority transactions. This error code shold not have been added in the first place, in commit `2e814d4702`.	4 years ago
Daniel Black	e8b0894dc8	MDEV-28243: AIX missing my_gethwaddr implementation and failing spider partition test. With some small datatype changes to the Linux/Solaris my_gethwaddr implementation the hardware address of AIX can be returned. This is an important aspect in Spider (and UUID). Spider test change reviewed by Nayuta Yanagisawa. my_gethwaddr review by Monty in #2081	4 years ago
Marko Mäkelä	892c426371	MDEV-13542: Do not crash on decryption failure fil_page_type_validate(): Remove. This debug check was mostly redundant and added little value to the code paths that deal with page_compressed or encrypted pages. fil_get_page_type_name(): Remove; unused function. fil_space_decrypt(): Return an error if the page is not supposed to be encrypted. It is possible that an unencrypted page contains a nonzero key_version field even though it is not supposed to be encrypted. Previously we would crash in such a situation. buf_page_decrypt_after_read(): Simplify the code. Remove some unnecessary error message about temporary tablespace corruption. This is where we would usually invoke fil_space_decrypt().	4 years ago
Marko Mäkelä	c9498f33de	MDEV-18519: Assertion failure in btr_page_reorganize_low() Even after commit `0b47c126e3` there are a few ib::fatal() calls in non-debug code that can be replaced easily. btr_page_reorganize_low(): On size invariant violation, return an error code instead of crashing. btr_check_blob_fil_page_type(): On an invalid page type, report an error but do not crash. btr_copy_blob_prefix(): Truncate the output if a page type is invalid. dict_load_foreign_cols(): On an error, return DB_CORRUPTION instead of crashing. fil_space_decrypt_full_crc32(), fil_space_decrypt_for_non_full_checksum(): On error, return DB_DECRYPTION_FAILED instead of crashing. fil_set_max_space_id_if_bigger(): Replace ib::fatal() with an equivalent ut_a() assertion.	4 years ago

1 2 3 4 5 ...

195604 Commits (5d0496c749dcdbed5974ccbd9f679a778982b4a8) All Branches Search

195604 Commits (5d0496c749dcdbed5974ccbd9f679a778982b4a8)

All Branches