mariadb

Tree: 4cad42392a

Author	SHA1	Message	Date
Marko Mäkelä	4cad42392a	MDEV-12266: Change dict_table_t::space to fil_space_t* InnoDB always keeps all tablespaces in the fil_system cache. The fil_system.LRU is only for closing file handles; the fil_space_t and fil_node_t for all data files will remain in main memory. Between startup to shutdown, they can only be created and removed by DDL statements. Therefore, we can let dict_table_t::space point directly to the fil_space_t. dict_table_t::space_id: A numeric tablespace ID for the corner cases where we do not have a tablespace. The most prominent examples are ALTER TABLE...DISCARD TABLESPACE or a missing or corrupted file. There are a few functional differences; most notably: (1) DROP TABLE will delete matching .ibd and .cfg files, even if they were not attached to the data dictionary. (2) Some error messages will report file names instead of numeric IDs. There still are many functions that use numeric tablespace IDs instead of fil_space_t, and many functions could be converted to fil_space_t member functions. Also, Tablespace and Datafile should be merged with fil_space_t and fil_node_t. page_id_t and buf_page_get_gen() could use fil_space_t& instead of a numeric ID, and after moving to a single buffer pool (MDEV-15058), buf_pool_t::page_hash could be moved to fil_space_t::page_hash. FilSpace: Remove. Only few calls to fil_space_acquire() will remain, and gradually they should be removed. mtr_t::set_named_space_id(ulint): Renamed from set_named_space(), to prevent accidental calls to this slower function. Very few callers remain. fseg_create(), fsp_reserve_free_extents(): Take fil_space_t as a parameter instead of a space_id. fil_space_t::rename(): Wrapper for fil_rename_tablespace_check(), fil_name_write_rename(), fil_rename_tablespace(). Mariabackup passes the parameter log=false; InnoDB passes log=true. dict_mem_table_create(): Take fil_space_t* instead of space_id as parameter. dict_process_sys_tables_rec_and_mtr_commit(): Replace the parameter 'status' with 'bool cached'. dict_get_and_save_data_dir_path(): Avoid copying the fil_node_t::name. fil_ibd_open(): Return the tablespace. fil_space_t::set_imported(): Replaces fil_space_set_imported(). truncate_t: Change many member function parameters to fil_space_t*, and remove page_size parameters. row_truncate_prepare(): Merge to its only caller. row_drop_table_from_cache(): Assert that the table is persistent. dict_create_sys_indexes_tuple(): Write SYS_INDEXES.SPACE=FIL_NULL if the tablespace has been discarded. row_import_update_discarded_flag(): Remove a constant parameter.	8 years ago
Marko Mäkelä	c02c329a8e	MDEV-12266: Skip a lookup when checking free space fsp_get_available_space_in_free_extents(): Declare the function static in the only caller, and take const fil_space_t& as a parameter.	8 years ago
Marko Mäkelä	330ecb906d	MDEV-12266: fsp_flags_try_adjust(): Remove lookup	8 years ago
Marko Mäkelä	05863142ad	MDEV-12266: Remove fil_system_t::named_spaces fil_space_get_by_name(): Remove. (Implement differently in mariabackup.) fil_ibd_open(): Check if the tablespace by the same ID already exists. If it is the same name, return success, else failure.	8 years ago
Marko Mäkelä	9043bec954	MDEV-12266: Make trx_rseg_t::space a pointer trx_rsegf_get(), trx_undo_get_first_rec(): Change the parameter to fil_space_t* so that fewer callers need to be adjusted. trx_undo_free_page(): Remove the redundant parameter 'space'.	8 years ago
Marko Mäkelä	39ed074317	MDEV-12266: Remove trx_undo_t::space	8 years ago
Marko Mäkelä	5dd5b6cadc	MDEV-12266: Clean up btr_search_drop_page_hash_when_freed() Remove the parameter page_size, and pass a dummy page size to buf_page_get_gen() along with BUF_PEEK_IF_IN_POOL.	8 years ago
Marko Mäkelä	e2bf76cb32	MDEV-12266: Cleanup DISCARD TABLESPACE fil_discard_tablespace(): Merge to row_discard_tablespace() which was the only caller.	8 years ago
Marko Mäkelä	f8d1bd011d	MDEV-12266: Cleanup TRUNCATE fil_recreate_table(), fil_recreate_tablespace(), fil_reinit_space_header_for_table(): Move the functions to the only calling module and declare static. fil_recreate_table(): Remove the constant parameter space_id=0,flags.	8 years ago
Marko Mäkelä	f2a581e6c7	MDEV-12266: Clean up recv_recover_page()	8 years ago
Marko Mäkelä	332e805e2c	MDEV-12266: Refactor trx_rseg_header_create()	8 years ago
Marko Mäkelä	428e02895b	MDEV-12266: Remove dict_index_t::table_name Replace index->table_name with index->table->name.	8 years ago
Marko Mäkelä	604fea1ad6	MDEV-12266: Remove dict_index_t::space We can rely on the dict_table_t::space. All indexes of a table object are always in the same tablespace. (For fulltext indexes, the data is located in auxiliary tables, and these will continue to have their own table objects, separate from the main table.)	8 years ago
Marko Mäkelä	e7980f9cee	MDEV-12266: Add dict_index_t::set_modified(mtr) This is a non-functional change (pure refactoring).	8 years ago
Marko Mäkelä	39cbba19d7	MDEV-12266: dict_recreate_index_tree(): Keep the fil_space_t	8 years ago
Marko Mäkelä	c577192d6c	MDEV-12266: fsp_flags_try_adjust(): Remove a lookup fsp_header_init(): Take fil_space_t* as a parameter.	8 years ago
Marko Mäkelä	2ac8b1a907	MDEV-12266: Add fil_system.sys_space, temp_space Add fil_system_t::sys_space, fil_system_t::temp_space. These will replace lookups for TRX_SYS_SPACE or SRV_TMP_SPACE_ID. mtr_t::m_undo_space, mtr_t::m_sys_space: Remove. mtr_t::set_sys_modified(): Remove. fil_space_get_type(), fil_space_get_n_reserved_extents(): Remove. fsp_header_get_tablespace_size(), fsp_header_inc_size(): Merge to the only caller, innobase_start_or_create_for_mysql().	8 years ago
Marko Mäkelä	600c85e85a	Allocate the singleton fil_system statically fil_system_t::create(): Replaces fil_init(), fsp_init(). fil_system_t::close(): Replaces fil_close(). fil_system_t::max_n_open: Remove. Use srv_max_n_open_files directly.	8 years ago
Marko Mäkelä	1f0f7d5907	Remove dict_build_tablespace_for_table() create_table_info_t::create_table_def(): Assign the innodb_temporary tablespace directly. dict_build_tablespace_for_table(): Merge to the only remaining caller, dict_build_table_def_step().	8 years ago
Marko Mäkelä	60ef478c2e	Remove an unnecessary global declaration	8 years ago
Marko Mäkelä	d177a0ed14	Remove unused function fil_space_get_id_by_name()	8 years ago
Marko Mäkelä	980dd09be6	Merge 10.2 into 10.3	8 years ago
Marko Mäkelä	014dfe473a	MDEV-15719: Adjust a test case	8 years ago
Marko Mäkelä	3eb73bf630	Remove unnecessary SysTablespace references	8 years ago
Marko Mäkelä	622d21e2b8	row_drop_table_for_mysql(): Use a constant string It does not hurt to delete non-existing records from SYS_TABLESPACES and SYS_DATAFILES. Because MariaDB does not support CREATE TABLESPACE, only the system tablespace (space_id=0) can contain multiple tables. But, there are no entries for the system tablespace in these tables (which actually are stored inside the system tablespace).	8 years ago
Sergei Petrunia	b922741074	MDEV-15472: Assertion `!is_set() \|\| (m_status == DA_OK_BULK && is_bulk_op())' failure MariaDB differs from the upstream for "DDL-like" command. For these, it sets binlog_format=STATEMENT for the duration of the statement. This doesn't play well with MyRocks, which tries to prevent DML commands with binlog_format!=ROW. Also, if Locked_tables_list::reopen_tables() returned an error, then close_cached_tables should propagate the error condition and not silently consume it (it's difficult to have test coverage for this because this error condition is rare)	8 years ago
Monty	4277c173a9	MDEV-15149 Assert upon concurrent creating / querying sequences MDEV-15117 Server crashes in in open_and_process_table or ASAN heap-use-after-free in is_temporary_table upon creating/flushing sequences. Problem was that sequence_insert closed and reopened the like table without proper locking. Fixed by ensuring that the like table is not reopened in sequence_insert	8 years ago
Monty	cd93eeeb1d	MDEV-15149 Assert upon concurrent creating / querying sequences Problem was that sequence_insert closed and reopened the like table without proper locking. Fixed by ensuring that the like table is not reopened in sequence_insert	8 years ago
Monty	e2664ee836	MDEV-14275 Improving memory utilization for information schema SELECT queries on information_schema table will now not store data in the temporary table for columns that are not used in the query. This can drastically reduce memory when there are many rows involved in a query, like using SELECT table_name FROM information_schema.table on a system with many tables. The difference for the above query is about 14K per existing table. The code works this way: - Create a bitmap for all information_schema fields used in the query - For BLOB and VARCHAR fields that are not use, create a Field_null field.	8 years ago
Monty	33fa6abd02	Ensure that map->mutex is reset in my_bitmap_init	8 years ago
Monty	75dd94c7ce	Fixed compiler warnings Remove compiler warnings in sphinx, item_sum.cc and opt_split.cc	8 years ago
Michael Widenius	d572c19f22	Added flush tables to acl_load_mutex-5170.test This is needed as otherwise a lot of MyISAM tables may be marked as crashed, depending on in which order tests are run	8 years ago
Monty	410d093089	Move extra/rpl_tests/table_index_statistics to suite/innodb	8 years ago
Michael Widenius	39018f2a5a	Move mysql-test-run/extra/rpl_tests to suite/rpl/include Renamed suite/rpl/include/rpl_sync.inc to rpl_sync_test.inc to remove clash with include/rpl_sync.inc	8 years ago
Michael Widenius	108ed22854	Move mysql-test-run/extra/binlog to suite/binlog/include	8 years ago
Michael Widenius	a7abddeffa	Create 'main' test directory and move 't' and 'r' there	8 years ago
Monty	ab1941266c	Move alter partition flags to alter_info->partition_flags This is done to get more free flag bits for alter_info->flags Renamed all ALTER PARTITION defines to start with ALTER_PARTITION_ Renamed ALTER_PARTITION to ALTER_PARTITION_INFO Renamed ALTER_TABLE_REORG to ALTER_PARTITION_TABLE_REORG Other things: - Shifted some ALTER_xxx defines to get empty bits at end	8 years ago
Monty	2dbeebdb16	Changed static const in Alter_info and Alter_online_info to defines Main reason was to make it easier to print the above structures in a debugger. Additional benefits is that I was able to use same defines for both structures, which simplifes some code. Most of the code is just removing Alter_info:: and Alter_inplace_info:: from alter table flags. Following renames was done: HA_ALTER_FLAGS -> alter_table_operations CHANGE_CREATE_OPTION -> ALTER_CHANGE_CREATE_OPTION Alter_info::ADD_INDEX -> ALTER_ADD_INDEX DROP_INDEX -> ALTER_DROP_INDEX ADD_UNIQUE_INDEX -> ALTER_ADD_UNIQUE_INDEX DROP_UNIQUE_INDEx -> ALTER_DROP_UNIQUE_INDEX ADD_PK_INDEX -> ALTER_ADD_PK_INDEX DROP_PK_INDEX -> ALTER_DROP_PK_INDEX Alter_info:ALTER_ADD_COLUMN -> ALTER_PARSE_ADD_COLUMN Alter_info:ALTER_DROP_COLUMN -> ALTER_PARSE_DROP_COLUMN Alter_inplace_info::ADD_INDEX -> ALTER_ADD_NON_UNIQUE_NON_PRIM_INDEX Alter_inplace_info::DROP_INDEX -> ALTER_DROP_NON_UNIQUE_NON_PRIM_INDEX Other things: - Added typedef alter_table_operatons for alter table flags - DROP CHECK CONSTRAINT can now be done online - Added checks for Aria tables in alter_table_online.test - alter_table_flags now takes an ulonglong as argument. - Don't support online operations if checksum option is used. - sql_lex.cc doesn't add ALTER_ADD_INDEX if index is not created	8 years ago
Monty	0631f20ff7	Fixed some DBUG_PRINT to use %p properly	8 years ago
Monty	c3f37c070c	Fixed alter online table for Aria tables fill_alter_table() always thought that index was changed because of of a wrong check of block_size. Some engines had code to correct this that should not be needed, Aria didn't and because of this some online operations didn't work. This code fixes the comparision of block_size to only compare if it's set.	8 years ago
halfspawn	209375fdd0	MDEV-15664 : sql_mode=ORACLE: Make TRIM return NULL instead of empty string	8 years ago
Marko Mäkelä	adaee46a90	MDEV-15682 mariabackup.unsupported_redo fails in buildbot with wrong result code Skip the test mariabackup.unsupported_redo if a checkpoint occurred before mariabackup --backup completed. Remove the slow shutdowns and restarts which were attempting to prevent the checkpoints from occurring.	8 years ago
Marko Mäkelä	6cccef21a6	MDEV-15720 ib_buffer_pool unnecessarily includes the temporary tablespace The purpose of the InnoDB buffer pool dump is to allow InnoDB to be restarted with the same persistent data pages in the buffer pool. The InnoDB temporary tablespace that was introduced in MariaDB 10.2.2 is always reinitialized on restart. Therefore, it does not make sense to attempt to dump or restore any pages of the temporary tablespace.	8 years ago
Marko Mäkelä	4d9969c216	MDEV-15719 ALTER TABLE…ALGORITHM=INPLACE is unnecessarily refused due to innodb_force_recovery ha_innobase::check_if_supported_inplace_alter(): Only check for high_level_read_only. Do not unnecessarily refuse ALTER TABLE...ALGORITHM=INPLACE if innodb_force_recovery was specified as 1, 2, or 3. innobase_start_or_create_for_mysql(): Block all writes from SQL if the system tablespace was initialized with 'newraw'.	8 years ago
Sergey Vojtovich	4faf34ad63	Clean-up trx_sys.mutex misuse Currently trx_sys.mutex protects only trx_sys.mysql_trx_list and trx_sys.m_views, which are not accessed by lock0lock debug routines. Thus there's no need to bother trx_sys.mutex here. Removed trx_assert_started(): this assertion is fully covered by check_trx_state().	8 years ago
Sergey Vojtovich	b36da48ad3	MDEV-15612 - Latching violation in trx_roll_must_shutdown recv_sys_t::mutex and rw_trx_hash_elementi_t::mutex were acquired in reverse (to recorded) order. Fixed by releasing recv_sys_t::mutex, before iterating rw_trx_hash. Statistics gathering doesn't really need recv_sys_t::mutex protection, since it is always done in one thread (trx_roll_crash_recv_trx) and thus it can't go wrong.	8 years ago
Sergei Petrunia	0d2fffb612	MDEV-15686: Loading MyRocks plugin back after it has been unloaded causes a crash Adjust the testcase to handle all possible outcomes.	8 years ago
Alexander Barkov	2a13b3db50	MDEV-15714 Remove the use of STRING_ITEM from the parser	8 years ago
Marko Mäkelä	d18a66147c	recv_validate_tablespace(): Fix -Wmissing-fallthrough	8 years ago
Marko Mäkelä	5beddfa08c	fil_node_open_file(): Add a missing space to message	8 years ago

1 2 3 4 5 ...

181746 Commits (4cad42392a2c498a2be92a77b21b1ec4027c9ea9) All Branches Search

181746 Commits (4cad42392a2c498a2be92a77b21b1ec4027c9ea9)

All Branches