mariadb

Tree: 2971d645c1

Author	SHA1	Message	Date
unknown	2971d645c1	Bug#26711 "Binary content 0x00 sometimes becomes 0x5C 0x00 after dump/load" Problem: "SELECT INTO OUTFILE" created incorrect dumps for BLOBs, so "LOAD DATA" later incorrectly interpreted 0x5C as the second byte of a multi-byte sequence, instead of escape character. Fix: adding escaping of multi-byte heads. mysql-test/r/ctype_big5.result: Adding test case mysql-test/t/ctype_big5.test: Adding test case sql/sql_class.cc: Add escape characters before multi-byte heads. strings/ctype-big5.c: Flagging character set as dangerous for escaping. strings/ctype-gbk.c: Flagging character set as dangerous for escaping. strings/ctype-sjis.c: Flagging character set as dangerous for escaping.	19 years ago
unknown	4bdbc3396e	Merge aelkin@bk-internal.mysql.com:/home/bk/mysql-5.0-rpl into dsl-hkibras1-ff5dc300-70.dhcp.inet.fi:/home/elkin/MySQL/TEAM/FIXES/5.0/bug27716-multi_upd_no_binlog mysql-test/r/innodb.result: Auto merged mysql-test/t/innodb.test: Auto merged sql/sql_update.cc: Auto merged	19 years ago
unknown	6b94fc579f	Bug #27716 multi-update did partially and has not binlogged Implementation of mysql_multi_update did not call multi_update::send_error method in some cases (see the test reported on bug page and test cases in changeset). Fixed with deploying the method, ::send_error() is refined to get binlogging code which works whenever there is modified non-transactional table. thd->no_trans_update.stmt flag is set in to TRUE to ease testing though being the beginning of relative bug#27417 fix (addresses a part of those issues). Eliminating two minor issues (small bugs) in multi_update methods. This patch for multi-update also addresses a part of the issues reported in bug#13270,bug#23333. mysql-test/r/innodb.result: result changed mysql-test/r/multi_update.result: results changed mysql-test/t/innodb.test: regression test for the bug combining transactional and non-transaction tables mysql-test/t/multi_update.test: regression tests added - erred query must be binlogged sql/sql_update.cc: making a call to multi_update::send_error when mysql_select return an error; deploying binlogging inside of ::send_error; refining multi_update::send_eof() to mark binlogging work done when its call to ::do_updates() errs and the query is binlogged with the error. ::send_error() will be called after all but do not do anything; thd->no_trans_update.stmt is corrected to be set to TRUE according to the existed code pattern. Although this part relates to another bugs (bug#27417 etc) it is needed here for testing; Eliminating a separate issue in multi_update::do_updates where either one of the class members trans_safe, transactional_tables was set after the per-table loop whereas both should be calculated during looping. Eliminating a separate issue in ::send_eof() where thd->no_trans_update.all won't be set TRUE when amoung others there'd be at least one modified transactional table. Binlogging is done to satisfy to general character bug#13270,bug#23333 so that those won't have fixes specific for multi-update.	19 years ago
unknown	eb056fb82b	Merge lthalmann@bk-internal.mysql.com:/home/bk/mysql-5.0-runtime into mysql.com:/nfsdisk1/lars/bk/mysql-5.0-rpl mysql-test/t/disabled.def: Auto merged	19 years ago
unknown	dd190b0e6b	bug#22725 refining the test because of Bug #28786 'reset master' does not reset binlogging on embeded server mysql-test/t/binlog_killed.test: the test can not pass on embedded server. Setting the include-guard.	19 years ago
unknown	e5c4d97c9e	bug#22725 test comments correction mysql-test/r/binlog_killed.result: changed mysql-test/t/binlog_killed.test: wrong comments (but important ones) left; little refinement in result calc	19 years ago
unknown	9f15fe64bd	Disable IM-tests.	19 years ago
unknown	9a1e9de91f	bug#22725 combining the final result variable in such way that either option of the test execution will yield zero. mysql-test/r/binlog_killed.result: results changed mysql-test/t/binlog_killed.test: there are two options for the test passing: 1. no rows inserted and the INSERT gets killed, then there is no INSERT query in binlog 2. all rows inserted, then INSERT gets to binlog and error_code is zero	19 years ago
unknown	54e1f2f0ce	bug#22725 tests refining, see binlog_killed.test file for details mysql-test/r/binlog_killed.result: results changed mysql-test/t/binlog_killed.test: killer conn waits for the first row to appear; log-disabling kill query since prey's id is not deterministic; correcting pattern to search in binlog for insert query;	19 years ago
unknown	70a530e401	bug#22725 refining the test. mysql-test/t/binlog_killed.test: due to killing reap may catch an error though it's indeterministic.	19 years ago
unknown	daa7b8a5b2	bug#22725 result file updated mysql-test/r/binlog_killed.result: results updated	19 years ago
unknown	00710d17bb	Bug#22725 Replication outages from ER_SERVER_SHUTDOWN (1053) set in replication events Refining the tests since pb revealed the older version's fragality - the error from SF() due to killed may be different on different env:s. DBUG_ASSERT instead of assert. mysql-test/r/binlog_killed.result: new result file mysql-test/t/binlog_killed.test: regression for bug#22725 simplified. tests for bug27563, BUG#27565 made inactive. sql/sql_insert.cc: DBUG_ASSERT	19 years ago
unknown	2212ad470e	Merge adventure.(none):/home/thek/Development/cpp/bug24988/my50-bug24988 into adventure.(none):/home/thek/Development/cpp/mysql-5.0-runtime sql/mysqld.cc: Auto merged	19 years ago
unknown	f27bf2b463	Bug#22725 Replication outages from ER_SERVER_SHUTDOWN (1053) set in replication events The reason for the bug was that replaying of a query on slave could not be possible since its event was recorded with the killed error. Due to the specific of handling INSERT, which per-row-while-loop is unbreakable to killing, the query on transactional table should have not appeared in binlog unless there was a call to a stored routine that got interrupted with killing (and then there must be an error returned out of the loop). The offered solution added the following rule for binlogging of INSERT that accounts the above specifics: For INSERT on transactional-table if the error was not set the only raised flag is harmless and is ignored via masking out on time of creation of binlog event. For both table types the combination of raised error and KILLED flag indicates that there was potentially partial execution on master and consistency is under the question. In that case the code continues to binlog an event with an appropriate killed error. The fix relies on the specified behaviour of stored routine that must propagate the error to the top level query handling if the thd->killed flag was raised in the routine execution. The patch adds an arg with the default killed-status-unset value to Query_log_event::Query_log_event. sql/log_event.cc: killed_status as the value of thd->killed can be passed as an arg to the constructor. if the value is different from the default the arg is set to the current thd->killed value. A caller might need to masquerade thd->killed with THD::NOT_KILLED. So far only mysql_insert() uses such explicit way to tell the constructor about killing status. sql/log_event.h: default arg to the constructor with meaning of killed status of the query. if the arg is not explicitly provided the status of thd->killed will be snapshot inside of the constuctor, which is potentially incorrect (see bug#27571) sql/sql_class.h: extending killed_state with no-state member. sql/sql_insert.cc: ignore the KILLED flag incl KILL_BAD_DATA when the INSERT query event is created without an `error'; sql/sql_update.cc: Suggestion how to fix bug#27571 as comments. mysql-test/r/binlog_killed.result: new result file mysql-test/t/binlog_killed.test: regression tests also apply for bug27563, BUG#27565	19 years ago
unknown	96d16d96d1	Bug#24988 FLUSH PRIVILEGES causes brief unavailability - A race condition caused brief unavailablility when trying to acccess a table. - The unprotected variable 'grant_option' wasn't intended to alternate during normal execution. Variable initialization moved to grant_init a lines responsible for the alternation are removed. sql/mysqld.cc: - Added documentation to describe grant_option flag. sql/sql_acl.cc: - This patch removes lines which causes grant_option to alternate and moves variable initialization to the grant_init()-function.	19 years ago
unknown	9f757559ee	Merge mysql.com:/nfsdisk1/lars/bkroot/mysql-5.0-rpl into mysql.com:/nfsdisk1/lars/MERGE/mysql-5.0-merge mysql-test/mysql-test-run.pl: Auto merged mysql-test/t/disabled.def: Auto merged sql/sql_load.cc: Auto merged	19 years ago
unknown	5ed76763f8	Code review comments sql/sql_lex.cc: Fixed parenthese typo, found during code review	19 years ago
unknown	1e33b063f0	Bug#27876 (SF with cyrillic variable name fails during execution (regression)) The root cause of this bug is related to the function skip_rear_comments, in sql_lex.cc Recent code changes in skip_rear_comments changed the prototype from "const uchar" to "const char", which had an unforseen impact on this test: (endp[-1] < ' ') With unsigned characters, this code filters bytes of value [0x00 - 0x20] With signed characters, this also filters bytes of value [0x80 - 0xFF]. This caused the regression reported, considering cyrillic characters in the parameter name to be whitespace, and truncated. Note that the regression is present both in 5.0 and 5.1. With this fix: - [0x80 - 0xFF] bytes are no longer considered whitespace. This alone fixes the regression. In addition, filtering [0x00 - 0x20] was found bogus and abusive, so that the code now filters uses my_isspace when looking for whitespace. Note that this fix is only addressing the regression affecting UTF-8 in general, but does not address a more fundamental problem with skip_rear_comments: parsing a string backwards, starting at end[-1], is not safe with multi-bytes characters, so that end[-1] can confuse the last byte of a multi-byte characters with a characters to filter out. The only known impact of this remaining issue affects objects that have to meet all the conditions below: - the object is a FUNCTION / PROCEDURE / TRIGGER / EVENT / VIEW - the body consist of only 1 instruction, and does not contain a BEGIN-END block - the instruction ends, lexically, with <ident> <whitespace>* ';'? For example, "select <ident>;" or "return <ident>;" - The last character of <ident> is a multi-byte character - the last byte of this character is ';' '*', '/' or whitespace In this case, the body of the object will be truncated after parsing, and stored in an invalid format. This last issue has not been fixed in this patch, since the real fix will be implemented by Bug 25411 (trigger code truncated), which is caused by the very same code. The real problem is that the function skip_rear_comments is only a work-around, and should be removed entirely: see the proposed patch for bug 25411 for details. sql/sp_head.cc: In skip_rear_comments, Filter out only whitespace, not other (non ascii or control) valid characters sql/sql_lex.cc: In skip_rear_comments, Filter out only whitespace, not other (non ascii or control) valid characters sql/sql_lex.h: In skip_rear_comments, Filter out only whitespace, not other (non ascii or control) valid characters sql/sql_view.cc: In skip_rear_comments, Filter out only whitespace, not other (non ascii or control) valid characters tests/mysql_client_test.c: Bug#27876 (SF with cyrillic variable name fails during execution (regression))	19 years ago
unknown	c8236f564c	Merge bk-internal.mysql.com:/home/bk/mysql-5.0 into vajra.(none):/opt/local/work/mysql-5.0-runtime sql/mysql_priv.h: Auto merged sql/sql_base.cc: Auto merged	19 years ago
unknown	0629727088	Merge pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0-build-work into pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0-build	19 years ago
unknown	6df02cf7d7	Merge pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0 into pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0-build configure.in: Auto merged include/my_global.h: Auto merged sql/item_func.cc: Auto merged strings/strtod.c: Auto merged	19 years ago
unknown	37f1e22247	Merge pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0-build into pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0-build-work	19 years ago
unknown	a53b80b3f3	Bug#27636 mysqlbinlog-cp932 and ctype_cp932 tests fails if LC_* variables set to _.UTF-8 As MySQL character set tests can print results in many character sets (latin1, utf8-8, sjis, cp932 and others) - its output can be incompatible with the current locale settings, which makes PERL confuse. Fix: reset LC_ALL and LC_CTYPE to "C", which is compatible with any character set. mysql-test/mysql-test-run.pl: Ignore current locale settings, because "mysqltest" output can be not compatible with the locale.	19 years ago
unknown	f9d7642e7b	5.0 version of fix for: Bug #23667 "CREATE TABLE LIKE is not isolated from alteration by other connections" Bug #18950 "CREATE TABLE LIKE does not obtain LOCK_open" As well as: Bug #25578 "CREATE TABLE LIKE does not require any privileges on source table". The first and the second bugs resulted in various errors and wrong binary log order when one tried to execute concurrently CREATE TABLE LIKE statement and DDL statements on source table or DML/DDL statements on its target table. The problem was caused by incomplete protection/table-locking against concurrent statements implemented in mysql_create_like_table() routine. We solve it by simply implementing such protection in proper way (see comment for sql_table.cc for details). The third bug allowed user who didn't have any privileges on table create its copy and therefore circumvent privilege check for SHOW CREATE TABLE. This patch solves this problem by adding privilege check, which was missing. Finally it also removes some duplicated code from mysql_create_like_table(). Note that, altough tests covering concurrency-related aspects of CREATE TABLE LIKE behaviour will only be introduced in 5.1, they were run manually for this patch as well. mysql-test/r/grant2.result: Added test for bug#25578 "CREATE TABLE LIKE does not require any privileges on source table". mysql-test/t/grant2.test: Added test for bug#25578 "CREATE TABLE LIKE does not require any privileges on source table". sql/handler.h: Introduced new flag for HA_CREATE_INFO::options in order to be able to distinguish CREATE TABLE ... LIKE from other types of CREATE TABLE. sql/mysql_priv.h: mysql_create_like_table() now takes source table name not as a Table_ident object but as regular table list element. sql/sql_parse.cc: CREATE TABLE ... LIKE implementation now uses statement's table list for storing information about the source table. We also use flag in LEX::create_info.options for distinguishing it from other types of CREATE TABLE. Finally CREATE TABLE ... LIKE now requires the same privileges on the source tables as SHOW CREATE TABLE. Moved this privilege check to check_show_create_table_access() function. sql/sql_table.cc: mysql_create_like_table(): - Provided proper protection from concurrent statements. This is achieved by keeping name-lock on the source table and holding LOCK_open mutex during whole operation. This gives protection against concurrent DDL on source table. Also holding this mutex makes copying of .frm file, call to ha_create_table() and binlogging atomic against concurrent DML and DDL operations on target table. - Get rid of duplicated code related to source database/table name handling. All these operations are already done in st_select_lex::add_table_to_list(), so we achieve the same effect by including source table into the statement's table list. sql/sql_yacc.yy: Now we use special flag in LEX::create_info::options for distinguishing CREATE TABLE ... LIKE from other types of CREATE TABLE and store name of source table as regular element in statement's table list.	19 years ago
unknown	5e236f85c5	Merge pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0.42 into pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0-build configure.in: Auto merged sql/item_func.cc: Auto merged	19 years ago
unknown	351abe5a89	Merge mysql.com:/home/svoj/devel/mysql/merge/mysql-4.1-engines into mysql.com:/home/svoj/devel/mysql/merge/mysql-5.0-engines	19 years ago
unknown	adef673652	Merge mysql.com:/home/svoj/devel/bk/mysql-5.0 into mysql.com:/home/svoj/devel/mysql/merge/mysql-5.0-engines	19 years ago
unknown	e5b2adeac1	Merge mysql.com:/home/svoj/devel/bk/mysql-4.1 into mysql.com:/home/svoj/devel/mysql/merge/mysql-4.1-engines	19 years ago
unknown	4f3b4af226	Merge pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0-build into pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0-build-work	19 years ago
unknown	d06875b3a4	Merge whalegate.ndb.mysql.com:/home/tomas/mysql-4.1-ndb into whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-ndb	19 years ago
unknown	f529d18ba6	Merge whalegate.ndb.mysql.com:/home/tomas/mysql-5.0 into whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-ndb	19 years ago
unknown	05464a4f45	Merge whalegate.ndb.mysql.com:/home/tomas/mysql-4.1 into whalegate.ndb.mysql.com:/home/tomas/mysql-4.1-ndb	19 years ago
unknown	fd5b27e1e2	Merge trift2.:/MySQL/M50/bug26609-5.0 into trift2.:/MySQL/M50/push-5.0	19 years ago
unknown	08639fb9e7	Add the "row_lock" test suite to the (to be) release build test run.	19 years ago
unknown	c7c3d16984	scripts/make_binary_distribution.sh : Include all the additional test suites in the binary packages ("tar.gz"). This is the tar.gz part of the fixes for bug#26609; for RPMs it is already done. scripts/make_binary_distribution.sh: Include all the additional test suites (for now: "funcs_1", "funcs_2", "row_lock") in the binary packages ("tar.gz"). Take them "as is", without any file filtering (except for the BK subdirectories "SCCS"). This is the tar.gz part of the fixes for bug#26609; for RPMs it is already done. Use this opportunity to correct the language in some comments.	19 years ago
unknown	9a1ab7e63f	Merge quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/maint/41 into quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/maint/50	19 years ago
unknown	221e23ad72	Merge quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/50 into quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/maint/50 configure.in: Auto merged mysql-test/r/strict.result: Auto merged mysql-test/r/type_datetime.result: Auto merged mysql-test/t/type_datetime.test: Auto merged sql/item.cc: Auto merged sql/item_cmpfunc.cc: Auto merged	19 years ago
unknown	ea263c4a4d	Merge quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/41 into quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/maint/41	19 years ago
unknown	4d8de9e792	Merge whalegate.ndb.mysql.com:/home/tomas/mysql-4.1-ndb into whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-ndb	19 years ago
unknown	66dc33eed2	Merge whalegate.ndb.mysql.com:/home/tomas/mysql-5.0 into whalegate.ndb.mysql.com:/home/tomas/mysql-5.0-ndb	19 years ago
unknown	ae79786ecf	Merge whalegate.ndb.mysql.com:/home/tomas/mysql-4.1 into whalegate.ndb.mysql.com:/home/tomas/mysql-4.1-ndb	19 years ago
unknown	f40047df9c	Merge pilot.blaudden:/home/msvensson/mysql/bug28401/my50-bug28401 into pilot.blaudden:/home/msvensson/mysql/mysql-5.0-maint	19 years ago
unknown	f52f931f4b	Bug #28401 mysql_upgrade Failed with STRICT_ALL_TABLES, ANSI_QUOTES and NO_ZERO_DATE - The SQL commands used by mysql_upgrade are written to be run with sql_mode set to '' - thus the scripts should change sql_mode for the session to make sure the SQL is legal. mysql-test/r/mysql_upgrade.result: Update test result mysql-test/t/mysql_upgrade.test: The SQL commands used by mysql_upgrade are written to be run with sql_mode set to '' - thus the scripts should change sql_mode for the session to make sure the SQL is legal. scripts/mysql_system_tables_fix.sql: Set sql_mode to '' before running the SQL commands to fix system tables - backport from 5.1	19 years ago
unknown	8b33c41554	Merge bk@192.168.21.1:mysql-5.0-opt into mysql.com:/d2/hf/mrg/mysql-5.0-opt mysql-test/r/ps.result: Auto merged mysql-test/t/ps.test: Auto merged sql/item.cc: Auto merged	19 years ago
unknown	8933c18cca	Merge bk-internal.mysql.com:/home/bk/mysql-5.0-opt into sergbook.mysql.com:/usr/home/serg/Abk/mysql-5.0 mysql-test/r/ps.result: Auto merged mysql-test/t/ps.test: Auto merged sql/item.cc: Auto merged	19 years ago
unknown	f7434c4f93	added cleanup to some tests mysql-test/r/sp_trans.result: added cleanup mysql-test/r/strict.result: added cleanup mysql-test/t/sp_trans.test: added cleanup mysql-test/t/strict.test: added cleanup	19 years ago
unknown	5f66ebe8b7	Merge mysql.com:/d2/hf/mrg/mysql-4.1-opt into mysql.com:/d2/hf/mrg/mysql-5.0-opt	19 years ago
unknown	caf045dbeb	Merge bk@192.168.21.1:mysql-5.0 into mysql.com:/d2/hf/mrg/mysql-5.0-opt mysql-test/r/ps.result: Auto merged mysql-test/t/ps.test: Auto merged sql/item.cc: Auto merged	19 years ago
unknown	25090a6da6	Merge bk@192.168.21.1:mysql-4.1 into mysql.com:/d2/hf/mrg/mysql-4.1-opt	19 years ago
unknown	ca633f5f56	Merge bk-internal:/home/bk/mysql-5.0-maint into pilot.blaudden:/home/msvensson/mysql/mysql-5.0-maint	19 years ago

1 2 3 4 5 ...

36523 Commits (2971d645c16c548678b8f94796ca1bcfd54f9c8e) All Branches Search

36523 Commits (2971d645c16c548678b8f94796ca1bcfd54f9c8e)

All Branches